hcq/oceanbase
hcq/oceanbase
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix dynamic memory leak in subplan filter onetime expr datum deep copy

Browse Source
This commit is contained in:
obdev 2023-04-19 08:11:42 +00:00 committed by ob-robot
parent 76b4679dc4
commit ff0be6d455
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/engine/subquery/ob_subplan_filter_op.cpp
View File

@ -1268,18 +1268,16 @@ int ObSubPlanFilterOp::prepare_onetime_exprs_inner()
{
int ret = OB_SUCCESS;
ObPhysicalPlanCtx *plan_ctx = GET_PHY_PLAN_CTX(ctx_);
ObDatum copyed;
for (int64_t i = 0; OB_SUCC(ret) && i < MY_SPEC.onetime_exprs_.count(); ++i) {
const ObDynamicParamSetter &setter = MY_SPEC.onetime_exprs_.at(i);
ObDatum *datum = NULL;
if (OB_FAIL(setter.src_->eval(eval_ctx_, datum))) {
LOG_WARN("expression evaluate failed", K(ret));
} else if (OB_FAIL(copyed.deep_copy(*datum, ctx_.get_allocator()))) {
LOG_WARN("datum deep copy failed", K(ret));
} else if (OB_FAIL(setter.update_dynamic_param(eval_ctx_, copyed))) {
} else if (OB_FAIL(setter.update_dynamic_param(eval_ctx_, *datum))) {
LOG_WARN("update dynamic param store failed", K(ret));
}
}
return ret;
}