hcq/openGauss-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix select @@ bool parameter bug.

Browse Source
This commit is contained in:
totaj
2023-08-01 14:33:19 +08:00
parent 74efc1a09a
commit 1108ae26e5
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/backend/parser/parse_coerce.cpp
View File

@ -3137,7 +3137,7 @@ Const* setValueToConstExpr(SetVariableExpr* set)
case PGC_BOOL:
{
bool variable_bool = false;
if (strcmp(variable_str,"true") || strcmp(variable_str,"on")) {
if (strcmp(variable_str, "true") == 0 || strcmp(variable_str,"on") == 0) {
variable_bool = true;
}
val = BoolGetDatum(variable_bool);

3
src/test/regress/input/set_system_variables_test.source
View File

@ -110,6 +110,7 @@ set @@session.enable_broadcast = on;
set @@session.enable_broadcast = default;
set @@enable_broadcast = (1 = 1);
set @@enable_broadcast = (true = true);
select @@enable_broadcast;
set @@enable_broadcast = (true = false);
select @@enable_broadcast;
@ -298,4 +299,4 @@ drop database if exists test_set;
\! @abs_bindir@/gs_guc reload -Z datanode -D @abs_srcdir@/tmp_check/datanode1 -c "enable_set_variable_b_format=off" >/dev/null 2>&1
\! sleep 1
show enable_set_variable_b_format;
show enable_set_variable_b_format;

12
src/test/regress/output/set_system_variables_test.source
View File

@ -237,23 +237,29 @@ set @@session.enable_broadcast = on;
set @@session.enable_broadcast = default;
set @@enable_broadcast = (1 = 1);
set @@enable_broadcast = (true = true);
set @@enable_broadcast = (true = false);
select @@enable_broadcast;
?column?
----------
t
(1 row)
set @@enable_broadcast = (true = false);
select @@enable_broadcast;
?column?
----------
f
(1 row)
select @@session.enable_broadcast;
?column?
----------
t
f
(1 row)
select @@session.enable_broadcast = 'true';
?column?
----------
t
f
(1 row)
set global most_available_sync = t;