hcq/openGauss-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

!2282 issue#I5UDM6 LogAccessExclusiveLock() when primary node acquire AccessExclusiveLock for systable

Browse Source 
Merge pull request !2282 from wangchunling/issue#I5UDM6
This commit is contained in:
opengauss-bot
2022-11-02 02:48:07 +00:00
committed by Gitee
parent 59893408f6 ecfc320dd6
commit 47541fce1f
1 changed files with 2 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/gausskernel/storage/lmgr/lock.cpp
View File

@ -754,30 +754,8 @@ static LockAcquireResult LockAcquireExtendedXC(const LOCKTAG *locktag, LOCKMODE
*/
if (lockmode >= AccessExclusiveLock && locktag->locktag_type == LOCKTAG_RELATION && !RecoveryInProgress() &&
XLogStandbyInfoActive()) {
/*
* In a scenario like:
*
* 1, openGauss run vacuum full or autovacuum pg_class, insert AccessExclusiveLock xlog.
* 2, datanode crash, vacuum full abort.
* 3, datanode restart in pending mode, start recovery.
* 4, startup thread acquire pg_class's AccessExclusiveLock.
* 5, startup thread complete recovery and wait for notify.
* 6, cm agent connect datanode, need to init relcache file.
* 7, cm agent connect want to acquire pg_class's AccessShareLock,
* but the AccessExclusiveLock lock is hold by startup thread.
* 8, dead lock, datanode hang.
*
* Other system tables like pg_attribute/pg_type.. also have such problem.
*
* To solve this problem, we don't insert AccessExclusiveLock xlog for system tables.
* This change may cause exception when primary run vacuum full system table while
* standby access the system table at the same time.
*
*/
if (locktag->locktag_field2 > FirstNormalObjectId) {
LogAccessExclusiveLockPrepare();
log_lock = true;
}
LogAccessExclusiveLockPrepare();
log_lock = true;
}
/*