hcq/openGauss-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

完善port入参校验和打印信息

Browse Source
This commit is contained in:
chenxiaobin19
2024-02-20 11:06:49 +08:00
parent 7ffad4e773
commit a83638f21b
1 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/bin/gs_retrieve/gs_retrieve.cpp
View File

@ -709,6 +709,18 @@ XLogRecPtr DoradoFindMaxLsn(char *workingPath, char *returnMsg, int msgLen, pg_c
return maxLsn;
}
static bool checkIsDigit(const char* arg)
{
int i = 0;
while (arg[i] != '\0') {
if (!isdigit(arg[i])) {
return false;
}
i++;
}
return true;
}
static int getOptions(const int argc, char* const* argv)
{
#define NEWHOST 1
@ -749,6 +761,11 @@ static int getOptions(const int argc, char* const* argv)
newHost = pg_strdup(optarg);
break;
case NEWPORT:
check_env_value_c(optarg);
if (checkIsDigit(optarg) == 0) {
write_stderr(_("%s: invalid port number \"%s\"\n"), progname, optarg);
return -1;
}
newPort = atoi(optarg);
break;
case OLDHOST:
@ -759,6 +776,11 @@ static int getOptions(const int argc, char* const* argv)
oldHost = pg_strdup(optarg);
break;
case OLDPORT:
check_env_value_c(optarg);
if (checkIsDigit(optarg) == 0) {
write_stderr(_("%s: invalid port number \"%s\"\n"), progname, optarg);
return -1;
}
oldPort = atoi(optarg);
break;
case 'U':
@ -837,7 +859,7 @@ int main(int argc, char **argv)
}
if (newPort <= 0) {
write_stderr(_("%s: no newport specified\n"), progname);
write_stderr(_("%s: no newport specified or it must be a true value\n"), progname);
do_advice();
exit(1);
}
@ -849,7 +871,7 @@ int main(int argc, char **argv)
}
if (oldPort <= 0) {
write_stderr(_("%s: no oldport specified\n"), progname);
write_stderr(_("%s: no oldport specified or it must be a true value\n"), progname);
do_advice();
exit(1);
}