Commit Graph

  • 679de5e573 Make pg_config location overridable for pgxs builds. Peter Eisentraut 2006-07-20 09:30:18 +00:00
  • 7da24bcbc1 Print out diff status code when we think there's a hard failure. May help in debugging behavior on Windows. Tom Lane 2006-07-20 03:30:58 +00:00
  • c3104376f9 Suppress unused-variable compiler warning, per Andrew Dunstan. Tom Lane 2006-07-20 02:15:17 +00:00
  • 27a83103ea Fix pg_regress.c to report tests in a parallel group when they finish, not when they're started. This mimics a subtle point of the behavior of the old shell script, and gives better feedback when watching the tests. Tom Lane 2006-07-20 02:10:00 +00:00
  • 5652ea703b Make pg_regress.c get paths from pg_config_paths.h, instead of -D switches passed from the Makefile. This looks like it will fix problem with virtual vs real paths under msys. Tom Lane 2006-07-20 01:16:57 +00:00
  • f141880150 Don't try to truncate multixact SLRU files in checkpoints done during xlog recovery. In the first place, it doesn't work because slru's latest_page_number isn't set up yet (this is why we've been hearing reports of strange "apparent wraparound" log messages during crash recovery, but only from people who'd managed to advance their next-mxact counters some considerable distance from 0). In the second place, it seems a bit unwise to be throwing away data during crash recovery anwyway. This latter consideration convinces me to just disable truncation during recovery, rather than computing latest_page_number and pushing ahead. Tom Lane 2006-07-20 00:46:56 +00:00
  • 9dc842f083 Don't try to truncate multixact SLRU files in checkpoints done during xlog recovery. In the first place, it doesn't work because slru's latest_page_number isn't set up yet (this is why we've been hearing reports of strange "apparent wraparound" log messages during crash recovery, but only from people who'd managed to advance their next-mxact counters some considerable distance from 0). In the second place, it seems a bit unwise to be throwing away data during crash recovery anwyway. This latter consideration convinces me to just disable truncation during recovery, rather than computing latest_page_number and pushing ahead. Tom Lane 2006-07-20 00:46:42 +00:00
  • a8e44f0b1b Update GRANT USAGE on schema permission description. Bruce Momjian 2006-07-19 18:42:31 +00:00
  • c28fbd4589 pgcrypto merge cleanup: Neil Conway 2006-07-19 17:05:50 +00:00
  • 60cfe25e68 Adjust spawn_process() to avoid unnecessary overhead processes: we can just exec instead of creating a subprocess. This reduces process usage from four processes per parallel test to two. I have no idea whether a comparable optimization is possible or useful in the Windows port. Tom Lane 2006-07-19 17:02:59 +00:00
  • 87c3129e2e Update WIN32 quoting roles documentation. Bruce Momjian 2006-07-19 17:01:24 +00:00
  • 5b8b137b16 Adjust pg_regress to print out the exact string given to system() when 'make install' or 'initdb' fails. Also minor simplification of fgets() usage --- fgets guarantees a trailing null anyway. Tom Lane 2006-07-19 16:23:17 +00:00
  • 9d9a65bfa7 Add WIN32 compile suggestion to pginclude README. Bruce Momjian 2006-07-19 15:06:06 +00:00
  • fe2c4e414a kill() is declared in <signal.h> per Single Unix Spec. Tom Lane 2006-07-19 05:21:57 +00:00
  • 1c5531b108 Tweak command quoting for Windows (I'd forgotten about SYSTEMQUOTE). Tom Lane 2006-07-19 04:50:57 +00:00
  • bcee9e8c09 Remove unnecessary inclusion of libpq into pg_regress --- overly enthusiastic copy and paste ... Tom Lane 2006-07-19 04:02:31 +00:00
  • a38c85bd5d Rewrite pg_regress as a C program instead of a shell script. This allows it to be used on Windows without installing mingw (though you do still need 'diff'), and opens the door to future improvements such as message localization. Magnus Hagander and Tom Lane. Tom Lane 2006-07-19 02:37:00 +00:00
  • 88295244be copydir() and rmtree() need to use lstat, not stat, to behave as expected with symlinks. Noted while trying to use rmtree in new C-code pg_regress. Tom Lane 2006-07-18 22:36:46 +00:00
  • 11b7aecbd4 The Win32 DEF files that are generated for libpq contain the attribute "DESCRIPTION", which is actually only allowed for device drivers. The compilers ignore it with a warning - if we remove them, we get rid of the warning. Bruce Momjian 2006-07-18 22:18:08 +00:00
  • 5ca68299be Add pginclude testing ideas. Bruce Momjian 2006-07-18 19:19:59 +00:00
  • c5fad5f35e Done: Bruce Momjian 2006-07-18 18:20:51 +00:00
  • fcd1b0d891 Mark a few functions as static or NOT_USED. Bruce Momjian 2006-07-18 17:42:01 +00:00
  • 84e6042725 Make pg_regress a tad simpler and more general-purpose by removing its code to forcibly drop regressuser[1-4] and regressgroup[1-2]. Instead, let the privileges.sql test do that for itself (this is made easy by the recent addition of DROP ROLE IF EXISTS). Per a recent patch proposed by Joachim Wieland --- the rest of his patch is superseded by the rewrite into C, but this is a good idea we should adopt. Tom Lane 2006-07-18 00:32:42 +00:00
  • 2256d299bb Mention dependency problems caused by pgrminclude on include files. Bruce Momjian 2006-07-17 19:37:21 +00:00
  • d77f73eb2a Improve psql's \df slash command to include the argument names and modes (OUT or INOUT) of the function. Patch from David Fetter, editorialization by Neil Conway. Neil Conway 2006-07-17 00:21:23 +00:00
  • c1e59cc5d9 Minor documentation tweak: in the tables of functions and operators, don't include a space between the function name and the parenthesis that begins its parameter list, for consistency. Neil Conway 2006-07-16 23:59:58 +00:00
  • 5c75ff2af4 Include libpq/pqcomm.h to ensure we have correct knowledge of HAVE_STRUCT_SOCKADDR_STORAGE_SS_LEN. Per results of pgcheckdefines. Tom Lane 2006-07-16 20:28:01 +00:00
  • 93120f3501 In a Windows backend, don't build src/port/pgsleep.c's version of pg_usleep at all. Instead call the replacement function in port/win32/signal.c by that name. Avoids tricky macro-redefinition logic and suppresses a compiler warning; furthermore it ensures that no one can accidentally use the non-signal-aware version of pg_usleep in a Windows backend. Tom Lane 2006-07-16 20:17:04 +00:00
  • 96c5389342 Ensure that we retry rather than erroring out when send() or recv() return EINTR; the stats code was failing to do this and so were a couple of places in the postmaster. The stats code assumed that recv() could not return EINTR if a preceding select() showed the socket to be read-ready, but this is demonstrably false with our Windows implementation of recv(), and it may not be the case on all Unix variants either. I think this explains the intermittent stats regression test failures we've been seeing, as well as reports of stats collector instability under high load on Windows. Tom Lane 2006-07-16 18:17:35 +00:00
  • 74dac69e3c Ensure that we retry rather than erroring out when send() or recv() return EINTR; the stats code was failing to do this and so were a couple of places in the postmaster. The stats code assumed that recv() could not return EINTR if a preceding select() showed the socket to be read-ready, but this is demonstrably false with our Windows implementation of recv(), and it may not be the case on all Unix variants either. I think this explains the intermittent stats regression test failures we've been seeing, as well as reports of stats collector instability under high load on Windows. Tom Lane 2006-07-16 18:17:23 +00:00
  • e96373aae5 Ensure that we retry rather than erroring out when send() or recv() return EINTR; the stats code was failing to do this and so were a couple of places in the postmaster. The stats code assumed that recv() could not return EINTR if a preceding select() showed the socket to be read-ready, but this is demonstrably false with our Windows implementation of recv(), and it may not be the case on all Unix variants either. I think this explains the intermittent stats regression test failures we've been seeing, as well as reports of stats collector instability under high load on Windows. Tom Lane 2006-07-16 18:17:14 +00:00
  • a420818d67 Fix a few places where $Id$ and $Header$ CVS tags had crept into the source tree. They should all be $PostgreSQL$ of course. Tom Lane 2006-07-16 02:44:01 +00:00
  • 808849e54f Fix lack of repeat-inclusion guard in win32 substitute sys/socket.h. I think this explains the 'implicit declaration of function gai_strerror' warnings visible in the current buildfarm report from snake: if sys/socket.h is included again after getaddrinfo.h, the file would merrily undefine the gai_strerror macro. Tom Lane 2006-07-16 01:35:28 +00:00
  • 3ff58b48c9 Put back another not-so-unnecessary #include, per report from Hiroshi Saito. Tom Lane 2006-07-16 01:05:23 +00:00
  • c36418be40 Fix getDatumCopy(): don't use store_att_byval to copy into a Datum variable (this accounts for regression failures on PPC64, and in fact won't work on any big-endian machine). Get rid of hardwired knowledge about datum size rules; make it look just like datumCopy(). Tom Lane 2006-07-16 00:54:22 +00:00
  • e040ab44e4 Improve error message wording. Tom Lane 2006-07-16 00:52:05 +00:00
  • daecd97617 Put back some more not-so-unused-as-all-that #includes. This un-breaks the EXEC_BACKEND code on my machines, so hopefully it will fix the Windows buildfarm members. Tom Lane 2006-07-15 15:47:17 +00:00
  • 89e2a95589 Fix some pgcrypto portability issues, per Marko Kreen. Tom Lane 2006-07-15 15:27:14 +00:00
  • 9b556322c5 Fix some missing inclusions identified with new pgcheckdefines tool. Tom Lane 2006-07-15 03:35:21 +00:00
  • a7143b3088 Fix some makefiles that fail to yield good results from 'make -qp'. This doesn't really matter for ordinary building of Postgres, but it's useful for automated checks, such as my just-committed pgcheckdefines. Tom Lane 2006-07-15 03:33:14 +00:00
  • 2d11d26113 Create a tool to catch #include omissions that might not result in any compiler warning, specifically #ifdef or #if defined tests on symbols that are defined in a file not included. The results are a bit noisy and require care to interpret, but it's a lot better than no tool at all. Tom Lane 2006-07-15 03:27:42 +00:00
  • 98bac16e4d Fix misguided removal of access/tuptoaster.h inclusion, per Kris Jurka. I'm going to insist on reversion of this entire patch unless pgrminclude is upgraded to a less broken state, but in the meantime let's get contrib passing regression again. Tom Lane 2006-07-14 19:05:52 +00:00
  • e2f7eb36d6 In PGP public key tests, encrypt the secret key with AES not CAST5, so that the test passes with or without OpenSSL. Marko Kreen Tom Lane 2006-07-14 17:47:40 +00:00
  • cd24163f6d Fix another passel of include-file breakage. Kris Jurka, Tom Lane Tom Lane 2006-07-14 16:59:19 +00:00
  • 9f167f564c Add dependency to fix parallel-make race condition. Alexander Dupuy Tom Lane 2006-07-14 16:45:55 +00:00
  • 78e8400a52 Add dependency to fix parallel-make race condition. Alexander Dupuy Tom Lane 2006-07-14 16:45:48 +00:00
  • c743cc2ee4 Add dependency to fix parallel-make race condition. Alexander Dupuy Tom Lane 2006-07-14 16:45:43 +00:00
  • a4f1da03cc Have find_static skip main() functions. Bruce Momjian 2006-07-14 14:59:00 +00:00
  • e0522505bd Remove 576 references of include files that were not needed. Bruce Momjian 2006-07-14 14:52:27 +00:00
  • ae643747b1 Fix a passel of recently-committed violations of the rule 'thou shalt have no other gods before c.h'. Also remove some demonstrably redundant #include lines, mostly of <errno.h> which was added to c.h years ago. Tom Lane 2006-07-14 05:28:29 +00:00
  • 51e8882197 Revert part of recent include patch not ready for application. Bruce Momjian 2006-07-14 04:59:30 +00:00
  • 03c2e5924e Add additional includes needed on some platforms. Bruce Momjian 2006-07-14 04:44:46 +00:00
  • 06bed485b0 Move CFLAGS for pginclude to the end of the command line. Bruce Momjian 2006-07-14 01:05:14 +00:00
  • 3c3c610c57 A recent backpatch to 7.3's contrib/ltree got mixed up, putting code in the wrong place. This moves it to the right place which allows it to compile. Patch from Kris Jurka. Neil Conway 2006-07-14 00:32:46 +00:00
  • a10fc5f254 Minor doc tweak: replace a "--" with "&mdash;". Neil Conway 2006-07-14 00:13:05 +00:00
  • f2a8aa0f89 Reorder the entries in the function section of the manual, to ensure they are alphabetically ordered. I believe the tables were correctly ordered in the past, but some of them had subsequently regressed. Neil Conway 2006-07-13 23:59:47 +00:00
  • fad1ea86bd Move math.h after postgresql.h Bruce Momjian 2006-07-13 20:14:12 +00:00
  • 10157d4e6f Skip stripping postgres_fe.h include file. Bruce Momjian 2006-07-13 18:25:09 +00:00
  • b43ebe5f83 More include file adjustments. Bruce Momjian 2006-07-13 18:01:02 +00:00
  • b844dd3f9e More include file adjustments. Bruce Momjian 2006-07-13 17:47:02 +00:00
  • 66c15dfda1 Adjust /contrib for new include file contents. Bruce Momjian 2006-07-13 16:57:31 +00:00
  • a22d76d96a Allow include files to compile own their own. Bruce Momjian 2006-07-13 16:49:20 +00:00
  • 70e2e3d8b1 Improve pginclude tools to process include file usage by other include files. Bruce Momjian 2006-07-13 16:39:20 +00:00
  • a18faa1ba2 Remove trailing comma from CreateStmtLikeOption enum definition. This is harmless, but it causes a warning with Tru64's cc. Neil Conway 2006-07-13 15:09:57 +00:00
  • 6809c064d7 Be consistent about not using ECHO_N/ECHO_C (seems unnecessary on Linux). Peter Eisentraut 2006-07-13 14:44:33 +00:00
  • d0b54441db Fix C++-style comment. Neil Conway 2006-07-13 04:52:51 +00:00
  • 1abf76e82c "Annual" pgcrypto update from Marko Kreen: Neil Conway 2006-07-13 04:15:25 +00:00
  • 99ac1e69ba Fix pgrminclude to work for stripping include files. Bruce Momjian 2006-07-12 16:28:27 +00:00
  • de7e81fff4 Update schema USAGE permission description. Bruce Momjian 2006-07-12 15:37:10 +00:00
  • 9e196d7c92 Clean up for warning: fe-auth.c:573: warning: passing argument 1 of 'free' discards qualifiers from pointer target type pg_krb5_authname used to return a (const char *) to memory allocated by krb. Somewhere along the lines this was changed so that a copy was made, returned, and freed instead. However the const modifier was never removed. Joe Conway 2006-07-12 02:31:56 +00:00
  • 7234777674 Apply entab fix from Marko Kreen for these problems: Alvaro Herrera 2006-07-11 21:21:59 +00:00
  • d29b66882a Tweak fillfactor code as per my recent proposal. Fix nbtsort.c so that it can handle small fillfactors for ordinary-sized index entries without failing on large ones; fix nbtinsert.c to distinguish leaf and nonleaf pages; change the minimum fillfactor to 10% for all index types. Tom Lane 2006-07-11 21:05:57 +00:00
  • 1be8f80288 Improve pginclude tests. Bruce Momjian 2006-07-11 20:51:25 +00:00
  • 4084681546 Improve pginclude compile flags. Bruce Momjian 2006-07-11 20:12:29 +00:00
  • 8230fbf964 Update pginclude documentation. Bruce Momjian 2006-07-11 19:52:12 +00:00
  • 001d30ee6b Add support to GIN for =(anyarray,anyarray) operation Teodor Sigaev 2006-07-11 19:49:14 +00:00
  • 6d57ed7797 Have pgrminclude process include files too. Bruce Momjian 2006-07-11 19:45:16 +00:00
  • 22269434a6 Add $CFLAGS support to pgrminclude. Bruce Momjian 2006-07-11 19:34:34 +00:00
  • 1ddbfa16a8 Move pgrminclude debug code to be more effective. Bruce Momjian 2006-07-11 19:31:29 +00:00
  • 108fe524a9 Improve shell script wrapping. Bruce Momjian 2006-07-11 19:30:05 +00:00
  • 01835c495c Add comments to pgrminclude. Bruce Momjian 2006-07-11 19:25:41 +00:00
  • 0c1db67f6a Correct the description of the pg_get_viewdef() function. Do some nearby SGML cleanup: sort table entries alphabetically. Neil Conway 2006-07-11 19:11:27 +00:00
  • 2fa7a041f3 Correct the description of the pg_get_viewdef() function. Do some nearby SGML cleanup: sort table entries alphabetically. Neil Conway 2006-07-11 19:11:26 +00:00
  • ac230e7431 Alphabetically order reference to include files, "S"-"Z". Bruce Momjian 2006-07-11 18:26:11 +00:00
  • 0ff3461bcc Alphabetically order reference to include files, "N" - "S". Bruce Momjian 2006-07-11 17:26:59 +00:00
  • 3a534ade39 Alphabetically order reference to include files, "G" - "M". Bruce Momjian 2006-07-11 17:04:13 +00:00
  • 0031f99bfa Add URL of code presentation to developers FAQ. Bruce Momjian 2006-07-11 17:02:16 +00:00
  • 234163649e GIN improvements - Replace sorted array of entries in maintenance_work_mem to binary tree, this should improve create performance. - More precisely calculate allocated memory, eliminate leaks with user-defined extractValue() - Improve wordings in tsearch2 Teodor Sigaev 2006-07-11 16:55:34 +00:00
  • fa601357fb Sort reference of include files, "A" - "F". Bruce Momjian 2006-07-11 16:35:33 +00:00
  • 8d716f0e47 Remove no-longer-needed configure test for krb5_encrypt(), per Jim Gates. Tom Lane 2006-07-11 16:15:03 +00:00
  • c469aed1cb Remove no-longer-needed configure test for krb5_encrypt(), per Jim Gates. Tom Lane 2006-07-11 16:14:50 +00:00
  • 79aabd140d Fix bug corrupting query in gist consistent function. Thank to Mario Weilguni <mweilguni@sime.com> to discover a bug. Teodor Sigaev 2006-07-11 16:11:06 +00:00
  • 2962428b3a Fix bug corrupting query in gist consistent function. Thank to Mario Weilguni <mweilguni@sime.com> to discover a bug. Teodor Sigaev 2006-07-11 16:09:47 +00:00
  • 7284c36ae7 Fix bug corrupting query in gist consistent function. Thank to Mario Weilguni <mweilguni@sime.com> to discover a bug. Teodor Sigaev 2006-07-11 16:06:40 +00:00
  • f446ede326 Fix bug corrupting query in gist consistent function. Thank to Mario Weilguni <mweilguni@sime.com> to discover a bug. Teodor Sigaev 2006-07-11 16:02:50 +00:00
  • 4fe8ba63fe Fix bug corrupting query in gist consistent function. Thank to Mario Weilguni <mweilguni@sime.com> to discover a bug. Teodor Sigaev 2006-07-11 16:00:44 +00:00
  • c713683fd7 Reverse inclusion order of <ws2tcpip.h> and <winsock2.h>, per Dave Page. Tom Lane 2006-07-11 14:25:09 +00:00
  • b85a965f5f Allow each C include file to compile on its own by including any needed header files. Bruce Momjian 2006-07-11 13:54:25 +00:00
  • 45a4309074 Add libpq include directory to script. Bruce Momjian 2006-07-11 02:01:24 +00:00
  • 6e37be02e7 Fix ALTER TABLE to check pre-existing NOT NULL constraints when rewriting a table. Otherwise a USING clause that yields NULL can leave the table violating its constraint (possibly there are other cases too). Per report from Alexander Pravking. Tom Lane 2006-07-10 22:10:57 +00:00