Commit Graph

  • f5940e7b34 Add: Bruce Momjian 2006-06-25 16:27:41 +00:00
  • b4595d71f2 Moved some free() calls that coverity correctly complains about. Michael Meskes 2006-06-25 10:00:11 +00:00
  • 5ececcbbf5 Moved some free() calls that coverity correctly complains about. Michael Meskes 2006-06-25 09:59:18 +00:00
  • 17bab8c3fe Moved some free() calls that coverity correctly complains about. Michael Meskes 2006-06-25 09:38:40 +00:00
  • bd7f34ba78 Our version of getopt_long does not set optarg upon detecting an error, as opposed to what other versions apparently do, so it's not safe to print an error message. Besides, getopt_long itself already did, so it's redundant anyway. Alvaro Herrera 2006-06-25 04:38:08 +00:00
  • 15af8b771b Our version of getopt_long does not set optarg upon detecting an error, as opposed to what other versions apparently do, so it's not safe to print an error message. Besides, getopt_long itself already did, so it's redundant anyway. Alvaro Herrera 2006-06-25 04:38:00 +00:00
  • 885a4d3d9a Our version of getopt_long does not set optarg upon detecting an error, as opposed to what other versions apparently do, so it's not safe to print an error message. Besides, getopt_long itself already did, so it's redundant anyway. Alvaro Herrera 2006-06-25 04:37:55 +00:00
  • e970b2a62b Remove individual user copyright because the code is contributed to PGDG: Bruce Momjian 2006-06-25 01:45:32 +00:00
  • 199f8f2858 Fix GEVHDRSZ for Win32. Bruce Momjian 2006-06-25 01:02:12 +00:00
  • d8f75d4131 Fix Win32/Cygwin problems: Bruce Momjian 2006-06-25 00:18:24 +00:00
  • ac7a126d0c Update entry: Bruce Momjian 2006-06-24 23:47:58 +00:00
  • fc6a2293b5 Add UPDATE entry for row reuse. Bruce Momjian 2006-06-24 23:45:02 +00:00
  • 50aa69a825 Fix re-inclusion of port header file on Windows, per Magnus. Tom Lane 2006-06-24 14:52:48 +00:00
  • c2f3c168fb Clarified copyright notice Michael Meskes 2006-06-23 14:50:01 +00:00
  • fe090f0778 Back-patch 7.4-era fix for memory leak with SSL connections due to missing X509_free() calls. Per a request from a Red Hat customer; seems silly for Red Hat to be shipping a patch that's not in upstream. Tom Lane 2006-06-23 14:42:52 +00:00
  • 69bf0a0ddd Remove dllinit.c; it was only needed for long-obsolete Cygwin versions, and there was some question about its copyright status. Tom Lane 2006-06-22 23:50:35 +00:00
  • 1c718dd8bf pg_stop_backup was calling XLogArchiveNotify() twice for the newly created backup history file. Bug introduced by the 8.1 change to make pg_stop_backup delete older history files. Per report from Masao Fujii. Tom Lane 2006-06-22 20:43:20 +00:00
  • 3a04f53e7f pg_stop_backup was calling XLogArchiveNotify() twice for the newly created backup history file. Bug introduced by the 8.1 change to make pg_stop_backup delete older history files. Per report from Masao Fujii. Tom Lane 2006-06-22 20:42:57 +00:00
  • 39bed3b388 Standalone backends need pgstat_bestart() too, per Qingqing Zhou. Tom Lane 2006-06-22 14:36:12 +00:00
  • a5606579fc Move setup_cancel_handler() up near start of psql main(), where the setup_win32_locks() call formerly was, to ensure that cancelConnLock is valid when it needs to be. Per Yoshiyuki Asaba. Tom Lane 2006-06-21 19:40:31 +00:00
  • 59fd249a30 Remove ancient kluge that kept nodeAgg.c from crashing on UPDATEs involving aggregates. We just disallowed that, and AFAICS there should be no other cases where direct (non-aggregated) references to input columns are allowed in a query with aggregation and no GROUP BY. Tom Lane 2006-06-21 18:39:42 +00:00
  • 62ae14545b Disallow aggregate functions in UPDATE commands (unless within a sub-SELECT). This is disallowed by the SQL spec because it doesn't have any very sensible interpretation. Historically Postgres has allowed it but behaved strangely. As of PG 8.1 a server crash is possible if the MIN/MAX index optimization gets applied; rather than try to "fix" that, it seems best to just enforce the spec restriction. Per report from Josh Drake and Alvaro Herrera. Tom Lane 2006-06-21 18:30:19 +00:00
  • 1f5ca045a4 Disallow aggregate functions in UPDATE commands (unless within a sub-SELECT). This is disallowed by the SQL spec because it doesn't have any very sensible interpretation. Historically Postgres has allowed it but behaved strangely. As of PG 8.1 a server crash is possible if the MIN/MAX index optimization gets applied; rather than try to "fix" that, it seems best to just enforce the spec restriction. Per report from Josh Drake and Alvaro Herrera. Tom Lane 2006-06-21 18:30:11 +00:00
  • e256bafaa2 Eliminate a gratuitously different wording of the 'cannot use aggregate function in check constraint' error message. Tom Lane 2006-06-21 18:09:53 +00:00
  • e582d2ee1a - During dblink_open, if transaction state was IDLE, force cursor count to initially be 0. This is needed as a previous ABORT might have wiped out an automatically opened transaction without maintaining the cursor count. - Fix regression test expected file for the correct ERROR message, which we now get given the above bug fix. Joe Conway 2006-06-21 16:43:46 +00:00
  • 1d895f426f - During dblink_open, if transaction state was IDLE, force cursor count to initially be 0. This is needed as a previous ABORT might have wiped out an automatically opened transaction without maintaining the cursor count. - Fix regression test expected file for the correct ERROR message, which we now get given the above bug fix. Joe Conway 2006-06-21 16:43:11 +00:00
  • 04c5b69603 Clean up psql variable code a little: eliminate unnecessary tests in GetVariable() and be consistent about treatment of the list header. Motivated by noticing strspn() taking an unreasonable percentage of runtime --- the call removed from GetVariable() was the only one that could be in a high-usage path ... Tom Lane 2006-06-21 16:05:11 +00:00
  • ca6667fef0 Added some more coverity report patches send in by Martijn van Oosterhout <kleptog@svana.org>. Michael Meskes 2006-06-21 11:38:35 +00:00
  • ca1d26338b Added some more coverity report patches send in by Martijn van Oosterhout <kleptog@svana.org>. Michael Meskes 2006-06-21 11:38:26 +00:00
  • 3f9aace723 Added some more coverity report patches send in by Martijn van Oosterhout <kleptog@svana.org>. Michael Meskes 2006-06-21 11:38:07 +00:00
  • 6bba43111e Fixed small typo in changelog Michael Meskes 2006-06-21 10:34:48 +00:00
  • 289a3b73e2 Added fixes from the coverity report send in by Joachim Wieland <joe@mcknight.de> Added missing error handling in a few functions in ecpglib. Michael Meskes 2006-06-21 10:31:45 +00:00
  • 08f1973911 Added fixes from the coverity report send in by Joachim Wieland <joe@mcknight.de> Added missing error handling in a few functions in ecpglib. Michael Meskes 2006-06-21 10:29:50 +00:00
  • a829da152c Added fixed from the coverity report send in by Joachim Wieland <joe@mcknight.de> Added missing error handling in a few functions in ecpglib Michael Meskes 2006-06-21 10:24:41 +00:00
  • 27c3e3de09 Remove redundant gettimeofday() calls to the extent practical without changing semantics too much. statement_timestamp is now set immediately upon receipt of a client command message, and the various places that used to do their own gettimeofday() calls to mark command startup are referenced to that instead. I have also made stats_command_string use that same value for pg_stat_activity.query_start for both the command itself and its eventual replacement by <IDLE> or <idle in transaction>. There was some debate about that, but no argument that seemed convincing enough to justify an extra gettimeofday() call. Tom Lane 2006-06-20 22:52:00 +00:00
  • 47a37aeebd Split definitions for md5.c out of crypt.h and into their own header libpq/md5.h, so that there's a clear separation between backend-only definitions and shared frontend/backend definitions. (Turns out this is reversing a bad decision from some years ago...) Fix up references to crypt.h as needed. I looked into moving the code into src/port, but the headers in src/include/libpq are sufficiently intertwined that it seems more work than it's worth to do that. Tom Lane 2006-06-20 19:56:52 +00:00
  • eaf8f312c7 Some editorial work on the documentation of the current-date/time functions. Tom Lane 2006-06-19 16:13:01 +00:00
  • 49f1f24450 Back-port shell script syntax fix needed for some BSD machines. Per buildfarm results from spoonbill. Tom Lane 2006-06-19 14:25:01 +00:00
  • 9e6815ef0f Do not use already free'ed errmsg, bug found by Joachim Wieland <joachim.wieland@credativ.de> Michael Meskes 2006-06-19 09:20:32 +00:00
  • 14f52896b8 Do not use already free'ed errmsg, bug found by Joachim Wieland <joachim.wieland@credativ.de> Michael Meskes 2006-06-19 09:20:22 +00:00
  • 23623f05f0 Do not use already free'ed errmsg, bug found by Joachim Wieland <joachim.wieland@credativ.de> Michael Meskes 2006-06-19 09:20:07 +00:00
  • aaf125f8df Do not use already free'ed errmsg, bug found by Joachim Wieland <joachim.wieland@credativ.de> Michael Meskes 2006-06-19 09:19:49 +00:00
  • b13c9686d0 Take the statistics collector out of the loop for monitoring backends' current commands; instead, store current-status information in shared memory. This substantially reduces the overhead of stats_command_string and also ensures that pg_stat_activity is fully up to date at all times. Per my recent proposal. Tom Lane 2006-06-19 01:51:22 +00:00
  • 6075feed40 Update my email address. Bruce Momjian 2006-06-18 19:34:00 +00:00
  • 1e8ae13640 Don't try to call posix_fadvise() unless <fcntl.h> supplies a declaration for it. Hopefully will fix core dump evidenced by some buildfarm members since fadvise patch went in. The actual definition of the function is not ABI-compatible with compiler's default assumption in the absence of any declaration, so it's clearly unsafe to try to call it without seeing a declaration. Tom Lane 2006-06-18 18:30:21 +00:00
  • 22045666d6 Fix saveHistory() to not emit bogus complaint during psql exit when using Darwin's libedit; per my proposal last August. Also, suppress cast-away- const warnings. Tom Lane 2006-06-18 17:30:48 +00:00
  • 605cb39576 Increase timeout in statement_timeout test from 1 second to 2 seconds. We have once or twice seen failures suggesting that control didn't get to the exception block before the timeout elapsed, which is unlikely but not impossible in a parallel regression test (with a dozen other backends competing for cycles). This change doesn't completely prevent the problem of course, but it should reduce the probability enough that we don't see it anymore. Per buildfarm results. Tom Lane 2006-06-18 16:21:40 +00:00
  • 63b103aac8 Increase timeout in statement_timeout test from 1 second to 2 seconds. We have once or twice seen failures suggesting that control didn't get to the exception block before the timeout elapsed, which is unlikely but not impossible in a parallel regression test (with a dozen other backends competing for cycles). This change doesn't completely prevent the problem of course, but it should reduce the probability enough that we don't see it anymore. Per buildfarm results. Tom Lane 2006-06-18 16:21:32 +00:00
  • f1e671a0b4 Increase timeout in statement_timeout test from 1 second to 2 seconds. We have once or twice seen failures suggesting that control didn't get to the exception block before the timeout elapsed, which is unlikely but not impossible in a parallel regression test (with a dozen other backends competing for cycles). This change doesn't completely prevent the problem of course, but it should reduce the probability enough that we don't see it anymore. Per buildfarm results. Tom Lane 2006-06-18 16:21:23 +00:00
  • 5266f221a2 Merge postmaster and postgres command into just postgres. postmaster symlink is kept for now for compatibility. To call single-user mode, use postgres --single. Peter Eisentraut 2006-06-18 15:38:37 +00:00
  • 34fe15672d backport workaround for OpenBSD compiler bug Andrew Dunstan 2006-06-17 14:50:44 +00:00
  • b243d39456 backport workaround for OpenBSD compiler bug Andrew Dunstan 2006-06-17 14:49:02 +00:00
  • 44cb3ae7ef Fix a couple of obvious problems in DROP IF EXISTS patch. Tom Lane 2006-06-16 23:50:48 +00:00
  • c892643a3c Code review for SELECT INTO STRICT patch: use saner choices of error SQLSTATEs, fix some documentation problems. Tom Lane 2006-06-16 23:29:27 +00:00
  • 33e125cc0b Clean up after someone's curious idea that it'd be good to strip leading zeroes from the SQLSTATE codes. They're strings, people, not numbers. Tom Lane 2006-06-16 22:41:50 +00:00
  • 3ba3e6c8ce Clean up after someone's curious idea that it'd be good to strip leading zeroes from the SQLSTATE codes. They're strings, people, not numbers. Tom Lane 2006-06-16 22:41:45 +00:00
  • e287fb27a5 docs for DROP ... IF EXISTS for the following cases: language, tablespace, trigger, rule, opclass, function, aggregate. operator, and cast. Andrew Dunstan 2006-06-16 22:27:55 +00:00
  • bac6570e78 Add: Bruce Momjian 2006-06-16 22:08:46 +00:00
  • dceac3acc0 Add: Bruce Momjian 2006-06-16 22:05:01 +00:00
  • f44391b0a0 Document issues with non-default tablespaces and pg_dumpall restores. Bruce Momjian 2006-06-16 22:01:22 +00:00
  • 4fff9d7290 Document issues with non-default tablespaces and pg_dumpall restores. Bruce Momjian 2006-06-16 22:01:17 +00:00
  • b055f00ebb Add URL for ISO dates: Bruce Momjian 2006-06-16 21:41:24 +00:00
  • bbcd01692b DROP ... IF EXISTS for the following cases: language, tablespace, trigger, rule, opclass, function, aggregate. operator, and cast. Andrew Dunstan 2006-06-16 20:23:45 +00:00
  • e79cc2db00 Add URL for currency type: Bruce Momjian 2006-06-16 19:49:50 +00:00
  • 237756b1ce Add URL for updatable views: Bruce Momjian 2006-06-16 18:50:24 +00:00
  • 1d9273b506 Add: Bruce Momjian 2006-06-16 18:48:42 +00:00
  • 06e10abc0b Fix problems with cached tuple descriptors disappearing while still in use by creating a reference-count mechanism, similar to what we did a long time ago for catcache entries. The back branches have an ugly solution involving lots of extra copies, but this way is more efficient. Reference counting is only applied to tupdescs that are actually in caches --- there seems no need to use it for tupdescs that are generated in the executor, since they'll go away during plan shutdown by virtue of being in the per-query memory context. Neil Conway and Tom Lane Tom Lane 2006-06-16 18:42:24 +00:00
  • b49ce32da1 Add URL to: Bruce Momjian 2006-06-16 18:38:39 +00:00
  • 64861671c9 Add URL for freespace map filling. Bruce Momjian 2006-06-16 18:37:31 +00:00
  • 632545d15c > > * Add support for public SYNONYMS > > http://archives.postgresql.org/pgsql-hackers/2006-03/msg00519.php Bruce Momjian 2006-06-16 18:32:07 +00:00
  • 16d8e82221 > o Add PL/Python tracebacks > > http://archives.postgresql.org/pgsql-patches/2006-02/msg00288.php Bruce Momjian 2006-06-16 18:11:03 +00:00
  • dc86109eba Add: Bruce Momjian 2006-06-16 17:44:43 +00:00
  • ad44b464d1 Add URL for: Bruce Momjian 2006-06-16 17:25:38 +00:00
  • 56e967f4ba Add to locale TODO.detail. Bruce Momjian 2006-06-16 17:14:32 +00:00
  • cfe71bd35d Add URL for ISO date/time syntax: > > http://archives.postgresql.org/pgsql-hackers/2006-01/msg00250.php > Bruce Momjian 2006-06-16 16:59:30 +00:00
  • 28b0d6bf62 Add LDAP documentation missed in code patch. Bruce Momjian 2006-06-16 15:16:16 +00:00
  • 8fc2a5afa7 Update preload_library magic block wording. Bruce Momjian 2006-06-16 12:47:49 +00:00
  • 40bc06fa16 Test for POSIX_FADV_DONTNEED to use posix_fadvise(). Bruce Momjian 2006-06-16 04:11:48 +00:00
  • 91fc80d0d3 Fix: Bruce Momjian 2006-06-16 04:04:52 +00:00
  • 57ffc4d78b Update magic block wording for preloaded libraries. Bruce Momjian 2006-06-16 04:02:35 +00:00
  • 94a5c4a01b Use posix_fadvise() to avoid kernel caching of WAL contents on WAL file close. Bruce Momjian 2006-06-15 19:15:00 +00:00
  • a584c12426 Add STRICT to PL/pgSQL SELECT INTO, so exceptions are thrown if more or less than one row is returned by the SELECT, for Oracle PL/SQL compatibility. Bruce Momjian 2006-06-15 18:02:22 +00:00
  • eb5558bce8 Fix to_ascii() markup error. Bruce Momjian 2006-06-15 17:52:48 +00:00
  • 167c7bb49a Add mention that preload_libraries check the magic block, so non-PostgreSQL libraries cannot be loaded using this capability. Bruce Momjian 2006-06-15 17:49:09 +00:00
  • 6241f46495 Update syntax suggestion: Bruce Momjian 2006-06-15 17:42:02 +00:00
  • 712e824ff1 Move list of supported to_ascii() encodings from footnote to main description. Bruce Momjian 2006-06-15 17:38:26 +00:00
  • fe8c1165d9 Add: Bruce Momjian 2006-06-15 17:17:41 +00:00
  • 653fa21700 Clarify dynamic pl/pgsql item and add URLs. Restructure server-side section into PL/pgSQL and non-PL/pgSQL sections: Bruce Momjian 2006-06-15 16:54:13 +00:00
  • fce5033b4a Add: Bruce Momjian 2006-06-15 16:02:32 +00:00
  • f8cdc265ea Done, removed: Bruce Momjian 2006-06-15 02:23:13 +00:00
  • 8b9bc234ad Remove the limit on the number of entries allowed in catcaches, and remove the infrastructure needed to enforce the limit, ie, the global LRU list of cache entries. On small-to-middling databases this wins because maintaining the LRU list is a waste of time. On large databases this wins because it's better to keep more cache entries (we assume such users can afford to use some more per-backend memory than was contemplated in the Berkeley-era catcache design). This provides a noticeable improvement in the speed of psql \d on a 10000-table database, though it doesn't make it instantaneous. Tom Lane 2006-06-15 02:08:09 +00:00
  • e1e133f264 Add to locale TODO.detail. Bruce Momjian 2006-06-14 23:28:22 +00:00
  • a9d2cc4d76 Remove, done: Bruce Momjian 2006-06-14 23:19:04 +00:00
  • d5ddb87616 Add: Bruce Momjian 2006-06-14 23:07:55 +00:00
  • ca2bb27529 Add URL to ILIKE encoding fix: Bruce Momjian 2006-06-14 23:03:12 +00:00
  • 8d21abd733 Add: Bruce Momjian 2006-06-14 22:31:53 +00:00
  • cda6a5a580 Already done: Bruce Momjian 2006-06-14 22:23:05 +00:00
  • 6894d695fa Done by Peter: Bruce Momjian 2006-06-14 21:58:21 +00:00
  • 456a852d5b Add: Bruce Momjian 2006-06-14 21:54:43 +00:00
  • 2f8ea0275d Add: Bruce Momjian 2006-06-14 21:47:06 +00:00