Commit Graph

  • f7587aeba8 > Am Dienstag, 17. August 2004 14:26 schrieb Fabien COELHO: > > The patch adds missing the "libpgport.a" file to the installation under > > "install-all-headers". It is needed by some contribs. I install the > > library in "pkglibdir", but I was wondering whether it should be "libdir"? Bruce Momjian 2004-08-28 22:55:06 +00:00
  • 922599464f Fix high-bit comparison compiler warning in pg_dump. Bruce Momjian 2004-08-28 22:52:50 +00:00
  • 5395aed9d5 Add regression tests for ALTER INDEX. Bruce Momjian 2004-08-28 22:06:04 +00:00
  • f78ecbf20e Now that TransactionIdDidAbort doesn't think it should try to modify pg_clog, there's no reason to do abort marking of subtransactions in a nonintuitive order. Tom Lane 2004-08-28 22:04:12 +00:00
  • c8702dcb8e Propogate pg_ctl -D to the postmaster for command-line identification. Bruce Momjian 2004-08-28 22:04:01 +00:00
  • 7531d2fd85 Add missing Assert to make TransactionIdDidAbort more consistent with TransactionIdDidCommit. Tom Lane 2004-08-28 21:58:59 +00:00
  • d77f74fa7e Remove contrib/rserv, since there are better replication solutions available elsewhere (including a descendant project on gborg). Tom Lane 2004-08-28 21:36:25 +00:00
  • 4d608ac197 Prevent pg_ctl restart from adding -D datadir multiple times. Bruce Momjian 2004-08-28 21:10:00 +00:00
  • 448eb0837f Rearrange order of operations in heap_drop_with_catalog and index_drop so that we close and flush the doomed relation's relcache entry before we start to delete the underlying catalog rows, rather than afterwards. For awhile yesterday I thought that an unexpected relcache entry rebuild partway through this sequence might explain the infrequent parallel regression failures we were chasing. It doesn't, mainly because there's no CommandCounterIncrement in the sequence and so the deletions aren't "really" done yet. But it sure seems like trouble waiting to happen. Tom Lane 2004-08-28 21:05:26 +00:00
  • a0a61f494d > > Another issue is that when installing the Postgres service with > > "pg_ctl register -w ...." the "-w" parameter was not put in > the registry "ImagePath" > > value for the Postgres service. (I added it manually to test.) So I > > suspect that "pg_ctl register" will need to be enhanced to add the > > "-w" parameter to the registry settings. Bruce Momjian 2004-08-28 21:01:38 +00:00
  • cc28a275cb Use dynamic buffer for token buffer in win32 admin check Bruce Momjian 2004-08-28 21:00:35 +00:00
  • 1c72d0dec1 Fix relcache to account properly for subtransaction status of 'new' relcache entries. Also, change TransactionIdIsCurrentTransactionId() so that if consulted during transaction abort, it will not say that the aborted xact is still current. (It would be better to ensure that it's never called at all during abort, but I'm not sure we can easily guarantee that.) In combination, these fix a crash we have seen occasionally during parallel regression tests of 8.0. Tom Lane 2004-08-28 20:31:44 +00:00
  • f900af7961 Further tightening of the array literal parser. Prevent junk from being accepted after the outer right brace. Per report from Markus Bertheau. Joe Conway 2004-08-28 19:31:29 +00:00
  • f444dafab0 Can't truncate pg_subtrans during a recovery checkpoint --- subtrans module isn't fully initialized yet. Tom Lane 2004-08-28 18:18:03 +00:00
  • 7ff1c9d974 Add missing semicolon; some bison versions warn of this. Tom Lane 2004-08-28 18:04:51 +00:00
  • 3e3f70a28a Fix Windows emulation of kill(pid, 0). This will now succeed, but only if the target PID is a PG postmaster or backend --- for our purposes that is actually better than the Unix behavior. Per Dave Page and Andrew Dunstan. Tom Lane 2004-08-27 18:31:48 +00:00
  • 288e0404b8 Make gistindex_keytest safe against NULL values. Same fix was already made in passing for 8.0, but now that we have a bug report showing it's needed, we should put it into 7.4 branch. Tom Lane 2004-08-27 17:47:56 +00:00
  • 1785acebf2 Introduce local hash table for lock state, as per recent proposal. PROCLOCK structs in shared memory now have only a bitmask for held locks, rather than counts (making them 40 bytes smaller, which is a good thing). Multiple locks within a transaction are counted in the local hash table instead, and we have provision for tracking which ResourceOwner each count belongs to. Solves recently reported problem with memory leakage within long transactions. Tom Lane 2004-08-27 17:07:42 +00:00
  • ef16b4e157 Update wording: Bruce Momjian 2004-08-27 04:34:28 +00:00
  • 968b87686a Update win32 comments. Bruce Momjian 2004-08-27 02:09:18 +00:00
  • 3bc7564cf9 Update: Bruce Momjian 2004-08-27 01:44:49 +00:00
  • 337b513e07 Fix user locks. Broken some time ago for all platforms by Windows-related changes. Tom Lane 2004-08-26 17:23:30 +00:00
  • 51d7e25651 Improve some comments. Tom Lane 2004-08-26 17:22:28 +00:00
  • dd9923eb25 New Win32 wording that mentions "code". Bruce Momjian 2004-08-26 16:54:36 +00:00
  • 32142e2a60 Update documentation to prefer CIDR format for pg_hba.conf and use new CIDR column in examples first. Bruce Momjian 2004-08-26 16:50:05 +00:00
  • 8ec3221d32 Update Win32 wording. Bruce Momjian 2004-08-26 13:44:38 +00:00
  • cf5dd06755 Add warning about Win32 bugs in this release. Bruce Momjian 2004-08-26 13:08:59 +00:00
  • ce8a4ffca6 Update Japanese FAQ. Bruce Momjian 2004-08-26 04:09:59 +00:00
  • 4b9ca271d6 Update tcp connection faq. Bruce Momjian 2004-08-26 03:18:25 +00:00
  • 93c3baa96f Add: Bruce Momjian 2004-08-26 03:09:13 +00:00
  • 7584194cc9 Fix typo in comment, per Andrew Dunstan. Tom Lane 2004-08-25 20:07:57 +00:00
  • fe455ee1d4 Revise ResourceOwner code to avoid accumulating ResourceOwner objects for every command executed within a transaction. For long transactions this was a significant memory leak. Instead, we can delete a portal's or subtransaction's ResourceOwner immediately, if we physically transfer the information about its locks up to the parent owner. This does not fully solve the leak problem; we need to do something about counting multiple acquisitions of the same lock in order to fix it. But it's a necessary step along the way. Tom Lane 2004-08-25 18:43:43 +00:00
  • b662311db0 Translation update Peter Eisentraut 2004-08-24 21:45:40 +00:00
  • 0d719d0b04 Translation update Peter Eisentraut 2004-08-24 21:45:13 +00:00
  • a56cebb18f Translation update Peter Eisentraut 2004-08-24 21:35:19 +00:00
  • 3cb1ffa653 Allow second and subsequent names in a qualified (dotted) name to be ColLabel instead of just ColId --- that is, any keyword can appear after a dot and it will be taken as an identifier. Fixes problems with names that are okay as standalone function names but fail when qualified. Tom Lane 2004-08-24 20:41:40 +00:00
  • 4359ebed37 Update item: Bruce Momjian 2004-08-24 11:09:44 +00:00
  • cda1bd6cfe Various minor improvements to the SGML documentation: fix some incorrect SGML markup, add a "deprecated features" section to the 8.0 release notes, untabify release.sgml and runtime.sgml, and make some other minor improvements. Neil Conway 2004-08-24 00:06:51 +00:00
  • 4dbb880d3c Rearrange pg_subtrans handling as per recent discussion. pg_subtrans updates are no longer WAL-logged nor even fsync'd; we do not need to, since after a crash no old pg_subtrans data is needed again. We truncate pg_subtrans to RecentGlobalXmin at each checkpoint. slru.c's API is refactored a little bit to separate out the necessary decisions. Tom Lane 2004-08-23 23:22:45 +00:00
  • 059912ce2e Mention removal of page images in PITR files: Bruce Momjian 2004-08-23 21:56:50 +00:00
  • 728026a6bc Update that 8.0 will support MS Win natively. Bruce Momjian 2004-08-23 21:51:53 +00:00
  • 1549f5e440 Update newest version number. Bruce Momjian 2004-08-23 16:16:43 +00:00
  • f009c316ba Tweak code so that pg_subtrans is never consulted for XIDs older than RecentXmin (== MyProc->xmin). This ensures that it will be safe to truncate pg_subtrans at RecentGlobalXmin, which should largely eliminate any fear of bloat. Along the way, eliminate SubTransXidsHaveCommonAncestor, which isn't really needed and could not give a trustworthy result anyway under the lookback restriction. In an unrelated but nearby change, #ifdef out GetUndoRecPtr, which has been dead code since 2001 and seems unlikely to ever be resurrected. Tom Lane 2004-08-22 02:41:58 +00:00
  • 37d937ea2c Code review for ALTER INDEX patch. Tom Lane 2004-08-22 00:08:28 +00:00
  • 235caf4bb2 Fix tab completion for ALTER INDEX. Bruce Momjian 2004-08-21 18:45:59 +00:00
  • bebbbde6aa Seems it would be nice if the ALTER INDEX ref page were actually linked into the docs ... Tom Lane 2004-08-21 16:16:04 +00:00
  • c1700bf8c0 Fix typo (extraneous comma). Tom Lane 2004-08-21 15:45:46 +00:00
  • ade9cbafdf Mention that to_char(interval) will be removed in 8.1. Bruce Momjian 2004-08-21 03:25:34 +00:00
  • d21eabc61a Remove Solaris bug mention in pg_hba.conf. Bruce Momjian 2004-08-21 03:21:57 +00:00
  • 34f34a041c Fix pg_ctl -w to properly wait on server startup. Bruce Momjian 2004-08-21 03:12:55 +00:00
  • 3bd726333c Recent tightening of allowed array-literal syntax broke one test case in contrib/ltree. Fix. Tom Lane 2004-08-21 00:26:54 +00:00
  • 86d78021a4 Whack btree_gist code around until it has some small hope of building on non-gcc compilers. Tom Lane 2004-08-21 00:09:10 +00:00
  • bf9d9bd2f3 Recognize plpgsql EXCEPTION condition names at function compile time instead of runtime, for better detection of invalid condition names (and maybe a little more speed, too). Tom Lane 2004-08-20 22:00:14 +00:00
  • 009b0d1a85 >>At this stage of the game I would just change pg_hba.conf.sample to use >>'127.0.0.1/32' instead of '127.0.0.1 255.255.255.255'. >> >> > >Yeah, that's probably the path of least resistance. Note that the >comments and possibly the SGML docs need to be adjusted to match, >however, so it's not quite a one-liner. Bruce Momjian 2004-08-20 20:23:06 +00:00
  • 3ca998b951 Allow psql to use 7.4.X database by not referencing tablespaces. Bruce Momjian 2004-08-20 20:18:23 +00:00
  • ee85595d46 > Please find enclose a submission to fix these problems. > > The patch adds missing the "libpgport.a" file to the installation under > "install-all-headers". It is needed by some contribs. I install the > library in "pkglibdir", but I was wondering whether it should be "libdir"? > I was wondering also whether it would make sense to have a "libpgport.so"? > > It fixes various macros which are used by contrib makefiles, especially > libpq_*dir and LDFLAGS when used under PGXS. It seems to me that they are > needed to > > It adds the ability to test and use PGXS with contribs, with "make > USE_PGXS=1". Without the macro, this is exactly as before, there should be > no difference, esp. wrt the vpath feature that seemed broken by previous > submission. So it should not harm anybody, and it is useful at least to me. > > It fixes some inconsistencies in various contrib makefiles > (useless override, ":=" instead of "="). Bruce Momjian 2004-08-20 20:13:10 +00:00
  • ff8e5526dd Add ALTER SCHEMA item detail: Bruce Momjian 2004-08-20 20:07:12 +00:00
  • f7168bd44c They are two different problems; the TOC entry is important for any multiline command or to rerun the command easily later. Bruce Momjian 2004-08-20 20:00:34 +00:00
  • b43fd16eec I notice that contrib/fuzzystrmatch/dmetaphone.c doesn't compile cleanly as it stands - it mixes declarations in code, C++-style. The attached patch shifts declarations to the tops of functions and enables this file to compile cleanly as C. Bruce Momjian 2004-08-20 19:48:14 +00:00
  • a9ed7476a0 Add psql tab completion TODO: Bruce Momjian 2004-08-20 19:30:39 +00:00
  • cecf41bd29 Attached is the third version of my patch that adds/fixes several things to/in the psql-tabcomplete code. This diff includes the still missing tab-complete support for TABLESPACE I already sent earlier. New in this version of the patch is a small adaption of the tab-complete code to support the adjusted SAVEPOINT-Syntax commited by Tom, as well as completion of the only half working (and I think only by accident) tabcomplete-suppport for "BEGIN [ TRANSACTION | WORK ]". Bruce Momjian 2004-08-20 19:24:59 +00:00
  • 1b5e0143b5 This patch allows pg_restore to recognize $-quotes in SQL queries. It will treat any unquoted string that starts with a $ and has no preceding identifier chars as a potential $-quote tag, it then makes sure that the tag chars are valid. If so, it processes the $-quote. Bruce Momjian 2004-08-20 16:07:15 +00:00
  • fcc5b95e0f Add mention of environment variable conflict with uncommenting config file variables: Bruce Momjian 2004-08-20 15:20:27 +00:00
  • 0bd5a8cd59 Fix typo in new ALTER INDEX manual page. Bruce Momjian 2004-08-20 14:56:57 +00:00
  • 09d4e96d7e Add ALTER INDEX, particularly for moving tablespaces. Bruce Momjian 2004-08-20 04:29:33 +00:00
  • daa076c4fd > Please find attached a submission to add a "exit on error" option to > pg_restore, as it seems that some people have scripts that rely on the > previous "abort on error" default behavior when restoring data with a > direct connection. > > Fabien Coelho Bruce Momjian 2004-08-20 04:20:23 +00:00
  • 46be0c18f1 > After all that about numbering centuries and millenia correctly, > why does CVS tip still give me > > regression=# select extract(century from now()); > date_part > ----------- > 20 > (1 row) > [ ... looks in code ... ] > > Apparently it's because you fixed only timestamp_part, and not > timestamptz_part. I'm not too sure about what timestamp_trunc or > timestamptz_trunc should do, but they may be wrong as well. Bruce Momjian 2004-08-20 03:45:14 +00:00
  • 2674bbbe99 Add: Bruce Momjian 2004-08-20 03:06:00 +00:00
  • 4d328bcd9c Update wording on commented postgresql.conf values: Bruce Momjian 2004-08-19 22:25:09 +00:00
  • bbd6eb5b95 Repair some issues with column aliases and RowExpr construction in the presence of dropped columns. Document the already-presumed fact that eref aliases in relation RTEs are supposed to have entries for dropped columns; cause the user alias structs to have such entries too, so that there's always a one-to-one mapping to the underlying physical attnums. Adjust expandRTE() and related code to handle the case where a column that is part of a JOIN has been dropped. Generalize expandRTE()'s API so that it can be used in a couple of places that formerly rolled their own implementation of the same logic. Fix ruleutils.c to suppress display of aliases for columns that were dropped since the rule was made. Tom Lane 2004-08-19 20:57:41 +00:00
  • a59084fe5e Update 7.2 regression tests to match what you get when using a modern version of Bison. REL7_2_5 Tom Lane 2004-08-19 20:03:49 +00:00
  • 040450beef Use backslash in %USERPROFILE%\.pgpass. Bruce Momjian 2004-08-19 16:39:13 +00:00
  • 04854a89ef Add: Bruce Momjian 2004-08-19 02:36:24 +00:00
  • 84f878f5cd Don't use get_home_path so libpq doesn't pull path.c into the library. Bruce Momjian 2004-08-19 00:00:34 +00:00
  • 76dd2333d5 Clean up some random departures from project's standard declaration style. Tom Lane 2004-08-18 19:27:13 +00:00
  • f657594bf7 Remove NT4 mention in release notes. Bruce Momjian 2004-08-18 15:48:36 +00:00
  • 7500704167 Remove as duplicate: Bruce Momjian 2004-08-18 04:00:32 +00:00
  • 83f8fb7459 Add: Bruce Momjian 2004-08-18 03:51:35 +00:00
  • 1f0a19c263 The enclose patch clarifies and makes a more useful example for the Global Values in PL/Perl section of the documents. Bruce Momjian 2004-08-18 03:37:56 +00:00
  • 3d20578e93 Add pg_dump section: Bruce Momjian 2004-08-18 03:19:42 +00:00
  • 0bdacf50f1 Brand 7.4.5 ... now that was our shortest-lived release ever ... REL7_4_5 Tom Lane 2004-08-18 03:11:25 +00:00
  • af032f15da Replace incorrect example for quote_ident Bruce Momjian 2004-08-18 03:06:56 +00:00
  • 94bb5fe888 Update release history for 7.4.5. Tom Lane 2004-08-18 03:03:49 +00:00
  • 950c8afcb4 Update release history for 7.4.5. Tom Lane 2004-08-18 03:03:32 +00:00
  • 1abf13db3c Add get_home_path() to use USERPROFILE on Win32 and HOME on Unix. Bruce Momjian 2004-08-18 02:59:12 +00:00
  • ba9b9a6e62 Fix bug introduced into _bt_getstackbuf() on 2003-Feb-21: the initial value of 'start' could be past the end of the page, if the page was split by some concurrent inserting process since we visited it. In this situation the code could look at bogus entries and possibly find a match (since after all those entries still contain what they had before the split). This would lead to 'specified item offset is too large' followed by 'PANIC: failed to add item to the page', as reported by Joe Conway for scenarios involving heavy concurrent insertion activity. Tom Lane 2004-08-17 23:16:07 +00:00
  • 19cd31b068 Fix bug introduced into _bt_getstackbuf() on 2003-Feb-21: the initial value of 'start' could be past the end of the page, if the page was split by some concurrent inserting process since we visited it. In this situation the code could look at bogus entries and possibly find a match (since after all those entries still contain what they had before the split). This would lead to 'specified item offset is too large' followed by 'PANIC: failed to add item to the page', as reported by Joe Conway for scenarios involving heavy concurrent insertion activity. Tom Lane 2004-08-17 23:15:33 +00:00
  • fcaad7e2c1 Standardize on the assumption that the arguments of a RowExpr correspond to the physical layout of the rowtype, ie, there are dummy arguments corresponding to any dropped columns in the rowtype. We formerly had a couple of places that did it this way and several others that did not. Fixes Gaetano Mendola's "cache lookup failed for type 0" bug of 5-Aug. Tom Lane 2004-08-17 18:47:09 +00:00
  • 388ffad040 Add: Bruce Momjian 2004-08-17 17:14:56 +00:00
  • f5f5d7bead Remove transactions TODO.detail. Bruce Momjian 2004-08-17 17:11:44 +00:00
  • 3f0fa93cfc Chain on to SIGPIPE handler rather than just do action on default. Bruce Momjian 2004-08-17 16:54:47 +00:00
  • 0d4aa039ac Fix agressive collection of thread flags. Bruce Momjian 2004-08-17 15:19:09 +00:00
  • 26f6111dd9 Add comment about portability function name inconsistency. Bruce Momjian 2004-08-17 14:38:38 +00:00
  • 109d7aff73 Fix linking problem when enabling thread safety on Darwin: uninitialized global variables are problematic on this platform. Simplest solution seems to be to initialize pthread key variable to 0. Also, rename this variable and check_sigpipe_handler to something involving "pq" to avoid gratuitous pollution of application namespace. Tom Lane 2004-08-17 04:24:23 +00:00
  • 8b82a705c8 Add DLLIMPORT for PostGIS. Bruce Momjian 2004-08-17 02:51:32 +00:00
  • 26fc9b655b Move io.h include higher in the file so it doesn't conflict with rename/unlink defined later. Problem exists on MS VC. Bruce Momjian 2004-08-17 02:44:13 +00:00
  • 6a5718b1ee Fix syntax error just introduced. Bruce Momjian 2004-08-16 23:49:58 +00:00
  • 23b6ade8f0 autoconf for recent thread check changes. Bruce Momjian 2004-08-16 23:41:44 +00:00
  • 64410289f8 Add trivial NULL statement to plpgsql, for Oracle compatibility. Tom Lane 2004-08-16 17:52:06 +00:00
  • bc91389df9 Add: Bruce Momjian 2004-08-16 16:14:31 +00:00