hcq/sysbench
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes #10: oltp: pgsql query execution failed

Browse Source 
Handle deadlocks correctly in the PostgreSQL driver, i.e. return
SB_DB_ERROR_DEADLOCK to the upper layer to restart the transaction and
increment the deadlocks counter.
This commit is contained in:
Alexey Kopytov
2015-09-23 16:59:04 +03:00
parent 26abf0c893
commit 76fc3ef79e
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
sysbench/drivers/pgsql/Makefile.am
View File

@ -17,6 +17,6 @@
noinst_LIBRARIES = libsbpgsql.a
libsbpgsql_a_SOURCES = drv_pgsql.c
libsbpgsql_a_CPPFLAGS = $(PGSQL_CFLAGS) $(AM_CPPFLAGS)
libsbpgsql_a_CPPFLAGS = -g $(PGSQL_CFLAGS) $(AM_CPPFLAGS)
EXTRA_DIST = CMakeLists.txt

23
sysbench/drivers/pgsql/drv_pgsql.c
View File

@ -512,12 +512,19 @@ int pgsql_drv_execute(db_stmt_t *stmt, db_result_set_t *rs)
status = PQresultStatus(pgres);
if (status != PGRES_TUPLES_OK && status != PGRES_COMMAND_OK)
{
log_text(LOG_FATAL, "PQexecPrepared() failed: %d %s", status,
PQerrorMessage(pgcon));
const char * const errmsg = PQerrorMessage(pgcon);
if (strstr(errmsg, "deadlock detected"))
{
PQexec(pgcon, "ROLLBACK");
return SB_DB_ERROR_DEADLOCK;
}
log_text(LOG_FATAL, "PQexecPrepared() failed: %d %s", status, errmsg);
return SB_DB_ERROR_FAILED;
}
rs->ptr = (void *)pgres;
return SB_DB_ERROR_NONE;
}
@ -581,8 +588,16 @@ int pgsql_drv_query(db_conn_t *sb_conn, const char *query,
status = PQresultStatus(pgres);
if (status != PGRES_TUPLES_OK && status != PGRES_COMMAND_OK)
{
const char * const errmsg = PQerrorMessage(con);
if (strstr(errmsg, "deadlock detected"))
{
PQexec(con, "ROLLBACK");
return SB_DB_ERROR_DEADLOCK;
}
log_text(LOG_ALERT, "failed to execute query: %s:", query);
log_text(LOG_ALERT, "error: %d %s", status, PQerrorMessage(con));
log_text(LOG_ALERT, "error: %d %s", status, errmsg);
return SB_DB_ERROR_FAILED;
}