wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity

cid#1448446 Unchecked dynamic_cast

Browse Source 
Change-Id: I888ca249e0e9551c74611dcfb8ba7c7c1dc36880
Reviewed-on: https://gerrit.libreoffice.org/76133
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara
2019-07-22 12:15:28 +01:00
parent dc63d52591
commit 00dfa1f2f0
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sdext/source/pdfimport/tree/writertreevisiting.cxx
View File

@ -694,8 +694,8 @@ void WriterXmlOptimizer::checkHeaderAndFooter( PageElement& rElem )
if (rit == rElem.Children.rend())
return;
ParagraphElement* pPara = dynamic_cast<ParagraphElement*>(rit->get());
if( !(pPara->y > rElem.h*0.85 && pPara->isSingleLined( m_rProcessor )) )
ParagraphElement& rPara = dynamic_cast<ParagraphElement&>(*rit->get());
if( !(rPara.y > rElem.h*0.85 && rPara.isSingleLined( m_rProcessor )) )
return;
std::list< std::unique_ptr<Element> >::reverse_iterator next_it = rit;
@ -704,10 +704,10 @@ void WriterXmlOptimizer::checkHeaderAndFooter( PageElement& rElem )
{
pNextPara = dynamic_cast<ParagraphElement*>(next_it->get());
}
if( pNextPara && pNextPara->y < pPara->y-pPara->h*2 )
if( pNextPara && pNextPara->y < rPara.y-rPara.h*2 )
{
rElem.FooterElement = std::move(*rit);
pPara->Parent = nullptr;
rPara.Parent = nullptr;
rElem.Children.erase( std::next(rit).base() );
}
}