wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity

loplugin:constantparam in ucb,unotools

Browse Source 
Change-Id: I4161adac7544e7b1a8a7d8e18a3ae6c72ca77062
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166310
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2024-04-19 12:41:54 +02:00
parent 7e0b8e74dd
commit c9bf1e18bd
5 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ucb/source/ucp/webdav-curl/DAVAuthListener.hxx
View File

@ -34,8 +34,7 @@ class DAVAuthListener : public salhelper::SimpleReferenceObject
const OUString & inHostName,
OUString & inoutUserName,
OUString & outPassWord,
bool bCanUseSystemCredentials,
bool bUsePreviousCredentials = true ) = 0;
bool bCanUseSystemCredentials) = 0;
};
} // namespace http_dav_ucp

3
ucb/source/ucp/webdav-curl/DAVAuthListenerImpl.hxx
View File

@ -46,8 +46,7 @@ namespace http_dav_ucp
const OUString & inHostName,
OUString & inoutUserName,
OUString & outPassWord,
bool bCanUseSystemCredentials,
bool bUsePreviousCredentials = true ) override;
bool bCanUseSystemCredentials ) override;
private:
const css::uno::Reference< css::ucb::XCommandEnvironment > m_xEnv;

7
ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx
View File

@ -47,8 +47,7 @@ int DAVAuthListener_Impl::authenticate(
const OUString & inHostName,
OUString & inoutUserName,
OUString & outPassWord,
bool bCanUseSystemCredentials,
bool bUsePreviousCredentials )
bool bCanUseSystemCredentials )
{
if ( m_xEnv.is() )
{
@ -61,10 +60,10 @@ int DAVAuthListener_Impl::authenticate(
// container to reject these. Thus, the credential input dialog will be shown again.
// #102871# - Supply username and password from previous try.
// Password container service depends on this!
if ( inoutUserName.isEmpty() && bUsePreviousCredentials )
if ( inoutUserName.isEmpty() )
inoutUserName = m_aPrevUsername;
if ( outPassWord.isEmpty() && bUsePreviousCredentials )
if ( outPassWord.isEmpty() )
outPassWord = m_aPrevPassword;
rtl::Reference< ucbhelper::SimpleAuthenticationRequest > xRequest

4
unotools/source/ucbhelper/ucblockbytes.cxx
View File

@ -998,10 +998,10 @@ void UcbLockBytes::setStream( const Reference<XStream>& aStream )
}
}
bool UcbLockBytes::setInputStream( const Reference<XInputStream> &rxInputStream, bool bSetXSeekable )
bool UcbLockBytes::setInputStream( const Reference<XInputStream> &rxInputStream )
{
std::unique_lock aGuard( m_aMutex );
return setInputStreamImpl(aGuard, rxInputStream, bSetXSeekable);
return setInputStreamImpl(aGuard, rxInputStream, /*bSetXSeekable*/true);
}
bool UcbLockBytes::setInputStreamImpl( std::unique_lock<std::mutex>& /*rGuard*/, const Reference<XInputStream> &rxInputStream, bool bSetXSeekable )

3
unotools/source/ucbhelper/ucblockbytes.hxx
View File

@ -105,8 +105,7 @@ public:
// calling this method delegates the responsibility to call closeinput to the caller!
css::uno::Reference < css::io::XInputStream > getInputStream();
bool setInputStream( const css::uno::Reference < css::io::XInputStream > &rxInputStream,
bool bSetXSeekable = true );
bool setInputStream( const css::uno::Reference < css::io::XInputStream > &rxInputStream );
void setStream( const css::uno::Reference < css::io::XStream > &rxStream );
void terminate();