Commit Graph

361347 Commits

Author SHA1 Message Date
4959ff5fef scripting: The if statement is redundant
Change-Id: Ia6186be4ed48fd75d1063eed233a88e09b675bf1
Reviewed-on: https://gerrit.libreoffice.org/11774
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-02 19:54:59 +00:00
e02c37866b writerfilter: that fallback appears necessary after all...
Change-Id: Id4bc638c81d695745fc44bde16252e3040f0a03c
2014-10-02 21:40:34 +02:00
a23801b740 Scope reduction by early bail-out.
Change-Id: Iacbf9f46a1b5683b6de5dd93002a69078af46951
2014-10-02 15:35:10 -04:00
cdd2fe037a Make the coding style consistent with the rest of Calc code.
I just ran SlickEdit's 'beautify' command with some follow-up manual
editing.

Change-Id: I402e782e7d147c4c95ebaa8ffcc40b50a0c565a7
2014-10-02 15:35:09 -04:00
ede0abe6b1 Bin EE_CNTRL_URLSFXEXECUTE which was only set, never tested
Change-Id: I18a9355bb902b19f0eeecb26d33eba4fb25db8cb
2014-10-02 21:09:52 +03:00
1d0636ebc6 Bin commented-out #defines
Change-Id: I01f473658708a75c3eac6219efd38cd8ec5aa44f
2014-10-02 21:09:52 +03:00
96d210bf9c bnc#657899: Paragraph vertical spacing differs from PowerPoint
We need to set the "paragraph summation" flag also for .pptx import. (As is
already done for .ppt import.)

This is what in the Options (Preferences) UI is called "Add spacing between
paragraphs and tables (in current document)", on the LibreOffice
Impress:General page. This is a setting that when set becomes local to the
document. I actually don't really understand why this needs to be a
user-visible option, wouldn't it be enough for it to be an internal flag that
is set for documents imported from .ppt and .pptx, and is clear otherwise?

Change-Id: I525178957276e7d587b6ac4be8ae7919fc245a27
2014-10-02 21:09:52 +03:00
72a7450c02 MWERKS etc. are not supported toolchains
Change-Id: I449fe34be396114529357388c87162aaf8976292
2014-10-02 20:00:18 +02:00
9086a4bbd3 remove checks of __GCC_MINOR__ that are always true in GCC 4.6 or later
Change-Id: I4412a0c1e4dee94cd717f24b8df5e257d895f721
2014-10-02 20:00:18 +02:00
3b59dbbffd remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macro
This is supported in GCC 4.6.0 already:
https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html

Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02 20:00:18 +02:00
86cd29772e remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macro
This has been supported by GCC and clang for a very long time.

Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-02 20:00:17 +02:00
78766aaa12 DOCX import: handle <w:tcPr> directly under <w:style>
Change-Id: I10dfb947bbd9e792c98932608acb2f0987fd8605
2014-10-02 18:07:26 +02:00
dc358107b8 Fix fdo#84512 Background color not shown in Styles-Dropdown
this fix is only for simple color backgrounds; gradient, hatching and bitmap are not implement.

Change-Id: I5ec31c0105491c6d27835d63648fedff21998926
Reviewed-on: https://gerrit.libreoffice.org/11762
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-02 15:57:40 +00:00
1f18b3b078 Related: fdo#58277 only DelRight after a successful GotoField
otherwise you're just deleting a char right after whereever
the cursor used to be.

It can be possible to not GotoField if the field in question
is in a redline-deleted portion and show changes is not on. i.e.
its actually already deleted

Change-Id: Ic4833d82c5c33e556f3e159e9732a6db071f5622
2014-10-02 16:56:18 +01:00
4a04a456d6 Typos
Change-Id: Ide4e95828fad867fbc3cd1300f29e832b3c83017
2014-10-02 17:33:29 +02:00
cd42e5f3e2 fdo#82430: MSVC build: avoid using SSE2 instructions in some externals
Hopefully this should fix up the most important external libraries.

Change-Id: I744cb5a2ce7fafb10852059050cf24589d6ca400
2014-10-02 17:20:15 +02:00
37c00bff11 typo: fix build: wrong parameter was used
Change-Id: Iaa82352f91167872c9cd39c8ce22b415b9e61d82
2014-10-02 17:01:03 +02:00
cb0d802095 do not use number-of-enum-items as an enum item itself
Because that breaks warning about all cases (not) being handled in switch.

Change-Id: I8fadccd4e5d125cc37b8e10087e9170f07e65440
2014-10-02 16:19:42 +02:00
baa06b2384 fix typo
Change-Id: I08eff921ab2de64e5734807963c542818456dd8e
2014-10-02 16:19:36 +02:00
3c6f329095 fdo#84315: quick fix for sw too
Similar to 08f33ca66559dfafd29ab0c6073232cf05a6d4e5

Change-Id: I04f11a3821cb3793e5f993995b0c10fc7a62420b
2014-10-02 16:10:42 +02:00
f1694b3f18 coverity#1158274 Uncaught exception
Change-Id: Icfbe30efa3ebd63620a900e345e4b4a74070b021
2014-10-02 14:49:11 +01:00
fd8682cc34 fix indent
Change-Id: Ife7b28fcb67051c41831ef9eb566c3a2c148033d
2014-10-02 14:49:11 +01:00
5717312686 consistent capitalization in both exceptions
Change-Id: I495a92c24847de265f04abb3670532270b5d6034
2014-10-02 14:49:10 +01:00
9e8701c711 coverity#1233618 Overlapping buffer in memory copy
Change-Id: I062dd96bfc4abf2bdaec2c17d1cf57d853d655d8
2014-10-02 14:49:10 +01:00
a7232e3f54 coverity#1242520 silence Arguments in wrong order
Change-Id: I88b96d42f5ee96641dc21e3e55415f6dc32b3951
2014-10-02 14:49:10 +01:00
51e81c91e9 coverity#1242512 silence Arguments in wrong order
Change-Id: Ic4e337a17a8149137ff82a64e5513460c36373a0
2014-10-02 14:49:09 +01:00
d2cf2d813b coverity#1242507 silence Arguments in wrong order
Change-Id: Ice857b6f97f1ac3f720226aa90392fb6e9229869
2014-10-02 14:49:09 +01:00
154cc4ab52 coverity#1242506 silence Arguments in wrong order
order doesn't matter one bit as far as I can see

Change-Id: I55aa5d23d9865a47ef4dcda9d3e19863794a18c9
2014-10-02 14:49:08 +01:00
67693ad0d4 coverity#1130190 'Constant' variable guards dead code
Change-Id: Ifc462622919c8247c1f4ff8304f3107a23ef1c49
2014-10-02 14:49:08 +01:00
31c407e35b coverity#735532 'Constant' variable guards dead code
Change-Id: Ia0b8ad6af83907a51678e37e41c445fa4a7b5a58
2014-10-02 14:49:08 +01:00
5d796ae7f4 coverity#1169811 'Constant' variable guards dead code
Change-Id: I1c795134469c0ab8cf6591982e2a44a6506e4fc5
2014-10-02 14:49:07 +01:00
9403f75f44 coverity#1202776 'Constant' variable guards dead code
Change-Id: Ib1d5dcc8b09e11a8ef2399e3ef1a5ae1769de90f
2014-10-02 14:49:07 +01:00
b3e87789d9 coverity#1242475 no point calling SetText with GetText results
Change-Id: I0ebd4a53a0d309b45f5af31adc6fa54a5f143a21
2014-10-02 14:49:07 +01:00
227d87d805 coverity#1242476 Dereference null return value
Change-Id: I1895537459bca9341d1e97bad7ca38813bdfa2fe
2014-10-02 14:49:06 +01:00
1c53c50662 coverity#735574 'Constant' variable guards dead code
Change-Id: Ifcb8078e3e52c1b3634ab1c6ad6d6121502950d9
2014-10-02 14:49:06 +01:00
38b6c13f08 coverity#735572 'Constant' variable guards dead code
Change-Id: I07e350a87ee58ba1dd032f2e5cffc8a05ebce029
2014-10-02 14:49:05 +01:00
be9f02f1b4 coverity#735571 'Constant' variable guards dead code
Change-Id: Idd3654f45a9fe9c0a92aa88b494cdd9192baa966
2014-10-02 14:49:05 +01:00
850b8dc7a2 coverity#1242483 Unintentional integer overflow
Change-Id: Ie258b4b6d4d99c7b2b0d61550a840539b216d09f
2014-10-02 14:49:05 +01:00
ba8469f6ef coverity#1242494 Resource leak
Change-Id: I4956890da9978381e2de7e8b1af37495884d4965
2014-10-02 14:49:04 +01:00
37f62f86af coverity#1242496 Resource leak
Change-Id: I419b217df306d41ed99e603bae9381f54c633598
2014-10-02 14:49:04 +01:00
ef6a120af6 coverity#1242497 Resource leak
Change-Id: I2c4295c7d308257290aaf04181805d7dc71d6553
2014-10-02 14:49:03 +01:00
b99aad6cc2 coverity#1242501 Resource leak
Change-Id: I0c684565e2d5e83d7d1bb99b3d8011a1d87994d5
2014-10-02 14:49:03 +01:00
11f2f71384 coverity#1242750 Unused value
Change-Id: I057434339e6aee710ba9fa7b6a2cc6a51a5206cf
2014-10-02 14:49:02 +01:00
1914fd354f coverity#1242751 Uninitialized scalar field
Change-Id: Ib56544cf49d53952c7381512b650633abac047e9
2014-10-02 14:49:02 +01:00
76563eb45b coverity#1242752 Uninitialized pointer field
Change-Id: I3485a29fe5ce88834b2ef0d30b9c32516befa0ff
2014-10-02 14:49:01 +01:00
205a00d04b coverity#1242766 Unused value
Change-Id: If7d33882d612788fba051ebae56468b80e96e09f
2014-10-02 14:49:01 +01:00
ddfb875ba2 coverity#1242768 Unused value
Change-Id: Ida66a4a4d00caa49e993938f86e357e4351a60c5
2014-10-02 14:49:00 +01:00
8559539c56 coverity#1242776 Unused value
Change-Id: Ia84bfbcdd4de08c9e87c877b3c1be84c0b712a07
2014-10-02 14:49:00 +01:00
7aa8b5bb22 coverity#1242785 Uninitialized pointer field
Change-Id: Ic97bd7c3fa2f192113d702f9338cb3eaeae6109c
2014-10-02 14:48:59 +01:00
d82057a3c7 coverity#1242800 Result is not floating-point
Change-Id: Idcd1b3bd542512707b722708e4b3336c71fbff80
2014-10-02 14:48:59 +01:00