Commit Graph

176 Commits

Author SHA1 Message Date
65b69c44fc loplugin: cstylecast
Change-Id: I31bbeb5f068754d6dc77c22d759058089b03c9b1
2014-09-29 12:50:36 +02:00
5501c8d222 remove unnecessary casts in calls to SvStream.WriteUInt16
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I482ca7abb84613971e7e8f839f7aa67a65cd71ff
2014-09-26 15:26:48 +02:00
bec72dd34f remove unnecessary casts in calls to SvStream.WriteUChar
left over from our conversion of the SvStream output operators
to more specific methods

Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26 15:26:19 +02:00
3ddae219e4 remove unused fields pName and pMethodName in SfxSlot class
Change-Id: Icca5a0dee296fae1abeb78ea8ffa2f9e934bb111
2014-09-22 07:29:17 +02:00
3107156f41 loplugin:staticcall
Change-Id: Id440c165f6e98a7d0fe0c8c578e404db75416c48
2014-06-13 17:54:28 +02:00
f961cf50a7 Fix memory leak
Change-Id: Ie12862f8df701298db51ed45b5c24814a6f94def
2014-05-28 08:55:12 +02:00
0897a5a8c5 coverity#1209405 Unchecked dynamic_cast
Change-Id: I5b16007b514169e2349c8c3a78d3c150c9d52d85
2014-05-26 15:51:59 +01:00
0d7b898bf7 coverity#1209786 Dereference before null check
Change-Id: I98bb62bbcb7ffbd2896ddbcbaeea27fff0851653
2014-05-09 09:43:16 +01:00
0698ccf040 coverity#1209793 Dereference before null check
Change-Id: I5c89f7291117d66ff07f7d686c7030396cb504df
2014-05-09 09:43:15 +01:00
6cf148baf9 translate to English
Change-Id: Ieb7ee3f8eb192612e76d5ad928389445e82ef90e
2014-05-08 14:48:22 +01:00
f0268c9c1b idl: sal_Bool->bool
Change-Id: I8b15c97b1fcc6acaf567e8b1d2d37cbc99687a9d
2014-05-08 11:44:54 +02:00
2be92a9d4e svidl: Unwind SFX_SLOTMAP_ARG, and kill it.
Change-Id: Icd99fd2cd530f52b0acf5d91667eeec8142e8340
2014-04-18 22:49:26 +02:00
62256ea10a svidl: Unwind SFX_ARGUMENT macro, and kill it.
Change-Id: I61334b687c251ccc90f125e8bf95f8689028b8c3
2014-04-18 22:49:26 +02:00
6b1f812678 svidl: Unwind SFX_ARGUMENTMAP macro, and kill it.
Change-Id: I7c4902a4151f207d8a61b76d05fad74a4c8854d4
2014-04-18 22:49:26 +02:00
4f4d9c0635 Avoid duplicate symbols in libmerged for Windows too.
This is working version of fc27a685d466dc380a8b68cd48f47db632ed3693

Change-Id: I48e861b5b7692ea051edf52d7ad9cc54ca989e22
2014-03-17 20:38:22 +01:00
50c5a4ce9c Revert "Avoid duplicate symbols in libmerged for Windows too."
Forgot to test properly on Windows :-(.

This reverts commit fc27a685d466dc380a8b68cd48f47db632ed3693.
2014-03-14 10:10:09 +01:00
fc27a685d4 Avoid duplicate symbols in libmerged for Windows too.
Export these symbols from sfx library.
For cases when we link together more libraries, there are more symbols,
so I've kept __attribute__((__weak__)) hack there.

Change-Id: I8b7f6fc9bea479dca5062344c04b74c1f3eb36b2
2014-03-14 09:31:42 +01:00
2a7f4e37b5 coverity#707933 Uninitialized scalar field
Change-Id: I03c835327eabc9bfdc9904abb2ba6a8f13bd7207
2014-03-08 20:28:01 +00:00
dbfff3f4ae coverity#707932 Uninitialized scalar field
Change-Id: I73524c3e1911456ef14dcb07f073fed85f869524
2014-03-08 20:28:01 +00:00
dbfc495a9a Add config option used when we try to link one huge object file.
In theory, it should not be used, we use it now to mark duplicated
symbols from sdi slots as weak. See idl/source/objects/types.cxx.

Change-Id: I3c6fccfb96884df6b9e6eb35b8615ba4d66ca208
2014-02-21 07:52:24 +01:00
b2878af322 more SvStream:operator>> conversion
Convert the template based read_lenPrefixed methods to regular
methods.

Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019
Reviewed-on: https://gerrit.libreoffice.org/7895
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:32:11 +00:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
a3682484c6 cid#705188 missing break in switch
Change-Id: I5e777801a7df934f61182f6df8f66fc18d00073c
2014-02-12 08:59:05 +02:00
dc61cc8c96 bool improvements
Change-Id: Ifdee50acbc72387812156af5cb8b078d97ebe5d1
2014-01-28 20:26:26 +01:00
16a2e90335 remove SvStream::operator<< methods
.. and convert the last few places still using those methods.

Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:47 +00:00
d803483f6a convert more SvStream::operator<< calls
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.

Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-22 22:00:39 +00:00
bbd9668d5f bool improvements (related to mixing bool/sal_Bool in &=, |=, ^=)
Change-Id: I9869d9709f28b68ef7b518527175589d80644668
2014-01-22 15:00:54 +01:00
c648d08720 convert SvStream::operator<< overloads to more explicit methods
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.

Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
2530d2923c presumably each entry needs a tab and semicolon
Change-Id: Iedb57186d56c6d1445bcfe2ad37d0569dba32b4e
2013-12-27 13:40:35 +00:00
c959586c09 cppcheck: fix Same expression on both sides of '||' + simplify a bit
Change-Id: I7903c4af5263f93dc4d311b73cb21e144a63d8d9
2013-12-27 14:28:42 +01:00
6eac9deadd remove unnecessary RTL_CONSTASCII_STRINGPARAM in OUString::equalsL
Convert code like this:
    if (aStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aStr == "rem")
which compiles down to the same code.

Change-Id: I2dfa0f0a457c465948ecf720daaa45ff29d69de9
2013-11-21 13:29:29 +02:00
d454834895 Revert "remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls"
This reverts commit acebbee971136e6ee0a7bc75bd57d937d6e1c295.

I mistakenly converted OUString::equalsL calls to OUString::startsWith
calls.
2013-11-20 16:38:28 +02:00
acebbee971 remove RTL_CONSTASCII_STRINGPARAM in OString::equalsL calls
Convert code like:
    if (aByteStr.equalsL(RTL_CONSTASCII_STRINGPARAM("rem")))
to:
    if (aByteStr.startsWith("rem"))

Change-Id: I09e40b3fdc87d59a8176c2a5f39cc6aa5cf5a576
2013-11-20 13:56:08 +02:00
d894fee80e remove RTL_CONSTASCII_STRINGPARAM in OStringBuffer constructor
Convert code like:
    OStringBuffer aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
    OStringBuffer aKeyName("NDX");
which compiles down to the same code

Change-Id: If9c96a290bc18cc8285fb733f27be58c6958b63c
2013-11-20 13:56:07 +02:00
1730df0127 remove unnecessary RTL_CONSTASCII_STRINGPARAM in OString::append
Convert code like:
   aOStringBuf.append( RTL_CONSTASCII_STRINGPARAM( " is missing )") );
to:
   aOStringBuf.append( " is missing )" );
which compiles down to the same code.

Change-Id: I3d8ed0cbf96a881686524a167412d5f303c06b71
2013-11-20 10:07:32 +02:00
93a23d1148 No __weak__ in Win32
Change-Id: I3bd5e3787d0f47cfef667734211cdf8c0fd606a7
2013-11-15 18:16:50 +02:00
73c560a63e convert IDL module from String to OUString
Change-Id: Idf8e0e02ee2fde23959a281cc6ffa1a43ee7f239
2013-09-17 09:05:17 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
05fac639a2 -Werror,-Wlogical-not-parentheses (Clang trunk towards 3.4)
...the apparently mistyped condition happened to work as intended, given that
TYPE_METHOD is zero.

Change-Id: I468013ab61caff45c174da752ffb1c9ca9d373bd
2013-07-08 17:32:24 +02:00
caab53cf21 fdo#43460 connectivity,extensions,filter,idl,idlc: use isEmpty()
Change-Id: I78ba286be5aa4d731f734e5eb16adb77c686aad9
Reviewed-on: https://gerrit.libreoffice.org/4325
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-18 17:31:20 +00:00
435f5e30c9 fdo#60724 correct spelling
Change-Id: I7318a9f4f3410edf4dbe67bf08f31682fcb4edc7
2013-04-15 05:10:29 +02:00
4e3baf32d9 svidl: more helpful error message for missing slot / types.
Change-Id: I89537f526e465137f5e8c17b4d7fd134ba59af4a
2013-04-10 15:14:28 +01:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
eec2eb05a2 fdo#39445 writing out tools/fsys.hxx (idl)
Removed uses of fsys from database.cxx, command.cxx, module.cxx, svidl.cxx.
Also removed a lot of cruft from svidl.cxx and command.hxx; unused variables
and code relating to them, eg. variables aCxxFile, aHxxFile, aSrcFile, aODLFile.
Changed some Strings to OUStrings in svidl.cxx and command.hxx.

Change-Id: I708284f70435c8f65cdcfc954af43976e28b8c9d
Reviewed-on: https://gerrit.libreoffice.org/2935
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-03-25 13:08:52 +00:00
f294ecbe68 add sw swd msfilter vbahelper to Library_merged
Change-Id: If7fc0b480c58599e86bf3b75080b8b18d5d79488
2013-03-21 17:27:00 -04:00
88be7d32f3 Simplify this
Change-Id: I341f4a74062e78f6a4d23ca24d635c6a95fb90cb
2013-02-12 16:31:28 +01:00
63bcb139b9 Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-21 15:04:17 +00:00
db7b486f88 Use the weak attribute for iOS, too
Change-Id: I090da1c6c9e48ef12f2a168eddb1a2cb91a8f533
2012-11-26 21:40:28 +02:00
b869b73947 Avoid duplicate symbols when DISABLE_DYNLOADING for Android
Change-Id: Iecd0ed802f6cc715ac77256bb4b49082b5976b4f
2012-09-20 14:26:31 +03:00
016918cf94 STL'ify SV_DECL_IMPL_PERSIST_LIST
Converts it to a template based on std::vector

Change-Id: Id7f89f494164c61a3a573cff443ac0e0488e93f1
2012-08-08 13:53:07 +03:00