9af5c13851
Re-use DataSeriesHelper::getRole().
...
Change-Id: Ia880bc03400d4cbf4c3033e01affafccc0a384fb
2014-06-24 22:05:20 -04:00
3f9275bd26
Annotate the code a little more, to make it easier to follow.
...
Change-Id: Iefc61fdc132a18e73b0136f0248d69ab9e07a5e8
2014-06-24 21:07:43 -04:00
1e0c38bb54
Unwind this logic a bit.
...
Change-Id: I320b28fb319b42eeae7cada31b6f27f9e342db15
2014-06-24 21:07:38 -04:00
3a7f55924b
Reduce indentation levels.
...
Change-Id: I5de3dea88a1e6f36c995697ba648ce6b82f4e8ae
2014-06-24 19:03:14 -04:00
349132616d
Let's remove these lcl_ fetish.
...
These are not even static local functions anyway, which was what
lcl_ prefix was originally used for.
Change-Id: I0e6b6cebbcf7cdfb449cf17320fb362fc73d92a8
2014-06-24 18:46:46 -04:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
bdd87b2acd
XY chart needs to set the X value property
...
Change-Id: Ib17b564c187dfec8abb7a17b2602f814362dd34f
2014-06-23 02:32:31 +02:00
c97424f82a
remove now unused dialog
...
Change-Id: I42c340a6aee016e37ee558d46a8eab101837e9c5
2014-06-22 05:05:00 +02:00
77cec206e3
show the property mapping sequences by default
...
Change-Id: I32417ed53e491a66f700e77ae0fff2154fa5441c
2014-06-22 05:05:00 +02:00
086d93f130
extract common code
...
Change-Id: I9327f232f1edb9ef052eb7868ac60774f3b6e4cf
2014-06-22 05:05:00 +02:00
d005413c2e
don't try to set property mapping if there is no value
...
Change-Id: I422d651e303553e2ce30895b44b8d96664418c19
2014-06-22 05:05:00 +02:00
b6e49ad5dd
avoid truncation double to float warning
...
Change-Id: I7f5c5f025954120c06fcce2c14915a8138843374
2014-06-21 04:48:48 +02:00
fb06300b73
fix windows build
...
Change-Id: I0de216a8c6259ba6ec825f85f52e2f48b97510d7
2014-06-21 04:46:14 +02:00
ac0989d5ea
avoid manual OpenGL extension checking
...
Change-Id: I75faa82fc2eef7f3bfd3546d64f47dee6a0b7d08
2014-06-21 04:21:41 +02:00
00272efc1c
I don't see a good reason for marking private methods with SAL_CALL
...
Change-Id: I9b73b6b6073b3249317f4e1124d840930cbe558f
2014-06-21 04:21:41 +02:00
374160d659
volatile does not make any sense here
...
Change-Id: I337d845e05007efb29f1c1fa39cdcc046b156281
2014-06-21 04:21:41 +02:00
7fd1fd1dea
remove unneeded code for 3D charts in controller
...
Change-Id: I5c1f624cc05a90878f717abc8ffb0b2220ce94d5
2014-06-21 04:21:41 +02:00
6ef4565efe
add code to call batch texture render
...
Includes warning fixes from Markus Mohrhard.
Conflicts:
chart2/source/view/inc/GL3DRenderer.hxx
chart2/source/view/main/GL3DRenderer.cxx
Change-Id: I09da7c49eb11da9ea2bc18a5e13f2fd2c0d6bd8f
2014-06-21 04:21:41 +02:00
87e23f425f
use shader to calculate alpha channel
...
Conflicts:
chart2/source/view/main/GL3DRenderer.cxx
Change-Id: I3cf9636b36ffd47589dd3ab61278802ca73644ce
2014-06-21 04:21:40 +02:00
f4436dcb95
add global scale matrix
...
Conflicts:
chart2/source/view/main/GL3DRenderer.cxx
Change-Id: I23b9929dd3f0f1b0a070091ed9c1fe920edfcbf9
2014-06-21 04:21:40 +02:00
4444e6cf79
fix the using 3.0 version bug
...
Change-Id: Ie197d0156a2d8b54fe6b08a905d82a63d31513f2
2014-06-21 04:21:40 +02:00
c7d390bf21
remove old comment
...
Change-Id: I427b408f898b4f4697f460a61fc306f65d68e12a
2014-06-21 04:21:40 +02:00
d3e15ac8df
add disabled code for square bars
...
Change-Id: I4b315d9a4a6fb384eaec4d58c53291e473fb6d85
2014-06-21 04:21:39 +02:00
1d38cb3655
fdo#71076, fdo#71767: Preserve number formats when charts are copied.
...
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
2538e30ccc
Use define constant to keep track of all NumberFormat property usage.
...
Change-Id: I2a544922e03ec8253290ac8bf5a89c9cdd72d8dd
2014-06-19 14:46:56 -04:00
1f3f725a29
small text positioning fixes
...
Change-Id: I7fb42f0c34c5216421324f471a813f4668b4a878
2014-06-19 15:37:05 +02:00
6e427b30fe
use better default colors
...
Change-Id: I0790f157632351a8fe68abf8f12041907027d6c9
2014-06-19 15:37:04 +02:00
d5a0926c23
fix range input in chart data source dialog
...
Change-Id: I9c139c6298d25c7a7072d0d0538f1945518d36f2
2014-06-19 15:37:04 +02:00
ee9e8f6771
Fix build with system glm once again
...
Change-Id: I7cd179f6f981455cfece1ca8ce0ea314ac341f99
2014-06-19 11:47:47 +02:00
b67f325a26
rtl::Reference fits just fine here
...
Change-Id: I65499ac299fb474e581245c5237a0b184f1f2b60
2014-06-18 11:26:33 +02:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
7c5580874c
add codes for calling the 3.0 shaders
...
Change-Id: I0e95879c04047ccb836543d801bda6a01ae469ef
2014-06-17 08:28:21 +02:00
1e3a1a0509
add codes for compile the 3.0 shaders
...
Conflicts:
chart2/source/view/inc/GL3DRenderer.hxx
Change-Id: Idc58635cc1604208317319bfa399a1574979a909
2014-06-17 08:28:20 +02:00
8e19f8ebd8
modify the mouse drag function
...
Change-Id: I9639b2a29522ba0765f4442c2f78de56388fe754
2014-06-17 07:43:58 +02:00
af5dfd8af2
add move to default process
...
Change-Id: I8d562b3e2d1bb83a6e07ed089a3006a109beeece
2014-06-17 07:43:58 +02:00
a96c575764
modify the click view angle
...
Change-Id: I8717745d2f503f8ad3c21673a07aed867b5681f9
2014-06-17 07:43:58 +02:00
6c4ce5f351
modify the default view angle
...
Change-Id: Ic7c901108a290a9d9c5a8564b6eefa7ed32a9e1f
2014-06-17 07:43:58 +02:00
c52e440377
modify the perspective view angle to 30
...
Change-Id: I07b39f8b372368f82137feec3a6d12921fc1ec9f
2014-06-17 07:43:57 +02:00
b8979cae28
fdo#79028: ungroup widgets and Show() them correctly
...
Showing the whole box (m_pBxMain) shows all children widgets, but
that's not what we want as different widgets must be exposed in
case of date vs. non-date axis.
m_pMt_MainDateStep was then visible at all times, thus bWasDateAxis
was always true and m_pFmtFldStepMain value got unintentionally reset
Change-Id: I4be0b18f181a45fe6bd3cac0594d6a34d875293e
2014-06-13 23:55:52 +02:00
ad82e0d25e
loplugin:staticcall
...
Change-Id: I3f3adebc0916c96b50e15c68b627e655166e2551
2014-06-13 17:54:23 +02:00
fc4f5d2f85
another lifecycle issue fixed
...
Change-Id: Id8acd1bda30156da8cf5f61537f76f778e1b9c74
2014-06-12 11:59:13 +02:00
bb761be472
Change SfxTabPage ctor SfxItemSet param from ref to pointer
...
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions. There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.
Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
a92e973b6d
Change SfxTabPage::Reset param from ref to pointer
...
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)
Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-11 10:39:03 +02:00
4dbeadb9c1
Change SfxTabPage::FillItemSet param from ref to pointer
...
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)
Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10 17:25:23 +02:00
08b0691bde
coverity#1158096 Unchecked dynamic_cast
...
Change-Id: I9d02b4e9e4c8dfea73cef3970d11e21eaefb80bd
2014-06-10 16:08:08 +01:00
ef68800d96
coverity#1158100 Unchecked dynamic_cast
...
Change-Id: I3040703b7182d186ac9e27c33295e929b8dc9ffe
2014-06-10 16:08:08 +01:00
0ededb3430
coverity#1158114 Unchecked dynamic_cast
...
Change-Id: I779e1cae1039886b2d43a025930cc50d7aaac95a
2014-06-10 16:08:08 +01:00
23f6f4fd1f
coverity#1158115 Unchecked dynamic_cast
...
Change-Id: Ic37180d32f1308a5065f547584046e31dae88ea0
2014-06-10 16:08:08 +01:00
5cbd7b68b9
coverity#1158117 Unchecked dynamic_cast
...
Change-Id: I0d78af6a9aa1f206ceaf0cc9942c2a1e450ea980
2014-06-10 16:08:07 +01:00
6d166057c9
coverity#1158118 Unchecked dynamic_cast
...
Change-Id: I25cb0dd2d6850565aff8a08e4d3955a497415d93
2014-06-10 16:08:07 +01:00
