a1d6f1dfd5
scoped_ptr will do just fine here.
...
Change-Id: I35701126963047f3e405a6560a90930de99ed3fa
2014-07-21 23:21:19 -04:00
998ab5c405
More on removing (unreasonable) use of std::auto_ptr.
...
Change-Id: I98f5fb22eecb7749e4c86e1ce52965b0c73641ca
2014-07-21 23:12:34 -04:00
9e970303dd
Remove auto_ptr from CharacterPropertyItemConverter.
...
And adjust all that's necessary.
Change-Id: I121e5aa4d117da2e5e6b11e4fd85960a8b3aa727
2014-07-21 20:31:24 -04:00
b2ffa40c12
Compiler macro in lieu of literal "Label" to make it easier to track it.
...
Change-Id: I6bc694fcc8f97b308747c097c4fa977d20524377
2014-07-21 20:31:24 -04:00
38272ba915
Scope reduction by throwing early.
...
Change-Id: Ic0b7b69b8c4e57064b31ef62ddceaf6094ca9991
2014-07-21 13:52:54 -04:00
9ab9d22f82
split helper and fix build
...
Change-Id: Ie479d363152d3c6a109d6e924b09c155c79511c8
2014-07-21 14:50:15 +01:00
2d226f4c0b
SchLayoutTabPage: that ctor wants a pointer
...
Change-Id: I7f500186c2ce485e7f6a857286c14d0a64354c31
2014-07-20 21:07:04 +02:00
4fa4f38593
fdo#81547, part1: use ctor reading .ui file, not a resource
...
This fixes a crash when this tabpage is one of the tabpages in
data series properties dialog (e.g. 3D column chart)
Change-Id: Iacbc689fb410b30515e433bcf4a96c087047ca73
2014-07-20 19:54:56 +02:00
f19b914455
WaE: -Werror=shadow and -Werror=unused-but-set-variable
...
Change-Id: Ic42d506db8fe065cb8f01e17f18a1238d1eff651
2014-07-20 13:59:13 +01:00
cbc50c90ad
Fix OpenGL chart reinitializing
...
Problem after ChartWindow was disabled and enabled
again, OpenGL content was lost.
Two things:
-After setting a new OpenGLWindow the corresponding
IRenderer must be set (x3DWindowProvider->update)
-InitOpenGL() call should not depend on DummyChart, but on
OpenGLWindow (OpenGLContext).
Change-Id: If74e1945de9973d3921ceea1ca6fef39311add7a
2014-07-20 09:54:06 +02:00
46cea34638
opengl charts: Move the init from sc to chart2, to have the right parent.
...
Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-07-20 09:54:05 +02:00
bbe02602fa
coverity#1215398 Uninitialized scalar field
...
Change-Id: I00fd3afeca6e7c0902231fe88f7f23d4a2b32a3f
2014-07-18 15:36:18 +01:00
1e2107e76b
fdo#77319: set spinbox value AFTER adjusting no. of decimal places
...
Doing it the other way round truncates the values
Change-Id: Ieb14c9d1b9dde496eac24737aced7c8da8ce1346
2014-07-17 22:54:16 +02:00
a113d3a751
error: unused variable 'TIMEOUT'
...
Change-Id: I9fe3078e2c4ea4a63efcc3e26a090c8e3cbc7ccc
2014-07-14 20:03:21 +02:00
dde00f1f8a
make threaded rendering work correctly, fdo#81110
...
The context may only be bound in one thread!
Change-Id: Ibb67f88c2f11fd48884ee39d89620193e4e5471b
2014-07-13 07:54:09 +02:00
664fb35ab5
first part for threaded chart rendering, fdo#81110
...
It is nor working correctly yet.
Change-Id: Ic592eb2f50265886ad6d97539d2c52d7c45179e6
2014-07-12 04:38:45 +02:00
b75f6baa3a
remove unused defines
...
Change-Id: Ic9118c390f4ba69e245cb16032d3cbe19c741b11
2014-07-12 04:38:20 +02:00
fc2a20fe8e
using memset on a vector is just so wrong
...
Change-Id: Ia022f5d0200a60d993c74f2c9f29f906c6284f0f
2014-07-12 04:38:20 +02:00
40e22a429b
we only need one typedef for PointList
...
Change-Id: Ic64f871e014bd48c5eadb6f92b69c6466d812925
2014-07-12 04:38:19 +02:00
6162e32edd
killed this method again
...
This method must be a zombie as it reappears again and again despite
being killed.
Change-Id: Ic41e3259f2125eca7d114f54b032553e53bf71a2
2014-07-12 04:38:19 +02:00
2f8841dd0a
remove unused method
...
Change-Id: I3b3006230476b0d16dad54035b0c80a95cbc2b20
2014-07-12 04:38:19 +02:00
dac4ca5f68
new loplugin: externalandnotdefined
...
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
942c21a003
coverity#1224984 Dereference before check
...
Change-Id: I93c8326d204d1b15a2a7ac5288a6c767029c6501
2014-07-10 22:11:28 +02:00
462f7e43a0
coverity#1224984 Dereference before null check
...
Change-Id: I05d54983d6231ec0b4293df51c7d55570d10cee7
2014-07-10 13:39:17 +01:00
22906fd347
add parenthese to fix precedence issue
...
Change-Id: Ifb4c750f4ddedd27593acde4e93331e74e9d37c4
2014-07-04 21:21:34 +02:00
b89311b971
coverity#735602-3 Division by zero
...
Change-Id: I2da9857e4d526b60b3bf50e10ab180c493fb288f
2014-07-04 20:11:46 +02:00
6cad548ee2
chart2: add some locking to chart::ChartType UNO service
...
On the libreoffice-4-3 branch, chart2_unoapi crashed with what looks
like a corrupted ChartType::m_aDataSeries triggering STL assertions.
Try to protect the mutable members with SolarMutex guards.
Change-Id: I3f2edd36b8ecf37ef60239415f70abfc8b59244d
2014-07-04 15:06:12 +02:00
7649a14222
Make these non-inline.
...
Change-Id: I0de443a78e3024c7d3834f964a92f5ccdabe3cc3
2014-07-03 15:29:41 -04:00
6c4e21a234
bnc#812796: Correctly handle static value array for OOXML charts.
...
We need to pass the role of the data sequence in order to avoid unreliable
guess work when importing static value array.
Also, not all Excel's scatter plots have real numeric X values; some have
textural X values in which case Excel switch to generating 1, 2, 3, ... as
X values. When importing to our chart implementation, using "categories" role
in such cases instead of "values-x" results in a more faithful chart rendering.
Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78
2014-07-02 20:56:31 -04:00
3575dba98d
remove whitespaces
...
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
8918dabbee
coverity#705359 Mixing enum types
...
and
coverity#705361 Mixing enum types
coverity#705362 Mixing enum types
Change-Id: I557d7178277e5d497e3bbab12b75724c05653f57
2014-07-02 14:00:41 +01:00
e50ef195bc
New loplugin:stringconcat
...
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
cbfaf0c794
coverity#1219805 Uninitialized scalar field
...
Change-Id: Id6b15e8515d73cb5bdf4bc6d02d235ebc7e282da
2014-07-01 10:56:16 +01:00
e5d60c4754
coverity#1213562 Uninitialized scalar field
...
Change-Id: I9a40cee6e807599e8e3d9f3df52186fd6226f7e1
2014-07-01 10:56:16 +01:00
1271ac20d4
coverity#706266 Uncaught exception
...
Change-Id: Iba3d2b8cddcd9e0f228d5b9fef1ce3290047c8b0
2014-07-01 10:56:16 +01:00
5ace3f3b4f
clang scan-build: various warnings
...
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01 10:56:14 +01:00
e123226d87
CreationWizard already inherits boost::noncopyable via OutputDevice
...
Change-Id: Ie155742ea9fc29b5b1adfa219c0bc6fdd78cb637
2014-06-30 19:53:12 +02:00
483a4b546c
Flush modified data to the model when pressing OK in the data table dialog.
...
This dialog used to have no OK / Cancel buttons, and the data would get
flushed when the dialog got dismissed. This behavior got lost during the
dialog conversion.
Also, SaveModified() does check whether or not the data table is modified.
No need to call IsModified() before calling SaveModified().
Change-Id: I5cea88cb52127cc5c7c1be67a5a592d87df92d0c
2014-06-27 11:35:11 -04:00
355c3cbb16
fix invalid memory access in chart tests
...
Change-Id: I056101d146c939ff958c83efc57fd110e8d52509
2014-06-27 10:05:45 +02:00
ecde8155fe
fdo#79151: No need to offset column index by category labels.
...
In fact, doing so would lead to a corrupt internal data table. The
internal data stores category labels separately from the column data, so
there is no reason why we need to offset for category labels here.
Change-Id: I29dd99e53837cba7a1e28d2a1ef39a5384378805
2014-06-26 22:49:35 -04:00
822d0e9db6
Use new GridPrinter instance for each table.
...
resize() sometimes leads to a crash. Need to debug later.
Change-Id: Ia3809eb4f171369a58b84d5b44001692be1453a1
2014-06-26 22:33:55 -04:00
c6da184295
Track all uses of ErrorBarX and ErrorBarY UNO property names.
...
Change-Id: I994424c98d977c3a8f9138cccc17348de813a9d7
2014-06-26 19:36:46 -04:00
95272e7e5b
Prevent a crash while dumping internal data content.
...
Change-Id: I0938b955b460d8c91607e6df0b9d9e1a4a971013
2014-06-26 18:58:41 -04:00
aa6495b6fa
Better way to dump the content of InternalData.
...
Row levels are currently not dumped, but that may change later.
Change-Id: I849f8b65d6f419bc4d97e2af2d456e73c7e9a355
2014-06-26 14:26:50 -04:00
2daceb87b9
clang: Uninitialized argument value
...
Change-Id: Id65c5815185cf022171e3523c6ad92545830104c
2014-06-26 16:29:13 +01:00
8192df3887
Clarify the code a little more.
...
Change-Id: Idc0ff4913695ade9543cd30511aff61d24e7c495
2014-06-26 11:26:15 -04:00
60e94d8982
Move the category level removal code into its own method.
...
Change-Id: I4f0cfb4b15bc145b7a5c3491a7acbff13999bf5d
2014-06-26 11:26:15 -04:00
a532e2bba1
Remove these pesky ::com::sun::star ....
...
Change-Id: I5c8e1418cc7e01426b67233e48289497a92868d3
2014-06-25 20:24:09 -04:00
94c56f6a76
Tuck this anonymous namespace inside chart namespace.
...
This way we can eliminate those explicit '::chart' qualifications.
Change-Id: I764e0ca57c8e10f7eac47f48a4cabf28d0562113
2014-06-25 20:12:46 -04:00
78751ce780
Add class descriptions. These two classes' roles were not very clear.
...
Change-Id: Ib45c9037f2c4b3ee5bfed79f3c93e5020bac477b
2014-06-25 20:12:46 -04:00
