Convert code like
aStr.compareToAscii("XXX") == 0
to
aStr.equalsAscii("XXX")
which is both easier to read and faster.
Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
Convert code like
if( ! aStr.compareToAscii("XXX") )
to
if( aStr.equalsAscii("XXX") )
which is both clearer and faster.
Change-Id: I267511bccab52f5225b291acbfa4e388b5a5302b
Convert code like:
0 == aStr.compareToAscii("XXX")
to
aStr.equalsAscii("XXX")
which is both clearer and faster.
Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
Seriously, would it be so awful to initialise the value even if strictly
speaking it is unnecessary? Hopefully avoiding that is not an attempt at
manual micro-optmisation? (Or did the initialisation actually cause some
warning?)
Besides, Clang is not just "the MacOS X compiler". I use Clang on Linux,
too. It is great. Our Clang plug-in (which can be easily used only on Linux)
is very useful.
Change-Id: I379afed707d96745ee29979bd79467309adf0147
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
Removed some chained OUString::append()'s from forms. OUStringBuffer
could really use a append operator(+=).
Change-Id: I635bdd25da9f09373e686d87a1d198bc09bda906
Reviewed-on: https://gerrit.libreoffice.org/5329
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
In particular, give type and message of exception
when unexpectedly caught.
Also miscellaneous other details.
Change-Id: I87d71028dbc902e1770fee4c3643c85e75b7646d
Add IsUTC member to:
com.sun.star.util.DateTime
com.sun.star.util.DateTimeRange
com.sun.star.util.Time
Add new stucts with explicit time zones:
com.sun.star.util.DateTimeWithTimezone
com.sun.star.util.DateWithTimezone
com.sun.star.util.TimeWithTimezone
Adapt the sax::Converter to read/write timezones, and fix the unit test.
Everything else just uses default (no time zone), this commit is just
to fix the API.
STRUCT: /UCR/com/sun/star/util/DateTime
nFields1 = 7 != nFields2 = 8
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/DateTimeRange
nFields1 = 14 != nFields2 = 15
Registry2 contains 1 more fields
STRUCT: /UCR/com/sun/star/util/Time
nFields1 = 4 != nFields2 = 5
Registry2 contains 1 more fields
Conflicts:
sc/source/filter/oox/unitconverter.cxx
Change-Id: I01f7a6d082a6b090c8efe71d2de137474c495c18
Reviewed-on: https://gerrit.libreoffice.org/4833
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
If no LanguageTag instance is at hand use the static methods to convert
between BCP 47 string, Locale and MS-LangID instead of creating
temporary instances.
Change-Id: I9597f768078eb81c840e84a5db5617f26bb7dc09
If it gives us a NULL as bound value,
use it, even if the underlying column
has constraint NOT NULL.
This can happen e.g. in OUTER JOIN,
with UNION, ...
Change-Id: I1fc0d9366764b90e0cdb443cd34c32b52f059e0b
Values that come from the database are always signed
(we inherit that from sdbc that inherits that from jdbc
that inherits that from Java's type system that does not have unsigned values)
So when using unsigned values, they always operator==-compare false!
Change-Id: I604b04afa23ede835c1f3db1f8c1bdeafbfba7ea
