Commit Graph

2319 Commits

Author SHA1 Message Date
089311bb3d coverity#704145 Resource leak in object
also cleaned up comments

Change-Id: Ia676d215cf8ef4830e31a1caf4153e33af84c200
Reviewed-on: https://gerrit.libreoffice.org/3071
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2013-03-28 13:03:19 +00:00
91aaceb727 fdo#39445 writing out tools/fsys.hxx (forms)
Change-Id: Iee0812ee098c3b7c12d297461907a2923bad2cc5
2013-03-27 08:31:16 -07:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
2413a8edc2 Fix warning: unused variable 'sConverted' [loplugin]
Change-Id: I14a2d98c519b2eab6645eaf8b2dcdbccc7c36c2f
2013-03-25 23:58:12 +02:00
9325dca981 "atomar" is not a word
SCNR

Change-Id: I3aaa8d9b37423d44fe11f161cc21c0a77b466353
2013-03-23 12:30:56 +02:00
2d9ce9191d Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)
...which is a confusing overload with unexpectedly different semantics from the
one-parameter form.  In preparation of marking it as deprecated.

Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
2013-03-20 13:05:35 +01:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
4c0c23af21 Simplify equalsIgnoreAsciiCaseAscii[L] calls
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19 11:32:20 +01:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
3991eaf556 reduce whitespaces between include and filename
Change-Id: I15f6ad0a760a28cbac53f99ba4d14ff5c24ce005
2013-03-19 01:26:45 +01:00
937b63af33 use startsWith() instead of compareToAscii()
brain damage...

Change-Id: I4dc63c7346f724eded9ac7b82cda25c2bb60beff
2013-03-11 11:07:09 +01:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
6583305dd7 simplify compareTo (now correct)
Change-Id: Ia4fd2f54d0bda71d472f46949500c0b23ff8e1b7
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-08 13:04:13 +01:00
3d4723f80a Revert "simplify some compareTo"
This reverts commit 19020191cbf3e3c7a7bf98d0958d86d931ae687b,

  s1.compareTo(s2, length-of-s2)

is *not* equivalent to

  s1 == s2
2013-03-08 09:03:10 +01:00
19020191cb simplify some compareTo
Change-Id: Ib63cfac8b5f129f31534020fd634750e846e3b98
2013-03-08 05:42:05 +01:00
21e1e859a7 fdo#60724 change spelling error REMOVEABLE -> REMOVABLE
Only applies to PropertyAttribute::REMOVEABLE, and all instances in comments.
All other instances of the misspelling have remained the same.
Example: AF_REMOVEABLE

Change-Id: I391f4101bbc3e06689318235a37d616065bc1686
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-03-06 10:39:30 +01:00
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
9ec4fc4de1 drop sole DBG_ASSERT only use of Application::GetFilterHdl
Change-Id: I6dd3e1141f9fe925bdb2cd2c7f0df994f35a119d
2013-03-04 16:29:27 +00:00
ce33f85ffd sal_Bool to bool
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04 23:14:41 +09:00
57d169b606 doubled namespace
Change-Id: I756f4a98b1eedcbe7674e9afd9b06816141688b9
2013-03-04 13:58:39 +01:00
5b04c9063c remove unused and commented out code
This code gets never called.

Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-03-04 11:34:07 +00:00
b313e37a92 fdo#46808, convert xforms::Model to new style
the service already existed, it just needed an IDL file.

Change-Id: Id8f33183d9332f9defd855b3a3c7413fde24a61b
2013-03-04 10:13:20 +02:00
f5ca04caca Related to fdo#60724: correct spelling
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml

Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
821ef2bb05 coverity#705651: fix memory leak
Change-Id: I1f0c8ac963f16fb4bd0d101c6a62996d9aebab78
2013-02-28 10:53:13 +01:00
633fca5f3c remove two more duplicates
Moreover clarify a comment and remove some commented code.

Change-Id: Iba87b9ea6675a9bb50b8af0f094891e59bd93bd8
Reviewed-on: https://gerrit.libreoffice.org/2406
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-26 13:03:29 +00:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
d5caf6898b loplugin: unused variables
Change-Id: I7fc203900256839e679bf73b717d121fedc42087
2013-02-24 17:44:31 +01:00
1443a9f7ab [Uu]sefull -> [Uu]seful
Change-Id: I5dad83789ff9b6815561208679a5e19821041e1f
2013-02-22 11:12:33 +01:00
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
1aaf9a9b36 Renamed hard-to-remember 8-char headers in editeng.
Change-Id: If255802082890e1b1b4c5197a791fa79a011773e
2013-02-12 15:15:06 -05:00
ff85e8319a fdo#46808, convert io::TextInputStream service to new style
Change-Id: Ida4abdd6587399aa8ade88af672bcb23ab7ea0f1
2013-02-11 08:02:15 +02:00
a7ecab870e fdo#46808, convert xml::xpath::XPathExtension service to new-style
Change-Id: Ibdfaa221d33ae405c08bc13aa9ed280b30448772
2013-02-11 08:02:14 +02:00
f53517a5b0 fdo#46808, convert xml::xpath::XPathAPI to new-style service
Change-Id: I54bb0eb08d687e7d54c42601c826c580a7a17ebb
2013-02-11 08:02:14 +02:00
fa3c9a9072 fdo#46808, convert some forms code to XComponentContext
Change-Id: Id36556018761a1961de8ccfb3c549d4af03230ea
2013-02-11 08:02:14 +02:00
45d416d315 fdo#46808, convert svt::GraphicAccess to XComponentContext
Change-Id: I081158bc43bf39ad165c14d8ada31dd0142ca82c
2013-02-11 08:02:14 +02:00
b5cd8f9186 fdo#46808, Adapt form::control::FilterControl UNO service to new style
The service already existed, it just did not have an IDL file

Change-Id: I1ca7ab09491057c1e9c91b5bb6763b84be10b47b
2013-02-11 08:02:12 +02:00
1ba8986446 fix for the awkward OUString::replaceAll() behaviour
Change-Id: I6ee919bb17ea7eb29cb9cfc0fc69d02d728d9a0f
2013-01-30 15:13:02 +01:00
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
f95a7c2c6d fdo#46808, Convert SvNumberFormatter to use XComponentContext
Change-Id: If4e8312dae6bc5eb8bb7655cf250f06ab37b7e5c
2013-01-28 08:25:24 +02:00
bc3be8493e Fix Member variable m_pView is not initialized in the constructor
Change-Id: I0b18698f23f7c2c446e60069d0efcb6d89b1e5d3
2013-01-26 21:27:30 +01:00
fea25896a8 tools/string.hxx: add operator==/!= for OUString/String
This has the disadvantage that it makes comparisons involving fast
OUString concatenation via operator+ ambiguous, as can be seen in
scriptdlg.cxx, but it allows comparing String and OUString wihout
explicit conversion, which is nice for incrementally converting code.

Change-Id: Ibfc728bdb161a01e0f8311915c97bcbba8b58c0b
Reviewed-on: https://gerrit.libreoffice.org/1803
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-22 11:26:39 +00:00
e3f11c10d8 Changed SetText() / GetText() to take/return OUString
replaced lots of Len() with isEmpty()

Change-Id: I6b82d48245ee2a0782e05a326f7934e9357227d0
Reviewed-on: https://gerrit.libreoffice.org/1795
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-01-21 20:48:35 +00:00
c26e2328ff turn some OSL_ENSURE into SAL_WARN_IF to avoid warnings about unused variables
And one OSL_ASSERT too.

Change-Id: I51f0083b9b9336e80c3b6a898c295173ad48f77c
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-01-09 09:37:58 +01:00
46fe5e5e06 fdo#46808, convert UnoControl and sub-classes to XComponentContext
Change-Id: I4ade267a44620f5a3af8009ac57a2456c62b83bc
2013-01-09 08:08:19 +02:00
3a50e97499 fdo#46808, Adapt sdb::OrderDialog UNO service to new style
The service already existed, it just did not have an IDL file.

Change-Id: If24e9d6069bf7454bb0add3be8c4bc5916cc4d1f
2013-01-09 08:08:14 +02:00
0c22f3eadd Make LO buildable again after the GraphicFilter move.
Change-Id: I3455a7294b136400f32163626d5a7a7f2bfa898c
2013-01-04 22:02:51 +01:00
bb121c864c fdo#46808, Convert frame::Desktop to new style service.
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).

Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.

I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.

I dropped the optional interfaces
   XStatusIndicatorFactory
   XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.

I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.

Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
2012-12-21 10:57:09 +02:00
6e5cb64670 fdo#46808, Adapt sdb::FilterDialog UNO service to new style
The service already existed, it just did not have an IDL file.

Change-Id: I2267bec182ad1cc8f6a37939861a7368a17fcef2
2012-12-21 09:12:09 +02:00
049afdad58 rhbz#782736 use right device for converting size
Change-Id: If433376df24a3646d80f30e1dfa45463653ea72b
2012-12-20 16:39:28 +01:00