Commit Graph

362540 Commits

Author SHA1 Message Date
a1fad26e04 fdo#84935: basic: DocBasicItem is a UNO service, lock SolarMutex in dtor
Change-Id: Ia31d735ba54d18f406653debce04a07c077d09eb
2014-10-23 15:38:20 +02:00
644678e2ac Avoid left shift of negative values (ubsan)
Change-Id: If465c155c70ec068b6bd7adc05f188bbecc2824e
2014-10-23 15:34:41 +02:00
413210a503 Avoid left shift of negative values (ubsan)
Change-Id: Ie4f6a4e3e54770c00741cc268ed9e27ecafac500
2014-10-23 15:27:37 +02:00
1e5d17f821 ATTR_VALUE_FORMAT is an SfxUInt32Item
Change-Id: I38f7cece6157cd0a48e3c6a09b25eccc47f8525e
2014-10-23 14:34:00 +02:00
0e63397d7f Remove pointless functions now that saveChild() is ZipPackageStream's member
Change-Id: Id43ec2e7ddb1035d3306170523764bb9a74c03b8
2014-10-23 14:30:31 +02:00
4b609883f9 Move ZipPackageStream::saveChild to proper source file
Change-Id: Icd108215874e830e5c9587f7dbb38a7f11ee27c8
2014-10-23 14:30:30 +02:00
1b3122a189 package: Add pure virtual ZipPackageEntry::saveChild()
..and adapt what needs to be changed.
So that, we can kill at least some usages of horrible ContentInfo struct.

Change-Id: I32d41f3b8ce2dfb65f0d1df18a540a3f67dcab6d
2014-10-23 14:30:30 +02:00
152c4afef4 package: ZipPackageStream: prefix members
Change-Id: I02a1c3189c6b52f4f539b0eaa8878985cae8b321
2014-10-23 14:30:30 +02:00
3a8bddc18e package: Add ZipOutputEntry to isolate deflating of streams.
Preparation commit for deflating streams in parallel.
We still use the same single XOutputStream (ByteChucker :-) for
sequential writing but this can now be changed more easily.

Change-Id: Idf26cc2187461660e31ac2e12c4708e761596fb2
2014-10-23 14:30:30 +02:00
0c24faee6b FastSerializer: Also use cache for writing to ForMerge if we are inside mark()
To ensure the correct order of calling ForMerge methods,
call flush always before touching maMarkStack.

This was the missing piece in optimizing write() methods,
because of writeBytes() checking each time what to call.
E.g. for Calc documents we don't use maMarkStack at all.
So, just transfer the output to proper "ForMerge" when inside mark()
and allow optimizations.
This commit makes write() methods almost 1/3 as fast.

Change-Id: I96c13888206c81f87e29b998839f78ea9d5570af
2014-10-23 14:30:29 +02:00
143bbb20a3 inline TokenMap::getUtf8TokenName
Change-Id: Icd9c6ebc9feb3e7aba28b01729b582a8f49c832a
2014-10-23 14:30:29 +02:00
d958e6d049 FastSerializer: Simplify OUString write a bit more
Change-Id: Ifa0746d635ec43cdc37867cf94bcc128bb8e2aca
2014-10-23 14:30:29 +02:00
f89cace61a FastSerializer: Avoid some cycles when dealing with doubles
Would be easier to use OStringBuffer, but we can't get its pData member.
Also its append(double) is suboptimal (or anything that uses
rtl_str_valueOfDouble) - should be doing something like this commit.

Change-Id: I8f3140081a574a84f0e60dc85cce1bd2de23cd34
2014-10-23 14:30:28 +02:00
03040ac23b FastSerializer: Use fixed sized Sequence directly as cache
Well, at least the allocated space is fixed size.
When passing that to XOutputStream, change the size in a hacky way.

Change-Id: I24fa134286e3086beda25c9a6915549e7c69119a
2014-10-23 14:30:28 +02:00
25eba216d8 FastSerializer: Use -1 for unknown string length
Change-Id: I3920caf9d95f20992b7961873f1668468d797e8e
2014-10-23 13:24:28 +02:00
f39d69f6b5 Remove few pointless OUString::number() and one method
Change-Id: I3e9a302a7513eebfeff07402f71fc3dde22e4cc2
2014-10-23 13:24:28 +02:00
c0c45cad41 maTokenNames.size() is constant: use it and be a bit faster
Change-Id: I39a6e2badf0c159e87763e2782bc89f0ee6068ec
2014-10-23 13:24:27 +02:00
5f46a7ad02 FastSerializer: Faster write(OUString): add ascii check
Saves about 80m pcycles for 180k calls.

Change-Id: I9c9b3bf5a076df56d1b5b87f0a85ac3404abe8a4
2014-10-23 13:24:27 +02:00
eb8e7a7632 FastSerializer: Simplify a bit
Change-Id: I7dee908f5441ad34128d688e1008fd6ffad2ab3f
2014-10-23 13:24:26 +02:00
865fc150ea Unused includes / using-declarations
Change-Id: I8b43635ab1f77b61469f060c9a092f1494388955
2014-10-23 13:24:26 +02:00
5ed4c11534 Use sc::CompileFormulaContext for faster export
It's a cache for maTabNames (sheet names mangled for the current grammar
for output) which ScCompiler needs and is expensive to get.

Change-Id: I7e2954104427a3c220f0f097be6cd45a66485b56
2014-10-23 13:24:26 +02:00
d8af144254 FastSerializer: Use faster TokenValue struct when possible
Saves another ~100m pcycles for 650k calls in startElementInternal()

Change-Id: I190326edc7feffb900e91fa7e5c3530b5b267f59
2014-10-23 13:24:25 +02:00
eb195bbe34 Use OUStringBuffers for performance reasons.
Saves 120m pcycles in just 250k calls to ScAddress::Format.

Change-Id: Ibf20cf0843a47cf0fa37a38c4fecf1ae1560412c
2014-10-23 13:24:25 +02:00
dbbbea6662 FastSerializer: Simplify cache to be fixed sized buffer
This makes writeBytes(), which is called a lot, simpler and thus faster.
E.g. for ~15m calls, this saves ~110m pcycles.

Change-Id: I29d01a1a8651f668aff574e0f015cd2f018eb1cd
2014-10-23 13:24:25 +02:00
659064475d This was OString already; use it that way
Change-Id: Ia2268ce8a1e2111adb609c515e5bfa824afa66ce
2014-10-23 13:24:24 +02:00
035fe8a6aa fdo#84938: replace MENUITEM constants with enum
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23 12:55:35 +02:00
bb0039fdca WaE: unused parameters
Change-Id: I689754378773fc6926e4cebe3ec14b5056fb8986
2014-10-23 13:48:19 +03:00
feba02c3a4 loplugin: cstylecast
Change-Id: I71cdd9154a8a5955e2915858cec33ec4e9ef4987
2014-10-23 12:36:16 +02:00
6a097a7d96 loplugin: cstylecast
Change-Id: I8c7cd4c2cdc134556c2c664a22e2048b51a3b98e
2014-10-23 12:36:16 +02:00
229eed079c loplugin: cstylecast
Change-Id: If991c0efe1ded6ef6d32b3a722ee87bbe36bf0bf
2014-10-23 12:36:16 +02:00
5f6f57c26e loplugin: cstylecast
Change-Id: Id4c581724e7e5466ffe46f11f0a8da2527c23dc6
2014-10-23 12:36:15 +02:00
e2548315bf loplugin: cstylecast
Change-Id: Iad39bce8e7562821bc8fbf8156ea56aedc19c7d6
2014-10-23 12:36:15 +02:00
d4ca0cc293 loplugin: cstylecast
Change-Id: I0eaeebad6be75a1c0cccdf90955fde1a2909bdba
2014-10-23 12:36:14 +02:00
50a8c89f36 loplugin: cstylecast
Change-Id: I9134aff4f2e6bff43ebb78c605e0ff521eac6ffc
2014-10-23 12:36:14 +02:00
cb414252b8 loplugin: cstylecast
Change-Id: I4aafc170895d8bab47206c7b07b4f1f6105d42d3
2014-10-23 12:36:14 +02:00
c7cacf639d Rename --enable-sal-info to --enable-sal-log
Change-Id: I896c9ac1c941b85d052fbefb902c4341664881d4
2014-10-23 13:16:32 +03:00
8133dc3d9a RES_FLTR_NUMRULE_NUM, RES_FLTR_SDR_ANCHOR, etc unused
Change-Id: I69b550d38dcafba3bacf438711cb6c3d20483065
2014-10-23 11:13:25 +01:00
3f89f88651 callcatcher: lots more unused post ww1 filter removal
Change-Id: I7bf6dc1d366093e797a19a8e555103c15b311ac8
2014-10-23 11:13:25 +01:00
4a32dc6562 coverity#1242682 Untrusted loop bound
Change-Id: Ib9b7c148f0679e458821cf2f30ef14d815b96706
2014-10-23 11:13:24 +01:00
04d34c63c7 coverity#1242688 Untrusted loop bound
Change-Id: Ic3e2c390de22d3e998daf760d73619218da020ec
2014-10-23 11:13:24 +01:00
d4617ef9c3 coverity#1078541 Division or modulo by zero
Change-Id: Iea43399c70e56ff4e32953a5ddc5751abed39ff7
2014-10-23 11:13:24 +01:00
2083b53500 coverity#1019337 Dereference after null check
Change-Id: I31584f1b204b85929a5549ecd7f7e05b6968e580
2014-10-23 11:13:23 +01:00
1f581d5041 coverity#1242587 Untrusted value as argument
Change-Id: I9720402f6482419cee84b468dd82a8c76ca1ddf4
2014-10-23 11:13:23 +01:00
ea8892cb44 coverity#1242599 Untrusted loop bound
Change-Id: I51bc114e215327f539612f94c40019c554698813
2014-10-23 11:13:22 +01:00
aa79a832b4 coverity#706585 Uncaught exception
Change-Id: Ic8d2963536b793f0a229901d9e13d8e54842d9b9
2014-10-23 11:13:22 +01:00
e89358aeca coverity#706586 Uncaught exception
Change-Id: I3ec05ae695428f92b7424295b6f2d3e833c6b162
2014-10-23 11:13:22 +01:00
6addde24f4 Add --enable-sal-info
Change-Id: I014d70ace7ce34b804ea2a018d3de8f94f7e0cbc
2014-10-23 13:02:28 +03:00
2593d96b8d Log parsing time of each xcd file
Change-Id: I290e2c84b17b9b5063139c6027b72f6cd3a78a99
2014-10-23 13:02:28 +03:00
d45607c4be Revert recent changes to comphelper::OSequenceOutputStream
Some of the changes could be wrong and we don't need them.

This reverts commit 784d4bea86d8cbb3a855e557c465ce50a049cefc.
This reverts commit 8524d5aba59148eef94859289f00ab6477e0e821.
This reverts commit 018f1deae884febbbe639c7ee46b45ce4807e9d3.
This reverts commit 8124fddc5803b4e104d4fc2456cb92cb030d9436.

We use our own helper cache class in FastSaxSerializer
since f736eba5a9df8645849a37b08d2764a5f495ab45.

Change-Id: Iaca6b5b11cb32595db4420a02fa72b0007cf6286
2014-10-23 11:53:19 +02:00
ea052e766a FastSerializer: Have own fast cache buffer implementation for XOutputStream
Previously comphelper::OSequenceOutputStream was used.

Change-Id: I4dc38c8c62422e59efa1071312497364cdf5be3c
2014-10-23 11:53:18 +02:00