Commit Graph

284 Commits

Author SHA1 Message Date
93056481e8 java: when rethrowing exceptions, store the original
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
2014-10-17 08:26:22 +02:00
12b01b920f java: no need to call String.valueOf to append to a String
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-17 08:26:19 +02:00
9341bf3dc3 java: when rethrowing, store the original exception
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16 12:27:15 +02:00
0c48deb59f bean: String comparison
Change-Id: Id2449ac887c92f87deb3b871b178ac16d3d6b4b8
Reviewed-on: https://gerrit.libreoffice.org/11922
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11 23:50:58 +00:00
017ea9eb0f bean: Use com.sun.star.uno.RuntimeException(Throwable thrwbl)
Change-Id: I6677072c349fc8c1997030b78fa38a5d78aec361
Reviewed-on: https://gerrit.libreoffice.org/11889
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-10 06:17:52 +00:00
b77b1ba8f0 We should know what our name is
Change-Id: I4e4d9c9aea5bb9387dbb2e69d94c48f4988c3346
2014-10-08 22:57:45 +03:00
f635ba0684 java: remove some unnecessary intermediary object creation
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
2014-10-07 13:20:01 +02:00
3aa70e21d7 [API CHANGE] OfficeBean: remove deprecated com.sun.star.beans classes
<https://wiki.openoffice.org/wiki/Documentation/DevGuide/JavaBean/The_Internal_Office_Bean_API>:
"Prior to OpenOffice.org 2.0 all Office Bean classes were in the
com.sun.star.bean package.  As of OpenOffice.org 2.0 the classes are contained
in the com.sun.star.comp.bean package.  The classes of the com.sun.star.bean
package are still contained in the officebean.jar but they are deprecated.
Further development and bug fixing will occur only in the com.sun.star.comp.bean
package."

Change-Id: I9421bfba941d9801a5cf8886ca971275740d178a
2014-09-30 14:41:51 +02:00
83636d2c09 java: when rethrowing exceptions, store the original cause
so that we get a nice complete stacktrace when it hits the final
handler

Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-25 13:47:25 +02:00
804e0335fb bean: unchecked call to getMethod() as a member of the raw type Class
http://docs.oracle.com/javase/tutorial/reflect/class/classTrouble.html

Change-Id: Ib548b47c412394e1518fea42b83d05a36c1655c8
Reviewed-on: https://gerrit.libreoffice.org/11477
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-17 06:12:24 +00:00
99920c36e9 bean: Array concatenated with a String
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Arrays.html#toString(java.lang.Object[])

Change-Id: I42090bf534a9a59fa97061ec2855f79328b1dd45
Reviewed-on: https://gerrit.libreoffice.org/11478
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-17 06:11:56 +00:00
bd21a82ea4 bean: encode(String) in URLEncoder has been deprecated
Change-Id: Ife3eaaaad199e79aeb6886a146324ffb145c7bc3
Reviewed-on: https://gerrit.libreoffice.org/11476
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-17 06:11:13 +00:00
be36698f60 Revert bean part of "java: remove dead methods"
...34bcf9b498bccb5c924f4cec850ff15d88df6f07; bean is a client API, not dead
code.

Change-Id: Iea17b6306152b9a4f2968bed550a44917803d9ec
2014-09-16 14:25:01 +02:00
0b3b907e96 bean: encode(String) in URLEncoder has been deprecated
Change-Id: Ib2be5d3369d6568056d47ad1da59bfa08c8ecd77
Reviewed-on: https://gerrit.libreoffice.org/11442
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-16 04:59:28 +00:00
7b8934d27e bean: use a non-varargs call for a stopOOoConnection method invocation
Change-Id: I589436be7d28b50b0b900a314b300d382eac5eb8
Reviewed-on: https://gerrit.libreoffice.org/11445
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-15 06:08:30 +00:00
0f114c3d00 bean: Boolean Parsing
Change-Id: If5e77da2b42b126e2c8fd7613b6adaed635fd683
Reviewed-on: https://gerrit.libreoffice.org/11364
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-10 08:16:23 +00:00
420170c8dd set names on some Java threads
Change-Id: I611821d5f84b440ba542a8d62a374df7b505de15
2014-09-08 20:53:26 +02:00
8c9fdc4a96 java: remove modifiers implied by the context
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
60f152caee java: avoid unnecessary comparisons in boolean expressions
i.e. stuff like "x == true"

Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20 10:35:53 +02:00
619dc5d4c8 remove some dead Java code
Change-Id: I03dc362f7302ac8539a4da3dcef9466a7c6d7159
2014-08-20 10:35:52 +02:00
0764292c5d java: use 'Short.valueOf' instead of 'new Short'
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long'
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19 14:57:17 +02:00
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
3a8d351988 java: remove unused methods
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
0d916bb240 java: remove unused imports
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
34bcf9b498 java: remove dead methods
found by UCDetector

Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
8583da1e93 java: remove unused fields
found by UCDetector

Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13 08:49:24 +02:00
68cd011c90 java: reduce scope, make some methods private
found by UCDetector

Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
70f56bc22f java: reduce scope, make member classes private
found by UCDetector

Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
da677dfd59 java: reduce scope, make fields private
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
14d1a11ec4 java: reduce scope, make constructors private
found by UCDetector

Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-13 08:49:22 +02:00
e701b3f732 java: reduce scope, make constants private
found by UCDetector

Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
2014-08-12 12:16:37 +02:00
5656fe58a0 java: fix broken javadoc tags
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12 09:41:31 +02:00
1c496506bc java: remove useless javadoc tags
that are not conveying any useful information

Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12 09:41:31 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
616b3ad504 java: remove exceptions from throws clauses that are not
.. actually thrown

Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08 09:48:20 +02:00
b58c053fed java: remove unnecessary semi-colons
Change-Id: Ibeeefc6e6ee8f7bed97a02f569f239ff035d38c4
2014-08-08 09:48:18 +02:00
a274d19d11 java: remove redundant super-interfaces
Change-Id: Iaf671ef87057362c804999a5154d8e8277bbc4b8
2014-08-08 09:48:18 +02:00
c5fdde23ed add a comment so I don't have to figure out this classes purpose again
Change-Id: I92f3cb3e9308e2d4e369c1ce216952b0eca09b17
2014-08-08 09:48:17 +02:00
336f3b9153 java: code some code to use non-deprecated constructors
Change-Id: I4194a3dfd361d1955cf5bb4fab915150eecfa21a
2014-08-08 09:48:17 +02:00
27459c71ef java: remove unused fields
Change-Id: I25fef9590a34ec8d9aab182b3d267ae3cd649a87
2014-08-08 09:48:16 +02:00
0c5f51ebbc java: remove commented out code
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
d26540bb05 java: remove unused fields
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
2014-08-05 11:31:50 +02:00
f124688cfd java: remove various unused variables
Change-Id: Id9f30938f594cb6fe73bf40adfffa65ec1b42cd1
2014-08-05 11:31:49 +02:00
66c34ff3e7 java: remove workarounds for missing functionality pre java 1.5
Since we now require java 1.5

Change-Id: I9e195f77c81bd9447f8e29c1862c68a57846c8a3
2014-08-04 14:50:58 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00