e27ac011c3
loplugin: cstylecast
...
Change-Id: I9fca98995131358b3b112b11e0b28feb1a3267d1
2014-10-01 13:08:43 +02:00
46ad54725b
bnc#648251: Avoid crash when attempting to open embedded OLE object as "text"
...
On non-Windows, when double-clicking an embedded OLE object, our glorious
content type detection logic detects it as "Text". As a side-effect, we start
to calculate text statistics on it. Which surely could produce interesting
numbers (you know what they say about statistics), but sadly causes a crash
involving the ICU RuleBasedBreakIterator, SwScanner,
sw::DocumentStatisticsManager and whatnot.
Avoid this by checking for a detected filter of type "Text" explicitly, and
avoiding the fun code paths in that case.
This leads to double-clicks being just ignored. Maybe it would be more useful
to produce a "General OLE Error" message box?
Change-Id: Iae0726b5e9c511a92bdff7229d2978cbf76cb07b
2014-08-27 15:08:58 +03:00
dac4ca5f68
new loplugin: externalandnotdefined
...
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
9af0abebfd
remove unnecessary use of Reference constructor in throw
...
Convert code like this:
throw IOException("xx",
Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
throw IOException("xx",
static_cast<OWeakObject*>(this) );
Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27 08:20:11 +02:00
9b791f9c31
remove unnecessary use of OUString constructor when throwing
...
Change-Id: I4a3f3f911dcfbf88696053215a2fb7a94678244c
2014-05-27 08:20:11 +02:00
dd33f91581
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part14
...
Change-Id: Ibccaa2138426c22cd63d273a1b6cdc927ebe80dc
2014-05-17 00:24:22 +02:00
2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-15 12:50:46 +00:00
142ecb8b36
embeddedobj: remove SAL_INFO's that only mark function entry
...
Change-Id: I06b344504e6052c25578f0bc4c3598d45d544003
2014-05-14 16:54:24 +02:00
0a1d822372
Many spelling fixes: directories a* - g*.
...
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.
(cherry picked from commit a6efc99d19d533fcf53106b6667bafba4d364370)
Conflicts:
accessibility/bridge/org/openoffice/java/accessibility/AccessibleTextImpl.java
accessibility/bridge/org/openoffice/java/accessibility/Component.java
accessibility/bridge/org/openoffice/java/accessibility/Container.java
accessibility/bridge/org/openoffice/java/accessibility/DescendantManager.java
accessibility/bridge/org/openoffice/java/accessibility/Dialog.java
accessibility/bridge/org/openoffice/java/accessibility/Frame.java
accessibility/bridge/org/openoffice/java/accessibility/List.java
accessibility/bridge/org/openoffice/java/accessibility/Menu.java
accessibility/bridge/org/openoffice/java/accessibility/Table.java
accessibility/bridge/org/openoffice/java/accessibility/Tree.java
accessibility/bridge/org/openoffice/java/accessibility/Window.java
accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx
accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx
accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx
accessibility/source/extended/accessibleiconchoicectrlentry.cxx
accessibility/source/extended/accessiblelistboxentry.cxx
accessibility/source/extended/accessibletablistbox.cxx
accessibility/source/extended/accessibletablistboxtable.cxx
accessibility/workben/org/openoffice/accessibility/awb/canvas/Canvas.java
accessibility/workben/org/openoffice/accessibility/misc/OfficeConnection.java
apple_remote/AppleRemote.m
autodoc/inc/ary/cpp/c_gate.hxx
autodoc/inc/ary/cpp/cp_ce.hxx
autodoc/inc/ary/cpp/cp_def.hxx
autodoc/inc/ary/cpp/cp_type.hxx
autodoc/inc/ary/doc/d_parametrized.hxx
autodoc/inc/ary/idl/i_type.hxx
autodoc/source/ary/inc/cross_refs.hxx
autodoc/source/ary/inc/sorted_idset.hxx
autodoc/source/display/html/outfile.hxx
autodoc/source/display/html/pagemake.cxx
autodoc/source/display/idl/hi_env.hxx
autodoc/source/parser/inc/tokens/tokproct.hxx
autodoc/source/parser_i/inc/s2_luidl/tokproct.hxx
autodoc/source/parser_i/inc/tokens/tkp2.hxx
automation/inc/automation/commtypes.hxx
automation/inc/automation/simplecm.hxx
automation/source/server/recorder.cxx
automation/source/server/recorder.hxx
automation/source/server/statemnt.cxx
automation/source/simplecm/packethandler.hxx
automation/source/simplecm/simplecm.cxx
avmedia/source/framework/soundhandler.cxx
basegfx/inc/basegfx/range/rangeexpander.hxx
basic/inc/basic/sbxdef.hxx
basic/source/classes/sbunoobj.cxx
basic/source/classes/sbxmod.cxx
basic/source/comp/dim.cxx
basic/source/comp/exprgen.cxx
basic/source/runtime/step1.cxx
basic/source/runtime/step2.cxx
basic/source/sbx/sbxint.cxx
basic/source/uno/namecont.cxx
basic/workben/mgrtest.cxx
bean/com/sun/star/beans/LocalOfficeConnection.java
bean/com/sun/star/beans/LocalOfficeWindow.java
bean/com/sun/star/comp/beans/LocalOfficeConnection.java
bean/com/sun/star/comp/beans/LocalOfficeWindow.java
bean/com/sun/star/comp/beans/OOoBean.java
bridges/inc/bridges/cpp_uno/bridge.hxx
bridges/source/cpp_uno/cc50_solaris_intel/cpp2uno.cxx
bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
bridges/source/cpp_uno/cc50_solaris_intel/uno2cpp.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/cpp2uno.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_macosx_powerpc/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_macosx_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/except.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_os2_intel/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_os2_intel/except.cxx
bridges/source/cpp_uno/gcc3_os2_intel/uno2cpp.cxx
bridges/source/cpp_uno/mingw_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/msvc_win32_intel/except.cxx
bridges/source/cpp_uno/s5abi_macosx_x86-64/except.cxx
bridges/source/cpp_uno/shared/component.cxx
bridges/source/jni_uno/jni_base.h
bridges/source/jni_uno/jni_bridge.cxx
bridges/source/jni_uno/jni_java2uno.cxx
bridges/source/jni_uno/jni_uno2java.cxx
canvas/inc/canvas/base/doublebitmapbase.hxx
canvas/inc/canvas/base/floatbitmapbase.hxx
canvas/inc/canvas/base/integerbitmapbase.hxx
canvas/source/cairo/cairo_canvasbitmap.cxx
canvas/source/cairo/cairo_textlayout.cxx
chart2/source/controller/dialogs/ObjectNameProvider.cxx
chart2/source/view/diagram/VDiagram.cxx
chart2/source/view/main/ChartView.cxx
cli_ure/source/native/makefile.mk
cli_ure/source/uno_bridge/cli_data.cxx
codemaker/source/javamaker/javatype.cxx
comphelper/inc/comphelper/componentcontext.hxx
comphelper/inc/comphelper/interaction.hxx
comphelper/inc/comphelper/locale.hxx
comphelper/inc/comphelper/string.hxx
comphelper/source/container/embeddedobjectcontainer.cxx
comphelper/source/misc/accessiblecontexthelper.cxx
comphelper/source/misc/asyncnotification.cxx
comphelper/source/misc/locale.cxx
comphelper/source/misc/mediadescriptor.cxx
comphelper/source/misc/numberedcollection.cxx
comphelper/source/misc/proxyaggregation.cxx
comphelper/source/misc/scopeguard.cxx
comphelper/source/misc/sequenceashashmap.cxx
configure.in
connectivity/source/commontools/parameters.cxx
connectivity/source/drivers/dbase/DTable.cxx
connectivity/source/drivers/evoab2/NStatement.cxx
connectivity/source/drivers/file/FPreparedStatement.cxx
connectivity/source/drivers/jdbc/DatabaseMetaData.cxx
connectivity/source/inc/flat/ETable.hxx
connectivity/source/parse/sqlnode.cxx
cosv/inc/cosv/persist.hxx
cosv/inc/cosv/ploc_dir.hxx
cosv/inc/cosv/tpl/dyn.hxx
cppu/source/LogBridge/LogBridge.cxx
cppu/source/uno/data.cxx
cppuhelper/source/bootstrap.cxx
cppuhelper/source/component_context.cxx
cppuhelper/source/propshlp.cxx
cppuhelper/source/servicefactory.cxx
cpputools/source/registercomponent/registercomponent.cxx
cui/source/customize/acccfg.cxx
cui/source/dialogs/about.cxx
cui/source/dialogs/commonlingui.hxx
cui/source/dialogs/showcols.cxx
cui/source/inc/cuihyperdlg.hxx
cui/source/inc/cuitabline.hxx
cui/source/options/optsave.src
cui/source/tabpages/tpline.cxx
cui/source/tabpages/transfrm.cxx
dbaccess/source/core/api/CacheSet.cxx
dbaccess/source/core/api/KeySet.cxx
dbaccess/source/core/api/RowSet.cxx
dbaccess/source/core/api/RowSet.hxx
dbaccess/source/core/api/RowSetBase.cxx
dbaccess/source/core/api/RowSetBase.hxx
dbaccess/source/core/api/RowSetCache.cxx
dbaccess/source/core/api/querycomposer.cxx
dbaccess/source/ext/adabas/Acomponentmodule.hxx
dbaccess/source/ui/app/AppControllerDnD.cxx
dbaccess/source/ui/app/AppDetailView.cxx
dbaccess/source/ui/browser/brwctrlr.cxx
dbaccess/source/ui/browser/sbagrid.cxx
dbaccess/source/ui/browser/unodatbr.cxx
dbaccess/source/ui/dlg/AdabasStat.hxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/dlg/directsql.cxx
dbaccess/source/ui/dlg/generalpage.hxx
dbaccess/source/ui/dlg/tablespage.cxx
dbaccess/source/ui/inc/JoinTableView.hxx
dbaccess/source/ui/inc/TableController.hxx
dbaccess/source/ui/inc/UITools.hxx
dbaccess/source/ui/inc/brwctrlr.hxx
dbaccess/source/ui/inc/datasourcemap.hxx
dbaccess/source/ui/querydesign/JoinTableView.cxx
dbaccess/source/ui/querydesign/QueryDesignView.cxx
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
dbaccess/source/ui/querydesign/TableWindow.cxx
dbaccess/source/ui/querydesign/querycontroller.cxx
dbaccess/source/ui/relationdesign/RelationTableView.cxx
dbaccess/source/ui/tabledesign/TableController.cxx
desktop/source/app/app.cxx
desktop/source/app/appinit.cxx
desktop/source/app/langselect.cxx
desktop/source/app/officeipcthread.cxx
desktop/source/deployment/manager/dp_extensionmanager.cxx
desktop/source/deployment/misc/dp_misc.cxx
desktop/source/deployment/misc/dp_resource.cxx
desktop/source/deployment/registry/dp_backend.cxx
desktop/source/deployment/registry/package/dp_package.cxx
desktop/source/migration/cfgfilter.cxx
desktop/source/migration/migration.cxx
desktop/source/splash/splash.cxx
desktop/win32/source/QuickStart/QuickStart.cpp
desktop/win32/source/setup/setup.cpp
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
dtrans/source/win32/clipb/MtaOleClipb.hxx
dtrans/source/win32/clipb/WinClipbImpl.cxx
editeng/source/editeng/editview.cxx
editeng/source/editeng/impedit2.cxx
editeng/source/editeng/impedit3.cxx
editeng/source/editeng/impedit4.cxx
editeng/source/editeng/textconv.hxx
editeng/source/misc/unolingu.cxx
embeddedobj/source/commonembedding/persistence.cxx
embeddedobj/source/general/dummyobject.cxx
embeddedobj/source/msole/olecomponent.cxx
embeddedobj/source/msole/olepersist.cxx
embeddedobj/test/Container1/NativeView.java
extensions/source/bibliography/framectr.cxx
extensions/source/macosx/spotlight/OOoContentDataParser.m
extensions/source/macosx/spotlight/unzip.h
extensions/source/macosx/spotlight/unzip.m
extensions/source/oooimprovement/myconfigurationhelper.hxx
extensions/source/propctrlr/eventhandler.cxx
extensions/source/propctrlr/formcomponenthandler.cxx
extensions/source/propctrlr/pcrcomponentcontext.hxx
extensions/source/scanner/twain.cxx
extensions/source/update/check/updatecheckconfig.hxx
external/mingwheaders/mingw_atl_headers.patch
extras/source/misc_config/wizard/web/layouts/source.xml.xsl
fileaccess/source/FileAccess.cxx
filter/inc/filter/msfilter/msocximex.hxx
filter/inc/filter/msfilter/svxmsbas.hxx
filter/qa/complex/filter/detection/typeDetection/Helper.java
filter/source/config/cache/basecontainer.cxx
filter/source/config/cache/cacheitem.hxx
filter/source/config/cache/contenthandlerfactory.cxx
filter/source/config/cache/filtercache.cxx
filter/source/config/cache/filtercache.hxx
filter/source/config/cache/filterfactory.cxx
filter/source/config/cache/frameloaderfactory.cxx
filter/source/config/cache/querytokenizer.hxx
filter/source/config/cache/typedetection.cxx
filter/source/config/cache/typedetection.hxx
filter/source/config/cache/versions.hxx
filter/source/config/fragments/makefile.mk
filter/source/config/tools/merge/pyAltFCFGMerge
filter/source/flash/swfwriter.cxx
filter/source/flash/swfwriter1.cxx
filter/source/msfilter/msdffimp.cxx
filter/source/msfilter/msocximex.cxx
filter/source/msfilter/msvbahelper.cxx
filter/source/msfilter/svxmsbas.cxx
filter/source/xmlfilterdetect/filterdetect.cxx
filter/source/xslt/import/uof2/uof2odf.xsl
filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
filter/source/xsltfilter/com/sun/star/comp/xsltfilter/Base64.java
forms/source/xforms/convert.hxx
forms/source/xforms/model.cxx
fpicker/source/aqua/SalAquaFilePicker.mm
fpicker/source/office/fpinteraction.cxx
fpicker/source/unx/gnome/SalGtkFolderPicker.cxx
fpicker/source/unx/kde4/KDE4FilePicker.cxx
fpicker/source/win32/filepicker/PreviewCtrl.cxx
fpicker/source/win32/filepicker/PreviewCtrl.hxx
fpicker/source/win32/filepicker/VistaFilePicker.cxx
fpicker/source/win32/filepicker/VistaFilePickerImpl.hxx
fpicker/source/win32/filepicker/helppopupwindow.hxx
fpicker/source/win32/folderpicker/MtaFop.hxx
framework/inc/classes/droptargetlistener.hxx
framework/inc/classes/filtercache.hxx
framework/inc/classes/filtercachedata.hxx
framework/inc/classes/protocolhandlercache.hxx
framework/inc/classes/servicemanager.hxx
framework/inc/commands.h
framework/inc/dispatch/basedispatcher.hxx
framework/inc/dispatch/blankdispatcher.hxx
framework/inc/dispatch/closedispatcher.hxx
framework/inc/dispatch/createdispatcher.hxx
framework/inc/dispatch/dispatchprovider.hxx
framework/inc/dispatch/helpagentdispatcher.hxx
framework/inc/dispatch/mailtodispatcher.hxx
framework/inc/dispatch/menudispatcher.hxx
framework/inc/dispatch/oxt_handler.hxx
framework/inc/dispatch/popupmenudispatcher.hxx
framework/inc/dispatch/selfdispatcher.hxx
framework/inc/dispatch/servicehandler.hxx
framework/inc/dispatch/startmoduledispatcher.hxx
framework/inc/dispatch/systemexec.hxx
framework/inc/helper/fixeddocumentproperties.hxx
framework/inc/helper/ocomponentaccess.hxx
framework/inc/helper/oframes.hxx
framework/inc/helper/otasksenumeration.hxx
framework/inc/helper/persistentwindowstate.hxx
framework/inc/helper/statusindicator.hxx
framework/inc/helper/statusindicatorfactory.hxx
framework/inc/helper/tagwindowasmodified.hxx
framework/inc/helper/titlebarupdate.hxx
framework/inc/helper/vclstatusindicator.hxx
framework/inc/interaction/quietinteraction.hxx
framework/inc/jobs/helponstartup.hxx
framework/inc/jobs/job.hxx
framework/inc/jobs/jobdata.hxx
framework/inc/jobs/jobexecutor.hxx
framework/inc/loadstate.h
framework/inc/macros/debug/assertion.hxx
framework/inc/macros/debug/event.hxx
framework/inc/macros/debug/filterdbg.hxx
framework/inc/macros/debug/memorymeasure.hxx
framework/inc/macros/debug/timemeasure.hxx
framework/inc/macros/xserviceinfo.hxx
framework/inc/queries.h
framework/inc/recording/dispatchrecordersupplier.hxx
framework/inc/services/autorecovery.hxx
framework/inc/services/backingcomp.hxx
framework/inc/services/contenthandlerfactory.hxx
framework/inc/services/desktop.hxx
framework/inc/services/detectorfactory.hxx
framework/inc/services/frame.hxx
framework/inc/services/frameloaderfactory.hxx
framework/inc/services/layoutmanager.hxx
framework/inc/services/license.hxx
framework/inc/services/logindialog.hxx
framework/inc/services/modulemanager.hxx
framework/inc/services/pathsettings.hxx
framework/inc/services/pluginframe.hxx
framework/inc/services/substitutepathvars.hxx
framework/inc/services/task.hxx
framework/inc/services/taskcreatorsrv.hxx
framework/inc/stdtypes.h
framework/inc/threadhelp/fairrwlock.hxx
framework/inc/threadhelp/inoncopyable.h
framework/inc/threadhelp/itransactionmanager.h
framework/inc/threadhelp/lockhelper.hxx
framework/inc/threadhelp/readguard.hxx
framework/inc/threadhelp/resetableguard.hxx
framework/inc/threadhelp/transactionguard.hxx
framework/inc/threadhelp/writeguard.hxx
framework/inc/uifactory/uielementfactorymanager.hxx
framework/inc/xml/acceleratorconfigurationreader.hxx
framework/qa/complex/dispatches/checkdispatchapi.java
framework/qa/complex/framework/autosave/AutoSave.java
framework/qa/complex/framework/autosave/Protocol.java
framework/qa/complex/framework/recovery/RecoveryTest.java
framework/qa/complex/loadAllDocuments/StreamSimulator.java
framework/source/accelerators/acceleratorconfiguration.cxx
framework/source/accelerators/acceleratorexecute.cxx
framework/source/accelerators/acceleratorexecute.hxx
framework/source/accelerators/keymapping.cxx
framework/source/accelerators/presethandler.cxx
framework/source/application/framework.cxx
framework/source/application/login.cxx
framework/source/classes/framecontainer.cxx
framework/source/classes/menumanager.cxx
framework/source/classes/taskcreator.cxx
framework/source/dispatch/closedispatcher.cxx
framework/source/dispatch/dispatchprovider.cxx
framework/source/dispatch/helpagentdispatcher.cxx
framework/source/dispatch/interceptionhelper.cxx
framework/source/dispatch/mailtodispatcher.cxx
framework/source/dispatch/menudispatcher.cxx
framework/source/dispatch/oxt_handler.cxx
framework/source/dispatch/servicehandler.cxx
framework/source/fwe/classes/framelistanalyzer.cxx
framework/source/fwe/dispatch/interaction.cxx
framework/source/fwe/helper/titlehelper.cxx
framework/source/fwe/helper/undomanagerhelper.cxx
framework/source/fwe/xml/eventsdocumenthandler.cxx
framework/source/fwe/xml/statusbardocumenthandler.cxx
framework/source/fwe/xml/toolboxdocumenthandler.cxx
framework/source/fwi/classes/protocolhandlercache.cxx
framework/source/fwi/threadhelp/lockhelper.cxx
framework/source/fwi/threadhelp/transactionmanager.cxx
framework/source/helper/persistentwindowstate.cxx
framework/source/helper/statusindicatorfactory.cxx
framework/source/helper/vclstatusindicator.cxx
framework/source/inc/accelerators/acceleratorcache.hxx
framework/source/inc/accelerators/acceleratorconfiguration.hxx
framework/source/inc/accelerators/presethandler.hxx
framework/source/inc/accelerators/storageholder.hxx
framework/source/inc/loadenv/actionlockguard.hxx
framework/source/inc/loadenv/loadenv.hxx
framework/source/inc/loadenv/loadenvexception.hxx
framework/source/inc/pattern/frame.hxx
framework/source/inc/pattern/storages.hxx
framework/source/inc/pattern/window.hxx
framework/source/jobs/helponstartup.cxx
framework/source/jobs/job.cxx
framework/source/jobs/jobdata.cxx
framework/source/jobs/jobdispatch.cxx
framework/source/jobs/jobresult.cxx
framework/source/jobs/joburl.cxx
framework/source/jobs/shelljob.cxx
framework/source/loadenv/loadenv.cxx
framework/source/services/autorecovery.cxx
framework/source/services/backingwindow.cxx
framework/source/services/desktop.cxx
framework/source/services/frame.cxx
framework/source/services/modulemanager.cxx
framework/source/services/pathsettings.cxx
framework/source/services/substitutepathvars.cxx
framework/source/uiconfiguration/moduleuicfgsupplier.cxx
framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
framework/source/uiconfiguration/uicategorydescription.cxx
framework/source/uiconfiguration/uiconfigurationmanagerimpl.cxx
framework/source/uiconfiguration/windowstateconfiguration.cxx
framework/source/uielement/uicommanddescription.cxx
framework/source/unotypes/fwk.xml
framework/source/xml/imagesdocumenthandler.cxx
framework/test/test.cxx
framework/test/test_componentenumeration.bas
framework/test/test_statusindicatorfactory.bas
framework/test/threadtest.cxx
framework/test/threadtest/threadtest.cxx
framework/test/typecfg/cfgview.cxx
framework/test/typecfg/xml2xcd.cxx
include/basegfx/polygon/b2dpolygon.hxx
include/canvas/base/graphicdevicebase.hxx
include/canvas/canvastools.hxx
include/comphelper/configurationhelper.hxx
include/comphelper/embeddedobjectcontainer.hxx
include/comphelper/propagg.hxx
include/comphelper/sequenceashashmap.hxx
include/connectivity/sqlerror.hxx
include/connectivity/sqlnode.hxx
include/cppuhelper/propshlp.hxx
include/editeng/AccessibleContextBase.hxx
include/framework/framelistanalyzer.hxx
sfx2/source/dialog/backingcomp.cxx
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
Change-Id: I2618bf83c0e30f68f23ff25f6eb466df04d34c6d
2014-04-30 12:13:36 +01:00
584e8c8c3c
embeddedobj: sal_Bool->bool
...
Change-Id: Ie3465a34963c768945b1ee7f5939ea1f233d3528
2014-04-22 09:53:13 +02:00
97a5ba4a71
remove comments why a file gets included
...
also remove some commented out code
Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
82d1b40444
Clean up function declarations
...
Change-Id: Ia33a39c9c8fe25c48c81c53270ca9ce5ef90221c
2014-04-14 11:19:42 +02:00
2a7fdf2a7b
fdo#77140 embeddedobj: avoid unneeded conversion in ConvertBufferToFormat()
...
The primary reason is not performance: on export currently we loose some
EMF+ properties. While it would be good to fix all those problems one by
one, this is a small fix to avoid all kind of roundtrip problems in this
situation.
Change-Id: If5e1c1eabd8290f36b538e374c9707ae17097786
2014-04-07 18:09:12 +02:00
d4e4bcb2df
coverity#706511 Uncaught exception
...
Change-Id: I2822c35e60a93b86bdcb56f1e4782aa46e1ce8e0
2014-04-04 20:58:31 +01:00
dc72c62b31
coverity#706512 Uncaught exception
...
Change-Id: I6ec80c02ca8ef737297e77ccda2a0b5919fa66cb
2014-04-04 20:58:30 +01:00
8f7c677dbb
Avoid possible resource leaks by boost::scoped_array
...
Change-Id: Ibf92b3098c50388d8b6d27f4476e613a1f8918b5
2014-04-02 16:09:11 +09:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
a94e973bf5
OLE: Turn an OSL_ENSURE() into a real condition.
...
This is part of some STAMPIT workaround; no idea what it is, but for sure it
causes problems with PowerPoint OLE in Writer - so let's avoid updating if it
is not "STAMPIT".
Change-Id: I266b419ba3461c547f7ee8e447ef64a47a8511e8
2014-03-04 23:05:12 +01:00
e74a09929d
Exclude WNT-specific includes on other platforms
...
Change-Id: I7eeae61275269e09092267f2a6ccb27d7bb91ddb
2014-02-27 12:51:43 +01:00
e4f6ba5e3c
Remove visual noise from embeddedobj
...
Change-Id: I63ce6896e2f82160ffedb9f6123ca765f49698c5
Reviewed-on: https://gerrit.libreoffice.org/8256
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 15:02:45 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
a3f32769fc
Fix bogus mass-conversion equalsAsciiL -> startsWith
...
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
2014-01-21 15:54:52 +01:00
300cf0a0bc
Use bool
...
Change-Id: I7b7be27bc2e6fe73811b800945d7c6dbd8248034
2014-01-10 17:11:45 +01:00
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
d694313b57
Catch block smells like leftover debugging code
...
...especially as it doesn't change hr from S_OK, and compiling with /EHsc
(instead of /EHa) reveals that OleRun does not throw any (C++) exceptions (and
thus produces an "unreachable code" warning for the catch block).
Change-Id: Ic34e83e6ede3a214ccb073e3e54d6fcc493d46ea
2013-11-29 17:42:08 +01:00
f01580ce9c
Windows: Require at least Windows XP SP2
...
* Windows XP SP2 is 0x0502, see
http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
this is done module wide now. So the overall behavior
is as before. This seems to be the best compromise for
now.
* We need at least SP2 because of the bluetooth stuff
used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
project specific precompiled header files.
* All local definitions of WINVER are removed, because
the global WINVER setting makes them obsolete now.
To the relation of the three macros:
Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.
WINVER and NTDDI_VERSION can be set idenpendently each
for itself.
Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org >
Tested-by: Thorsten Behrens <thb@documentfoundation.org >
2013-11-20 07:15:16 -06:00
3af99e4d59
convert equalsAsciiL calls to startsWith calls
...
Convert code like:
aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) )
to
aStr.startsWith( "ActiveConnection" )
which compiles down to the same machine code.
Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-20 10:07:31 +02:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
2c35fff7ec
remove most use of RTL_CONSTASCII_USTRINGPARAM macro
...
This is largely unnecessary when working with OUString
Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
484819a235
remove unnecessary use of OUString constructor in EMBEDDEDOBJ module
...
Change-Id: I60bbdd2a2592a1e5333abe50711aa227786ce935
2013-11-11 11:21:23 +02:00
d6b80337fb
fdo#68849 add some header guards
...
Change-Id: I1cd598fba94e337c2ccad68a4a888743aeb292f0
2013-10-22 05:32:49 +02:00
7235d23267
fdo#54938: Adapt supportsService implementations to cppu::supportsService
...
Change-Id: I683c0d30c3286ed5d725d4eefe8b3977b82ee316
Reviewed-on: https://gerrit.libreoffice.org/6035
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2013-10-07 17:01:33 +00:00
ec9a074513
-Werror,-Wunused-variable
...
Change-Id: I9d09f8b632f568637f0a2ccb1ff62ce5d3d5afed
2013-10-02 18:14:38 +02:00
64b993e046
finish deprecation of O(U)String::valueOf()
...
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.
Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
19277d02fb
osl_getThreadIdentifier(0) -> osl::Thread::getCurrentIdentifier()
...
Change-Id: Ida9785c4b9fda0459769957734952e69d7a9de44
2013-08-21 14:19:10 +02:00
ba0a57702c
remove OUString wrap for string literals
...
For some functions and all kinds of Exceptions.
CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException
createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService
bash command:
for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
| cut -d ':' -f1 | sort -u
| xargs sed -i
-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
-e "s/\($i.*\)\"+ /\1\" + /g";
done
Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-06-29 21:52:54 +00:00
660b67a413
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*
Change-Id: Id4e90b83a7275bfd30914f7514a609cebbfbf4ac
Reviewed-on: https://gerrit.libreoffice.org/4044
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Luboš Luňák <l.lunak@suse.cz >
2013-05-31 18:08:02 +00:00
e2e2cc6114
remove usage of RTL_CONSTASCII_USTRINGPARAM
...
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.
Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
334086d0bd
Resolves: #i113605# missing :ReleaseStgMedium() call on STGMEDIUM object
...
which causes obvious memory leaks
Found by: zhangjf
Patch by: zhangjf
(cherry picked from commit e0d9b7a23ca3e7ba181134cd89f3f18233031ef1)
Change-Id: I5f99f8cf02e155e5284df3df89feb49d9a30c2c1
2013-05-02 11:33:48 +01:00
1264480bc3
fdo#60724 correct spelling
...
Change-Id: I3d978cb657647b4a4e9709258c6a6a4ac1d339a9
2013-04-15 05:39:31 +02:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
e1f6dac689
Replace compareTo(...) == 0 with ==
...
Proposed patch for the following issue:
https://bugs.freedesktop.org/show_bug.cgi?id=62096
Change-Id: Ib83a9051ea12c53642f781e5427a6ca728049a7f
Reviewed-on: https://gerrit.libreoffice.org/3198
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Reviewed-by: Luboš Luňák <l.lunak@suse.cz >
Tested-by: Miklos Vajna <vmiklos@suse.cz >
2013-04-05 08:57:28 +00:00
39d45390f4
removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
...
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms
Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 10:48:30 +00:00
8b27d78b4a
automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
...
Done with a perl regex:
s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms
Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-03-19 09:00:26 +00:00
f5ca04caca
Related to fdo#60724: correct spelling
...
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml
Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
c13802e009
Fix typo "persistant" -> "persistant"
...
Change-Id: I639afec2508d189c10a180fd8f824e634afbd14a
Reviewed-on: https://gerrit.libreoffice.org/2347
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2013-02-28 16:05:17 +00:00
5a65ca67d9
fdo#60491: embeddedobj: catch exception in fallback path
...
This allows the OLE object to at least be passed to the OS for
opening...
Change-Id: I97f93eb3a015d7771f3fc909517ffb96d61fde52
2013-02-10 02:10:05 +01:00
af8c759914
embeddedobj: log some exceptions
...
Change-Id: I2e565bc6e57f7bf59fdd6eb5fc577e0b3d58b9f6
2013-02-10 02:10:04 +01:00
