035fe8a6aa
fdo#84938: replace MENUITEM constants with enum
...
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23 12:55:35 +02:00
ad9498f8b8
More -Werror,-Wunused-private-field
...
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html >
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15 15:58:56 +02:00
9a65df2513
coverity#1078526 Logically dead code
...
Change-Id: I203511fcb1e740d7d371821d49a7c13a72e6fc3b
2014-10-03 09:07:56 +01:00
1777c425fe
loplugin: cstylecast
...
Change-Id: I4a8786f335b5f9a14116c546d32f1ff6cff99930
2014-10-02 07:37:19 +02:00
b53b5081a8
framework: sal_Bool -> bool
...
Change-Id: Ie56d3fe674af048d7aea32f141c5825e4c2aa98b
2014-09-12 11:48:34 +02:00
037d03b9fa
Typo: (N|n)ormaly->(N|n)ormally
...
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-09-10 22:35:39 +02:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
cc25f70ef1
compareTo -> equals
...
convert OUString::compareTo usage to equals to startsWith where it
is more appropriate
Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
2014-06-04 11:52:34 +02:00
1d2993df98
coverity#737167 Uncaught exception
...
Change-Id: I9ac3ffbecf8c9efc0b69ad4606c61dbf8fa5a0e9
2014-06-04 09:38:12 +01:00
0f2824b117
remove more unnecessary use of OUString constructor
...
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-27 08:20:12 +02:00
3467112fbd
coverity#983680 Uncaught exception
...
Change-Id: I62baf5b8809d915a4fe6a32788868072d55258e0
2014-05-24 16:11:00 +01:00
ac76cc7e60
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
...
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
61ce018658
Resolves: #i86528# use the module manager to identify the context...
...
for addons menu merging
(cherry picked from commit 2aac0070dbef6c1ad7eeccf7d4015cdcbffe067e)
Conflicts:
framework/source/classes/menumanager.cxx
framework/source/fwe/classes/addonmenu.cxx
framework/source/uielement/menubarmanager.cxx
include/framework/addonmenu.hxx
Change-Id: I3b606671db3a4c6ba8ed2b850e01e1ac91db7581
2014-05-19 13:28:17 +01:00
b1e29a6ac5
Single line between methods
2014-05-17 21:14:06 +01:00
68741d0055
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part13
...
Change-Id: Ieecfd7ccb10c75ac639d0ba8e7cb588607097c2a
2014-05-15 22:52:22 +02:00
b2096deaff
various loplugin:passsequencebyref
...
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
2014-05-14 16:54:27 +02:00
493bd11fcb
Removed redundant private methods comments
2014-05-14 14:17:01 +01:00
248145f99e
Find places where uno::Sequence is passed by value.
...
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-05-14 08:10:22 +00:00
2ce779cd0c
fix-includes.pl: framework
...
Change-Id: I405196a2df0be0eb77961540b457933777b90a50
2014-05-11 01:55:38 +02:00
0a1d822372
Many spelling fixes: directories a* - g*.
...
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done before.
(cherry picked from commit a6efc99d19d533fcf53106b6667bafba4d364370)
Conflicts:
accessibility/bridge/org/openoffice/java/accessibility/AccessibleTextImpl.java
accessibility/bridge/org/openoffice/java/accessibility/Component.java
accessibility/bridge/org/openoffice/java/accessibility/Container.java
accessibility/bridge/org/openoffice/java/accessibility/DescendantManager.java
accessibility/bridge/org/openoffice/java/accessibility/Dialog.java
accessibility/bridge/org/openoffice/java/accessibility/Frame.java
accessibility/bridge/org/openoffice/java/accessibility/List.java
accessibility/bridge/org/openoffice/java/accessibility/Menu.java
accessibility/bridge/org/openoffice/java/accessibility/Table.java
accessibility/bridge/org/openoffice/java/accessibility/Tree.java
accessibility/bridge/org/openoffice/java/accessibility/Window.java
accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx
accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx
accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx
accessibility/source/extended/accessibleiconchoicectrlentry.cxx
accessibility/source/extended/accessiblelistboxentry.cxx
accessibility/source/extended/accessibletablistbox.cxx
accessibility/source/extended/accessibletablistboxtable.cxx
accessibility/workben/org/openoffice/accessibility/awb/canvas/Canvas.java
accessibility/workben/org/openoffice/accessibility/misc/OfficeConnection.java
apple_remote/AppleRemote.m
autodoc/inc/ary/cpp/c_gate.hxx
autodoc/inc/ary/cpp/cp_ce.hxx
autodoc/inc/ary/cpp/cp_def.hxx
autodoc/inc/ary/cpp/cp_type.hxx
autodoc/inc/ary/doc/d_parametrized.hxx
autodoc/inc/ary/idl/i_type.hxx
autodoc/source/ary/inc/cross_refs.hxx
autodoc/source/ary/inc/sorted_idset.hxx
autodoc/source/display/html/outfile.hxx
autodoc/source/display/html/pagemake.cxx
autodoc/source/display/idl/hi_env.hxx
autodoc/source/parser/inc/tokens/tokproct.hxx
autodoc/source/parser_i/inc/s2_luidl/tokproct.hxx
autodoc/source/parser_i/inc/tokens/tkp2.hxx
automation/inc/automation/commtypes.hxx
automation/inc/automation/simplecm.hxx
automation/source/server/recorder.cxx
automation/source/server/recorder.hxx
automation/source/server/statemnt.cxx
automation/source/simplecm/packethandler.hxx
automation/source/simplecm/simplecm.cxx
avmedia/source/framework/soundhandler.cxx
basegfx/inc/basegfx/range/rangeexpander.hxx
basic/inc/basic/sbxdef.hxx
basic/source/classes/sbunoobj.cxx
basic/source/classes/sbxmod.cxx
basic/source/comp/dim.cxx
basic/source/comp/exprgen.cxx
basic/source/runtime/step1.cxx
basic/source/runtime/step2.cxx
basic/source/sbx/sbxint.cxx
basic/source/uno/namecont.cxx
basic/workben/mgrtest.cxx
bean/com/sun/star/beans/LocalOfficeConnection.java
bean/com/sun/star/beans/LocalOfficeWindow.java
bean/com/sun/star/comp/beans/LocalOfficeConnection.java
bean/com/sun/star/comp/beans/LocalOfficeWindow.java
bean/com/sun/star/comp/beans/OOoBean.java
bridges/inc/bridges/cpp_uno/bridge.hxx
bridges/source/cpp_uno/cc50_solaris_intel/cpp2uno.cxx
bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
bridges/source/cpp_uno/cc50_solaris_intel/uno2cpp.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/cpp2uno.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
bridges/source/cpp_uno/cc50_solaris_sparc/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_macosx_powerpc/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_macosx_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/except.cxx
bridges/source/cpp_uno/gcc3_netbsd_intel/uno2cpp.cxx
bridges/source/cpp_uno/gcc3_os2_intel/cpp2uno.cxx
bridges/source/cpp_uno/gcc3_os2_intel/except.cxx
bridges/source/cpp_uno/gcc3_os2_intel/uno2cpp.cxx
bridges/source/cpp_uno/mingw_x86-64/uno2cpp.cxx
bridges/source/cpp_uno/msvc_win32_intel/except.cxx
bridges/source/cpp_uno/s5abi_macosx_x86-64/except.cxx
bridges/source/cpp_uno/shared/component.cxx
bridges/source/jni_uno/jni_base.h
bridges/source/jni_uno/jni_bridge.cxx
bridges/source/jni_uno/jni_java2uno.cxx
bridges/source/jni_uno/jni_uno2java.cxx
canvas/inc/canvas/base/doublebitmapbase.hxx
canvas/inc/canvas/base/floatbitmapbase.hxx
canvas/inc/canvas/base/integerbitmapbase.hxx
canvas/source/cairo/cairo_canvasbitmap.cxx
canvas/source/cairo/cairo_textlayout.cxx
chart2/source/controller/dialogs/ObjectNameProvider.cxx
chart2/source/view/diagram/VDiagram.cxx
chart2/source/view/main/ChartView.cxx
cli_ure/source/native/makefile.mk
cli_ure/source/uno_bridge/cli_data.cxx
codemaker/source/javamaker/javatype.cxx
comphelper/inc/comphelper/componentcontext.hxx
comphelper/inc/comphelper/interaction.hxx
comphelper/inc/comphelper/locale.hxx
comphelper/inc/comphelper/string.hxx
comphelper/source/container/embeddedobjectcontainer.cxx
comphelper/source/misc/accessiblecontexthelper.cxx
comphelper/source/misc/asyncnotification.cxx
comphelper/source/misc/locale.cxx
comphelper/source/misc/mediadescriptor.cxx
comphelper/source/misc/numberedcollection.cxx
comphelper/source/misc/proxyaggregation.cxx
comphelper/source/misc/scopeguard.cxx
comphelper/source/misc/sequenceashashmap.cxx
configure.in
connectivity/source/commontools/parameters.cxx
connectivity/source/drivers/dbase/DTable.cxx
connectivity/source/drivers/evoab2/NStatement.cxx
connectivity/source/drivers/file/FPreparedStatement.cxx
connectivity/source/drivers/jdbc/DatabaseMetaData.cxx
connectivity/source/inc/flat/ETable.hxx
connectivity/source/parse/sqlnode.cxx
cosv/inc/cosv/persist.hxx
cosv/inc/cosv/ploc_dir.hxx
cosv/inc/cosv/tpl/dyn.hxx
cppu/source/LogBridge/LogBridge.cxx
cppu/source/uno/data.cxx
cppuhelper/source/bootstrap.cxx
cppuhelper/source/component_context.cxx
cppuhelper/source/propshlp.cxx
cppuhelper/source/servicefactory.cxx
cpputools/source/registercomponent/registercomponent.cxx
cui/source/customize/acccfg.cxx
cui/source/dialogs/about.cxx
cui/source/dialogs/commonlingui.hxx
cui/source/dialogs/showcols.cxx
cui/source/inc/cuihyperdlg.hxx
cui/source/inc/cuitabline.hxx
cui/source/options/optsave.src
cui/source/tabpages/tpline.cxx
cui/source/tabpages/transfrm.cxx
dbaccess/source/core/api/CacheSet.cxx
dbaccess/source/core/api/KeySet.cxx
dbaccess/source/core/api/RowSet.cxx
dbaccess/source/core/api/RowSet.hxx
dbaccess/source/core/api/RowSetBase.cxx
dbaccess/source/core/api/RowSetBase.hxx
dbaccess/source/core/api/RowSetCache.cxx
dbaccess/source/core/api/querycomposer.cxx
dbaccess/source/ext/adabas/Acomponentmodule.hxx
dbaccess/source/ui/app/AppControllerDnD.cxx
dbaccess/source/ui/app/AppDetailView.cxx
dbaccess/source/ui/browser/brwctrlr.cxx
dbaccess/source/ui/browser/sbagrid.cxx
dbaccess/source/ui/browser/unodatbr.cxx
dbaccess/source/ui/dlg/AdabasStat.hxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/dlg/directsql.cxx
dbaccess/source/ui/dlg/generalpage.hxx
dbaccess/source/ui/dlg/tablespage.cxx
dbaccess/source/ui/inc/JoinTableView.hxx
dbaccess/source/ui/inc/TableController.hxx
dbaccess/source/ui/inc/UITools.hxx
dbaccess/source/ui/inc/brwctrlr.hxx
dbaccess/source/ui/inc/datasourcemap.hxx
dbaccess/source/ui/querydesign/JoinTableView.cxx
dbaccess/source/ui/querydesign/QueryDesignView.cxx
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
dbaccess/source/ui/querydesign/TableWindow.cxx
dbaccess/source/ui/querydesign/querycontroller.cxx
dbaccess/source/ui/relationdesign/RelationTableView.cxx
dbaccess/source/ui/tabledesign/TableController.cxx
desktop/source/app/app.cxx
desktop/source/app/appinit.cxx
desktop/source/app/langselect.cxx
desktop/source/app/officeipcthread.cxx
desktop/source/deployment/manager/dp_extensionmanager.cxx
desktop/source/deployment/misc/dp_misc.cxx
desktop/source/deployment/misc/dp_resource.cxx
desktop/source/deployment/registry/dp_backend.cxx
desktop/source/deployment/registry/package/dp_package.cxx
desktop/source/migration/cfgfilter.cxx
desktop/source/migration/migration.cxx
desktop/source/splash/splash.cxx
desktop/win32/source/QuickStart/QuickStart.cpp
desktop/win32/source/setup/setup.cpp
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
dtrans/source/win32/clipb/MtaOleClipb.hxx
dtrans/source/win32/clipb/WinClipbImpl.cxx
editeng/source/editeng/editview.cxx
editeng/source/editeng/impedit2.cxx
editeng/source/editeng/impedit3.cxx
editeng/source/editeng/impedit4.cxx
editeng/source/editeng/textconv.hxx
editeng/source/misc/unolingu.cxx
embeddedobj/source/commonembedding/persistence.cxx
embeddedobj/source/general/dummyobject.cxx
embeddedobj/source/msole/olecomponent.cxx
embeddedobj/source/msole/olepersist.cxx
embeddedobj/test/Container1/NativeView.java
extensions/source/bibliography/framectr.cxx
extensions/source/macosx/spotlight/OOoContentDataParser.m
extensions/source/macosx/spotlight/unzip.h
extensions/source/macosx/spotlight/unzip.m
extensions/source/oooimprovement/myconfigurationhelper.hxx
extensions/source/propctrlr/eventhandler.cxx
extensions/source/propctrlr/formcomponenthandler.cxx
extensions/source/propctrlr/pcrcomponentcontext.hxx
extensions/source/scanner/twain.cxx
extensions/source/update/check/updatecheckconfig.hxx
external/mingwheaders/mingw_atl_headers.patch
extras/source/misc_config/wizard/web/layouts/source.xml.xsl
fileaccess/source/FileAccess.cxx
filter/inc/filter/msfilter/msocximex.hxx
filter/inc/filter/msfilter/svxmsbas.hxx
filter/qa/complex/filter/detection/typeDetection/Helper.java
filter/source/config/cache/basecontainer.cxx
filter/source/config/cache/cacheitem.hxx
filter/source/config/cache/contenthandlerfactory.cxx
filter/source/config/cache/filtercache.cxx
filter/source/config/cache/filtercache.hxx
filter/source/config/cache/filterfactory.cxx
filter/source/config/cache/frameloaderfactory.cxx
filter/source/config/cache/querytokenizer.hxx
filter/source/config/cache/typedetection.cxx
filter/source/config/cache/typedetection.hxx
filter/source/config/cache/versions.hxx
filter/source/config/fragments/makefile.mk
filter/source/config/tools/merge/pyAltFCFGMerge
filter/source/flash/swfwriter.cxx
filter/source/flash/swfwriter1.cxx
filter/source/msfilter/msdffimp.cxx
filter/source/msfilter/msocximex.cxx
filter/source/msfilter/msvbahelper.cxx
filter/source/msfilter/svxmsbas.cxx
filter/source/xmlfilterdetect/filterdetect.cxx
filter/source/xslt/import/uof2/uof2odf.xsl
filter/source/xslt/odf2xhtml/export/xhtml/body.xsl
filter/source/xsltfilter/com/sun/star/comp/xsltfilter/Base64.java
forms/source/xforms/convert.hxx
forms/source/xforms/model.cxx
fpicker/source/aqua/SalAquaFilePicker.mm
fpicker/source/office/fpinteraction.cxx
fpicker/source/unx/gnome/SalGtkFolderPicker.cxx
fpicker/source/unx/kde4/KDE4FilePicker.cxx
fpicker/source/win32/filepicker/PreviewCtrl.cxx
fpicker/source/win32/filepicker/PreviewCtrl.hxx
fpicker/source/win32/filepicker/VistaFilePicker.cxx
fpicker/source/win32/filepicker/VistaFilePickerImpl.hxx
fpicker/source/win32/filepicker/helppopupwindow.hxx
fpicker/source/win32/folderpicker/MtaFop.hxx
framework/inc/classes/droptargetlistener.hxx
framework/inc/classes/filtercache.hxx
framework/inc/classes/filtercachedata.hxx
framework/inc/classes/protocolhandlercache.hxx
framework/inc/classes/servicemanager.hxx
framework/inc/commands.h
framework/inc/dispatch/basedispatcher.hxx
framework/inc/dispatch/blankdispatcher.hxx
framework/inc/dispatch/closedispatcher.hxx
framework/inc/dispatch/createdispatcher.hxx
framework/inc/dispatch/dispatchprovider.hxx
framework/inc/dispatch/helpagentdispatcher.hxx
framework/inc/dispatch/mailtodispatcher.hxx
framework/inc/dispatch/menudispatcher.hxx
framework/inc/dispatch/oxt_handler.hxx
framework/inc/dispatch/popupmenudispatcher.hxx
framework/inc/dispatch/selfdispatcher.hxx
framework/inc/dispatch/servicehandler.hxx
framework/inc/dispatch/startmoduledispatcher.hxx
framework/inc/dispatch/systemexec.hxx
framework/inc/helper/fixeddocumentproperties.hxx
framework/inc/helper/ocomponentaccess.hxx
framework/inc/helper/oframes.hxx
framework/inc/helper/otasksenumeration.hxx
framework/inc/helper/persistentwindowstate.hxx
framework/inc/helper/statusindicator.hxx
framework/inc/helper/statusindicatorfactory.hxx
framework/inc/helper/tagwindowasmodified.hxx
framework/inc/helper/titlebarupdate.hxx
framework/inc/helper/vclstatusindicator.hxx
framework/inc/interaction/quietinteraction.hxx
framework/inc/jobs/helponstartup.hxx
framework/inc/jobs/job.hxx
framework/inc/jobs/jobdata.hxx
framework/inc/jobs/jobexecutor.hxx
framework/inc/loadstate.h
framework/inc/macros/debug/assertion.hxx
framework/inc/macros/debug/event.hxx
framework/inc/macros/debug/filterdbg.hxx
framework/inc/macros/debug/memorymeasure.hxx
framework/inc/macros/debug/timemeasure.hxx
framework/inc/macros/xserviceinfo.hxx
framework/inc/queries.h
framework/inc/recording/dispatchrecordersupplier.hxx
framework/inc/services/autorecovery.hxx
framework/inc/services/backingcomp.hxx
framework/inc/services/contenthandlerfactory.hxx
framework/inc/services/desktop.hxx
framework/inc/services/detectorfactory.hxx
framework/inc/services/frame.hxx
framework/inc/services/frameloaderfactory.hxx
framework/inc/services/layoutmanager.hxx
framework/inc/services/license.hxx
framework/inc/services/logindialog.hxx
framework/inc/services/modulemanager.hxx
framework/inc/services/pathsettings.hxx
framework/inc/services/pluginframe.hxx
framework/inc/services/substitutepathvars.hxx
framework/inc/services/task.hxx
framework/inc/services/taskcreatorsrv.hxx
framework/inc/stdtypes.h
framework/inc/threadhelp/fairrwlock.hxx
framework/inc/threadhelp/inoncopyable.h
framework/inc/threadhelp/itransactionmanager.h
framework/inc/threadhelp/lockhelper.hxx
framework/inc/threadhelp/readguard.hxx
framework/inc/threadhelp/resetableguard.hxx
framework/inc/threadhelp/transactionguard.hxx
framework/inc/threadhelp/writeguard.hxx
framework/inc/uifactory/uielementfactorymanager.hxx
framework/inc/xml/acceleratorconfigurationreader.hxx
framework/qa/complex/dispatches/checkdispatchapi.java
framework/qa/complex/framework/autosave/AutoSave.java
framework/qa/complex/framework/autosave/Protocol.java
framework/qa/complex/framework/recovery/RecoveryTest.java
framework/qa/complex/loadAllDocuments/StreamSimulator.java
framework/source/accelerators/acceleratorconfiguration.cxx
framework/source/accelerators/acceleratorexecute.cxx
framework/source/accelerators/acceleratorexecute.hxx
framework/source/accelerators/keymapping.cxx
framework/source/accelerators/presethandler.cxx
framework/source/application/framework.cxx
framework/source/application/login.cxx
framework/source/classes/framecontainer.cxx
framework/source/classes/menumanager.cxx
framework/source/classes/taskcreator.cxx
framework/source/dispatch/closedispatcher.cxx
framework/source/dispatch/dispatchprovider.cxx
framework/source/dispatch/helpagentdispatcher.cxx
framework/source/dispatch/interceptionhelper.cxx
framework/source/dispatch/mailtodispatcher.cxx
framework/source/dispatch/menudispatcher.cxx
framework/source/dispatch/oxt_handler.cxx
framework/source/dispatch/servicehandler.cxx
framework/source/fwe/classes/framelistanalyzer.cxx
framework/source/fwe/dispatch/interaction.cxx
framework/source/fwe/helper/titlehelper.cxx
framework/source/fwe/helper/undomanagerhelper.cxx
framework/source/fwe/xml/eventsdocumenthandler.cxx
framework/source/fwe/xml/statusbardocumenthandler.cxx
framework/source/fwe/xml/toolboxdocumenthandler.cxx
framework/source/fwi/classes/protocolhandlercache.cxx
framework/source/fwi/threadhelp/lockhelper.cxx
framework/source/fwi/threadhelp/transactionmanager.cxx
framework/source/helper/persistentwindowstate.cxx
framework/source/helper/statusindicatorfactory.cxx
framework/source/helper/vclstatusindicator.cxx
framework/source/inc/accelerators/acceleratorcache.hxx
framework/source/inc/accelerators/acceleratorconfiguration.hxx
framework/source/inc/accelerators/presethandler.hxx
framework/source/inc/accelerators/storageholder.hxx
framework/source/inc/loadenv/actionlockguard.hxx
framework/source/inc/loadenv/loadenv.hxx
framework/source/inc/loadenv/loadenvexception.hxx
framework/source/inc/pattern/frame.hxx
framework/source/inc/pattern/storages.hxx
framework/source/inc/pattern/window.hxx
framework/source/jobs/helponstartup.cxx
framework/source/jobs/job.cxx
framework/source/jobs/jobdata.cxx
framework/source/jobs/jobdispatch.cxx
framework/source/jobs/jobresult.cxx
framework/source/jobs/joburl.cxx
framework/source/jobs/shelljob.cxx
framework/source/loadenv/loadenv.cxx
framework/source/services/autorecovery.cxx
framework/source/services/backingwindow.cxx
framework/source/services/desktop.cxx
framework/source/services/frame.cxx
framework/source/services/modulemanager.cxx
framework/source/services/pathsettings.cxx
framework/source/services/substitutepathvars.cxx
framework/source/uiconfiguration/moduleuicfgsupplier.cxx
framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx
framework/source/uiconfiguration/uicategorydescription.cxx
framework/source/uiconfiguration/uiconfigurationmanagerimpl.cxx
framework/source/uiconfiguration/windowstateconfiguration.cxx
framework/source/uielement/uicommanddescription.cxx
framework/source/unotypes/fwk.xml
framework/source/xml/imagesdocumenthandler.cxx
framework/test/test.cxx
framework/test/test_componentenumeration.bas
framework/test/test_statusindicatorfactory.bas
framework/test/threadtest.cxx
framework/test/threadtest/threadtest.cxx
framework/test/typecfg/cfgview.cxx
framework/test/typecfg/xml2xcd.cxx
include/basegfx/polygon/b2dpolygon.hxx
include/canvas/base/graphicdevicebase.hxx
include/canvas/canvastools.hxx
include/comphelper/configurationhelper.hxx
include/comphelper/embeddedobjectcontainer.hxx
include/comphelper/propagg.hxx
include/comphelper/sequenceashashmap.hxx
include/connectivity/sqlerror.hxx
include/connectivity/sqlnode.hxx
include/cppuhelper/propshlp.hxx
include/editeng/AccessibleContextBase.hxx
include/framework/framelistanalyzer.hxx
sfx2/source/dialog/backingcomp.cxx
vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
Change-Id: I2618bf83c0e30f68f23ff25f6eb466df04d34c6d
2014-04-30 12:13:36 +01:00
dc6175ff1f
Remove LockHelper::getGlobalMutex().
...
Do what the TODO suggests - change it to SolarMutex in most cases.
In some cases it is only there to guard a local static, introduce a local
mutex for those.
Change-Id: Idc3155818f737b958b36ee9125e2e9e8cb1b91a1
2014-04-15 13:10:56 +02:00
4198039441
Remove unused functions
...
Change-Id: I0f305ef5b9f13e3516b3bbf45d405fad5115521a
2014-04-09 14:21:42 +02:00
a6287e21f1
framework: sal_Bool->bool
...
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
2014-04-07 13:53:49 +02:00
d816acd0e2
coverity#706548 Uncaught exception
...
Change-Id: Ie3be6d503b50cfa86be8fff162d01a72c6b47bf7
2014-04-07 10:14:50 +01:00
d9701f0ebc
Typo: s/ouer/our
...
Change-Id: I0179678c6c5dd6a05b1d7d5038a901e7bf2af3de
2014-04-06 20:27:21 +03:00
e32e7946aa
Bin empty @seealso, @param, @return etc metacomments
...
Change-Id: I9582afceb5daf5993bfca1445370d8a60030c3c5
2014-04-06 20:02:08 +03:00
f4e8d2ad0e
Bin empty @seealso, @param, @return and @onerror metacomments
...
Change-Id: I30a761a21a98419816c4b67258664becd79e2db1
2014-04-06 19:37:48 +03:00
ee3945bd98
Kill superfluous spacing before semicolons
...
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
2014-04-06 19:37:48 +03:00
951ed199f1
Kill superfluous vertical whitespace
...
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
2014-04-06 19:37:48 +03:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
e6ff457de6
callcatcher: update unused code
...
Change-Id: I9d8601eb66a460702530e013bf573c6482c49c0b
2014-03-31 09:22:44 +01:00
1978655c32
coverity#1194897 Logically dead code
...
Change-Id: I4cf8d63822c4a68b7cdc126a8d76c1ce7b064655
2014-03-30 21:21:28 +01:00
65c3e11ea9
framework: sal_Bool->bool
...
Change-Id: If3276f184c63e85762fe54ce19655c30e00aeb15
2014-03-27 13:45:07 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
c8239a1dd4
Remove newly unused framework::LockHelper class
...
...and make LockHelper::getGlobalLock() FWI_DLLPUBLIC again (so there's a single
such lock, not one per library).
Change-Id: I0aed77333dc93cdf1c7dd7b96620fb7a8eb3dd64
2014-03-20 17:30:03 +01:00
250a4e8875
Remove newly unused framework::Guard
...
Change-Id: I49650bfd036c5df22f81c3e8cf30bc0795154a30
2014-03-20 17:30:02 +01:00
4ddb43bcf1
Turn odd framework::LockHelper::getGlobalLock() into an osl::Mutex
...
...and extract it to framework::GlobalLock::get().
The old lock was actually effectively two different locks,
LockHelper::getGloblaLock() and
LockHelper::getGlobalLock().getShareableOslMutex(), and both were used in
different places. These places all use the same single osl::Mutex instance now,
but hopefully that does not lead to problems (which it shouldn't, given the
documentation of LockHelper::getShareableOslMutex: "Sometimes we need a osl-
mutex for sharing with our uno helper ... What can we do? We must use a
different mutex member :-( I HOPE IT WORKS!").
Of course, the "TODO: This presumable should return the SolarMutex" still
applies.
Change-Id: I7caea3241d1b70a00272fe1f2214c071ef22cf2c
2014-03-20 17:30:02 +01:00
e28207718c
Use SolarMutexGuard directly
...
Change-Id: I0438d85b0c51010eff9e8d53ed8acada98563a20
2014-03-18 15:27:06 +01:00
3b45c88a40
Use SolarMutexGuard directly
...
Change-Id: I5408403318691f9b83c5b69658a37916fa23ea69
2014-03-18 15:27:06 +01:00
5e5c6656c9
Remove unused ThreadHelpBase base
...
Change-Id: I367ffa9343a0227eab9726c636d7e8e622219bf4
2014-03-18 15:27:06 +01:00
36a5ea2a9c
Use SolarMutexGuard directly
...
Change-Id: Ia80e709bea172722aa07ee75ebeeef4ac8f5281a
2014-03-18 15:27:06 +01:00
8b28069c8f
Remove unused ThreadHelpBase base
...
Change-Id: Ib530dec8e812d8ecccba47c70e3d1e9640083378
2014-03-18 15:27:05 +01:00
0bed494bfc
Use cppu::BaseMutex instead of framework::ThreadHelpBase
...
Change-Id: I77b88bf1bed18c6a863f9e6d753035c90ef64c07
2014-03-18 15:27:05 +01:00
bff533248d
Use cppu::BaseMutex instead of framework::ThreadHelpBase
...
Change-Id: I3e210cee3b6e0956175083ff0b55ff52c060d9c2
2014-03-18 13:29:13 +01:00
60d14352f7
Remove dead file
...
Change-Id: I53dfb7f9d49a4b383dc8a32e4cd3b30a4db47819
2014-03-17 18:04:42 +01:00
07b32bc2bf
Consolidate framework::{Resetable,}Guard
...
Change-Id: I97290c2504992f4a92e6aeb71e02a2542dd35faa
2014-03-17 18:00:10 +01:00
ab3acb7ef7
Consolidate framework::{Read,Write}Guard
...
...now that it is obvious that they both do the same
Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115
2014-03-17 16:52:34 +01:00
1d6fd96df7
framework: prefer passing OUString by reference
...
Change-Id: I23c2ac9ef6bfc3eedb8ad6cb199c12d42ed642c8
2014-03-17 13:30:53 +02:00
927933404d
framework: simplify deprecated XTypeProvider.getImplementationId
...
Change-Id: Id137a35c385a5198243eefb9a42f4deace24e195
2014-03-10 17:39:55 +01:00
