Commit Graph

4218 Commits

Author SHA1 Message Date
143bbb20a3 inline TokenMap::getUtf8TokenName
Change-Id: Icd9c6ebc9feb3e7aba28b01729b582a8f49c832a
2014-10-23 14:30:29 +02:00
f39d69f6b5 Remove few pointless OUString::number() and one method
Change-Id: I3e9a302a7513eebfeff07402f71fc3dde22e4cc2
2014-10-23 13:24:28 +02:00
d8af144254 FastSerializer: Use faster TokenValue struct when possible
Saves another ~100m pcycles for 650k calls in startElementInternal()

Change-Id: I190326edc7feffb900e91fa7e5c3530b5b267f59
2014-10-23 13:24:25 +02:00
035fe8a6aa fdo#84938: replace MENUITEM constants with enum
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23 12:55:35 +02:00
3f89f88651 callcatcher: lots more unused post ww1 filter removal
Change-Id: I7bf6dc1d366093e797a19a8e555103c15b311ac8
2014-10-23 11:13:25 +01:00
d45607c4be Revert recent changes to comphelper::OSequenceOutputStream
Some of the changes could be wrong and we don't need them.

This reverts commit 784d4bea86d8cbb3a855e557c465ce50a049cefc.
This reverts commit 8524d5aba59148eef94859289f00ab6477e0e821.
This reverts commit 018f1deae884febbbe639c7ee46b45ce4807e9d3.
This reverts commit 8124fddc5803b4e104d4fc2456cb92cb030d9436.

We use our own helper cache class in FastSaxSerializer
since f736eba5a9df8645849a37b08d2764a5f495ab45.

Change-Id: Iaca6b5b11cb32595db4420a02fa72b0007cf6286
2014-10-23 11:53:19 +02:00
406062334a FastSerializer: avoid some more OStrings
Change-Id: I2d5dbe9adccdd231cc16a1f83a90a4adeb965c64
2014-10-23 11:53:18 +02:00
50d2ffd2a1 FastSerializer: Use FastAttributeList directly to write faster.
Change-Id: I28085d4e060bcf052e6aa97a0822a4d653d7c066
2014-10-23 11:53:18 +02:00
e1c503a2e3 fastparser: avoid allocating un-used FastTokenLookup class.
This contained an rtl_Sequence complete with horror internal
allocator, caught red-handed serializing threaded loading to no
good purpose.

Change-Id: I837b2c17e4f70fd6a49bed33ad74a7d79f98f35c
2014-10-23 11:53:17 +02:00
20538c2512 FastSerializer: Avoid sequences where possible
Change-Id: I359ca9d3b766b71904e4199ebfbdbd5b203775cc
2014-10-23 11:53:17 +02:00
6be21256bd FastSerializer: Have OString version of write() too.
And remove characters() member function.

Change-Id: Ifcedbb6d969b7b057ff378d2fbce09c2dde5ac18
2014-10-23 11:53:16 +02:00
cc3ac382a2 FastSerializer: Do not keep whole sequence in memory; write in chunks
Change-Id: Ibca65a2b8397358ac4013c8e5b53389ac6949e4d
2014-10-23 11:53:15 +02:00
8cc5b621aa Remove mutex from OSequenceOutputStream; it's intended to be fast
Make the caller responsible for using it wisely.
AFAICS it's used only in FastSaxSerializer, so far.

Change-Id: I50d48fd7f3e6cdeb9e4637868da213b8171e542b
2014-10-23 11:53:15 +02:00
b7266ddb2f FastSerializer: Buffer output and write it only at the end
Use OSequenceOutputStream class to concatenate strings in a
Sequence<sal_Int8> buffer. And write data to file only at the end.

The design is a bit fragile, since all FSHelpers need to be destroyed
before calling FilterBase::commitStorage(). Otherwise data is not written.

Change-Id: I26b02335ef36011bfcda17484b560811d18c7657
2014-10-23 11:53:14 +02:00
f89e5ebcf1 vcl: fixup outdev.hxx tab spacing
Change-Id: I3ca1784b931dfc4f3dc42abe8f0af588fd6b8bd0
2014-10-23 20:29:40 +11:00
d701a1a6df Move virtual ScToken members up to FormulaToken
Change-Id: I20eb3b44d540f459cd1902a7a3b6a5c867e5bc07
2014-10-23 09:30:09 +02:00
a6b01d01f7 gcc4.7.3 complains about the asserts
'error: comparison is always true due to limited range of data type'

So just make the underlying type be 'signed int'

Change-Id: Ibf4ff72d85d33e88b7506289c622d34773ca259a
2014-10-23 09:21:48 +02:00
ec1b82e682 Describe text animation types.
Change-Id: I4f878eff707e318fa80b7d3c19833bf724e4bcef
2014-10-22 18:07:30 -04:00
f3f1d8eadd Method descriptions.
Change-Id: Iece61424e09fc36768889fde2c848ed2b0722701
2014-10-22 18:07:29 -04:00
9f06a0988d fdo#84844 Sidebar: Use SvxColorToolBoxControl for paragraph color
Change-Id: I0231a52288ca9a8a2a5e5cdb13fdff772b989640
2014-10-22 23:25:52 +03:00
e2b84636b3 Related: fdo#84844 Support of Sidebar wide buttons in SvxColorToolBoxControl
The end goal is to convert the Sidebar to use
SvxColorToolBoxControl, and get rid of the Sidebar
specific color popup, so we don't need to maintain
two popups.

Change-Id: I42e5bcb611acae25f16dfe9623d19727fc39ea07
2014-10-22 23:25:52 +03:00
87cb3a7c96 unusedcode: Remove Deflater::setLevel
Which makes bSetParams always false; remove that too, together with nLevel.

Change-Id: I94a4ec14b2b2c498d749ef72c1b6b118bba37076
2014-10-22 16:03:20 +02:00
1a2c28cf0d callcatcher: update unused code
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-22 13:11:34 +01:00
f5fc81616c Avoid unnecessary #include
Change-Id: I6ec5de40ce2f4cbcce751dcae16dae60abbc1a37
2014-10-22 13:14:43 +02:00
4b89bd55b0 Speed up xmlreader::Span::equals
Change-Id: Id1613a100e96667717cc32f44f84c0916055ea01
2014-10-22 11:46:23 +02:00
d9f303a030 Remove unused FormulaToken::Is3DRef
Change-Id: Ib720bc4b3bfff8e428d14d65ff73144db82c60e0
2014-10-22 10:58:21 +02:00
4492b1cf0c Remove dead CustomerNumber functionality
Change-Id: I221d3b9f0bf0f90a117fcf0caead52f2c31f7926
2014-10-21 17:22:55 +02:00
c35fec830a The only SID supported by PropExec/State_Impl is SID_ATTR_UNDO_COUNT
...apparently, given that the SID_ATTR_UNDO_COUNT entry in sfx2/sdi/appslots.sdi
is the only place that mentions those functions.  That reveals that all the
other SIDs mentioned there are completely unused.  (Also, there seems to be no
need to wrap the remaining PropExec/State_Impl functionality in #ifndef
DISABLE_SCRIPTING.)

Change-Id: Iea7a41aa323b7876d316794cebe962e6e086236d
2014-10-21 17:22:55 +02:00
e73ee8db85 Remove unused SfxInterface::GetResManager_Impl
Change-Id: Ia9ad8072b07f0121af18377445c90480ff7c2600
2014-10-21 12:36:08 +02:00
5309cab855 Remove unused pSfxFormalArgs_Impl
Change-Id: I0c1e8c42fd03bd861323cbff172031f5405c1597
2014-10-21 12:36:08 +02:00
182fc4f184 fdo#84938: replace WINDOW_BORDER constants with enum
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-21 09:06:40 +02:00
4332787892 nShearWink -> nShearAngle
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-21 08:56:29 +02:00
3bb30a68e0 loplugin: cstylecast
Change-Id: If50022b55a558c4124d71acbbe0ef5eb48801d0b
2014-10-20 13:33:58 +02:00
8c8d6f0849 loplugin: cstylecast
Change-Id: Ia3055b00c20a885dfa0584f864f0e91ccad1e9c9
2014-10-20 13:33:11 +02:00
e12ba2eddc Resolves: fdo#85006 limit script stripping to known suffixes
Change-Id: I276535b007bbb55555148d5937076b86da5de825
2014-10-20 11:53:18 +01:00
eb7aa9f1fa fix problem with gcc compiler complaining on variable type
Change-Id: I9a16e24e79d22b0af1710d6ac25eaa5fb19c71ff
Reviewed-on: https://gerrit.libreoffice.org/12047
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20 10:43:11 +00:00
1361dfc0aa coverity#1242606 Untrusted loop bound
Change-Id: Iafa03d4dd65eb343a80996880bc1ed846d1b7491
2014-10-20 10:57:14 +01:00
67c9d05451 fdo#84938: replace TIB_ constants with enum
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-20 07:16:46 +00:00
8091cf383a Increase assert coverage of OStringBuffer arguments
Change-Id: Ifd3c9919ef104909efa8964e7a0cb5e723e3331d
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-20 09:01:03 +02:00
ddac852282 -Werror=shadow
Change-Id: I940661c947307dc5dea371e5e6f9a9aedbfc904d
2014-10-19 12:02:47 +02:00
06562c6784 convert SV_BMP_ constants to enum
Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05
Reviewed-on: https://gerrit.libreoffice.org/12018
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18 18:18:48 +00:00
01552f1e77 SID_TOGGLE_MENUBAR (aka slot:6661, .uno:MenuBarVisible) is dead
...since introduction of XLayoutManager's private:resource/menubar/menubar in
3fb2acf5b77bff59909f616c44c7de17048b64d7 "INTEGRATION: CWS layoutmanager
(1.52.10); FILE MERGED" etc. and final removal of SID_TOGGLE_MENUBAR bits in
f605b16e395e8ccc3d1aba7907b0792039016f69 "INTEGRATION: CWS sfxcleanup (1.119.8);
FILE MERGED" etc.

What still needs fixing are

  extensions/source/activex/SOActiveX.cxx
  odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java
  odk/examples/OLE/activex/SOActiveX.cpp

in a similar way as e.g. 0273d3d81d29d5c1f6c387cca633cd99722c100e "INTEGRATION:
CWS jl18 (1.6.8); FILE MERGED."

Change-Id: I52a43fc7186a4f60929ab6246a2da2e715be7510
2014-10-17 16:58:26 +02:00
5bdfa8c124 Resolves: fdo#62682 crash on second export of svg
because the first export has left "dangling" CalcFieldValueHdl Links in
Outliners that got created based on the Drawing Outliner while it had a
temporary CalcFieldValueHdl installed, and didn't get the old CalcFieldValueHdl
installed when the old Drawing Outliner one was re-installed.

Change-Id: I064a154ece488c9a4c3467b753451df7e73ae883
2014-10-17 15:20:00 +01:00
f5b1b266bc coverity#1247646 Uncaught exception
Change-Id: I332fb602466613e9e79ba4510879411e0bee9da6
2014-10-17 15:19:54 +01:00
d63f917d31 coverity#1247643 Uncaught exception
Change-Id: I0da9140bf1f76a92c95c042c5039f7cfdbde6c34
2014-10-17 15:19:52 +01:00
6bb741b7f4 coverity#1247638 Uncaught exception
Change-Id: Ibdda31c2a8d8c3314173f381b60800ccfbcc25f7
2014-10-17 15:19:49 +01:00
0c0c77af06 coverity#1247635 Uncaught exception
Change-Id: Ic346a5820102a922f54c971e01587601991bd484
2014-10-17 15:19:47 +01:00
fabbdc70ad coverity#1247632 Uncaught exception
Change-Id: I8d6df8c6853f0bd2f0b099d14bf0ac246170e7f1
2014-10-17 15:19:44 +01:00
ef057fc58e coverity#1247629 Uncaught exception
Change-Id: Ib0f0555ba5630b225a4a5fbc64394becdeb9f7dd
2014-10-17 15:19:42 +01:00
51d86c9e62 Consistency around SdrAngleItem in svx/sxciaitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-17 15:36:13 +02:00