Commit Graph

289 Commits

Author SHA1 Message Date
c353caee1c loplugin: cstylecast
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
2014-09-29 12:50:35 +02:00
e660e1ed73 pyuno: remove obsolete NOOPT comment about GCC 3.2
Change-Id: Ie280325ddc45a79f3b73ae10f6e9cf952657091b
2014-09-12 18:42:11 +02:00
6492c8576e Make the "Mac-like" or "canonical" app bundle structure always used on OS X
In other words, only executable files go in the MacOS folder. Dynamic
libraries and bundled frameworks (i.e., LibreOfficePython), and
nothing else, go in the Frameworks folder, and all other files go in
the Resources folder.

Especially, note that Java class files and rc (.ini) files also go in
Resources.

Such an app bundle structure is what Apple strongly suggests one
should use, and it has been hinted that future versions of code
signing and/or Gatekeeper will require such a structure.

There is still some ugliness thanks to traces of the historical
separation of URE from "the office". Like there are two separate
"unorc" files, one for URE, one for the LibreOffice application. IMHO,
this should be cleaned up, but is probably controversial.

(Eek! I now see there are actually *three* unorc files in the app
bundle. Not intentional. Need to fix that later.)

Change-Id: Idcf235038deb5b8e1d061734993e9f31869b7606
2014-09-09 13:55:23 +03:00
0364d3b7e6 fdo#46678: pyuno: fix deadlock in Runtime::any2PyObject()
When calling XUnoTunnel::getSomething(), the function must drop the
CPython GIL to avoid deadlock since there are implementations of
XUnoTunnel that acquire SolarMutex.

Change-Id: I51ffce9bdee9a51c932902e77856f865eae81d2a
2014-08-28 16:16:01 +02:00
7a9abd681b coverity#982756 Dereference null return value
Change-Id: I0f2ef4cb61a5774c3d2251897ee914f959ae44a8
2014-08-07 18:00:45 +01:00
de61e7302d coverity#706600 Uncaught exception
Change-Id: I93868e6acc8e245f15ece38e00390dfc3bd9ee8c
2014-07-21 13:59:34 +01:00
0df43cc217 coverity#982756 Dereference null return value
Change-Id: I5bfb5c86093aca4b88b2abf39836a1c6d7cb0bea
2014-07-10 13:39:17 +01:00
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
9828206408 Demystify magic ponies
Change-Id: I7e619daf8743d3471ece72d81f6cf1bb61741646
2014-06-04 08:55:11 +02:00
86598a4e18 coverity#982753 Dereference null return value
Change-Id: I011a600a27c801dca32734e680ea5a13dfebdfe3
2014-06-03 20:10:18 +01:00
2ca70c3b5c coverity#982755 Dereference null return value
Change-Id: I652b308d087c1ee9fff95f81297b079e3f816e07
2014-06-03 20:10:18 +01:00
b75b626ee5 coverity#982756 Dereference null return value
Change-Id: Ia29c6167df0ce061fae88d81bef9a98ca37fcce3
2014-06-03 20:10:17 +01:00
f556b1b614 coverity#982752 Dereference null return value
Change-Id: I394a13939d67b6959903e277dd78ea05cdcadfa8
2014-05-26 15:51:58 +01:00
6342a9c49e coverity#982754 Dereference null return value
Change-Id: I0d0dc196f223a988fd029cc61a8b160b2150534c
2014-05-26 15:51:58 +01:00
dfddb56699 coverity#982757 Dereference null return value
Change-Id: Ie2c88a778bb25e6909138e633fe115686e2cc026
2014-05-26 15:51:58 +01:00
88d9c87058 coverity#982758 Dereference null return value
Change-Id: Ia797bbd9c5587d2b55dd183a377e5b3dded96e7b
2014-05-26 15:51:57 +01:00
b15532a03c coverity#982761 Dereference null return value
Change-Id: I35e93ccf5992236d163d708089cd798e324157fb
2014-05-26 15:51:57 +01:00
e17245c0c2 coverity#982759 Dereference null return value
Change-Id: I72209c52d6a8d036f0903f39b91fc62a2880448b
2014-05-26 15:51:57 +01:00
5bdc28028c coverity#982760 Dereference null return value
Change-Id: I779fa5fa418370dd6c53308943374e981f65ae29
2014-05-26 15:51:56 +01:00
b074466007 coverity#982169 Unchecked return value
Change-Id: I4aa333a907ff050fff4a4c7c41120ce00961673c
2014-05-26 15:51:54 +01:00
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
a81a079305 pyuno: fix warnings with system python 3.4.0
warning: missing initializer for member '_typeobject::tp_finalize' [-Wmissing-field-initializers]

Change-Id: I7ab82025fd8c2f0d8fa4943690a217c4a4dc369d
2014-05-19 20:04:22 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
e5d0a9ad78 pyuno: sal_Bool->bool
Change-Id: I071c8984cd86b523d8ebae04b5fb2bdc1ac1a5b1
2014-05-08 11:48:14 +02:00
d69b30a84d coverity#1019376 Resource leak
Change-Id: Ifa9c5a7b3aa0d219e09fa3081e66d870a508a84d
2014-04-02 15:51:15 +01:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
86a32589e9 Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
d89928441d pyuno: simplify deprecated XTypeProvider.getImplementationId
Change-Id: Ia99dca3619fb893d1b9f3a46f1f1285e3fe1bc8e
2014-03-10 17:39:56 +01:00
25cedf1dc7 Introduce com.sun.star.beans.theIntrospection singleton
...deprecating com.sun.star.beans.Introspection (single-instance) service.

Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
2014-03-07 10:33:07 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
3a35e28628 Remove visual noise from pyuno
Change-Id: I27f5edf45d5968879436e2466f953576651ed8ae
Reviewed-on: https://gerrit.libreoffice.org/8290
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 09:21:35 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
9e77c2fb7c Remove UNOIDL "array" and "union" vaporware remnants
...and deprecate what cannot be removed for compatibility.

Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-31 10:15:47 +01:00
b1de7935b8 coverity#983054, reorder code to avoid memory leak
Change-Id: If14160802f77673e3ebe69850e00d0506125969c
2014-01-30 12:01:47 +01:00
612dac063a bool improvements
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
2014-01-29 11:08:32 +01:00
8e15df3dce bool improvements
Change-Id: I42f6d8b3e62834b0612d84586f791f25e967c9c7
2014-01-28 20:26:24 +01:00
51f252dbf2 coverity#440338 Dereference null return value
Change-Id: I5da7c1d8fe7f4632b386a02dd54f4b203a00fc25
2014-01-28 11:29:17 +00:00
cedba3ffd8 Use bool
Change-Id: I4c05c602ecdd77d07e8106387270bf01718e975b
2014-01-10 17:11:44 +01:00
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
983e033273 Fix different typos for "unknown"
Change-Id: Ib2ee00d4e9f4c6c05d090adfcd5fb791fcbca72c
2013-11-25 22:05:13 +01:00
ab5d1fbfb4 SAL_WARN_UNUSED com::sun::uno::Any
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
2236cd0023 -Werror,-Wunused-member-function
Change-Id: Ic4dba1d313c3a27ac02f9d382d2b55218e1bad10
2013-11-14 10:14:58 +01:00
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
1acaa577b6 sal: add special handling of argc==0 to osl_setCommandArgs()
... to set up a fake command line.  This is used from pyuno, when
invoked from the "python" executable as "import uno".

On WNT there is an API to get the actual command line, so just use that
even in the "fake" case; on UNX just fake something up.

Just for the record the whole osl_setCommandArgs() is called exactly once
assumption should work out _unless_ there is a program that uses SAL_MAIN
_and_ does a python-level "import uno" _before_ it wants to create a
python-based UNO service (via pyuno_loader::CreateInstance), since
pyuno already takes care to call Runtime::initialize() at most once.

Change-Id: Ifd23de733ea3e6b694d46ab039b6aa4fd3e7fc1b
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-10 14:38:38 +02:00
2386a92c1e pyuno: set up fake command line in getComponentContext()
Easy to trigger the assert in osl_getCommandArgCount(), just
run instdir/*/program/python and "import unohelper".

Avoid that by setting up a fake command line, hopefully
nobody expects to be able to give relevant args to python...

Change-Id: I0df6c23d6ecbb3c2bce81a9d5bcecdcb1729ddbb
2013-10-09 19:46:00 +02:00
df1076965f fdo#70196: Python 2 compatibility for UNO import error handling
Add backwards compatibility support for Python 2 to the earlier
change in fdo#66025 to improve import error handling under Python 3.

Change-Id: I47bf8ef255c4c2a3e4a2754414977aaa8ed32483
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-07 15:10:54 +02:00
edba11021b WaE: unused variable
Change-Id: Iea8461444c29de9968a5bfa85a2dabb186db47ca
2013-10-02 19:32:31 +03:00