644678e2ac
Avoid left shift of negative values (ubsan)
...
Change-Id: If465c155c70ec068b6bd7adc05f188bbecc2824e
2014-10-23 15:34:41 +02:00
413210a503
Avoid left shift of negative values (ubsan)
...
Change-Id: Ie4f6a4e3e54770c00741cc268ed9e27ecafac500
2014-10-23 15:27:37 +02:00
1e5d17f821
ATTR_VALUE_FORMAT is an SfxUInt32Item
...
Change-Id: I38f7cece6157cd0a48e3c6a09b25eccc47f8525e
2014-10-23 14:34:00 +02:00
5ed4c11534
Use sc::CompileFormulaContext for faster export
...
It's a cache for maTabNames (sheet names mangled for the current grammar
for output) which ScCompiler needs and is expensive to get.
Change-Id: I7e2954104427a3c220f0f097be6cd45a66485b56
2014-10-23 13:24:26 +02:00
eb195bbe34
Use OUStringBuffers for performance reasons.
...
Saves 120m pcycles in just 250k calls to ScAddress::Format.
Change-Id: Ibf20cf0843a47cf0fa37a38c4fecf1ae1560412c
2014-10-23 13:24:25 +02:00
feba02c3a4
loplugin: cstylecast
...
Change-Id: I71cdd9154a8a5955e2915858cec33ec4e9ef4987
2014-10-23 12:36:16 +02:00
6a097a7d96
loplugin: cstylecast
...
Change-Id: I8c7cd4c2cdc134556c2c664a22e2048b51a3b98e
2014-10-23 12:36:16 +02:00
229eed079c
loplugin: cstylecast
...
Change-Id: If991c0efe1ded6ef6d32b3a722ee87bbe36bf0bf
2014-10-23 12:36:16 +02:00
1f581d5041
coverity#1242587 Untrusted value as argument
...
Change-Id: I9720402f6482419cee84b468dd82a8c76ca1ddf4
2014-10-23 11:13:23 +01:00
ea8892cb44
coverity#1242599 Untrusted loop bound
...
Change-Id: I51bc114e215327f539612f94c40019c554698813
2014-10-23 11:13:22 +01:00
b7266ddb2f
FastSerializer: Buffer output and write it only at the end
...
Use OSequenceOutputStream class to concatenate strings in a
Sequence<sal_Int8> buffer. And write data to file only at the end.
The design is a bit fragile, since all FSHelpers need to be destroyed
before calling FilterBase::commitStorage(). Otherwise data is not written.
Change-Id: I26b02335ef36011bfcda17484b560811d18c7657
2014-10-23 11:53:14 +02:00
2e363d1135
Remove ScToken from the formula::FormulaToken hierarchy
...
...to keep UBSan from complaining about illegal downcasts from FormulaToken to
ScToken (which were practically harmless, given that ScToken did not add any
data members).
Change-Id: I8fdc026eec363442cc4b720b71d65c972b4a4446
2014-10-23 09:30:10 +02:00
d9a782be7b
Turn ScToken::checkTextEqual into a free function
...
Change-Id: I03daf7bb68ed33d9610b7ef19d3bd6c18dc8170f
2014-10-23 09:30:09 +02:00
d701a1a6df
Move virtual ScToken members up to FormulaToken
...
Change-Id: I20eb3b44d540f459cd1902a7a3b6a5c867e5bc07
2014-10-23 09:30:09 +02:00
19d2f42119
Make ScToken::GetSingleRef etc. return * instead of &
...
...so that default implementations can return nullptr without further ado
Change-Id: Idc8778fe868efa00b1de597a54aa07a2e6fa3bc0
2014-10-23 09:30:09 +02:00
7281580ef0
Turn virtual ScToken::Dump into a single free function DumpToken
...
Change-Id: I2c81f24a27ede9922ed8ff16cf0ea4af824e9e59
2014-10-23 09:30:08 +02:00
512ed170fe
Turn static ScToken::ExtendRangeReference into free function
...
...and rename to extendRangeReference to avoid confusion with
formula::FormulaCompiler::ExtendRangeReference.
Change-Id: Ifcad309c14e04a0e37c80ca44462da587387241d
2014-10-23 09:30:08 +02:00
1ba2028ab9
Move FormulaToken::TextEqual overrides down into specific subclasses
...
Change-Id: I5f27054ef2f9fdc4d0be0afe91ad31d053976bcf
2014-10-23 09:30:08 +02:00
75c4091b14
Inlining make no sense for virtual functions.
...
Change-Id: I6392eaceb0544b7faa9a0c726acf6619d971dbb7
2014-10-22 18:07:28 -04:00
165eef4927
GetSymName() not used.
...
Change-Id: Ia369bf99a5e381a6f1f9c3d8a2499aa1780f04b8
2014-10-22 18:07:28 -04:00
ae7901abd6
GetNameAsString() identical to GetName(). Remove this and use GetName().
...
Change-Id: I26dce2dd11792ee118e78d23d652a5feb0789830
2014-10-22 18:07:28 -04:00
0ae2d01cb8
( void ) -> ()
...
Change-Id: I0d3d1d9ab5f7bc270c89a2a98d45ebea3cc37e02
2014-10-22 18:07:28 -04:00
e5084fbf72
Be sure to copy the cell text attributes values to and from clip.
...
Otherwise we'd have to unnecessarily re-calculate the script types again
which is not cheap...
Change-Id: Ie589fb4a7e5ec9b5ef646dabea4e6bd0c0aca560
2014-10-22 18:07:27 -04:00
5156c5937b
Set script type to latin for formula cells with numeric results.
...
But only when the column contains only standard number format types.
Change-Id: I83982d2e87f9776cf03754beaf183e35675be992
2014-10-22 18:07:27 -04:00
90f2f34267
Exit early in case the column has no cell notes to copy to destination.
...
Change-Id: Ifca77ccda7b2065b00ee29f29f377da599929843
2014-10-22 18:07:27 -04:00
beb2d06e2e
Set latin script to numeric blocks of applicable columns.
...
Change-Id: Ib81ef144f168fed38100127bd63f43ea5a835a13
2014-10-22 18:07:27 -04:00
a4b7d8a401
Check for standard number format rather than just for 'General'.
...
That's what the ods import filter does.
Change-Id: Ibcd9a80a51785a448594d29a02283cca0ec53e95
2014-10-22 18:07:27 -04:00
bc1dd8feb8
Move this useful function to sc::NumFmtUtil.
...
Change-Id: I7b42a4418408ee2c988c32e7f1adeee3dfe269c8
2014-10-22 18:07:26 -04:00
f1fcac4bc9
Try to determine whether or not a column has all 'General' number format
...
during import. We'll then use this information to set script type to latin
for all numeric cells in those columns rather than leaving the script type
'unknown'.
Change-Id: I69eae1effc32c57290b0265bc6c87e58f51944b1
2014-10-22 18:07:26 -04:00
e0d62d8ef7
Move SetAttrEntries from ScDocument to ScDocumentImport.
...
Since that method was really an optimization for xls(x) import code.
Change-Id: Ie2530f5dc27411bd45d72440681689c6c7a8b10a
2014-10-22 18:07:26 -04:00
ab4606f9e7
Update all script types in the marked ranges up-front.
...
This is slightly faster than doing it on a as-needed basis.
Change-Id: I7618f003f3c98ee894c3f1cf597681e4281cc6ab
2014-10-22 18:07:26 -04:00
8922f72d1e
Annotate FindEditCellsHandler.
...
Change-Id: Ib49a7a3eccee62e5496f7f19824631866e072b6a
2014-10-22 18:07:25 -04:00
04ee80c1a6
Store height array to RowHeightContext and reduce function arg counts.
...
Change-Id: I09b79bc76ffc55e25c24bbfa8f000f4a46df0a1c
2014-10-22 18:07:25 -04:00
48f2cc5a2e
Set rotation reference directly via internal API.
...
Note that the original code would first set the rotation reference value
stored in the Xf, then later unconditionally overwrite it according to
the border setting. The new code only ports the second part. Perhaps
there was a bug in the original code....
Change-Id: I15b6839e9a58e8070a43db70e1a88b42ed99f2d8
2014-10-22 18:07:25 -04:00
cfcfd1a868
Set cell style name to the document directly, bypassing the UNO API.
...
Change-Id: I28decfdfd8248fb9b95416b9b269a4ffabcc6370
2014-10-22 18:07:25 -04:00
1a2c28cf0d
callcatcher: update unused code
...
Change-Id: I96b4d44e44389245f3ccc4a08198676461c6a38b
2014-10-22 13:11:34 +01:00
d9f303a030
Remove unused FormulaToken::Is3DRef
...
Change-Id: Ib720bc4b3bfff8e428d14d65ff73144db82c60e0
2014-10-22 10:58:21 +02:00
9ecac3874d
Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTING
...
Feature test macros that govern conditional compilation should be
defined in config_*.h include files, not on the compilation command
line.
Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-22 09:30:23 +03:00
166eaf213b
conversion to double should not be necessary
...
Change-Id: I12ad83453b68077fe672576680b0cd5fd9acf49f
2014-10-21 10:54:43 +02:00
182fc4f184
fdo#84938: replace WINDOW_BORDER constants with enum
...
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-21 09:06:40 +02:00
4332787892
nShearWink -> nShearAngle
...
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-21 08:56:29 +02:00
67c9d05451
fdo#84938: replace TIB_ constants with enum
...
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84
Reviewed-on: https://gerrit.libreoffice.org/12023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-20 07:16:46 +00:00
281847613b
fdo#82047: Correctly adjust references in range names on row deletion.
...
Change-Id: Iac924b0b6932863f7f9cc088f996e0b07c340d2c
2014-10-18 20:25:00 -04:00
e556657e36
fdo#39468 Translate German Comments - sc/source/filter/{lotus,rtf}
...
Change-Id: Ib5f1865cfd5d62f45919af8119d4ab691811225b
Reviewed-on: https://gerrit.libreoffice.org/12021
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-18 13:59:31 +00:00
7fef943114
fdo#80284: Avoid broadcasting during cell delete & shift.
...
Broadcasting it here and marking formula cells dirty prevents them
from being entered into the formula tree at the end. They get marked
"postponed dirty" during reference update, and are supposed to be
set dirty at the end.
Change-Id: I65977300ee4ee26b6166d170acd2145abcbbf288
2014-10-17 21:53:21 -04:00
51d86c9e62
Consistency around SdrAngleItem in svx/sxciaitm.hxx
...
...similar to what has been done for svx/sdtmfitm.hxx in
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."
Change-Id: I8e76e4751e50f5952c6dfff9ee10362166bf0523
2014-10-17 15:36:13 +02:00
51b215902d
fdo#73080: Fix the single cell reference cases as well.
...
Change-Id: Ib9a8ae04733c5bcb982ef4d337112eb8249d0ee0
2014-10-16 20:50:56 -04:00
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
f9aa686432
Resolves: fdo#81496 crash in calc format page
...
Change-Id: Ic70f6f605e13a5c95b504f1bf0322e11313a21e7
2014-10-16 09:09:46 +01:00
3e2bd1e402
fdo#73080: Correctly count blank cells in COUNTBLANK.
...
Especially when formula cells are involved.
Change-Id: I40950e7108778821c17d08354f01bb157b1551e6
2014-10-15 20:09:48 -04:00
