Commit Graph

385479 Commits

Author SHA1 Message Date
ba3a918404 Remove trivial class XMLTransformerContextVector
Change-Id: I140614895d5727ffd97681ddd06bf7439fe7a443
2015-12-17 16:51:16 +01:00
21e72c5f1d Hold XMLTransformerContext by rtl::Reference
Change-Id: I60b8d422d53d47537996756aa1b7fb3c26f8383a
2015-12-17 16:51:16 +01:00
b902432b43 lokdocview: Use GLib basic types
Change-Id: I07add7b9dcb1dc53d7ed61ff71545489de3be155
Reviewed-on: https://gerrit.libreoffice.org/20778
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2015-12-17 15:47:43 +00:00
9c8c3acffa lokdocview: Added some missing comments/annotations
Change-Id: I2f62bae37719ce96677a5ca6ffd93c8edb325a6a
Reviewed-on: https://gerrit.libreoffice.org/20777
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2015-12-17 15:46:47 +00:00
a2682e4b08 lokdocview: Superfluous *_set_zoom() call on widget initialization
G_PARAM_CONSTRUCT implies that parameter will be set upon widget
initialization which means calling lok_doc_view_set_zoom() while
document still points to null.

Change-Id: Ib576ac3b32c2349be2b2df6067ae79a056a03028
Reviewed-on: https://gerrit.libreoffice.org/20775
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2015-12-17 15:45:24 +00:00
244aad533b lokdocview: Remove an easy FIXME
Change-Id: I8305f3eb45330f457089ca0524a0df004410f59c
Reviewed-on: https://gerrit.libreoffice.org/20774
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2015-12-17 15:44:09 +00:00
4c18af27bf tdf#96398 kill remaining NPAPI support for plugins _inside_ LO
- probably out of date
- links against Gtk2 and thus causes a GTk2 dependency in core packages
- the only serious usecase (Flash) is doomed anyway

Change-Id: I7264ab5eb04c2f4b6c31a815e45b9818209e5ae2
Reviewed-on: https://gerrit.libreoffice.org/20658
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-12-17 15:31:17 +00:00
57b1cf5862 tdf#96482 Revert "Resolves: tdf#94069 call setVisible when setDesignMode is called"
This reverts commit a7816853bad55ada597092c16ba9a0a761e067d0.

tdf#94069 (freeze) has been corrected differently in master (5.2.alpha) anyway.
2015-12-17 16:17:42 +01:00
5b404cc2ad out-of-bounds arg mapping access, this was always wrong but never hit it seems
Change-Id: I15843b320ac8ddcefce8094da7aa7c6b81b42e4f
2015-12-17 15:44:34 +01:00
a7d0c00d73 Fix creation of infobar
Fallout from 7dd77a12713c0557c5826d3541e97ef6120e1d00
2015-12-17 15:32:17 +01:00
4eea9f2146 handle varargs with first required and subsequent optional, tdf#71459 related
Change-Id: I56c66f516ba2a2e12cab4848c8c352315f27b3bb
2015-12-17 15:14:43 +01:00
db1e34aecd add RAWSUBTRACT spreadsheet function, tdf#71459
Change-Id: I2ae13771c85044b771e253a8189a30cb4aecb30f
2015-12-17 15:14:43 +01:00
348d7f6170 sd: enable insert graphic when UNO command has URL file argument
When LOOL requires to insert a graphic, it uses UNO command ".uno:InsertGraphic", 
and the corresponding URL file image argument.

However Impress, ignores URL file image argument, and by default
pop up a dialog, so no image is inserted in LOOL.

Change-Id: If1939247f5df0bb4e7daf8816a2306e34419ae2f
Reviewed-on: https://gerrit.libreoffice.org/20747
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2015-12-17 14:08:39 +00:00
eaa7f30102 Remove gnome-open support
Gnome-open has been deprecate for some time.  xdg-open replaces it.

Change-Id: I7fc0f32a1f2fbadbe3d1cee58d0089213665c3a5
Reviewed-on: https://gerrit.libreoffice.org/20347
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-12-17 13:56:22 +00:00
b7842c93dc tdf#95648: Erase the OpenGLCompatibleDC to white before drawing text into it
For some reason this is needed in the case of GraphiteWinLayout and
OpenGL. Otherwise when a space glyph is "drawn" into a space that is
wider than the nominal width of the space glyph, we get two black
rectangles surrounding the white space "glyph".

Change-Id: Ifb4ea00d9e5f078518ac97d7dd18694088aa1cdf
2015-12-17 15:19:20 +02:00
dc3eb865bd tdf#32248 SVG: first attempt to support tspan elements
it's not perfect but at least we can already display the text,
which is better than displaying nothing

Change-Id: I89627010ac8071c106b41c1de6b183a619f8158b
Reviewed-on: https://gerrit.libreoffice.org/20642
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2015-12-17 12:23:38 +00:00
2f0fba494e guard against null Foundry
Change-Id: I8aabc68e8dfb9376cafe4cc709b18344da083a01
2015-12-17 10:52:36 +00:00
dab2582f05 gtk3+wayland: start floating windows hidden
once they are visible we can't move them under wayland, so
start then hidden, move them and then show

these floating windows are very delicate.

Change-Id: Ia233c23f25cec453df79ef70cab6210dbdd280a0
2015-12-17 09:13:10 +00:00
016730421e remove newly unused WB_NEEDSFOCUS and fragile FLOAT_FOCUSABLE
Change-Id: Idce03318fbc01039a6c0638879785607970993c0
Reviewed-on: https://gerrit.libreoffice.org/20746
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-17 09:11:38 +00:00
3d3e95d685 impress's AnnotationWindow is the only user of WB_NEEDSFOCUS
Here it is creating a toplevel floating system window which needs special
hackery to function.

Instead convert it to a non-system window which means that it is in reality
only a vcl construct. The small downside is that it is now unable to leave the
confines of the toplevel system window in which it lives. Upside is that
all the special hackery related to it which generally doesn't work half the time
in various window managers and now in wayland can go away.

Change-Id: I7ad7c35091086f7671ff4a178c7fa04202c20e09
Reviewed-on: https://gerrit.libreoffice.org/20745
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-17 09:10:46 +00:00
9d76a0cb7e Get rid of ImplDoTiledRendering()
It returned true only on iOS, and we do use tiled rendering
successfully also on the other non-DESKTOP platform, Android, plus
obviously for LibreOffice Online and other LibreOfficeKit clients, so
it is quite likely that the function was not really needed. Besides,
the code doesn't even build for iOS at the moment.

Change-Id: I229bce61eaab9b795a1d5e959cb6587dcedf1ef1
2015-12-17 10:36:33 +02:00
7dd77a1271 Remove unused ToolPanel (aka TaskPane)
Superseded by the Sidebar

Change-Id: I54970d71cd9d42de4f47b223e50dd9474b40632a
Reviewed-on: https://gerrit.libreoffice.org/20724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-12-17 08:27:55 +00:00
5b44a9733a sw, sd, sc: clean up no longer necessary isTiledRendering() member functions
Change-Id: I508a29fd261865771d780b1c241841d9abfeb6ed
2015-12-17 09:16:28 +01:00
550d95ae6e Manage m_pSttNdIdx via unique_ptr
...so it gets deleted upon an exception

Change-Id: I239f916019806eef1b761248fd167f5febf25001
2015-12-17 08:50:52 +01:00
bb9a7c340d starmath: Drop const modifier of SmNode::Arrange's 1st argument
as well as SmNode::AdaptToX / AdaptToY's.
It was pointless because the client code in the functions always cast it off.

Change-Id: I00c690bd98a566fb167708216d766a2894de669f
Reviewed-on: https://gerrit.libreoffice.org/20710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-17 07:01:01 +00:00
c9f6e12e7e OString/OUString: move constructors and operator=
Change-Id: Icdc5f7137cca8360f116d5d4c7b0bf4a4c526e1d
Reviewed-on: https://gerrit.libreoffice.org/20712
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-17 06:59:50 +00:00
15614c847d gengal: Don't depend on whole instsetoo_native_setup package
..to avoid rebuilding galleries all the time
because 'version' rc-file target is PHONY.
Instead name what exactly is needed.

Change-Id: Idf3c5a4a5b64a48ae06c46acf24e49f6a1ac2114
Reviewed-on: https://gerrit.libreoffice.org/20407
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Matúš Kukan <matus@libreoffice.org>
2015-12-16 21:24:25 +00:00
988f1c7121 sw: extend some more OOXML export test to check embedded objects
Change-Id: Ie1047a2a213632f05b0ae091a3a7e4118a271082
2015-12-16 20:37:39 +01:00
291f55edf3 assert that no ODF import happens without a BaseURL
Change-Id: I4520a9d0350349cb083ed627a19264a3a97e090f
2015-12-16 20:37:39 +01:00
032e34d001 tdf#96250 LOK: guard against 0 pRenderingArguments
Change-Id: Ifa39777795ce966662c31c891ffc1b9b1a297b00
2015-12-16 20:31:47 +01:00
70bfd5d747 tdf#96546 - Bitmap getTexture calls can crash too - enter GL zone earlier.
Change-Id: Idd095e0a3b5e5226eaf1db90bfb0a838bc51de19
Reviewed-on: https://gerrit.libreoffice.org/20741
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-12-16 17:55:26 +00:00
72f0067258 tdf#96536 sw Hide Whitespace: shrink oversized page frames on para delete
The body frame did get a request to shrink, but because it had fixed
size, nothing happened. Trigger a recalc that does the right thing wrt.
hidden whitespace.

Change-Id: I446978da8b33372c2ab30200b45b1bcec1dea7a0
2015-12-16 16:02:19 +01:00
97361478e6 don't call getOutputString when we are not using the result, tdf#92802
Change-Id: I5569eb618b5577714bd10c77ade198638394df8b
Reviewed-on: https://gerrit.libreoffice.org/20725
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-12-16 14:57:44 +00:00
98498fc763 These would probably wreak havoc
...judging by how XFStyleContainer appears to own the pointers in m_aStyles, but
are apparently not needed anyway

Change-Id: I5ca64680bf8b7b5198f30dac4f4558069d476970
2015-12-16 15:48:51 +01:00
14220052ef Related tdf#90700 Add configuration for web connection timeout.
Currently the connection timeout is governed by operating system
default.

LO timeouts will be used in place of the TCP socket operating
system ones, only in operating system where this is currently
possible.

The timeouts to use can be changed in LO configuration:
'Tools > Options > Advanced > Expert Configuration'.
Propriety names are ConnectTimeout and ReadTimeout.

ConnectTimeout contains the timeout (in seconds) used when
making a connection (max 180 s, min 2 s, default 20 s).

ReadTimeout contains the timeout (in seconds) used when reading
from a socket (max 180 s, min 20 s, default 60 s).

Change-Id: Ide69ab137274c3bf71332b6e76666151ecac1f1e
Reviewed-on: https://gerrit.libreoffice.org/20195
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-12-16 14:35:13 +00:00
d7e5b95c14 Make test code actually test something
...and calling remove on a list apparently returns None

Change-Id: I7a44d85cfebf17ac89bef0ce2d322a2cfa929899
2015-12-16 15:11:44 +01:00
81a1d5ceb7 loplugin:vclwidgets
Change-Id: I9a9748879fcc55b524138d865e71a713efad180d
2015-12-16 14:21:27 +01:00
df997d92e0 Simplify Desktop::getInfoHelper
Change-Id: I13058816e8b2b1c821f0123f110671706bf90449
2015-12-16 14:21:27 +01:00
a201684800 Remove comment noise
Change-Id: I7794e40e07520c1e504b1167aa64cf24819271f2
2015-12-16 14:21:26 +01:00
4ac13fb72a No need for TransactionGuard::stop
Change-Id: If1c0b7285817bb10338077460b77de4a27d35753
2015-12-16 14:21:26 +01:00
e9e61809ea Simplify TransactionManager
Change-Id: I51d1969f9f88d9e29fc081fd54df365578900126
2015-12-16 14:21:26 +01:00
fc44b7104c No need to pass eReason out of TransactionManager::registerTransaction
Change-Id: I0c8468219a4a9df904f34ec1363043bc46265c14
2015-12-16 14:21:25 +01:00
51351a28ec TransactionGuard is always called with null eReason
Change-Id: If416f9539136563dba43f38f7622d70e7fb1f005
2015-12-16 14:21:25 +01:00
1681323093 Remove dead ctor
Change-Id: If1576f9eabcad4e0287181838e0a019fe9372065
2015-12-16 14:21:24 +01:00
52379d720b Clean up
Change-Id: I170b12d1024d51beb5c48333c0759bc33049f577
2015-12-16 14:21:24 +01:00
620f365032 sw layout xml dump: show if the frame has fix size
Change-Id: Ie9f9c5cc94b87914bcd7d5392f6fd1ee447e94ec
2015-12-16 13:45:56 +01:00
8a342e9f6a unusedcode removed in this commits
001e694ecd21095b6fcfb5632ace63d8e0c2b7f8
 OutputDevice::LogicHeightToDeviceCoordinate(long) const

449d272daf5e99f039cdfdd25f020bd798fb9e1d
 OutputDevice::GetCanvas() const
 OutputDevice::HasAlpha()
 OutputDevice::LogicToPixel(basegfx::B2DPolygon const&) const
 OutputDevice::LogicToPixel(basegfx::B2DPolygon const&, MapMode const&) const
 OutputDevice::LogicToPixel(vcl::Region const&, MapMode const&) const
 OutputDevice::PixelToLogic(vcl::Region const&, MapMode const&) const

Change-Id: I284a89ccf9c3bc0dffd47789e0fe8afe83606e0f
Reviewed-on: https://gerrit.libreoffice.org/20732
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-16 12:22:26 +00:00
0db3361527 Fix indentation
Change-Id: Ie0b842cd35ca05e4adfc0b8692423e0a91e1739c
2015-12-16 12:10:07 +01:00
bba3f7bf8f but only for dialog
Change-Id: I7e4f5c075ca4844f81a59071bed475ea1da4bf91
2015-12-16 11:02:27 +00:00
afeddaf7e0 Related: rhbz#1281906 set a min size on un-resizeable non-layout dialogs
a min size equates to a size-request which is reliable under gtk3+wayland
as the dialog contents size.

a default size equates to the size of the dialog, which includes decorations
under wayland

Change-Id: I20baf00fb5952ab93628f4dd6891779ce682783c
2015-12-16 10:47:25 +00:00