Commit Graph

252 Commits

Author SHA1 Message Date
21a9bc8716 no need to take a mutex when only dealing with stack-local data
Change-Id: Ie45e626aad55a8174a53b769a98601bf54dedf65
Reviewed-on: https://gerrit.libreoffice.org/19979
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16 11:37:11 +00:00
25aec383f9 use initialiser for Sequence<OUString>
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:18:55 +00:00
c504477e7c com::sun::star->css in UnoControls/
and remove some noise comments

Change-Id: I290ec365b58fa1b21838a6faf84006434c3e7bbd
Reviewed-on: https://gerrit.libreoffice.org/19904
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-11 11:01:31 +00:00
3bf5bc0374 loplugin:nullptr (automatic rewrite)
Change-Id: I8be8b75317f0a8cf9005feefea05c053b76c7b0f
2015-11-10 10:31:14 +01:00
065c8b48a6 use uno::Reference::set method instead of assignment
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-30 08:10:22 +02:00
367105e024 cleanup some local var declarations
found with
   git grep -nP '(\w+)\s+=\s+\g1\(' | lots-of-hand-filtering

Change-Id: I598b0cfa6607823eaef09d95e610e05145c727f7
2015-10-19 13:08:29 +02:00
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
82f0a4f930 Fix typos
Change-Id: I3926eca56ac9f54f9ddbf88610888ce97cf00b34
Reviewed-on: https://gerrit.libreoffice.org/18990
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-30 10:41:48 +00:00
2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
462e986e0d Fix typos
Change-Id: Id9296115f30858e7fd470a199e59343a96d7deec
Reviewed-on: https://gerrit.libreoffice.org/16712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-04 10:18:19 +00:00
b997705c07 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I2828f5fe78efffaa5dee19a3d56592d12878d956
2015-06-08 16:22:58 +02:00
d5129a9dd6 new clang plugin: loopvartoosmall
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.

So far, I have only run the plugin up till the VCL module.

Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.

Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-28 12:49:54 +02:00
cbaca2c1ce remove unused #include awt/InvalidateStyle.hpp
Change-Id: I7ea52365157fc642401db64c3b4a40d4643d16ae
2015-05-05 15:51:09 +02:00
5d5f447e73 UnoControls, toolkit, uuoi, xmlsecurity: convert new to ::Create.
Change-Id: I7b8c7ece656589c50fb066e9fa1565fd59f930da
2015-04-16 22:21:04 +01:00
d246f47422 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I61a85caf1587291eaa6b999050a52c92d9e416e3
2015-04-01 08:35:13 +02:00
44790193a7 loplugin:staticfunction
Change-Id: I982ba552579019e4902ae59fddf14a6b34ba5954
2015-03-27 10:51:08 +02:00
3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
556373c41f V668 no sense in testing the result of new against null
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11 09:58:36 +00:00
5f6fcb4e7c Typos
Change-Id: Ibc378fa5f515de61bb768b4ef082638b40c94e00
2015-03-08 16:45:30 +01:00
c1b9402d49 Typos
Change-Id: I151957e415eff793e3d054050526b7d6892d28d4
2015-02-28 14:54:12 +01:00
ba233e87ef remove unnecessary parenthesis in return statements
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
81cb993127 Fix of a few typos
Change-Id: Ib2a311f0341d165a8f9d3f7a11ec36378fd69519
Reviewed-on: https://gerrit.libreoffice.org/14373
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-02-09 16:20:09 +00:00
45ec1d9b56 brute-force find-and-remove of unused #define constants.
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2015-01-08 10:39:36 +02:00
1990c75175 Daft += "\0" triggers assert
...try

GetProcessServiceManager().createInstance("stardiv.UnoControls.ProgressMonitor").addText("foo", "bar", false)

in Basic...

Change-Id: I30318c3e8e671a97b6a3fe2dd9ec03add21794ab
2014-12-16 13:31:48 +01:00
8502d64878 Daft "\0" triggers assert in OUString literal ctor
...try

GetProcessServiceManager().createInstance("stardiv.UnoControls.StatusIndicator")

in Basic...

Change-Id: Iafc22188feb8a1d3f1b19ac4f6e209be62a44d17
2014-12-16 13:23:19 +01:00
aa65aea24f Missing UnoControls/Makefile
Change-Id: Iebf1c42c384909f6226c25eb151985f8bc244c93
2014-12-16 13:19:29 +01:00
75b0e1f9c0 Kill the libreofficekit static library / shim.c.
It looks like the cleanest method of getting lok_init into
a LibreOfficeKitInit.h header (in a c89 compatible way) is to
have it as a static function.

(inline is only available in C99 or later -- this is actually
 available on Linux which is the only place that we can actually
 use lok_init anyways currently, however given we have to keep
 c89 for the C code (for MSVC) compatibility, selectively enabling
 c99 would likely be more messy.)

Conflicts:
	libreofficekit/Module_libreofficekit.mk

Change-Id: I0493e7a68ed5397479220bb6ba8c3db870b6dd32
2014-12-04 12:23:02 +01:00
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
0371a63365 remove unnecessary 'using namespace rtl' declarations
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29 11:28:54 +00:00
a2320eaf39 loplugin: cstylecast
Change-Id: I28443b688f8ab752162846e5cea661f26d269cad
2014-09-29 12:50:36 +02:00
15652daf08 UnoControls: sal_False/True -> false/true
Change-Id: If30d43a2693c6df2d483ec135efa54ccb643fdb0
2014-09-15 17:23:23 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
dc0b96639f -Werror,-Wtautological-undefined-compare
Change-Id: If546680f4c16ccd733188a65d82129ec2358017b
2014-06-10 10:53:46 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
4d878a0809 Many spelling fixes: some more files.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades.

(cherry picked from commit e62c0f54ef18a5a79b76e934834b148523c69847)

Conflicts:
	LICENSE
	NOTICE_category_b
	UnoControls/source/base/basecontainercontrol.cxx
	UnoControls/source/base/registercontrols.cxx
	UnoControls/source/controls/OConnectionPointContainerHelper.cxx
	UnoControls/source/controls/progressbar.cxx
	UnoControls/source/controls/progressmonitor.cxx
	UnoControls/source/controls/statusindicator.cxx
	UnoControls/source/inc/framecontrol.hxx

Change-Id: I882a1d640d931b4e89b2d19f3585fd35fdd320ca
2014-04-30 13:30:20 +01:00
e6ac6cbccf automaticly -> automatically.
Change-Id: Iae55083160eee86ac8301f272634dd3ae65fd847
2014-04-27 01:28:55 +02:00
8bb2ce61c0 fixincludeguards.sh: some smaller dirs
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-19 11:10:13 +02:00
1e0fae45a6 Bin empty @seealso, @param, @return and @onerror metacomments
Change-Id: I6517028670a953954b31599fa3e23f4c8ee8cfc9
2014-04-06 20:00:28 +03:00
fdecbd4a41 Kill superfluous spacing before semicolons
Change-Id: I2c5c2c2e8c57796d147141748fb57a4c5645a96a
2014-04-06 20:00:28 +03:00
5814e76432 Kill superfluous vertical whitespace
Change-Id: Ieb7956acdc24d6b18939e916e33eb12dc268e778
2014-04-06 20:00:27 +03:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
af4b38d6e7 Remove dead code
Change-Id: I59fb7843d5c9a6cf2873b6d668d0e9dccff316d2
2014-03-25 09:15:39 +01:00
6303605297 UnoControls: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I6ad8bb98f967d7bfa062ae24d9ff35837620a77a
2014-03-10 17:39:51 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
b06820d74c Remove visual noise from UnoControls
Change-Id: I0ffbc08cf769e39e8c3b7519e8d2e13ccbe6e3d8
Reviewed-on: https://gerrit.libreoffice.org/8331
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 06:02:19 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00