Commit Graph

5805 Commits

Author SHA1 Message Date
291f55edf3 assert that no ODF import happens without a BaseURL
Change-Id: I4520a9d0350349cb083ed627a19264a3a97e090f
2015-12-16 20:37:39 +01:00
07004a7e9c chart2: add DocumentBaseURL in ChartFrameLoader::load()
... as seen in JunitTest_chart2_unoapi

Change-Id: Ibe0cd210b8f2ddf730483705292e9027654b6fd4
2015-12-15 17:44:37 +01:00
45300b43fe chart2: fix obvious mis-use of wrong member in XMLFilter::impl_Import()
... so we get a BaseURI set.

Change-Id: I01176a8a0b0a1f4386f4d58bdf36bd5cb29cf3e5
2015-12-15 17:44:36 +01:00
576c7562ec Return std::unique_ptr from svt::AcceleratorExecute::createAcceleratorHelper
...to prevent errors like 5ac6e00274e732435b55c2908db9cea658fe549b "Memory leak"

Change-Id: I3e20393af628849d8a387b491b75e1aacdea982a
2015-12-11 16:15:53 +01:00
2afead78b3 tdf#69977: constructing and destructing AccessibleElementInfo...
... is surprisingly expensive
shaves about 5% off the time to build this chart

Change-Id: I8e5d071edba50d264c2ab01c6bc0b2cad0e41ec6
Reviewed-on: https://gerrit.libreoffice.org/20588
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-10 10:32:15 +00:00
19f64ccc8c chart2: replace boost::ptr_map with std::map
Change-Id: I07a8b2eaa11ca29e3303d323060c3a4c52823967
2015-12-04 12:01:13 +01:00
f46327e6c9 chart2: replace boost::ptr_map with std::map
Change-Id: Id647a5b681e10defd944ccb2ec8509689df704af
2015-12-04 12:01:13 +01:00
25ad18c1e1 chart2: replace boost::ptr_map with std::map<std::unique_ptr>
Change-Id: I0b80042bdab33b52b339267292249add6f70ac3c
2015-12-04 12:01:13 +01:00
7532317631 WaE: comparison between signed and unsigned integer expressions
Change-Id: I051e2682bdff3bf88fecd726bd57652e5f9e8806
2015-12-03 14:44:50 +02:00
e6721d2d17 uno::Sequence->std::vector in SfxIntegerListItem
Change-Id: Icdbb361feea2ebee74f9d0a906bdd3c2882443e8
2015-12-03 13:57:23 +02:00
7f8c4b8445 Use comphelper::containerToSequence()
Change-Id: I18d6ef04ff00f971a4c54ba259733c07501c6c1a
2015-12-03 13:57:22 +02:00
ec3f724158 loplugin:unusedfields
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-30 10:34:38 +02:00
bc8dcb2b5d -Werror,-Wunused-private-field
Change-Id: I70e753b1532fe465d378b8b4b0bbd2b7582130fe
2015-11-26 14:17:38 +01:00
a508f639a0 mark UNO structs as SAL_WARN_UNUSED, where possible
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-26 13:26:25 +02:00
1f86864e97 loplugin:unusedfields various
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
2015-11-25 13:57:29 +02:00
b639fe60ea VirtualDevices either match another device depth, or are 1 bit
cairo can therefore always render to a svp virtual device with
need for a fallback

Change-Id: I5d03ae541820389e26f7448444444be009fb28a4
2015-11-23 14:25:59 +00:00
c43a3a5867 establish that Virtual Devices either match Physical Device depth or ...
are 1 or (rarely) 8 bit and lock that down.

Change-Id: I3d946ebef34ffb71c5adea7aa420af50e9584e05
2015-11-23 14:25:59 +00:00
c79b7fd8d4 loplugin:unusedfields in chart2
Change-Id: I7da22cc193d9fadf9a3b5dc1453f5574d2357c31
2015-11-20 12:41:00 +02:00
fe3fd05966 add mapKeysToSequence/mapValuesToSequence methods to comphelper
and use them

Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec
Reviewed-on: https://gerrit.libreoffice.org/20055
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-20 08:14:13 +00:00
2554efabb6 use comphelper::containerToSequence
in chart2, we remove a local equivalent of the method

Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-19 09:33:29 +02:00
53f16c39f5 remove unused typedefs and inline use-once typedefs
and improve the script a little

Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84
Reviewed-on: https://gerrit.libreoffice.org/20033
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-18 10:38:08 +00:00
d9e6270392 loplugin:unnecessaryvirtual
update the plugin with lessons learned from the mergeclasses plugin and
re-run it

Change-Id: I9d622eb3d05fceaf8fa764c533c8fa5dfb4c7711
Reviewed-on: https://gerrit.libreoffice.org/20015
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-17 12:26:32 +00:00
96c26b0d9d use initialiser for Sequence<OUString>
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
25aec383f9 use initialiser for Sequence<OUString>
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:18:55 +00:00
54d22957bc use initialiser for Sequence<OUString>
performed using:
git grep -lP 'Sequence.*OUString.*\(1\)'
| xargs perl -0777 -pi -e
  "s/Sequence<OUString> (\w+)\(1\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f
Reviewed-on: https://gerrit.libreoffice.org/19968
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 11:31:23 +00:00
8e234c5b7d use initialiser syntax for Sequence<OUString>
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 10:13:08 +00:00
40c4a08652 loplugin:nullptr (automatic rewrite)
Change-Id: I71de514405bb9bcc746c1ab9633e7fe659888943
2015-11-10 10:31:18 +01:00
c3efbb1d23 fix build, std::make_unique is C++14, use o3tl::make_unique
after my recent boost::ptr_vector->std::vector<std::unique_ptr>
conversions

Change-Id: I5ebea198365bb2fddf43851c70ebea3f3e19d61b
2015-11-10 10:20:48 +02:00
41e9197eb6 fix build
after my boost::ptr_vector->vector<unique_ptr> conversions

Change-Id: I1141e8ad614a650a274bf41bf3ebad9143c561c0
2015-11-10 09:59:10 +02:00
73baabfffc chart2: replace boost::ptr_vector with std::vector<unique_ptr>
Change-Id: I5c374afcfa2760ebf21e461f38fe392692054dfe
2015-11-10 09:41:53 +02:00
e0dec4c73b chart2: replace boost::ptr_vector with std::vector<unique_ptr>
Change-Id: Ia5c35cbd54045a79e896832adf2dbe68c5facf1f
2015-11-10 09:41:53 +02:00
126103cd2a chart2: replace boost::ptr_vector with std::vector<unique_ptr>
Change-Id: I8bc458c2bcbcb72791ba93a6fe15c83e05d8fae1
2015-11-10 09:41:53 +02:00
c3e642c0b6 chart2: replace boost::ptr_vector with std::vector<unique_ptr>
Change-Id: I706b730ebbe6a7637a3f1a9cea80a1604f005a53
2015-11-10 09:41:53 +02:00
6c80a8fe89 new loplugin: oncevar
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 08:34:40 +00:00
d097d86940 coverity#1338265 Uncaught exception
Change-Id: I5fd48ccaa9dc5c0477cb1d7da307c8403d92e3f7
2015-11-06 12:16:00 +00:00
e460c11f42 coverity#1338253 Uncaught exception
Change-Id: Ia4235060dc2e8943a91e9115111bac9fe9a3fc66
2015-11-06 12:15:56 +00:00
a86b41ca81 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
Change-Id: I5accc3f27b545c1dca6281201151729e3717fb0f
2015-11-06 09:34:50 +01:00
48a3359070 Reduce scope of #include <tools/poly.hxx>
Change-Id: I0d64393c029d27c8e6f3b6d360d2509dad16d860
2015-11-05 20:32:47 +01:00
59b072e22b yyyyy
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
be729e7721 tdf#94269: Replace "n" prefix for bool variables with "b"
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797
Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-11-02 23:40:57 +01:00
065c8b48a6 use uno::Reference::set method instead of assignment
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-30 08:10:22 +02:00
644487a115 loplugin:unusedmethods
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861
Reviewed-on: https://gerrit.libreoffice.org/19231
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27 08:20:43 +00:00
13938d6de8 Replace boost::bind by lambdas in chart2 tree.
Change-Id: Ida56649f15b58b3b11b3d43c5017fd5ebd9a2cf1
Reviewed-on: https://gerrit.libreoffice.org/19606
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27 05:40:46 +00:00
d550cdb941 implement text rotation for chart axis sidebar panel, tdf#94970
Change-Id: Ifce97c437238bd1520a2122aa4027a1bcbba1e5d
2015-10-23 00:35:37 +02:00
66a25e96ca make it harder to use the API wrongly, tdf#95056
Change-Id: I07129285ac7f00513802a60c31d5de27f6f4a5d6
2015-10-22 23:49:13 +02:00
73cfe5fece disable all error bar radion buttons in the beginning, tdf#95057
Change-Id: I611a637038669fe855b4357045bff8d3eb5f8600
2015-10-22 23:49:13 +02:00
2f3ea8dfbc refactor out some com::sun::star typedefs
which mostly serve to make the code harder to read

Change-Id: Ia2a83fee9f850ab6f0bea6305ce8600d6b785fe8
2015-10-21 14:17:56 +02:00
56e6f0da83 new loplugin: badvectorinit
look for places calling the 1-argument vector fill constructor and then
immediately called push_back, which is generally a sign that its
leaving empty slots.

Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517
Reviewed-on: https://gerrit.libreoffice.org/17525
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-10-20 11:35:31 +00:00
dedf0a28d5 loplugin:defaultparams
Change-Id: I03541b984db147f8bd3ed35f83e297cf7eecd7f0
2015-10-20 11:44:54 +02:00
1707c47de7 loplugin:defaultparams
Change-Id: I946e1970647d8005f54ac0362f5c2b04f867b22f
2015-10-19 17:49:17 +02:00