c4ecd6c493
That SB variable was a temporary debugging aid
...
...inadvertently checked in with 7bcf64c29a0f5d3d2d60fe98afadab6e48dbe8b3 "Add
isReadOnly() support to simplified configuration access"
Change-Id: I9b8b477f682605fcdcf65f8e1255524d010495be
2015-11-26 12:39:03 +01:00
a508f639a0
mark UNO structs as SAL_WARN_UNUSED, where possible
...
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-26 13:26:25 +02:00
e78bb6d545
loplugin:unusedfields in include/comphelper,include/editeng
...
Change-Id: I619c2cf1765df97159fc52ee84e0e9e8d16a22fe
2015-11-24 14:20:25 +02:00
b8793748b0
Seems more natural to pass a homogenous list by initializer_list
...
...than by template parameter pack (even if that requires using ServiceDecl*, as
initializer_list cannot take reference types)
Change-Id: Ia986201b52d8daedfe925f132ebc79bc2c0ba378
2015-11-20 13:39:52 +01:00
ab9add5c96
loplugin:sallogareas
...
Change-Id: Ib1f06cb5f925535858bc14aab6f59ad7fd2a3a8d
2015-11-20 10:14:49 +01:00
2554efabb6
use comphelper::containerToSequence
...
in chart2, we remove a local equivalent of the method
Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-19 09:33:29 +02:00
25aec383f9
use initialiser for Sequence<OUString>
...
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"
Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 12:18:55 +00:00
d7801c3982
Namespace cleanup and disambiguation
...
Change-Id: Ib6d2f8b4e71436c3a7c26bdfc9847152ebaf0739
Reviewed-on: https://gerrit.libreoffice.org/19900
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-11-12 10:47:26 +00:00
fb4ce444c2
loplugin:nullptr (automatic rewrite)
...
Change-Id: Ibd0e6ae5e3243464b2484a009f2b4781bdaac471
2015-11-10 10:31:19 +01:00
9acf5eab9a
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: I779e46c9c0db80485d213117028896a7e5b9e943
2015-11-06 09:34:55 +01:00
59b072e22b
yyyyy
...
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
8c987fabab
lok: Introduce LOK_CALLBACK_UNO_COMMAND_RESULT callback.
...
Posting of the .uno:Something commands is asynchronous. To be able to find
out when eg. .uno:Save finished, this commit introduces a callback that fires
when that happens.
To be able to receive such a notification, the appropriate postUnoCommand()
must be called with 'true' as the parameter for bNotifyWhenFinished (defaults
to 'false').
Change-Id: I254939ebc8ea5f309ae39686dcaaeddd5148b0c9
2015-11-03 13:25:23 +01:00
cb4fa1d1e2
use uno::Reference::set method instead of assignment
...
Change-Id: I080668f86f0ab8b3bba857ee21411f907ae285c4
2015-10-30 11:08:36 +02:00
3bc5df7f32
UNO: no need to use OUString constructor when calling createInstance
...
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-30 08:59:59 +00:00
7cdbde4867
Initialize Sequence<beans::NamedValue> from initializer_lists
...
Change-Id: I216dcbd983dcf3df79df9fda371b93114540a9d8
2015-10-29 08:57:08 +02:00
644487a115
loplugin:unusedmethods
...
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861
Reviewed-on: https://gerrit.libreoffice.org/19231
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-27 08:20:43 +00:00
0b018d202d
tdf#39440: fix several warnings reported by cppcheck
...
Change-Id: I560d28b7cc67740c6479494d0e5aa62d2ac6ffae
Reviewed-on: https://gerrit.libreoffice.org/19587
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-10-25 22:31:44 +00:00
1579dcb11e
Rename some "document name" params to "document URL"
...
...to match reality, cf. 7660e4dcecfb19ad8e9e21e5fe53637bd1b9dc6c
"tdf#89694 Password dialog for opening OOXML shows url-encoded path"
Change-Id: I9fdd204494374770186347e92aa0bd6e7093ffaa
2015-10-20 15:18:26 +02:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
c0096b5b84
Hold the SolarMutex while updating properties; thanks to sberg.
...
Change-Id: Id9dc4c7e083da2a8d44c7295a8b605de81bca1ef
Reviewed-on: https://gerrit.libreoffice.org/19272
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
2015-10-09 14:52:05 +00:00
f76b3dd039
Move SolarMutex down from tools to comphelper/ to make life easier.
...
Change-Id: I7dd21f30daa27e5de2848eb16aee9a610dd629d5
Reviewed-on: https://gerrit.libreoffice.org/19271
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
2015-10-09 14:51:44 +00:00
ccf8bdcf92
Create a wrapper to make listening for configmgr changes easy.
...
Change-Id: Ib58d04f9e046e604b24e0e338796a7a60aa1d6fd
Reviewed-on: https://gerrit.libreoffice.org/19253
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
2015-10-09 08:42:49 +00:00
fce720b3e4
comphelper: add string::join()
...
If there is a need for it, this could be extended later to work with uno
sequences and/or OUStrings as well.
Change-Id: Id0af8b1755c8e4b668720563d10a052337e1b2c9
2015-10-08 08:37:57 +02:00
9a1f09b93b
clang-analyzer-deadcode.DeadStores
...
Change-Id: Ifd016962dda31b312070745e7646879186d074e9
2015-10-05 09:52:43 +02:00
e209d115d4
remove old standalone Sun bug numbers
...
Sun bug numbers without any accompanying text are completely useless.
Fixed with
git grep -lP '//\s*#\d+#\s*$'
| xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.
Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 06:57:19 +00:00
c50eb68af3
Renamed wrongly prefixed boolean variables
...
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-09-29 18:33:40 +00:00
96fa0df15b
comphelper: replace for_each with range-based for
...
Replace complex uses of ::std::for_each with a range-based for-loop.
Change-Id: I57d3d2e830e7700b793e1836777cbe72504c6825
Reviewed-on: https://gerrit.libreoffice.org/18817
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-24 16:23:34 +00:00
1704221067
comphelper: add LibreOfficeKit::set/isViewCallback()
...
Change-Id: Iad0b2ee419327daf478f3ddda2378effe0184067
2015-09-21 07:30:23 +02:00
22b80ac8e2
boost->std
...
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-14 12:54:25 +00:00
1d6cd0146e
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: I957be579527123be25abca0b7dcb69295711abf8
2015-08-31 08:04:28 +02:00
6900bf41e2
o3tl/cow_wrapper: remove boost dependency
...
Remove boost dependencies from ::o3tl::cow_wrapper, and add
the necessary includes to files including checked_delete and
noncopyable that do not already include the necessary files.
Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686
Reviewed-on: https://gerrit.libreoffice.org/18125
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-08-29 22:51:36 +00:00
fe6c124da7
Remove demonstrated-useless comphelper::compare
...
Change-Id: Ifd1b38afb963255b76f0d821eb46e4c6a972128a
2015-08-21 10:34:04 +02:00
63de6ba249
There is no css::uno::Sequence<sal_uInt8> in UNO
...
Change-Id: Ibf5095fea20314180a4e002295c89f570d66d45f
2015-08-19 14:48:28 +02:00
39ce314c12
comphelper::isA(Type... -> Type == cppu::UnoType...
...
Change-Id: I1bfb99b1715a907a03af5a30df6c7a41f91fd2fb
2015-08-19 14:48:27 +02:00
d21260cdb6
Remove two silly typedefs
...
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
5da0dce19c
Consolidate isFileUrl checks
...
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-19 12:24:37 +02:00
4f87e9da41
loplugin: defaultparams
...
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
2015-08-11 09:48:17 +02:00
eab0ae6a51
cppcheck: nullPointerRedundantCheck
...
Change-Id: I5cac2cdb383de5448383434a910eb97061c29071
2015-08-10 12:13:30 +01:00
819fd24487
comphelper: replace boost::function with std::function
...
Change-Id: I042c97d8472c3afceffba36808687f382571e6c2
2015-07-31 21:24:24 +02:00
18110ca3bd
comphelper, desktop: fix MSVC mergedlib link failure
...
Duplicate symbols are easily avoided by removing duplicate code.
Change-Id: I9b598a44156d6ff71b0691e69ab8163b15e2e26f
2015-07-27 21:22:07 +02:00
d74436fb86
com::sun::star->css in comphelper
...
Change-Id: I4aa0b2d15f2a06cbbbf63a363f403ca6435ffbcd
Reviewed-on: https://gerrit.libreoffice.org/17365
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-27 11:01:04 +00:00
11f24bc2f0
tdf#92130 fix DoEvents to be recognized as keyword
...
Change-Id: I24868acec66a72abbb52b8026ed3a092dbd97632
Reviewed-on: https://gerrit.libreoffice.org/17347
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2015-07-25 23:44:03 +00:00
bc9a8ddbb7
tdf#82744: fix WebDAV lock/unlock behaviour - part 2
...
Changes done to the code in framework, comphelper and unotools,
in no particular order
- add an interaction handler dedicated to WebDAV
The stock interaction handler can be missing depending on the need of
the framework performing its tasks, so a dedicated handler is
provided, this one is always present.
- force opening of a WebDAV file.
A WebDAV file sould be open r/o even if explicitly requested to open
as r/w.
This is a limitation of current WebDAV implementation, not of the
standard.
This change is needed in order to reopen correctly a file as
requested by a 'Edit Mode' GUI command.
Change-Id: I5368fa2c0511f1630e6d6139c6a986d33aa19082
Reviewed-on: https://gerrit.libreoffice.org/17182
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-07-22 16:17:04 +00:00
a890a7696f
tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants, for comphelper.
This also includes extra changes in other modules
required accordingly.
Change-Id: Id1537f46f1c90f760a0d8987a6dafa0e1da03b8f
Reviewed-on: https://gerrit.libreoffice.org/16929
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-20 07:06:22 +00:00
e363123a24
loplugin:simplifybool
...
Change-Id: I928325376b97ddd312af0f0a71187f29be607c6a
2015-07-16 14:00:16 +02:00
5b2f823194
add a SAL_RAND_REPEATABLE for repeatable random nums
...
merge the formula and comphelper ones together
Change-Id: I2e7e2cdb176afc6982e384fa1e007da5b914e6f0
2015-07-10 08:58:20 +01:00
ffa8892c5a
Fix typos
...
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-04 10:23:17 +00:00
10a7c828be
coverity#1308587 Uncaught exception
...
Change-Id: I45e699ebf255e7d933a3b5d77717dcd7583d8383
2015-06-29 12:58:03 +01:00
b55166d266
Revert "return and use std::vector from OInterfaceContainerHelper"
...
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29 10:11:53 +02:00
e57314f61f
return and use std::vector from OInterfaceContainerHelper
...
since most of the time we don’t need a heavyweight uno::Sequence.
Adds a new method getElementsAsVector().
Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a
Reviewed-on: https://gerrit.libreoffice.org/15747
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-06-29 07:25:22 +00:00
