3f50c6e050
java: remove ((unnecessary)) parentheses
...
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05 14:55:16 +02:00
ff3b3bed94
java: make inner classes static where possible
...
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-11-05 13:43:01 +02:00
1716b3a338
remove some useless comments
...
found with git grep '// /'
Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-13 10:07:49 +02:00
19b85e90ab
Fix typos
...
Change-Id: Ib30f4e5f16518cbbe71cf03998513ebd8c2a4d1a
Reviewed-on: https://gerrit.libreoffice.org/18949
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
Tested-by: Oliver Specht <oliver.specht@cib.de >
2015-10-02 07:55:15 +00:00
799cc41b53
Fix typos
...
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-07-08 05:48:18 +00:00
465489d97a
Fix typos
...
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-07-03 09:43:46 +00:00
efd4bfa818
java:regulatize the order of 'final' and public/private
...
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.
Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-06-11 09:34:00 +00:00
275f0c7b25
Let JUnit take care of exceptions
...
Inspired by commit
4dd0ac62855c5b9382cac004c7eebb9bed983a2b
Change-Id: I6ca29aecde357a3cb5852acfc9b5443761052960
Reviewed-on: https://gerrit.libreoffice.org/16094
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-06-05 13:17:50 +00:00
5fe011ae02
split forms unoapi test for performance
...
- test previously took 2m51s here
- slowest part is now 54s
Change-Id: Ib81fcb1a6e27dd54e0c3a319ff065166d57654ff
Reviewed-on: https://gerrit.libreoffice.org/15959
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com >
2015-05-29 11:54:05 +00:00
9b8fb077d2
java: inline some test properties
...
Change-Id: I8be2ee13652ed7223e41765811db577ecc1c85d6
2015-01-13 08:42:56 +02:00
43cc8ad33e
java: remove dead code
...
found by UCDetector
Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-05 08:23:29 +02:00
567592c9e2
java: don't synch on an object and also assign to it
...
Change-Id: Ie0a098e935e640f10b77d259c96bbd1c604d701e
2014-12-19 10:41:55 +02:00
f8fbef2653
java: remove more test skeleton code
...
Change-Id: I37a82554de4f77be7e0fb3e42245a70b53beb83c
Reviewed-on: https://gerrit.libreoffice.org/13476
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-15 12:36:12 +00:00
7557f23b31
java: reduce visibility of fields and methods
...
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-11 06:09:03 +00:00
9adb820158
java: simplify the getMSF() methods
...
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3
Reviewed-on: https://gerrit.libreoffice.org/13406
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-12-10 08:04:58 +00:00
5d60214678
java: remove some comment noise
...
Change-Id: I1c258b853097448d4a59334d915e94dba4c7eb34
2014-11-25 10:34:27 +02:00
1658c017a2
java,framework: remove unused vars and parameters
...
Change-Id: I7df5ff730436b95cb93af9f813d7bc572da2b951
Reviewed-on: https://gerrit.libreoffice.org/13098
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-25 05:05:24 +00:00
0063cf2856
java: make fields final where possible
...
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
bb437029c1
java: convert fields to local variables where possible
...
found by PMD
Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:03:29 +00:00
1e48bfafdd
forms: The if statement is redundant
...
Change-Id: I1d339ea6052e648acf4405d2d40795c82ee043ca
Reviewed-on: https://gerrit.libreoffice.org/11713
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-10-30 14:24:48 +00:00
03c7c26cbe
java: final fields that can be static
...
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
12b01b920f
java: no need to call String.valueOf to append to a String
...
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-17 08:26:19 +02:00
9341bf3dc3
java: when rethrowing, store the original exception
...
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-16 12:27:15 +02:00
bbd5a30411
java: ensure that the stream is cleaned up before the method returns
...
Change-Id: Id3efeda2fd66173ba2f5662eaacb3629da54573d
Reviewed-on: https://gerrit.libreoffice.org/11991
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-16 10:25:18 +00:00
02ace92aba
java: optimise calls to toArray
...
passing in a correctly sized array requires one less allocation
Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
2014-10-07 13:20:01 +02:00
4173bc5f7e
forms: enhanced for loop
...
Change-Id: I0c83d6fce9440f5d8b23e5f1bfca71d8f61d056b
Reviewed-on: https://gerrit.libreoffice.org/11719
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-10-01 19:44:53 +00:00
4badca0740
forms: use Arrays.toString in integration.forms.RadioButtons
...
Change-Id: I797692857c874d879192ca9a4ff73b98ed5ebd86
Reviewed-on: https://gerrit.libreoffice.org/11721
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-09-30 17:42:22 +00:00
73d6c6b51b
forms: replace StringBuffer with StringBuilder
...
Change-Id: Iee1b7ea214e5ed2fdd8bd5fe93dc16fbaaf312a8
Reviewed-on: https://gerrit.libreoffice.org/11720
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2014-09-30 17:42:12 +00:00
1c70f59c13
forms: the assigned value is never used
...
Change-Id: I8eadc27ba8880630ec93c68145969f3e8ba6c189
Reviewed-on: https://gerrit.libreoffice.org/11712
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-30 12:19:10 +00:00
62bd1d1783
forms: remove import from the same package
...
Change-Id: Ia15b4586e183bcd24a47c1a072c4d6e8ca280e98
Reviewed-on: https://gerrit.libreoffice.org/11714
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-30 12:16:29 +00:00
bf7ddfdeb7
Fix java.util.Calendar.set in integration.forms.DateValidator
...
Change-Id: I1bd87c623b923469c325ebfcba4ba82e2a648ae2
Reviewed-on: https://gerrit.libreoffice.org/11694
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-29 12:54:30 +00:00
72f50083e7
forms: getMonth() and getYear() are deprecated in java.util.Date
...
Change-Id: I31664bbd8c1c3b02e8a7381226d4d558b37466a2
Reviewed-on: https://gerrit.libreoffice.org/11690
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-29 12:44:30 +00:00
16417688ef
forms: Pass array of length equal to the size of the collection
...
Change-Id: Id880953105f6100b15cd78f48ce0c8dbcb7ffb8d
Reviewed-on: https://gerrit.libreoffice.org/11687
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-09-29 08:14:26 +00:00
0ce1267ae2
remove more unnecessary constructor declarations
...
Change-Id: Ie5a243006b112c2e6daf12992f3dba8baf12748d
2014-08-20 12:12:43 +02:00
c0415d5f1e
java: remove unnecessary constructor declarations
...
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor
Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
60f152caee
java: avoid unnecessary comparisons in boolean expressions
...
i.e. stuff like "x == true"
Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20 10:35:53 +02:00
4b4bff3402
java: no need to instantiate String objects directly
...
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
0764292c5d
java: use 'Short.valueOf' instead of 'new Short'
...
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
ff0ad0493e
java: use 'Integer.valueOf' instead of 'new Integer'
...
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc
java: use Boolean.valueOf instead of instantiating Boolean objects
...
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
56ef5533fc
java: classes in java.lang package do not need to be fully qualified
...
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
0d916bb240
java: remove unused imports
...
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
ac5954d7c5
java: remove commented out code
...
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
01c042471d
remove unnecessary use of Java reflection
...
Change-Id: I1cbbd8ee34684ec0fd74cd59529276b31eb7d1c2
2014-08-13 13:34:42 +02:00
34bcf9b498
java: remove dead methods
...
found by UCDetector
Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
68cd011c90
java: reduce scope, make some methods private
...
found by UCDetector
Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
70f56bc22f
java: reduce scope, make member classes private
...
found by UCDetector
Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
da677dfd59
java: reduce scope, make fields private
...
found by UCDetector
Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
14d1a11ec4
java: reduce scope, make constructors private
...
found by UCDetector
Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-13 08:49:22 +02:00
5656fe58a0
java: fix broken javadoc tags
...
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12 09:41:31 +02:00
