wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
385,479 Commits 5 Branches 0 Tags
ba3a9184045f7862ee94de8b3210dcbe9558f61a
Commit Graph

1163 Commits

Author SHA1 Message Date
Noel Grandin
a78182a993 loplugin:unusedfields in include/package,include/registry 
Change-Id: Iadba30885ba3bab7aaee58e298a9dc6b22c8b977
 2015-11-25 08:25:09 +02:00
Noel Grandin
56b2a2d874 loplugin:unusedfields in oox,package,reportdesign 
Change-Id: I83d03dcc76b5f0d54ebb0513ae972acb0db8eef1
 2015-11-23 08:26:11 +02:00
Noel Grandin
2554efabb6 use comphelper::containerToSequence 
in chart2, we remove a local equivalent of the method

Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
 2015-11-19 09:33:29 +02:00
Noel Grandin
8569c6d0ad use initialiser list for Sequence<OUString> 
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-16 08:35:42 +00:00
Noel Grandin
25aec383f9 use initialiser for Sequence<OUString> 
replaced using:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)'
| xargs perl -0777 -pi -e
"s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9
Reviewed-on: https://gerrit.libreoffice.org/19969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 12:18:55 +00:00
Noel Grandin
8e234c5b7d use initialiser syntax for Sequence<OUString> 
replaced using the script:

git grep -lP 'Sequence.*OUString.*\(1\)'
  | xargs perl -0777 -pi
    -e "s/Sequence< OUString > (\w+)\(1\);
.*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g"

Change-Id: I23688a91562051a8eed11fc2a85599545c285c34
Reviewed-on: https://gerrit.libreoffice.org/19967
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 10:13:08 +00:00
Stephan Bergmann
1fc2fe74f2 loplugin:nullptr (automatic rewrite) 
Change-Id: I1e5338558bc57afe51db57655550e9b7246f7214
 2015-11-10 10:31:33 +01:00
Jan-Marek Glogowski
912c034453 Don't check version field from local ZIP header 
Our current Maven based Java toolchain produces JARs, which
have a different "version needed to extract" in the ZIP local
and central directory header.

I had a look at 7zip and unzip and they already ignore the version
but compare other data LO already ignores - sig. The "standard"
document from PKWARE doesn't help.

So just compare the file path and calculate the data offset and
otherwise ignore all (duplicated) information from the local index
and rely on a correct central directory entry. Various programs
produce(d) "broken" ZIP files; even LO at some point (see git log).

Change-Id: I8d63abb0d49a1087c7654f401b62355c147c3118
Reviewed-on: https://gerrit.libreoffice.org/19779
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
 2015-11-05 16:00:58 +00:00
Noel Grandin
5ced1a6e42 use uno::Reference::set method instead of assignment 
Change-Id: I1c7240fe2e2b5eb825f028ca7502e5ba8793046b
 2015-11-04 14:42:23 +02:00
Noel Grandin
8d80b5be02 com::sun::star->css in package,pyuno 
Change-Id: I7b7b0e7fea2d1a2b9f6f5501ad5e0b8c1b4a17b9
 2015-10-23 15:14:45 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann
db34ab81ae clang-analyzer-deadcode.DeadStores 
Change-Id: I823aab2038eb08f4061e353b5fafc12b8e60e671
 2015-10-07 15:43:44 +02:00
Noel Grandin
8a248d69cc loplugin:mergeclasses 
in this case, just rename the baseclass so that it matches the
other places we do this

Change-Id: I21704db7352f72e43636dde9e92c8bef61b7e251
 2015-10-06 09:26:14 +02:00
Andrea Gelmini
3764f7435e Fix typos 
Change-Id: Id27f5a357c1333dec5c24c4f5e0fdaed7a775774
Reviewed-on: https://gerrit.libreoffice.org/18963
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-09-30 10:59:35 +00:00
Andrea Gelmini
9f6cb675b0 Fix typos 
Change-Id: I013414cf10e25acd5216643855aaa230258a1b5f
Reviewed-on: https://gerrit.libreoffice.org/18962
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-09-30 07:03:18 +00:00
Caolán McNamara
3a00aaef2a boost->std 
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-18 07:59:14 +00:00
Michael Stahl
6fcaaca6cf comphelper: fix MSVC --enable-mergedlibs build, OFOPXMLHelper 
The OFOPXMLHelper class causes duplicate definition link errors
due to its WeakImplHelper base class.

It turns out that the OFOPXMLHelper class itself is only used by other
exported functions in comphelper itself so just hide the
implementation detail.

Change-Id: I3ac8c561af703193cc2609e2c799b630a0d43127
 2015-09-01 18:25:47 +02:00
Takeshi Abe
5ba6aafa20 package: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: If88e1d741075e86997c91dc2c59eeebe45f67c1f
Reviewed-on: https://gerrit.libreoffice.org/17980
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-26 06:35:34 +00:00
Stephan Bergmann
5da0dce19c Consolidate isFileUrl checks 
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
 2015-08-19 12:24:37 +02:00
Stephan Bergmann
0b9b5f833c Simplify ZipPackage::isLocalFile check 
(vnd.sun.star.wfs is long gone)

Change-Id: I3e25f1728504cbad07bb97187a7bac23b33695dc
 2015-08-18 15:32:14 +02:00
Caolán McNamara
a19e2064c0 avoid possible leak on exception 
Change-Id: Id3c16e5fedc5e57c8daccafa25bdb2fbbd0131b0
 2015-08-17 14:55:14 +01:00
Caolán McNamara
ef698035aa Related: tdf#88314 delete temp files 
clear to close the inputstream before attempting to delete the temp file, which
is plausible as the windows-specific failure in earlier attempts at this

Change-Id: I751aa3a098dd960f56b77a5f5fc93783c1060556
Reviewed-on: https://gerrit.libreoffice.org/17531
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-07 07:53:18 +00:00
Caolán McNamara
458bf08125 Resolves: tdf#88314 close temp file after each thread completed 
Change-Id: Ic2eec30cfb5f61c53777eefeeb8bad6f552da2fc
Reviewed-on: https://gerrit.libreoffice.org/17355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-08-05 22:15:54 +00:00
Norbert Thiebaud
33a21d37f3 Revert "Resolves: tdf#88314 close temp file after each thread completes" 
This reverts commit 738cf411e9315d17c7eb8be47ded643a00dfe5c5.

It brokes windows in https://gerrit.libreoffice.org/#/c/17289/
as per http://ci.libreoffice.org/job/lo_gerrit_master/4465/Gerrit=Gerrit,Platform=Windows/

was pushed despite that.. :-(
 2015-07-26 00:23:50 -05:00
Caolán McNamara
738cf411e9 Resolves: tdf#88314 close temp file after each thread completes 
and reopen them when we need their data.

That way we don't have as many open files as substreams in the
package, so we don't run out of file handles

Change-Id: Ic124e275abf15f4578c77ee271d185f40cb844b1
Reviewed-on: https://gerrit.libreoffice.org/17289
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-07-24 13:24:55 +00:00
Noel Grandin
a792aa2c48 loplugin:unusedmethods toolkit,package 
Change-Id: I83618cd2fd12fb0c1691dc7255fc7192e68649cd
Reviewed-on: https://gerrit.libreoffice.org/17031
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-14 09:28:14 +00:00
Noel Grandin
e546ed01e6 loplugin:unusedmethods package 
Change-Id: I19d6bbb9288d72b99d1023b4983b1c3fff7570e8
Reviewed-on: https://gerrit.libreoffice.org/16811
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-07 11:01:11 +00:00
Andrea Gelmini
7f73bb5b44 Fix typos 
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510
Reviewed-on: https://gerrit.libreoffice.org/16709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-03 08:19:04 +00:00
Noel Grandin
371200675c drop yet another reimplementation of rtl::Reference (SotMutexHolderRef) 
Change-Id: I57f9dff931242405420bd45fae7ec5f13718707f
 2015-06-29 09:16:18 +02:00
Andrea Gelmini
69c88a32aa Fix typos 
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:28:31 +00:00
Stephan Bergmann
a77caf49cd loplugin:stringconstant: handle OUString+=OUString(literal) 
Change-Id: Ib9bf6e0919ee0cab02d826859317ea20cb64cabb
 2015-06-26 13:55:33 +02:00
Noel Grandin
4729774b24 remove unnecessary check for null when calling delete 
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
 2015-06-15 14:46:41 +02:00
Julien Nabet
3754474cde Typos 
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
 2015-06-13 09:13:52 +02:00
Caolán McNamara
8a3120ced5 cppcheck: noExplicitConstructor 
Change-Id: Id6291335945a8f10cef3afd1a2b3bae65fdf4562
 2015-06-11 14:56:14 +01:00
Noel Grandin
776a3f14f2 convert expressions like 'size() == 0' to 'empty()' 
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
 2015-06-11 10:07:08 +02:00
Noel Grandin
d203948fdb convert 'it.begin() == it.end()' to 'it.empty()' 
Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145
Reviewed-on: https://gerrit.libreoffice.org/16212
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-11 06:48:29 +00:00
Stephan Bergmann
430d760acd loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I1a3766bba2c157f20422d3ffb0c08f631b537724
 2015-06-08 16:26:57 +02:00
Caolán McNamara
525e514545 WaE: unreferenced local variable 
Change-Id: Ie04966936a406fefbbcd1d96d7d3d299f98a31ae
 2015-06-05 11:56:09 +01:00
Caolán McNamara
05661623c7 uncaught exceptions in parallel deflate threads on re-export of HTB23106 odgs 
Change-Id: Ib6aef478b8dcf1c7a7262ab60eef4d44da0de632
 2015-06-05 11:46:47 +01:00
Noel Grandin
55bc128636 loplugin:loopvartoosmall 
Change-Id: I86ff38a90018a2ddfb2db3babf67168b0e6257a5
 2015-06-01 09:58:56 +02:00
Stephan Bergmann
1cb0b37ad0 Rephrase comparisons between bool and sal_Bool 
...to cater for forthcoming loplugin:implicitboolconversion improvements

Change-Id: I88c0c4681137022005c3a4c418e91cb17bc17148
 2015-05-08 09:49:01 +02:00
Stephan Bergmann
0a48e0fb4e loplugin:simplifybool 
Change-Id: Ia4177cf1a4b0c06ef614b54298fd6f9224956afc
 2015-04-24 12:36:25 +02:00
Stephan Bergmann
2240118177 Improved loplugin:literaltoboolconversion looking into cond. exprs. 
...automatic rewriter fixes

Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
 2015-04-23 18:39:07 +02:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Caolán McNamara
a0f2bb7042 unnecessary cast 
Change-Id: I7c040b2539b9f7f923620a02d0a27e8e000fee4a
 2015-04-12 21:17:58 +01:00
Noel Grandin
35163715ea loplugin:staticmethods 
Change-Id: Ie348778ea666c24e95e048386547f301083a0017
 2015-04-09 10:13:18 +02:00
Stephan Bergmann
9222f5d065 A UNO Any can't contain an Any 
...and css::uno::makeAny<css::uno::Any>() was never meant to be used.  Introduce
css::uno::toAny for the (template-code) cases that shall return an Any for both
Any and non-Any inputs.

Change-Id: Ifa977d73f1da71b2fedde7e8140b19497c4a0257
 2015-04-08 17:45:08 +02:00
Stephan Bergmann
c9c991a9af Reduce to static_cast any reinterpret_cast from void pointers 
Change-Id: I6979d9af3a97918593f0596df17c096bd3f4c4ad
 2015-03-31 13:15:43 +02:00
Stephan Bergmann
b857703113 const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: I313d61fc6e7be3a5513da83d3de9202237306739
 2015-03-26 15:33:33 +01:00
Matúš Kukan
ca5ff45597 tdf#90010 Partially revert "package: Do not bother with deflating jpeg images" 
This reverts commit 0843ade74e5848c0babad509b10c334b01847be2 for the case, when
the document is protected by password. Would be nice to fix properly later.

Change-Id: If159639d6f74de4e106e9dad382faac9d5de4a09
 2015-03-25 22:32:40 +01:00