Commit Graph

4618 Commits

Author SHA1 Message Date
4eea9f2146 handle varargs with first required and subsequent optional, tdf#71459 related
Change-Id: I56c66f516ba2a2e12cab4848c8c352315f27b3bb
2015-12-17 15:14:43 +01:00
dad412e07f Resolves: tdf#95440 SharedString are interned per document, re-intern
... if literal strings are copied with formula expression tokens.

Change-Id: I13526907bb6c2c605c6ed9584fa6e3f2b18623b8
2015-12-15 17:50:21 +01:00
7086ed5951 sc: replace boost::ptr_map with std::map<std::unique_ptr>
Change-Id: I800f8d4facaa6dc8eb04b2544ce0e9035af66442
2015-12-15 17:44:34 +01:00
0585d81a76 Bin silly 'STATIC DATA' comments
Change-Id: I50e3772b7b479d2cf1eb644c7334d0f987874ccb
2015-12-15 08:31:55 +02:00
e0d2acfa65 tdf#96447 : Show correct borders in border editor when multimarked
Change-Id: Icfa10e1662f6ac00110a8d301734a72dcacc1780
Reviewed-on: https://gerrit.libreoffice.org/20672
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-12-14 22:10:27 +00:00
9c1ba0988f geez, how about actually checking the Move() error return? tdf#92779 related
Handle failure condition where we know how to treat it, i.e. when
updating references, assert in all other places that so far silently
ignored it and implicitly assumed the failing Move() truncating at
bounds would be alright. In case we'll encounter an assertion we'll have
to inspect those places and decide what to do about it.

Noticed this error with a reference like B1048575 and inserting two rows
above, it became B1048576 instead of B#REF!

Change-Id: I00757f3ed2e305b591178047933ed60f1533317e
2015-12-11 14:44:41 +01:00
fb8a3fac5d loplugin:nullptr: More NULL -> nullptr automatic rewrite
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-10 08:06:06 +01:00
3200068c9e loplugin:nullptr
Change-Id: I8a1678d1677dbff82b6785834e63007c2c3e9924
2015-12-08 08:16:27 +01:00
c7b3783c67 loplugin:defaultparams
Change-Id: I1a55166217ace26c95f73f710d88d787fdc4e007
2015-12-07 19:41:28 +01:00
2e512174f2 tdf#34449 : ability of deleting borders of a cell from adjacent cell
Change-Id: Ieb13a9ea88faa220d1ee352b0e47268a7fda5f38
Reviewed-on: https://gerrit.libreoffice.org/19715
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-12-07 13:49:53 +00:00
bd8a89f208 sc interpreter: Don't hide S/W Interpreter behind an environment variable.
Instead provide a user setting that can be enabled so that the S/W Interpreter
is used on a subset of the operations.  The operations for which it is used
are controlled by a whitelist in ScCalcConfig::setOpenCLConfigToDefault().

Change-Id: I7d3f3a864fcb1231e5484ec23961f14fca1466c5
2015-12-01 16:40:44 +01:00
d46203b55d Resolves: tdf#95748 no group interpreter when calculations are running
Change-Id: I17283fc5e39da2d7222c302dd63522df69d0ad96
2015-12-01 14:12:20 +01:00
87ad170574 add DebugCalculationEntry::mnGroup
Change-Id: Ic8b6c661be7570479c271d3ce0aa750e13724fc7
2015-12-01 14:12:19 +01:00
6d7b984ed1 add DebugCalculationEntry::mnRecursion
Change-Id: I159cb1dcbe7a9678f7353292c3eab2fbc325d7f9
2015-12-01 14:12:18 +01:00
625a2f4240 add DebugCalculation::storeResultError()
Change-Id: I26ab76c5d53d606ddb141c9dadb534b4739a6c64
2015-12-01 14:12:17 +01:00
0222608159 sc: Introduce Abstract Base Class for ScMatrix, for a future rework.
We want to introduce another type of ScMatrix that will directly contain
DoubleVectorRefToken and operate on that.  The idea is that it is pointless to
construct a ScMatrix via lots of copying around, when we already have a nice
array of doubles.

Change-Id: I3e5d7b9e2e0f9b9bf350336a8582cfd852586b3f
2015-11-24 17:41:30 +01:00
70b09d9322 cppcheck: noExplicitConstructor
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
2015-11-24 10:35:44 +00:00
c43a3a5867 establish that Virtual Devices either match Physical Device depth or ...
are 1 or (rarely) 8 bit and lock that down.

Change-Id: I3d946ebef34ffb71c5adea7aa420af50e9584e05
2015-11-23 14:25:59 +00:00
05eda0dc19 loplugin:unusedfields in sc
Change-Id: If5123e676a27302f3e11475309bc748977c6f430
2015-11-23 08:55:53 +02:00
71f0e4e5e2 tdf#83126: Find All: Don't ignore Search Direction Rows/Col option
bAll (ie "Find All") seems a little tricky for GetBackward but not for GetRowDirection method

Change-Id: I47d2b378fb493bcdc1ad30902a3a677eedc50789
Reviewed-on: https://gerrit.libreoffice.org/20067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-11-21 14:33:28 +00:00
fd8c802533 solve 6/8 cases of the dreaded conditional logical format in matrix results
So we now have
=IF({1,0},TRUE(),42)  => {TRUE,42}
=IF({0,1},TRUE(),42)  => {42,1}
=IF({1,0},42,FALSE()) => {42,0}
=IF({0,1},42,FALSE()) => {FALSE,42}

instead of before
=IF({1,0},TRUE(),42)  => {TRUE,TRUE}
=IF({0,1},TRUE(),42)  => {TRUE,TRUE}
=IF({1,0},42,FALSE()) => {TRUE,FALSE}
=IF({0,1},42,FALSE()) => {FALSE,TRUE}

Not perfect but better..

Change-Id: Ib4970f3c4c1bea87130730b956a0a6754879c6e6
2015-11-21 00:03:26 +01:00
056bce9c61 sc: One more place needed when one wants to enable the S/W interpreter.
Rename the variable too when I am at that; it may be broken, but the user
knows what he/she's doing when using an env. var.

Change-Id: Ia457c477e5677e7f89a35b331df0933e2eb3f5b3
2015-11-20 22:50:43 +01:00
2224d88f6b editeng: wrong default item for EE_PARA_FORBIDDENRULES
Change-Id: Idad6192fd1e3049913fac3dd906264fde6d1914e
2015-11-18 20:41:29 +01:00
b442d5dd3c use unique_ptr for pImpl in sc/
Change-Id: I2516c83f8dfca1f1217be7dcb2a28f5dcd2f704e
2015-11-18 08:35:34 +02:00
05896a1641 sc: loplugin:badstatics
Not sure if there would be a performance penalty to re-loading these
icons every time, so move the static map from
ScIconSetFormat::getBitmap() to a member of ScDocument.

Change-Id: If560d70cea27e25396dd821d9e77a785e3b79820
2015-11-17 23:49:04 +01:00
c0f4898185 sc: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I59831588fb7bc7e907fbffb24ddfe068552b6492
2015-11-13 20:31:17 +01:00
442666210f sc: boost::ptr_vector->std::vector<std::unique_ptr>
Change-Id: I4360e3238407d9cc7d664c543868cdb66271dbe8
2015-11-13 15:43:11 +02:00
f73284fb86 new loplugin ptrvector - find bad comparison of container<unique_ptr>
Change-Id: Idb18ae1ca2f7c644680703dc3b7dd3cd6000e040
2015-11-13 15:18:06 +02:00
8325fcb56d cppcheck: noExplicitConstructor
Change-Id: Ife26f55c28c4631aec4ba4105225bfca72da8bff
2015-11-13 10:17:26 +00:00
5140fe150b sc: loplugin:badstatics: clear ScGlobal::xDrawClipDocShellRef
Change-Id: Iede68e39a449ad0ea4a07d0a349c70c523ad6633
2015-11-13 11:03:09 +01:00
343ec4b723 sc: boost::ptr_vector->std::vector<std::unique_ptr>
Change-Id: I21fdb9f503241c2fa38f3de059a1f674a6631c78
2015-11-13 10:54:20 +02:00
601fd58cc3 sc: boost::ptr_vector->std::vector<std::unique_ptr>
Change-Id: Ie152e03e6219495683ebc50d916406fff0e54b6d
2015-11-13 10:54:19 +02:00
e5e2f119ef sc: boost::ptr_vector->std::vector<std::unique_ptr>
Change-Id: I85eb08c85700a2a5e0bd0edaf46ca99fded9dbb5
2015-11-13 10:54:19 +02:00
f3ba19b37f sc: boost::ptr_vector->std::vector<std::unique_ptr>
Change-Id: I7bf6fad1ed2d0f8e9a42293e0ceec7fc3b59963f
2015-11-13 10:54:19 +02:00
c2defd97cb sc: inline LabelsType
Change-Id: I6035b73e170664d23c706a26c1dee953cd19c518
2015-11-13 10:54:19 +02:00
75aaa65a8f sc: rename ObjectSetType to ScDPObject
Change-Id: I64720c2678f702e895c9b91571d98c0059e02a27
2015-11-13 10:54:19 +02:00
a029ab3d48 sc:rename ItemsType to ScDPItemDataVec
Change-Id: Ib81da8bd2e934330deea6f862c6774db4df93603
2015-11-13 10:54:19 +02:00
99cc76e41b remove fixme comment and fragments of things that are done since long
Change-Id: Ia1daaecb69e4d2e42315edeb96f9d659a3efed0c
2015-11-12 19:48:27 +01:00
fd8c98861c loplugin:nullptr
Change-Id: I6dea86675c3220386e3d64cf03e82c3f33ae00ce
2015-11-11 16:49:10 +01:00
fa91dd31f3 5th step to remove tools/rtti.hxx
tools/rtti.hxx removed
completed the interface of some Sdr.*  Items
and removed pseudo items

Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11 10:49:30 +00:00
de29ac0953 loplugin:nullptr (automatic rewrite)
Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
2015-11-10 10:31:36 +01:00
8e36027e27 sc: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: Id80f6d6be9f5cb15448ea00299b8e371ccd812ee
2015-11-09 12:04:12 +01:00
3b49489707 sc: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I1929d105d46c373c40d1f53e7d933435118737d4
2015-11-09 12:04:11 +01:00
5fd6aa03c8 sc: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I74440dd6d7904fe9e6a59f7ff757f202d2718b07
2015-11-09 12:04:11 +01:00
6c80a8fe89 new loplugin: oncevar
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 08:34:40 +00:00
c337c48f9f WaE: redundant const_cast [loplugin:redundantcast]
Change-Id: I0a4007231747360cabc24adf73a0c131d30dd5cd
2015-11-07 01:55:42 +02:00
7d68b8e52f sc: replace boost::ptr_map with std::map<std::unique_ptr>
Change-Id: Ia2ac921664fd5b7336125a2f62bca932542b2286
2015-11-06 20:37:40 +01:00
37856f59d2 sc: replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: Iea907bd407d0a6d1d7fa8a5a98ae7a9b4bbed642
2015-11-06 20:37:39 +01:00
e53db9461e loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
Change-Id: Ief66447f04245b8ab0a4acbf097eb7283529d45d
2015-11-06 09:36:49 +01:00
ef6ddb3675 tdf#79983 - Fix to make calc sort lists case sensitive
Change-Id: I9d4aec8ccb395f8bf59f08d0f5ed461e99c9ea64
Reviewed-on: https://gerrit.libreoffice.org/19433
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-11-05 20:36:56 +00:00