ded7c4ba32
Typos
...
Change-Id: I7a161afb520c3f26be0d5846a3ef2300c558a7d2
2015-12-12 23:46:34 +01:00
ec3f724158
loplugin:unusedfields
...
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-30 10:34:38 +02:00
985d259e7d
Silence clang-cl warnings in gperf-generated code
...
Change-Id: Id30e7afb3024d94cacf392bcd72c952d5a2ba5c4
2015-11-28 08:44:52 +01:00
017aa343a4
Missing include
...
Change-Id: I1516acb038f08479cdd4ffd42d5af1e7ec555d10
2015-11-28 08:44:48 +01:00
e014761161
-Werror,-Wunused-private-field
...
Change-Id: I7e00f9b90fb910a8ac0fa934887d276ef2e0ba89
2015-11-26 13:07:35 +01:00
a508f639a0
mark UNO structs as SAL_WARN_UNUSED, where possible
...
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-26 13:26:25 +02:00
1f86864e97
loplugin:unusedfields various
...
Change-Id: I59d9f7f73677358b4ae57efda965d43718bdf0d5
2015-11-25 13:57:29 +02:00
990691b144
loplugin:unusedfields in sdext/
...
Change-Id: Ibf5083cde3553289b3a29c9b992800e4bd82e6e4
2015-11-23 13:30:53 +02:00
14b7524f65
Use std::vector instead of boost::shared_array
...
Change-Id: If28713daab4bb5cbdb450879c2dc2a265c62a4f3
2015-11-17 16:34:58 +01:00
96c26b0d9d
use initialiser for Sequence<OUString>
...
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"
Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-15 12:20:39 +00:00
db17d3c17c
new loplugin: memoryvar
...
detect when we can convert a new/delete sequence on a local variable to
use std::unique_ptr
Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc
Reviewed-on: https://gerrit.libreoffice.org/19884
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-11 07:16:20 +00:00
d930b6c2e6
loplugin:nullptr (automatic rewrite)
...
Change-Id: I8aec30601862feaeb99e3ce01adf61665688fa9a
2015-11-10 10:31:38 +01:00
6c80a8fe89
new loplugin: oncevar
...
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-09 08:34:40 +00:00
dd4c240818
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: I7efbeda973c2cfa2472eec5b3d309e8e22aa5d9b
2015-11-06 09:37:03 +01:00
8299b8b81c
Remove unused PPPOptimizerTokenEnum enumerators
...
Change-Id: Ia94becb796f71aa602c65375539f8cdafb270bca
2015-11-05 21:29:58 +01:00
ffde331fbe
Remove unused strings
...
Change-Id: I376a1a9c8198e71eb8fd893ca4382fd25bd55817
2015-11-05 09:18:22 +01:00
06302bb3d1
use uno::Reference::set method instead of assignment
...
Change-Id: I03a8cc8405e1e7ddf75fabd2ba7d85edddf5b30c
2015-11-05 07:41:29 +02:00
59b072e22b
yyyyy
...
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
b5db48ada1
no need to use OUString constructor in call to createInstance
...
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-11-01 15:25:43 +00:00
3bc5df7f32
UNO: no need to use OUString constructor when calling createInstance
...
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-30 08:59:59 +00:00
ab20a5888d
com::sun::star->css in sdext
...
Change-Id: I1720391c6842a75033aca4e1b852a8cb89ca1efa
Reviewed-on: https://gerrit.libreoffice.org/19638
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-29 06:52:29 +00:00
3569c58c0e
Remove obsolete version map files
...
Change-Id: Ic179264fe306bb2bca9797f10e26c0224fb1dd00
2015-10-23 15:10:09 +02:00
332056e197
loplugin:defaultparams
...
Change-Id: I4c6936e882455b0ef39169a904281a9124b61689
2015-10-20 11:46:27 +02:00
7000c07834
Fix building with --enable-pdfimport on FreeBSD.
...
Found-by: Don Lewis
Patch-by: Don Lewis
(cherry picked from commit 788b479fff17918d21d26f71ce33c4cea0835251)
Change-Id: Idb72387186a7575989292179d52e4629415e5741
2015-10-13 09:21:03 +01:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
b1a6a99b9a
presenter console: add 'Restart Timer' button
...
Use case is that the presentation is started a few minutes in advance,
so the audience can check if they are at the correct room, seeing the
title side. Then previously the presentation had to be stopped and
started again, so the presenter had an idea how much time the talk took
so far. The side effect of this workaround was that the audience saw a
short flash while the presentation was not running.
Fix this by adding a button to just restart the timer, then it's not
needed to stop/start the presentation manually.
The two icons are just placeholders for now, real design is still
needed.
Change-Id: Id67e7e53a339ea5672dfb1c261f63d43466e9eff
2015-10-06 07:47:54 +02:00
3ad8f409d7
Prefer getSelectedFiles to getFiles (sdext+qadevOOo)
...
Change-Id: I4827e47b7d67b0112c0f9023c0db4ce8975f06e1
Reviewed-on: https://gerrit.libreoffice.org/19126
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-10-04 14:32:30 +00:00
185f207ef1
Fix typos
...
Change-Id: I3ea8a90f0ec917b4e26335fcd31a5f7e0888589e
Reviewed-on: https://gerrit.libreoffice.org/18972
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2015-09-30 06:30:53 +00:00
5c26f79467
cppcheck: noExplicitConstructor
...
Change-Id: Ibb94d40706fced3c1c053fd58ef4e2af2d849587
2015-09-27 21:05:19 +01:00
335704695d
boost->std
...
Change-Id: I21ca18c23277423d106d990fd537d58108bd1084
Reviewed-on: https://gerrit.libreoffice.org/18679
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-09-18 13:46:27 +00:00
8ac129a59b
Handle IOException during filter detection
...
Change-Id: Ie2b8b65f0f2b7b34efbba478a7ccda7ef3719bd6
2015-09-10 16:39:24 +02:00
55b077ca4a
Work around bogus warning C4701: potentially uninitialized local variable
...
Change-Id: I9c5d9c53785828b3535c960f826ccd3720b2e4c3
2015-09-07 17:03:45 +02:00
419abc4ffd
clang-analyzer-deadcode.DeadStores
...
...the computation of nTop, nBottom was done in this curious way ever since its
inception with 108632dc97a720639df495de3b5d966ee286be95 "CWS-TOOLING: integrate
CWS impressaccessibility3"
Change-Id: Ib516e944d96dc10ff12d0a82c0d8c921b57b0466
2015-09-07 16:48:29 +02:00
5670937747
clang-analyzer-deadcode.DeadStores
...
Change-Id: I7c19ce1bde1eb405fe64aba7504fc511c0ab646e
2015-09-07 16:37:25 +02:00
e15d4b8ee9
sdext: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: I663029b736489b81ed4ccb5f7bd657fbaf091bdf
Reviewed-on: https://gerrit.libreoffice.org/18206
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-01 07:59:50 +00:00
c71c419c63
loplugin:stringconstant: OUStringBuffer: appendAscii -> append
...
Change-Id: I82330271362a428b2850d0f561770d35de1ee6b0
2015-08-31 08:02:03 +02:00
6900bf41e2
o3tl/cow_wrapper: remove boost dependency
...
Remove boost dependencies from ::o3tl::cow_wrapper, and add
the necessary includes to files including checked_delete and
noncopyable that do not already include the necessary files.
Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686
Reviewed-on: https://gerrit.libreoffice.org/18125
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-08-29 22:51:36 +00:00
7d769f9df5
loplugin: defaultparams
...
Change-Id: Ibf0ea539d2a95073a12f84964759d9c7a94baa7b
2015-08-20 13:52:17 +02:00
5da0dce19c
Consolidate isFileUrl checks
...
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-19 12:24:37 +02:00
a5b842f3aa
remove unused SfxFilterFlags values
...
from both the code and the XCU files
Change-Id: I47f1f33c3ad4a37e346e3b8020dd9d3e284ccb77
Reviewed-on: https://gerrit.libreoffice.org/17522
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-05 11:08:25 +00:00
902d61bc7f
sdext: replace boost::function with std::function
...
This one is a bit odd, wonder if that was a bug:
- aAction(aPredicate);
+ aAction(aPredicate());
Change-Id: I0ddd565b65fe4778a297486805fa7f7a12702224
2015-08-03 14:47:45 +02:00
2660d24a07
new loplugin: refcounting
...
This was a feature requested by mmeeks, as a result of
tdf#92611.
It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.
Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-03 06:37:16 +00:00
a45827b230
loplugin:unusedmethods
...
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-30 06:23:00 +00:00
e963a88912
formatting of public/private/protected section qualifiers
...
make it consistent across the codebase, no space between keyword
and the colon
Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-17 09:49:35 +00:00
e544f449ed
Fix typos
...
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com >
2015-07-08 12:21:19 +02:00
0c8dd8f503
loplugin:unusedmethods sdext
...
Change-Id: I9119e612a92d05f587a1f1e19ca21b2f95102891
Reviewed-on: https://gerrit.libreoffice.org/16809
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-07 09:09:03 +00:00
3dfdd18707
Fix typos
...
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1
Reviewed-on: https://gerrit.libreoffice.org/16710
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-04 10:22:11 +00:00
b51ba9e383
Work around const-ness issues in the GooString API
...
cf. <https://gerrit.libreoffice.org/#/c/16357 > "Revert the removal of cast to
build on old poppler"
Change-Id: I75184cec64b4f32e0cf9adedeb84c8591be4fc73
2015-07-01 09:20:18 +02:00
aade27554d
Fix typos
...
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-22 12:36:21 +00:00
0032fc0385
Fix check for broken standard library
...
The compiler's __GNUC__ etc. need not match the libstdc++ version used (esp.
when using Clang as compiler), and libstdc++'s __GLIBCXX__ macro doesn't inrease
monotonically with version numbers, so resort to a configure check.
Change-Id: I06de6b68324169863f6f5c31ae5d855e8b04cd6b
2015-06-19 15:25:53 +02:00
