Commit Graph

380472 Commits

Author SHA1 Message Date
c74ccac7cd sfx2: add SfxViewShell::libreOfficeKitViewCallback()
This is similar to the existing LOK callback, the difference is that the
existing one assumes there is only one SfxViewShell instance at the same
time.

This newer callback is precisely per-view, so model notifications can
invoke all view callbacks, while view notifications can invoke only the
callback of the relevant view.

This is just the framework, all actual client code has to be still
ported over (and then the existing callback can be removed).

Change-Id: I3d8f27740c69fcf6ffbbdce12db2ea088321493d
2015-09-21 07:30:23 +02:00
714257af17 SfxLokHelper::setView: check if view is already current
Change-Id: I9cf3a4887774657e0e205114688b088fc11c6822
2015-09-21 07:30:22 +02:00
d3446bc860 lokdocview: set view before calling lok::Document member functions
getTextSelection() is still to be done, but has to be moved to the
widget first.

Change-Id: I780a31f1dbce38b2b7398bfdacbbc1c40881229d
2015-09-21 07:30:22 +02:00
42844c2a8b Add missing lok::Document::setPartMode() wrapper
Change-Id: I5dd5f0cfb8b34621b18a35be682249e042d9b173
2015-09-21 07:30:21 +02:00
c9ebc92a1e LOK: allow postMouseEvent() in multiple views
Change-Id: Iafb08cb44a96dbc03d12367d21b4120063bd0222
2015-09-21 07:30:21 +02:00
a04b31c9fa LOK: make getViews() be a member function of Document
Just to be consistent, as all other view-related member functions are
there, too.

No real impact, as only the unit test uses this so far, and it always
works with a single document.

Change-Id: I46f1ed8265ab95017986ab45c1b510e961192241
2015-09-21 07:30:21 +02:00
f2e55ea106 gtktiledviewer: use setView() before postKeyEvent()
Also in SfxLokHelper::setView() set the current view shell directly,
GetFocus() in VCL may be a NOP for hidden windows.

With this, the Writer layout dump shows that two Gtk windows can have
different cursor positions correctly.

Change-Id: I81890c1d8ad7972f1194db3d5f2e9d8a39fc2f87
2015-09-21 07:30:20 +02:00
8cb6094447 Use SfxViewFrame::Current()
Allows getting rid of vcl::ITiledRenderable::getCurrentViewShell(),
which would do the same, just not implemented outside Writer.

Change-Id: Id26ceca560fb9002dc2d5c740c411b9c4a149523
2015-09-21 07:30:20 +02:00
46588c42a5 lok::Document: add get/setView()
Change-Id: Ic3bce8f01d7e048e853c063c4bce1255845c60d0
2015-09-21 07:30:20 +02:00
855e1bac1d gtktiledviewer: add setupWidgetAndCreateWindow() to avoid copy&paste
Change-Id: Ibbbaaa1c148cfd4578ad37e0f99b62ab885a1a83
2015-09-21 07:30:19 +02:00
b3498e9fcd lokdocview: set up the widget in all windows
With this finally the number of GTK+ windows always match the number
returned by SfxLokHelper::getViews().

Change-Id: Ia45bef7dea86b80cfac00e2ad7c1a16d7f5b507b
2015-09-21 07:30:19 +02:00
e6e5c248e5 lokdocview: avoid GTK+ calls in openDocumentInThread()
GTK+ calls should be made from the main thread.

Change-Id: Idcfa46d427d6e35fc544246a691bafc72f75a74c
2015-09-21 07:30:19 +02:00
c1d7214531 gtktiledviewer: set up a new GtkWindow for a new view
Change-Id: I9dcb5871c231a49bcd65a1187df6c3c81f92bd55
2015-09-21 07:30:19 +02:00
8d8a8e1a2e gtktiledviewer: factor out setupDocView() from main()
Change-Id: Iac803f03267859c11f0f9090346b09b90c115b76
2015-09-21 07:30:18 +02:00
2b69ce33ed gtktiledviewer: factor out createWindow() from main()
Change-Id: Ib7ccd2192247805205b65e5e8da67bcc826f4d31
2015-09-21 07:30:18 +02:00
4fd59356cb lokdocview: allow not calling documentLoad()
Change-Id: I2ff57c4be11cd3908bc951ebf572a2c02e2c4585
2015-09-21 07:30:17 +02:00
d51e3f7877 gtktiledviewer: allow findbar in multiple windows
With this, all previously global data is now stored per-window in the
g_aWindows map.

Change-Id: I45b4449ee7d516106ea0b039d1af97db49edf759
2015-09-21 07:30:17 +02:00
d8bf31e129 gtktiledviewer: allow part selector in multiple windows
Change-Id: Ib31fca3d8b4119704fb1a5c3cee885e7c239c247
2015-09-21 07:30:16 +02:00
bec8a1b74f gtktiledviwer: tool item registration is per-window
Change-Id: I11a6cda7b9b8949c48c201c4bd467b49f2f43ca5
2015-09-21 07:30:16 +02:00
91d67ec9a5 gtktiledviwer: allow GtkToolItems in multiple windows
Change-Id: I6c19a9bdd34163d12047929170e5cfa7bb9a5820
2015-09-21 07:30:15 +02:00
36fa8d443a gtktiledviewer: allow multiple status bars
Change-Id: I84c4102937deee662814c41607ee8de380a067f2
2015-09-21 07:30:15 +02:00
f6ef6af23d gtktiledviewer: allow multiple DocView instances
Change-Id: I4e8a08d71a94445e8fd30563867a2741cad862e5
2015-09-21 07:30:15 +02:00
20df29e660 gtktiledviewer: these globals can be static
Change-Id: Ife0a4bb1102f6135e297dc69ba5b52b89a5dd9dd
2015-09-21 07:30:14 +02:00
d990a8762e sfx2: add missing header guard
Change-Id: Ide261670be475f5d54d9d12c701ad82470396aeb
2015-09-21 07:30:14 +02:00
10a0cad9d6 lok::Document: add destroyView()
Change-Id: Id9e92593217541b4123e95279019cec3c958056c
2015-09-21 07:30:14 +02:00
4f62c14748 CppunitTest_desktop_lib: fix reported name of failed test
Change-Id: Iaa9effdcf6d6c6b2292e3fc7b666afdb3678694d
2015-09-21 07:30:13 +02:00
2e523afe61 lok::Office: add getViews()
Change-Id: Iabfb0f2a19106dc4a6bdae45f9e85d76c68a973e
2015-09-21 07:30:13 +02:00
179a0d0ea0 gtktiledviewer: add button tooltips
Change-Id: Ifad67adf80761118bbbfb110cbadd493214fee93
2015-09-21 07:30:12 +02:00
655c7877a0 lok::Document: add createView()
Change-Id: Ic871ec41992b611b10958799b2dc12375a91efe4
2015-09-21 07:30:12 +02:00
58b5c13b00 sfx2: add SfxLokHelper
This is meant to be a class that is visible outside sfx2 (so e.g.
desktop can use it later), but has access to various sfx2 internals.

Change-Id: I83204963492b11c1c4a621e86528a64fba27acf3
2015-09-21 07:30:12 +02:00
7b0de91faa vcl::ITiledRenderable: add getCurrentViewShell() and implement it for Writer
Change-Id: Ic936746f3d473e15f5a1589cba35173778b442c6
2015-09-21 07:30:11 +02:00
e13510cf2c sw layout dump: show selection ranges from all shells
Change-Id: I89d0f3c66f3939fc6795892d727d782c3f8bbda3
2015-09-21 07:30:11 +02:00
f78216d15d fix regression with chart sidebar list position
regression from 66f1e65fde85168ae582ea75f72ebb290caa0a08

Change-Id: I92a5d6926ee912d4802f074d1e4aae63cf672ab1
2015-09-20 21:57:28 +02:00
85eb1e5148 use localized string for title text, tdf#94294
Change-Id: Id27e5c3794b728ce79d63b6c7d552df0cc1ba239
2015-09-20 21:33:58 +02:00
e1afea91e9 remove unnecessary base class
Change-Id: Iaa1890d11f9bfba7a8b0996b9adf79b781bcd8bf
2015-09-20 21:33:58 +02:00
e93f9b39d3 disable a few more controls when no border is set, tdf#94291
Change-Id: I687616e80685ea4cc462a48e55882c44745e003f
2015-09-20 21:33:58 +02:00
963c35d7cb loplugin:staticmethods
Change-Id: I2df14df9dd03c23876da57e943e6714f1a52843b
2015-09-20 21:32:13 +02:00
b7e2810924 remove unused _SCALC_EXE #ifdef
Change-Id: I4e9a025d2aa497037425dd982488c1351b4a7c3a
Reviewed-on: https://gerrit.libreoffice.org/18733
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2015-09-20 19:25:58 +00:00
6904d2b41c Remove unused impGetOverflowingParaObject
Change-Id: Ice77d390ba6eaa327c868eed1db93f3e0bfac18e
2015-09-20 20:57:21 +02:00
fb4bf4580f loplugin:stringconstant
Change-Id: I5337566bad2a63de4ead73022bfafba7f050059a
2015-09-20 20:54:52 +02:00
2ff09b059a loplugin:loopvartoosmall
Change-Id: I5e3506492f75e0f8e7ce770713b424a854d9813d
2015-09-20 20:53:12 +02:00
f1611d52cc convert SC_FILL constants to scoped enum
Change-Id: Ib5399440c4f63ec6b3753ffafd243626aef65d49
Reviewed-on: https://gerrit.libreoffice.org/18723
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-20 16:34:56 +00:00
20b7959ab9 WaE: loplugin:cstylecast
Change-Id: I953467bd0713a462cb9dcf66c8119eb1883553a2
2015-09-20 16:46:31 +03:00
16964a87c0 WaE: loplugin:literaltoboolconversion
Change-Id: Ib7cf1a0d4033fe2807a21de2c4bbcddb079e4128
2015-09-20 16:45:02 +03:00
aac58c6275 WaE: loop index type 'unsigned int' is narrower than length type 'size_t'
Change-Id: I2e0999468686e8c5521b7342903df5a68f8648d0
2015-09-20 16:42:53 +03:00
f66ecf00ed WaE: passing OUString by value, rather pass by reference
Change-Id: Ic6842bdb382c05912399db86aa08765d8653a019
2015-09-20 16:41:34 +03:00
2f5cfa063e WaE: this method can be declared static
Change-Id: Ia1adfc8465e101e1e4c4bf75318c2f40d822c8ae
2015-09-20 16:36:27 +03:00
bdf1d60036 WaE: C-style cast from 'const drawinglayer::primitive2d::BasePrimitive2D' ...
... to 'drawinglayer::primitive2d::SdrBlockTextPrimitive2D' (performs:
static_cast) (BaseToDerived) [loplugin:cstylecast].

Change-Id: I5f4603335591ddd90a2241b7ddd96f0a1d6b6006
2015-09-20 16:31:38 +03:00
59019c6894 WaE: rewrite as call of rtl::OUString::isEmpty
Change-Id: I0dc1a59eaeefd1a55640b94a00142b0fe6696523
2015-09-20 16:28:18 +03:00
cc3e899fab WaE: this method can be declared static
Change-Id: I1b656cc53f00b866ed6e86d291149e7f1790f26f
2015-09-20 16:28:11 +03:00