wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
380,472 Commits 5 Branches 0 Tags
c74ccac7cd94eba052d21cf74e03e214d58942e4
Commit Graph

260 Commits

Author SHA1 Message Date
Caolán McNamara
33cddeea13 boost->std 
Change-Id: Iff14f69c200217c5d868978e8ffc06962b99ac09
Reviewed-on: https://gerrit.libreoffice.org/18568
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-14 19:32:42 +00:00
Daniel Robertson
87a2c1d5a0 tdf#88462 connectivity convert manual XInterface 
Convert postgresql driver ReflectionBase manual XInterface
implementation to use ::cppu::WeakComponentImplHelper.

Change-Id: I738bd7df33de9c0fe0e3242eb5a4fab6a8dcb3f0
Reviewed-on: https://gerrit.libreoffice.org/18207
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-09-03 08:08:31 +00:00
Stephan Bergmann
7bff36d45d loplugin:stringconstant: OUStringBuffer: appendAscii -> append 
Change-Id: I68b02ad101c4c2165b4618ed5d97cbffc2c43d2d
 2015-08-31 08:04:12 +02:00
Noel Grandin
8601307838 loplugin: defaultparams 
Change-Id: Id0a933d3507bc0f8145afa04effadf8475c8e210
 2015-08-14 10:52:46 +02:00
Noel Grandin
403c13487c loplugin:unusedmethods 
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-05 09:39:22 +00:00
Noel Grandin
3ff2e30ff6 cui,connectivity: inline some use-once typedefs 
Change-Id: I1b043031014a3e823cd614966984a2ac2be1ac71
 2015-08-04 08:55:56 +02:00
Takeshi Abe
1a24285dd5 tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants, for connectivity.

Change-Id: I3645a2855e903848936520ac854fc1039fc456e8
Reviewed-on: https://gerrit.libreoffice.org/16971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-17 07:17:37 +00:00
Takeshi Abe
871cd42b95 Fix an opposite condition 
... slipped in at 54013188b24a1a02491a2853f731461253065424.

Change-Id: Ib18b2f12d4ad97b9ec5dd771d5f13b35e0274e33
Reviewed-on: https://gerrit.libreoffice.org/16932
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-07-10 19:53:50 +00:00
Noel Grandin
54013188b2 cleanup some unnecessary direct usage of the OString/OUString C API. 
Change-Id: I6edee95aae1c169ce70063562a0c1b287e0c4735
Reviewed-on: https://gerrit.libreoffice.org/16861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-10 08:09:00 +00:00
Andrea Gelmini
87dc6c82d5 Fix typos 
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875
Reviewed-on: https://gerrit.libreoffice.org/16706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-03 09:02:48 +00:00
Andrea Gelmini
8a2efbb717 Fix PostgreSQL function name 
Change-Id: Ic089540c07c7fe7c85705fc3513411a7e2571a12
Reviewed-on: https://gerrit.libreoffice.org/16640
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
 2015-07-02 13:40:06 +00:00
Caolán McNamara
e678100a40 coverity#1308573 Uncaught exception 
Change-Id: Ie3ecffe0fe91572ffff6e124075e1be1ef978731
 2015-06-29 09:43:33 +01:00
Lionel Elie Mamane
5652313e8a postgresql-sdbc: fixup string2intarray 
this allows getGeneratedValues to work

Change-Id: Ia87e87afa8cdb01f1d39c84bc7d7143c101d8891
 2015-06-17 14:19:26 +02:00
Lionel Elie Mamane
eb0c95c56e postgresql-sdbc: include error message in SQLException 
Change-Id: I9d91503e6beb08f11368fc6b80fefb61f60d4486
 2015-06-17 14:19:25 +02:00
Caolán McNamara
8066c73940 cppcheck: noExplicitConstructor 
Change-Id: I2b5fba9cdd950349a8e8d22bbd7bb6e17f008920
 2015-06-15 11:11:42 +01:00
Julien Nabet
6e62d72b93 Remove include stdio (part1) 
Change-Id: I364aedbd8870c2bbd3440f144143c503dd7ff2c1
Reviewed-on: https://gerrit.libreoffice.org/15767
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-05-17 14:57:02 +00:00
Noel Grandin
71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann
17e74bf1a0 Replace remaining getCppuType et al with cppu::UnoType 
Change-Id: Id2361bd7b50f4724211661b024583b8a3445500b
 2015-04-01 08:36:20 +02:00
Stephan Bergmann
1b42acc95e Clean up C-style casts from pointers to void 
Change-Id: I6c7c31befd61cbf0800a62c08e7395ddf78e4b30
 2015-03-28 19:09:18 +01:00
Stephan Bergmann
d3d34a289b const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: If7e4e3cae1021529819e0b43ef334020ff8b7a43
 2015-03-26 15:33:29 +01:00
Noel Grandin
c7a50d072f new constantfunction loplugin 
Change-Id: Ie9b7a0c41fc4dbd2560ceff6bae9ab85357f518b
 2015-03-25 08:55:31 +02:00
Noel Grandin
3e8a7ce7df Revert "loplugin:constantfunction: connectivity" 
it seems to be causing unit-test and build failures

This reverts commit 5cbb51c009fa266e8418ef93799ac64e431c22f5.

Change-Id: Idc6372f98200b23828aa19b22a75b6b2b640d1ab
 2015-03-23 11:02:11 +02:00
Noel Grandin
5cbb51c009 loplugin:constantfunction: connectivity 
Change-Id: Ic1a71851a80ed2715969b0f00a0e59ab3a0593db
 2015-03-23 09:42:23 +02:00
Caolán McNamara
5a308b1239 V801: Decreased performance 
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
 2015-03-09 12:41:09 +00:00
Noel Grandin
a3646d5572 cppcheck: duplicate inherited member 
Change-Id: Iee20ca4523739eb082ea1fa8c1145891c0caed29
 2015-03-02 10:25:49 +02:00
Noel Grandin
4a87597e42 remove unused struct 
Change-Id: Icabf74fde82e917826f20ffdc8fcd71a26538bbe
 2015-03-02 08:59:19 +02:00
Caolán McNamara
a0c81e5ad4 V804: Decreased performance 
Change-Id: I484dd153e5d7f0664eac85595011d610f2b8df7b
 2015-03-01 21:14:52 +00:00
Stephan Bergmann
c6be3cf03b loplugin:deletedspecial 
Change-Id: I0faa47383f8952a74742a640ab2af602b4fcba8f
 2015-02-07 12:35:57 +01:00
Stephan Bergmann
4e3da621fe Some more loplugin:cstylecast clean-up 
Change-Id: I132d22e2af3cf673c17d8964f690d48990834884
 2015-01-28 13:50:37 +01:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual 
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
 2015-01-26 08:42:28 +02:00
Stephan Bergmann
141b01ac65 Some more loplugin:cstylecast: connectivity 
Change-Id: Iee1d11aef454284dbe050780c4308917c1a2b36f
 2015-01-20 09:06:46 +01:00
Lionel Elie Mamane
79b5bf5cab PostgreSQL statement: use :cppu::WeakComponentImplHelper 
Change-Id: I081d375b0249a3b0e47c1dd6db3f86fef272e7fd
Reviewed-on: https://gerrit.libreoffice.org/13925
Tested-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-01-15 13:01:00 +00:00
Lionel Elie Mamane
d7a6017e2a PostgreSQL statement: deliver promised XMultipleResults interface 
Change-Id: I0bb6df332a6666a0ae96bba38626b2626f880490
 2015-01-15 12:49:57 +01:00
Lionel Elie Mamane
1000d7499b PostgreSQL boolean more accurately described as boolean 
Let's see if this breaks anything...

Change-Id: Id7503f8059ca99ec155d72c275a7657280ee2bc6
 2015-01-07 16:03:12 +01:00
Lionel Elie Mamane
b39f07f1a0 protect agains past-the-end string access 
Change-Id: I651c7b062b454fad85eff8852f7e62804a0d0058
 2015-01-07 16:01:54 +01:00
Miklos Vajna
311a92f23b connectivity: fix gcc-4.8 build 
Change-Id: I2df7eb2af12f235cfa05bc75da32e8baf1455b5b
 2015-01-04 14:21:13 +01:00
Caolán McNamara
ca8787a981 boost::unordered_map->std::unordered_map 
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
 2015-01-04 12:51:09 +00:00
Stephan Bergmann
bca00da686 connectivity: Use appropriate OUString functions on string constants 
Change-Id: I10b2ddf9dcc83219fea8eb55783507eed52702e8
 2014-12-12 17:51:11 +01:00
Michael Stahl
15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Stephan Bergmann
fc0d57b7af Revert "use the new OUString::fromUtf8 method" 
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
 2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23 use the new OUString::fromUtf8 method 
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
 2014-11-06 13:51:10 +02:00
Noel Grandin
705c48d32e fdo#38835 strip out OUString globals 
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
 2014-11-05 08:44:19 +02:00
Stephan Bergmann
ad9498f8b8 More -Werror,-Wunused-private-field 
...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
 2014-10-15 15:58:56 +02:00
Noel Grandin
7d7b289da4 loplugin: cstylecast 
Change-Id: I114924d5e0407883b2e77016da3c2e3e55657b21
 2014-10-03 15:20:03 +02:00
Stephan Bergmann
ed95e1c561 connectivity: sal_Bool -> bool 
Change-Id: Id9458a3aa0928eedc87aec39f305b206e2638e67
 2014-09-12 13:11:59 +02:00
Tor Lillqvist
6492c8576e Make the "Mac-like" or "canonical" app bundle structure always used on OS X 
In other words, only executable files go in the MacOS folder. Dynamic
libraries and bundled frameworks (i.e., LibreOfficePython), and
nothing else, go in the Frameworks folder, and all other files go in
the Resources folder.

Especially, note that Java class files and rc (.ini) files also go in
Resources.

Such an app bundle structure is what Apple strongly suggests one
should use, and it has been hinted that future versions of code
signing and/or Gatekeeper will require such a structure.

There is still some ugliness thanks to traces of the historical
separation of URE from "the office". Like there are two separate
"unorc" files, one for URE, one for the LibreOffice application. IMHO,
this should be cleaned up, but is probably controversial.

(Eek! I now see there are actually *three* unorc files in the app
bundle. Not intentional. Need to fix that later.)

Change-Id: Idcf235038deb5b8e1d061734993e9f31869b7606
 2014-09-09 13:55:23 +03:00
Thomas Arnhold
c2034f3993 fixincludeguards: fix include guards 
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-06 19:16:40 +00:00
Noel Grandin
11383f56fb connectivity: remove SAL_THROW macro 
Change-Id: Id3bbb7a0d39a41b7106303f42d55ba4968235b63
 2014-06-05 08:17:47 +02:00