eb012bf0a8
editeng: com::sun::star->css
...
Change-Id: Ied65d2de394ce54cb2c35abb152cf58ac3139395
Reviewed-on: https://gerrit.libreoffice.org/18503
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-13 06:21:03 +00:00
267f401e2a
cppcheck: noExplicitConstructor
...
Change-Id: I2a1add8cf526cdb305ad99ccb138454a88f2fdbd
2015-09-07 09:56:07 +01:00
3bc69b1d0d
don't write SvxBackgroundColorItem via inherited SvxColorItem::Store
...
SvxBackgroundColorItem inherits from SvxColorItem and for backwards
compatibility with the StarOffice 5 binary file format (yes, really)
writes/reads only rgb and not the transparency value, so copying and pasting
text from a sidebar comment in writer to itself or another one results in a
black character background as the default COL_AUTO turns into black
Change-Id: I18b5105dd8e060b9e49dda6026e26d3a0f00d8f5
2015-08-27 14:45:02 +01:00
236714e86c
Clean up remaining utl::LocalFileHelper::Convert...
...
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040
"ConvertURLToSystemPath->getSystemPathFromFileURL" and
28f3464a571a23a2c16bd0980e9021b95d011511
"ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those
Convert... functionality with direct calls to the corresponding osl::FileBase
functions.
Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-19 10:48:42 +02:00
6b7354ae66
for testing allow disabling configmgr for time critical paths
...
Change-Id: I08021f18d53e1748927f8847649994f95252bbc2
Reviewed-on: https://gerrit.libreoffice.org/17844
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-08-19 01:04:00 +00:00
ef46917ff3
Put Polygon from tools under tools:: namespace
...
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.
Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
2015-08-17 02:07:43 +00:00
0db25f68ab
remove default value from SfxPoolItem::PutValue
...
more useful to make it explicit.
Specifically, otherwise my defaultvalue clang plugin would want to
remove lots of places that contains #define constants which, while
technically the same as the default value, convey semantic
information which is quite useful.
Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-08-14 09:16:06 +02:00
38023af6c1
loplugin:unusedmethods
...
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a
Reviewed-on: https://gerrit.libreoffice.org/17312
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-24 10:36:20 +00:00
dc7fc2074d
convert WALLPAPER constants to scoped enum
...
Change-Id: I3b4b4e8a94904e22823a263bd5446a2e1aa47661
2015-07-24 09:52:08 +02:00
3d2f43438d
loplugin:unusedmethods sd
...
Change-Id: I9b5399ace50db3259df2e619f28ae547a38e6c6d
Reviewed-on: https://gerrit.libreoffice.org/17254
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-21 09:05:41 +00:00
83ea8f2d72
Removed comment
...
No evindence of intn.hxx in all git history
Change-Id: I435f3082e0bb13b1e3129b49c7eaea80d75ea452
Reviewed-on: https://gerrit.libreoffice.org/17186
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de >
2015-07-20 21:27:12 +00:00
9f4f237a38
loplugin:unusedmethods svl
...
Change-Id: If86cc43fda4d138cf7f678d81fa2b35f68f3c03b
Reviewed-on: https://gerrit.libreoffice.org/17162
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-20 06:33:44 +00:00
7ab881a57d
loplugin:unusedmethods editeng
...
Change-Id: I15b2be5a9cd6e72447b674a65eabe9f89cb6ff12
Reviewed-on: https://gerrit.libreoffice.org/17115
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-16 08:37:25 +00:00
26ac3ee8b2
editeng, convert to typed Link<>
...
and remove SvxBrushItem::SetDoneLink since the field it sets
is unused.wq
Change-Id: Ide95a295fa8004f1ddab5e560f01d36d36658a72
Reviewed-on: https://gerrit.libreoffice.org/16943
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-13 06:58:01 +00:00
892455e72a
Simplify uses of comphelper::string::equals with constant argument
...
Change-Id: I7b12dd04f6811f71b776ee9168703434217b59c8
2015-06-24 15:27:28 +02:00
aade27554d
Fix typos
...
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-22 12:36:21 +00:00
3fa7b0b70f
Fix typos
...
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
Reviewed-on: https://gerrit.libreoffice.org/16310
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:25:13 +00:00
4729774b24
remove unnecessary check for null when calling delete
...
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15 14:46:41 +02:00
5a2e09989a
cppcheck:redundantCondition
...
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-15 11:56:55 +02:00
b226928c6d
cppcheck: redundantCondition [part1]
...
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-14 12:17:55 +02:00
f222de1de0
Remove unnecessary Bool2Any
...
(It feels better to use explicitly bool-typed css::uno::makeAny<bool>(x) rather
than implicitly typed css::uno::makeAny(x) or css::uno::Any(x), in case x is not
already of type bool.)
Change-Id: I282b3764bb207aeae9f13cc981e68e8ef2b8ab93
2015-06-10 22:40:41 +02:00
72c7b9829d
Bool2Any wants to get bool instead of sal_uInt8
...
which is what GetTransparency() returns. Iow, do what SvxBrushItem
does :)
Change-Id: Ief65ab75d8c0955c1ec264611a70dcc693412170
2015-06-10 17:00:55 +02:00
321f4925a7
tdf#88055: Don't export transparent background colour as white
...
The fix is twofold:
1. retrieve transparency from colour in SvxBackgroundColorItem
(add QueryValue, PutValue methods, use additional memberID to
retrieve alpha channel as a bool property)
2. add CharBackTransparent bool property to Draw [text] shapes,
xmloff needs it to be able to output 'transparent' string instead of
'#XXYYZZ' colour code in ODF format
Change-Id: Id830bd18fd6da5d9a46e2a94aa254d5d2a6b7ebb
Reviewed-on: https://gerrit.libreoffice.org/16182
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-10 14:29:09 +00:00
7f4230675c
tdf#90804 remove SfxFieldUnit enum
...
b78d881520f2eb658180e2c90ffee3d30a80f0ae removed unused values
from SfxFieldUnit enum. This broke the mapping between SfxFieldUnit
and FieldUnit. In fact SfxFieldUnit was redundant.
Change-Id: I13c7e7d708c6eeab0de192f4cd110b0a23989a31
Reviewed-on: https://gerrit.libreoffice.org/16150
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2015-06-08 13:44:11 +00:00
6140ca9f1d
loplugin:loopvartoosmall
...
Change-Id: Icb31e51575f7fffd36be73bbd87a3c5e56c3aa26
2015-05-29 08:48:41 +02:00
ab465b90f6
bin/rename-sw-abbreviations.sh
...
renames the most annoying abbreviations in Writer (and partially
in the shared code too).
Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20 13:05:49 +02:00
23b439a664
convert DEFAULTCONSTANT constant to scoped enum
...
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-20 09:52:09 +02:00
b5e16d8dab
Related tdf#88056: use better-fitting <text:page-name>
...
Implemented Regina's suggestions:
* this is a text field, therefore it belongs to text namespace
* page-name (evtl. slide-name) describes much better what this
field really contains
This (among other changes) reverts commit 6609de8856519e0e9
Change-Id: Idab3b7c291839a9137f80d325a7d3f5ef0ff2636
2015-05-18 16:51:59 +02:00
f30ce25c3c
convert GRFILTER_I_FLAGS to scoped enum
...
Change-Id: Ic1cb9b32fe252706cd607abb2ae1fd5a00999901
2015-05-14 12:00:40 +02:00
f845a08a61
Replace IMPL_STATIC_LINK[_TYPED] with more useful variants
...
Change-Id: I9aca53ea7c957524a4ade0f20ef47954ddcbf5de
2015-05-10 11:25:42 +02:00
bfcb2a1a75
convert DEFAULTFONT_ constants to scoped enum
...
Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
2015-05-06 09:01:29 +02:00
78706545a6
convert FONTTOSUBSFONT constants to scoped enum
...
Change-Id: I994bfc76d709d01406404991dbfbd49b15bd03f4
2015-05-06 09:01:27 +02:00
3ead3ad52f
Gradually typed Link
...
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30 10:20:00 +02:00
e6c08b6b30
Remove unnecessary STATIC_LINK macro
...
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-29 18:29:59 +02:00
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
a602a1ce43
operator == return type wants to be bool
...
Change-Id: I7ef0a09b718ca701ed2b6f4a50593f8ef1421dd3
2015-04-28 10:21:09 +02:00
bfa4494560
loplugin:simplifybool
...
Change-Id: I0d41417b964f7f43b413a7b29fb1cf930f363427
2015-04-24 12:36:21 +02:00
2240118177
Improved loplugin:literaltoboolconversion looking into cond. exprs.
...
...automatic rewriter fixes
Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
2015-04-23 18:39:07 +02:00
cd23e6d3dd
convert BorderWidth flags to scoped enum
...
Change-Id: I99214dc2056122158df9d861e3fb3e44bf0b16f6
2015-04-22 10:28:39 +02:00
6609de8856
Related tdf#88056: this guy's better off in presentation namespace
...
no use for it outside Impress really ...
Change-Id: I419ce252ec1b32a7ef225fefc02ec5dd87ba402a
2015-04-21 10:56:56 +02:00
9f23260105
SvStream: WriteUChar -> WriteBool
...
Change-Id: I89aa0e22c31d368ab36fe46917db6aacb11c7b14
2015-04-17 15:20:43 +02:00
a7b7c64afc
convert SCRIPTTYPE_ constants to scoped enum
...
Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433
Reviewed-on: https://gerrit.libreoffice.org/15344
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-04-17 07:21:08 +00:00
0de25f9591
fix assert on saving fdo70092-1.odt to .doc
...
Change-Id: Ib2e969ca54da16b29ec20338148ee51810cb3c47
2015-04-14 13:59:28 +01:00
b3f42066e7
don't assert on export of novell363086-2.docx to doc
...
Change-Id: I40a78a9891753e0e3e1bc67a7e40f15ff756e833
2015-04-13 15:10:32 +01:00
593515e529
loplugin:staticmethods
...
Change-Id: I332d3b3158b46cf130540c6e1479dd01cb457d03
2015-04-13 09:37:13 +02:00
820576af4f
start wrapping OutputDevice in VclPtr
...
Change-Id: If3ecbb0599b50d50ce6b3997ca7892200c332ffe
2015-04-10 12:10:43 +01:00
90dc63a8dd
convert SHADOW_ constants to enum class
...
Change-Id: I1d3c144b2438776a31a246a2d0d4fe57b0caeaa3
2015-04-08 09:07:08 +02:00
54e87df11f
Change INetProtocol enumerators to CamelCase
...
...to avoid clashes with macros and poor warnings about hiding global FILE
Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
44b3e56bb4
Change INetProtocol to scoped enumeration
...
...and fix o3tl::enumarray::operator [] const overload
Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
4b66829390
convert BOX_LINE and BOXINFO_LINE to enum class
...
since their usage is intertwined.
Also introduce new o3tl utilities enumrange and enumarray to make
working with scoped enums a little simpler.
Change-Id: I2e1cc65dd7c638e59f17d96dfae504747cad6533
2015-04-01 09:36:19 +02:00
