Commit Graph

5104 Commits

Author SHA1 Message Date
99bfc363a6 convert Link<> to typed
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-20 06:37:36 +00:00
1de1b63c22 boost->std
Change-Id: Id55e334156628a916ce15fca8ec618eed0ae9366
Reviewed-on: https://gerrit.libreoffice.org/18683
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 14:27:53 +00:00
0619346216 convert Link<> to typed
Change-Id: Id600a5ee28440ee91c7089c8f7aa05f83bc0e63c
2015-09-17 12:22:47 +02:00
bd1da37163 convert Link<> to typed
Change-Id: I1ce46ea4784ecbd30a47d749d863173e0fe86fe6
2015-09-17 12:22:47 +02:00
4662def919 convert Link<> to typed
Change-Id: Iad25d514be71ea4d0f8d2b773197aa30371d776b
2015-09-17 12:22:47 +02:00
ac0eeb43aa convert Link<> to typed
Change-Id: I2f59aec574ed2c5120c554bdff13a9efab6992df
2015-09-17 12:22:47 +02:00
1e2119fd02 convert Link<> to typed
Change-Id: I3d35a0bb75b6989dd13371543d1bdf3ef5f47641
2015-09-17 08:19:34 +02:00
44404a0c8a convert Link<> to typed
Change-Id: If6334d32abbec379acbb9def98fdf6cb5144238b
2015-09-16 08:38:53 +02:00
c4fb1122b3 convert Link<> to typed
Change-Id: I628de57f87b4ba20a797d345bdf71cf10cf148fc
2015-09-16 08:38:53 +02:00
3c68751f6b cppcheck: noExplicitConstructor
Change-Id: If00a2de2c23271baaee126230c6bf9e657666ff4
2015-09-15 10:44:00 +01:00
e0714ae393 convert Link<> to typed
Change-Id: I8f3e401afa27778678788b4ac90ea927a2fed1d7
2015-09-15 09:37:31 +02:00
3107b23762 sal_uInt16 and SAL_MAX_UINT16 to sal_Int32 and LISTBOX_APPEND
Change-Id: Id68a8369d0ca907d4afc0d8a22d31d1e4c24133c
2015-09-12 14:18:52 +02:00
c5909e2518 Update many ListBox users to its sal_Int32 interface
Change-Id: I6469ac5e2d17406bee9bc434930e2471cb3bae9f
2015-09-12 14:18:50 +02:00
c80fb09256 convert Link<> to typed
Change-Id: I8f64b8f8e1e8ac7ce1475fc5132acb7171237a32
2015-09-11 08:48:55 +02:00
be73c1602d convert Link<> to typed
Change-Id: I3127752785b77672d37f99bc9eaa881377dabe7c
Reviewed-on: https://gerrit.libreoffice.org/18431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-09 08:10:11 +00:00
61623d5b90 convert Link<> to typed
Change-Id: I365a81a0a960f5da736c9a97aa056da16c99452f
2015-09-08 08:16:46 +02:00
0e1d027f84 use comphelper::containerToSequence and fix some casting
Change-Id: Ic476204e9db8a0cd1164002a4a8b55f90aef515e
2015-09-04 13:08:29 +02:00
4ea70f87f7 convert Link<> to typed
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4
Reviewed-on: https://gerrit.libreoffice.org/18306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-04 06:31:30 +00:00
5beffcf3f1 convert Link<> to typed
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83
Reviewed-on: https://gerrit.libreoffice.org/18258
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03 07:20:27 +00:00
c2f8beb593 loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: Iea6b497b91b8874bfaded494a114cbeef4417b70
2015-08-31 08:03:39 +02:00
2de6bd04d9 Bin a few leftover (?) stderr printouts
If they are truly needed, use SAL_INFO then.
2015-08-28 14:32:29 +03:00
bd8b93fdff make PostUserEvent Link<> typed
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
167bc621ef Convert vcl Button Link<> click handler to typed Link<Button*,void>
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-26 11:15:35 +02:00
373e71ee65 tdf#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: I97726ed32e5aa92e7da7d248380a78b1b201e46e
Reviewed-on: https://gerrit.libreoffice.org/17912
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-21 22:25:03 +00:00
732f69e623 loplugin:defaultparams
Change-Id: I900ddfbba7f58d4ed78a709170506222a1feb320
2015-08-21 18:06:54 +02:00
d21260cdb6 Remove two silly typedefs
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19 13:34:43 +02:00
5da0dce19c Consolidate isFileUrl checks
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-19 12:24:37 +02:00
ad1f0d1f1a o3tl: rename compat_functional header
After the cleanup, the stuff there really stands on its own (and the
remaining usage of select1st/2nd is more descriptive than lambdas).

Change-Id: I0aba131d5dc550189f8130d167dc94167e404540
Reviewed-on: https://gerrit.libreoffice.org/17806
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17 16:38:30 +00:00
ef46917ff3 Put Polygon from tools under tools:: namespace
Polygon is one of these names that Clash with some system objects
A similar work has been done earlier with PolyPolygon.

Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5
Reviewed-on: https://gerrit.libreoffice.org/17789
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-17 02:07:43 +00:00
719c55cda7 loplugin: defaultparams
Change-Id: I455b200febc9939f3fb81597938b26c0e9eb5f74
2015-08-14 10:52:47 +02:00
87130a4e18 tdf#92459 Cleanup unclear lambdas
Replace lambdas used to select the first/second member of a pair with
the new simplified select1st/2nd from o3tl/compat_functional. There
should be no side effects due to this change.

Change-Id: I17f37796e0c4defe96a10aa491d192adb9eebb89
Reviewed-on: https://gerrit.libreoffice.org/17656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11 22:29:12 +00:00
8a7b4d5bb5 Explicit capture annotations
Change-Id: I7be1a36196a07a80a7b7173c3869621f5d707204
2015-08-08 15:16:34 +02:00
4ce10ff6ce tdf#92459 remove compat_functional from extensions
Replace all uses of deprecated features from the o3tl in
compat_functional.hxx with lambda expressions in extensions. There
should be no side effects due to this patch.

Change-Id: Ib9a217c1d61593eaba82431ab047e5b899c74568
Reviewed-on: https://gerrit.libreoffice.org/17587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-08 12:31:06 +00:00
975875d53a tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants in extensions.

Change-Id: I45e9dc5769150181df88791b3f748002ca713c02
Reviewed-on: https://gerrit.libreoffice.org/17517
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-06 08:14:23 +00:00
403c13487c loplugin:unusedmethods
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 09:39:22 +00:00
2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
38023af6c1 loplugin:unusedmethods
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a
Reviewed-on: https://gerrit.libreoffice.org/17312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24 10:36:20 +00:00
ba39c9dd6a Bin pointless #ifndef #define dance
Change-Id: I0f7a3183a16a56f831a828af9de6c8f8c459339a
2015-07-23 13:32:17 +03:00
e963a88912 formatting of public/private/protected section qualifiers
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-17 09:49:35 +00:00
d9dd11e16d loplugin:simplifybool
Change-Id: Ib1af2097743f81c0bdd237941eab017a5d463b37
2015-07-16 14:00:17 +02:00
cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13 18:14:11 +02:00
fafd0b61cc extensions: convert boost::bind
Change-Id: I7922140eaaeb428da0f268cac41f7a227693c25a
2015-07-10 23:27:43 +02:00
7aa9f04538 do not include boost/utility.hpp
It just includes a bunch of other boost headers; mostly we need
boost/noncopyable.hpp so include that directly.

This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp
completely, which is the 2nd biggest header after ustring.hxx.

Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-10 23:25:22 +02:00
6a2643b92d tdf#92611 - unwind UNO lifecycle snafu.
Introduced in commit 1c4025babd7037a3292aa530c7d45ab8d6ef6dcb.
Was using UNO reference counting on a member allocated as part
of another object.

Change-Id: Ic86b2aa30359dc202c8bc2f1a0de476167a1e561
Reviewed-on: https://gerrit.libreoffice.org/16889
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-09 17:15:27 +00:00
799cc41b53 Fix typos
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0
Reviewed-on: https://gerrit.libreoffice.org/16834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-08 05:48:18 +00:00
465489d97a Fix typos
Change-Id: Id884946cae0687d0b71c967e236e58df17567884
Reviewed-on: https://gerrit.libreoffice.org/16707
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03 09:43:46 +00:00
1a8915ef83 Fix typos
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e
Reviewed-on: https://gerrit.libreoffice.org/16582
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30 15:57:12 +00:00
d16d9f950f remove some unnecessary typedefs to pointer
that were really not helping make the code any clearer.
Found with a search
   git grep -P 'typedef\s+\w+\s*\*\s*\w+\;'
and manual inspection

Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2015-06-30 09:13:24 +02:00
36abd8c69e loplugin:stringconstant: handle OUString+=OUString(literal)
Change-Id: I6f877a3b58686e037a48e2b594c58b6502c2ef78
2015-06-26 13:55:31 +02:00
768abe343c loplugin:stringconstant: Flag more inefficiencies
Change-Id: Ia4f844e0e9249f54d134fbbde11aa1f7e250e8af
2015-06-25 12:38:36 +02:00