Commit Graph

4526 Commits

Author SHA1 Message Date
c8204ba5b8 boost->std
Change-Id: I7f3bb094f116103c1146a7d60e3af94c0b37d9ea
Reviewed-on: https://gerrit.libreoffice.org/18677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 09:28:59 +00:00
d030c4a2a5 revert for mac and win unit case crashes after boost->std
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17 18:59:32 +01:00
6f495a195b boost->std
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-17 17:01:14 +01:00
f2b93f2e31 ENABLE_THREADED_OPENCL_KERNEL_COMPILATION has been zero for a long time
And I doubt we will try to turn it on again, so remove dead code.

Change-Id: Iaa8908fdb5a197ef0d1da5eaf08ae08df2a86ee7
Reviewed-on: https://gerrit.libreoffice.org/18404
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2015-09-17 06:04:27 +00:00
e4a8ae0bf5 Resolves: tdf#94249 do not remove broadcasters while iterators are in use
EndListeningContext holds BroadcasterStoreType iterators in its
ColumnBlockPositionSet and collects broadcasters to purge them at the
end. Removing broadcasters from ScColumn::maBroadcasters in between
invalidates the iterators. Hence calling the "normal" EndListening()
that removes a broadcaster when all listeners are gone while an
EndListeningContext is in use is bad.

Change-Id: Ibdd88469e91e6173ceff1f391c23ef7cb7c6f596
2015-09-16 12:44:26 +02:00
d6a5aac0f9 Split formula group for OpenCL up into smaller bits when necessary
Will make it less demanding on low-end hardware, where the device
driver is unresponsive for too long when an OpenCL kernel handling lots
of data is executing. This makes Windows restart the driver which is
problematic.

I tried several approaches of splitting, both at higher levels in sc
and at the lowest level just before creating and executing the OpenCL
kernel(s). This seems to be the most minimal and local approach. Doing
it at the lower level would have required too much poking into our
obscure OpenCL code, like passing an offset parameter to every kernel.

Use a simple heuristic to find out whether to split. On the
problematic low-end devices, CL_DEVICE_PREFERRED_VECTOR_WIDTH_FLOAT is
4, while for more performant devices it is 1 or 8.
2015-09-15 18:43:33 +03:00
97ad639352 Resolves: tdf#93895 broadcast cell changes when multi-selection was pasted
It is not sufficient to collect the cells, one has to broadcast on the
collection.

Change-Id: I11f889936aff43f958c56789e539809289819752
2015-09-14 17:37:19 +02:00
927447356f replace boost::ptr_container with std::container<std::unique_ptr>
Change-Id: I8fd1121577c6443f9100b181402083d1b7c30b6b
Reviewed-on: https://gerrit.libreoffice.org/18525
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-13 06:25:18 +00:00
074d4b2362 Typo: muliple->multiple
Change-Id: Iebcf44d99bd4cabd5f7f1242e44c1c1d8e5a10d5
2015-09-12 08:05:48 +02:00
44f34c1163 Resolves: tdf#92995 do not delete caption objects that are held by Undo
Drag&Drop Undo is a special case of ownership..

Change-Id: I2fe7769c4d84efe09d432335d5d8e72d506bf7a1
2015-09-10 15:56:45 +02:00
5906a2a638 convert Link<> to typed
Change-Id: I184d836e944d6dcfd17233a7a83680f1c1bff9bf
2015-09-09 10:06:11 +02:00
241a0c1ab1 aTopPos is not used for anything as far as I can see
Change-Id: Id7ef5fbceffecb6cee8efb80b6de4946a8300839
2015-09-08 15:59:46 +03:00
37a36671e0 reactivate fixed mempool for ScFormulaCell
... it got lost with 8b252f30267d043522ff2cbf2bf42275bb7a6ec6

Change-Id: I1a7c9bbaa1fd70d24c168d53aae6691a45c29085
2015-09-08 14:02:22 +02:00
7df729da30 Revert "USE_MEMPOOL is not defined anywhere"
Well.. then let's remove the ifdef instead of the implementation,
dammit..

This reverts commit 64c6b0ed6c67d169021732d276ec02706e139261.
2015-09-08 14:02:22 +02:00
64c6b0ed6c USE_MEMPOOL is not defined anywhere
Change-Id: I4d3c87aac31c6690cd061ce41e7efae113055c12
2015-09-08 14:14:14 +03:00
679a5dc0cf TableRef: update table column names when cell content changed
Change-Id: Id699358c7dae635b13ed4b981326a6490255a4d4
2015-09-04 21:14:41 +02:00
884d53813a remove unused ScDocument::RefreshTableColumnNames(const ScRange&)
Change-Id: Ia3d09478b31503eb6ab9e352b2925bc1b496a8e3
2015-09-03 19:08:10 +02:00
834eddc8f7 TableRef: add RefreshTableColumnNames() from range
Change-Id: I32a47e306469aec5fe366a6621129e14b0d49c13
2015-09-03 00:09:02 +02:00
26e84b3852 TableRef: introduce ScDBDataPortion enum
... to replace
* bool bStartonly=false with ScDBDataPortion::AREA
* bool bStartonly=true  with ScDBDataPortion::TOP_LEFT

and provide means to look at header row only with
ScDBDataPortion::HEADER as needed for TableRef.

Change-Id: I9f6affd04c15a6204193687b2379160eb975f56e
2015-09-02 16:10:34 +02:00
489dbb311d fix dubious usage of [0] instead of proper dereferencing
introduced in commit 4aed1c6f384ab372b1c03f607445f92f0181f822
"replace boost::ptr_vector with std::vector<std::unique_ptr>"

Change-Id: Id16921f212128d34835a4c0b9facd18cb264da62
2015-08-31 13:39:16 +02:00
4a5d980ff2 remove some typedef indirection
which just serves to make the code harder to read

Change-Id: Ib681aad99180df26b1cf3f4e23324dc5a86cc299
2015-08-31 13:03:03 +02:00
4aed1c6f38 replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I3f75ad585ca288f0369e91dd5bc90151270346dc
Reviewed-on: https://gerrit.libreoffice.org/18048
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31 07:28:00 +00:00
9f075246c5 loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: I4e350a0c6045d07677edae4f9921db0a42b4e0f5
2015-08-31 08:02:18 +02:00
9c8fd7d1c5 Clean up sEmpty
Change-Id: If1b2bfe308caa2bce92e73d2c5c86ee273faed93
2015-08-27 08:00:32 +02:00
a6050c32f3 Clean up aEmpty
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-27 08:00:32 +02:00
9a050db847 replace boost::ptr_vector with std::vector<std::unique_ptr>
Change-Id: I21fbfe37f89fa404688cd1b287163801da9f7e0a
Reviewed-on: https://gerrit.libreoffice.org/17974
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-26 06:28:17 +00:00
7e318570dc tdf#39440 reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: Ie492fb9c106b37c3fe7b0105236ad6315f4f159e
Reviewed-on: https://gerrit.libreoffice.org/17921
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-22 13:04:12 +00:00
082a7faeed sc: replace boost::ptr_set with std::set<std::unique_ptr>
Change-Id: I966069726fd7dbc57e03e93514bec62d8bbb2ba0
Reviewed-on: https://gerrit.libreoffice.org/17862
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-19 20:43:49 +00:00
b5ae7dbc87 sc: replace boost::ptr_set with std::set<std::unique_ptr>
Change-Id: I93bdb33a442a358b0067d57499b11d73bfbaa2d9
Reviewed-on: https://gerrit.libreoffice.org/17860
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-19 19:36:18 +00:00
236714e86c Clean up remaining utl::LocalFileHelper::Convert...
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040
"ConvertURLToSystemPath->getSystemPathFromFileURL" and
28f3464a571a23a2c16bd0980e9021b95d011511
"ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those
Convert... functionality with direct calls to the corresponding osl::FileBase
functions.

Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-19 10:48:42 +02:00
1bea831074 introduce temporary hard-recalc state, tdf#92749 follow-up
This allows listeners to be setup and initial lookup caches to be kept,
which were thrown away after the initial calculation as an interim fix
for tdf#92749.

Change-Id: I34068b3f6b833a46f3c526579efbdc342a2e71df
2015-08-18 14:01:10 +02:00
f7e493229b Resolves: tdf#92749 invalidate lookup caches after initial hard recalc
... because the caches are not setup as listeners during when the
document's hard recalc state is active.

Change-Id: Ie7ec84ee64d046e3e55ce26b92824e94a2f660e9
2015-08-18 11:37:30 +02:00
a962d699b0 add a simple formula cell calculation chain dumper
Change-Id: Ie6409724dcf0baa2f1d7dd62ed8d995f0374dbf1
2015-08-18 11:37:29 +02:00
8d54e96536 make Link<> typed
Change-Id: If16adfa3310df94c79d1a4fe9a9bb4f4f56365f0
2015-08-17 09:59:58 +02:00
f089de7dc5 Resolves: tdf#93358 resync attribute pattern that may have changed
Change-Id: If3ce8feec940c7212fe467f39db868630522b17e
2015-08-15 01:35:15 +02:00
18da84abd6 loplugin: defaultparams
Change-Id: I807ce811f5988d6134b4c6f73408cd034f25a7f7
2015-08-14 11:11:41 +02:00
ea29d32075 Resolves: tdf#93098 replace remembered listener when replacing cell
... where SvtListener* is the base of ScFormulaCell* and lead to use
after delete.

Change-Id: I45b8e16f05cf5d4d0d4858dc9cd0c748f8184978
2015-08-13 18:41:38 +02:00
ca6c2bab87 rename confusing classes
In module sc classes FuncData and FuncCollection are used for
legacy binary AddIn functions. In module scaddins also exist
classes FuncData. This can be confusing, so the classes and relevant
members/variables have been renamed in module sc.

Change-Id: Ib0700ed1177b760a4d46312b8578ca8b55882c53
Reviewed-on: https://gerrit.libreoffice.org/17670
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-08-12 20:36:49 +00:00
2d4edd7de2 Resolves: tdf#93388 broadcasting to removed listeners isn't a good idea
This cures only a symptom, the underlying cause is that the broadcasters
still are listed in maBulkGroupAreas.

Change-Id: I9625483016a51eb6f6a7e3d58ed42c7dad3a57b3
2015-08-12 20:21:50 +02:00
6385c8e837 tdf#39468 Translate German Comments - sc/source/core/data/
With work from Christian M. Heller <christian.heller63@gmail.com>

rebased it to make it possible to merge

Change-Id: Ib018fe94513a3b987bb992d86e4597612b44894f
Reviewed-on: https://gerrit.libreoffice.org/14866
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2015-08-11 14:11:06 +00:00
368a3e45a3 sc: inline some use-once typedefs
Change-Id: I332e160dda3f167e61f99da1eb0aa6bd72a48b06
2015-08-04 08:55:56 +02:00
a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
774085dbe5 tdf#92548, limit number of characters shown in formula wizard
Change-Id: I5c322140d40e1ec31e8664a6f731e57b9b3defdb
2015-07-27 20:02:09 +02:00
90e8ad7ab7 loplugin:unusedmethods scripting,sc
Change-Id: I0016aefce1aad3a89bd23dcec6fbab58a7c844d7
Reviewed-on: https://gerrit.libreoffice.org/17263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-22 07:02:34 +00:00
82b896f1f8 loplugin:unusedmethods formula
Change-Id: I62ff278679638dda7e10c86c49b1966641418e8b
Reviewed-on: https://gerrit.libreoffice.org/17223
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21 06:50:30 +00:00
3e17ed1fc2 Resolves: tdf#92767 use ISO 8601 for internal date string representation
Change-Id: I481bf3295feb64827de2122234a9300d0b8ced40
2015-07-17 18:22:07 +02:00
8eadeb91cd Resolves: tdf#77479 do not reset AutoFilter range for temporary operations
Change-Id: I22f5e74ca91eb188ce669762927dd25604a256ff
2015-07-17 15:26:49 +02:00
1d852b32d7 loplugin:unusedmethods svx
Change-Id: I92158457b3ffaaf7c84c6f4c87708d766c8c9f61
Reviewed-on: https://gerrit.libreoffice.org/17117
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16 12:18:39 +00:00
2aefb89b29 execute the terrible bottle neck loop only if there are conditional formats
Change-Id: Ic8bd65a728289c9fa1a0721b0ecbd9b4a48672ca
2015-07-09 21:13:43 +02:00
f4b189df64 simplify the logic a little
Change-Id: I8ff2bc971fd1ab7acf6c416ae85a03152ca2a3d9
2015-07-09 12:02:13 +02:00