Commit Graph

1821 Commits

Author SHA1 Message Date
c8204ba5b8 boost->std
Change-Id: I7f3bb094f116103c1146a7d60e3af94c0b37d9ea
Reviewed-on: https://gerrit.libreoffice.org/18677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 09:28:59 +00:00
d030c4a2a5 revert for mac and win unit case crashes after boost->std
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17 18:59:32 +01:00
6f495a195b boost->std
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-17 17:01:14 +01:00
11c4f58fb1 convert Link<> to typed
Change-Id: I2573b42143078c4e72ab201392c69ee296f4974e
2015-09-16 08:38:55 +02:00
fb59df3a55 there's no default ScMatrixMode enum other than the known ones
... and if there was one not handled let the compiler complain.

Change-Id: Ibe3a2a913edfbfbba30a83a8d985d5509853ff6d
2015-09-15 19:01:27 +02:00
d8d6997363 stab MM_FAKE, it's a zombie
Change-Id: Iee70d0d027197c431926ab1194e0daa5eb429caf
2015-09-15 19:01:26 +02:00
6f4e11a95b convert Link<> to typed
Change-Id: I2aeda615e39db5a3cd39e168db34425e2912be8b
2015-09-09 10:06:12 +02:00
679a5dc0cf TableRef: update table column names when cell content changed
Change-Id: Id699358c7dae635b13ed4b981326a6490255a4d4
2015-09-04 21:14:41 +02:00
1873563bb2 sc: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I2f55a6231e903b0ca198cee3a88023ad1db6c50c
Reviewed-on: https://gerrit.libreoffice.org/18072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-09-03 16:14:41 +00:00
e65c447cef revert an unmaintainable dead end approach
back to the drawing board..

This reverts commit 4185c2a66137ffa0b0476421f8ef3d4f4a89b805.
This reverts commit be7b9220e8f59673a69bbb98f784c4118a08d249.
This reverts commit 17a74558c48bd1496d122231777b9a7e63a1252a.
Partially reverts commit 92fbe21b85bcd5c3a6fe1c9674cadd357da0d982 for
the ScDocShellModificator dtor part.

Change-Id: If4199b57c6e7301bc87a9c10b8864b6b086d1300
2015-09-03 12:12:30 +02:00
37a6fdf890 loplugin:stringconstant also for cases using char const v[] = "..."
Change-Id: Iba38686620624178a7be39d703389402bbcea4cb
2015-09-03 09:34:00 +02:00
f0744793c8 comment a nice-to-have idea
Change-Id: If03dba2fa7394ec898cb6d87e06bc85171319fcd
2015-09-03 00:09:05 +02:00
0347ba1346 TableRef: use ScRangeList instead of vector for Join()
... so adjacent areas result in one call to RefreshTableColumnNames().

Change-Id: I1c42a37cbe9630b66504654fec021e39f0c0e67c
2015-09-03 00:09:05 +02:00
834eddc8f7 TableRef: add RefreshTableColumnNames() from range
Change-Id: I32a47e306469aec5fe366a6621129e14b0d49c13
2015-09-03 00:09:02 +02:00
1cb61611c2 add ScDocShellModificator::AppendCellContentModified()
... e.g. for future ScDBData column names update.

Change-Id: I893b494c50a278022d3ea4fa73230dfdc3d468b1
2015-09-03 00:09:02 +02:00
26e84b3852 TableRef: introduce ScDBDataPortion enum
... to replace
* bool bStartonly=false with ScDBDataPortion::AREA
* bool bStartonly=true  with ScDBDataPortion::TOP_LEFT

and provide means to look at header row only with
ScDBDataPortion::HEADER as needed for TableRef.

Change-Id: I9f6affd04c15a6204193687b2379160eb975f56e
2015-09-02 16:10:34 +02:00
9f075246c5 loplugin:stringconstant: OUStringBuffer: appendAscii -> append
Change-Id: I4e350a0c6045d07677edae4f9921db0a42b4e0f5
2015-08-31 08:02:18 +02:00
a6050c32f3 Clean up aEmpty
Change-Id: I4c4294b7fb1cb537ba3ae3e6e7e747a3333b7469
2015-08-27 08:00:32 +02:00
9beb2bedc0 tdf#39440 sc: reduce scope of local variables
This addresses some cppcheck warnings.

Change-Id: Ia7f58c24429310b66f4464d8ba8b4f2e5c6fef38
Reviewed-on: https://gerrit.libreoffice.org/17922
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-23 06:04:49 +00:00
082a7faeed sc: replace boost::ptr_set with std::set<std::unique_ptr>
Change-Id: I966069726fd7dbc57e03e93514bec62d8bbb2ba0
Reviewed-on: https://gerrit.libreoffice.org/17862
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-19 20:43:49 +00:00
b5ae7dbc87 sc: replace boost::ptr_set with std::set<std::unique_ptr>
Change-Id: I93bdb33a442a358b0067d57499b11d73bfbaa2d9
Reviewed-on: https://gerrit.libreoffice.org/17860
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-08-19 19:36:18 +00:00
236714e86c Clean up remaining utl::LocalFileHelper::Convert...
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040
"ConvertURLToSystemPath->getSystemPathFromFileURL" and
28f3464a571a23a2c16bd0980e9021b95d011511
"ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those
Convert... functionality with direct calls to the corresponding osl::FileBase
functions.

Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-19 10:48:42 +02:00
1bea831074 introduce temporary hard-recalc state, tdf#92749 follow-up
This allows listeners to be setup and initial lookup caches to be kept,
which were thrown away after the initial calculation as an interim fix
for tdf#92749.

Change-Id: I34068b3f6b833a46f3c526579efbdc342a2e71df
2015-08-18 14:01:10 +02:00
f60c67c486 loplugin: defaultparams
Change-Id: I4f635044b93f74fb397a4e47535e91160fce456c
2015-08-14 11:21:57 +02:00
01075a7274 inline the "old" SbxErr constants
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28 08:35:34 +02:00
91b1f300cf convert to typed Link<> in sfx2
Change-Id: Ifa42bd14d7329ff1043fa736513c468dda30485e
Reviewed-on: https://gerrit.libreoffice.org/17195
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20 08:01:58 +00:00
8eadeb91cd Resolves: tdf#77479 do not reset AutoFilter range for temporary operations
Change-Id: I22f5e74ca91eb188ce669762927dd25604a256ff
2015-07-17 15:26:49 +02:00
98b0cd7660 do not reset existing HasHeader on anonymous database range
tdf#88402 related

Change-Id: I401c67da383227496e9d8c2b2ed0671e2a2796f2
2015-07-17 00:59:52 +02:00
6567538600 inherit existing HasHeader when expanding/shrinking anonymous database range
tdf#88402 related

Adding columns, invoking Data->Sort, Cancel now still does not lose a
HasHeader set in a previous Sort dialog.

Change-Id: I1388b8f6a1964fb584f1826751072ba648f53ab7
2015-07-17 00:26:43 +02:00
33255f974f Resolves: tdf#88402 remember sort "has headers" at anonymous database ranges
Change-Id: I4a126f40589fd401f3a63f74be5e86e3df947ef6
2015-07-16 17:55:49 +02:00
5ee9e2983a remove ScRange::Justify() and replace calls with PutInOrder()
Change-Id: I350050ac085b1f220d5288d33c253ba0c9a5fd2c
2015-07-08 22:21:08 +02:00
e9c3583c2c improve the returnbyref loplugin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb
Reviewed-on: https://gerrit.libreoffice.org/16731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06 07:04:50 +00:00
3dfdd18707 Fix typos
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1
Reviewed-on: https://gerrit.libreoffice.org/16710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-04 10:22:11 +00:00
cf029c125d loplugin:stringconstant: handle OUString+=OUString(literal)
Change-Id: Ie4e62535848718ca66a1fa977b09891e91ee7421
2015-06-26 13:55:33 +02:00
cb0a4a43a5 loplugin:stringconstant: Flag more inefficiencies
Change-Id: Icdd850336caf998e62cdb5a90fc3683eddd04a3e
2015-06-25 12:38:37 +02:00
77cc71476b LinkUpdateMode is a global setting
Change-Id: Ida1257337c6e0916f2228fe053d9c9f085183af6
2015-06-23 08:26:36 +02:00
9ed033917b Fix typos
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce
Reviewed-on: https://gerrit.libreoffice.org/16373
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-21 19:56:13 +00:00
0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]>
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17 15:50:45 +00:00
814af9f1e5 Fix typos
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f
Reviewed-on: https://gerrit.libreoffice.org/16309
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16 11:21:07 +00:00
c82c94b401 loplugin:staticmethods
Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9
2015-06-11 08:46:23 +02:00
17282387d6 tdf#89972: also copy external reference status
fixes regression from commit 4467c67dc8bf17c67c70985c0d0ea64636884f9f,
where the new optimized code path failed to properly register
ScFormulaCell with ScExternalRefManager.
Introduces a new public method in ScExternalRefManager: insertRefCellAsTmpl
that registers a formula cell to listen to the same external references
as template cell
Introduces new property to ScFormulaCell: mbIsExtRef
that indicates that some external references are referenced by this cell

Also introduces new method ScExternalRefManager::hasCellExternalReference
(for use in unit test, will be posted immediately)

Change-Id: Iee07d7b51949fd31953b5fa662a213052eb85181
Reviewed-on: https://gerrit.libreoffice.org/16066
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-10 20:28:56 +00:00
1c5613e108 loplugin:cstylecast: deal with remaining pointer casts
Change-Id: I700b727c048aff5c19411fb9d5bd9601b296cb06
2015-06-08 16:27:31 +02:00
3f72218069 Apply new VclPtr clang plugin to catch potential problems.
Omit the plugin, and sw's FrameControlsManager for now.

Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f
Reviewed-on: https://gerrit.libreoffice.org/16117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-06 20:26:54 +00:00
aa25be5965 loplugin:loopvartoosmall
Change-Id: Iafe55d4aa65a380d8d338edd54338f53a3e920dc
2015-06-01 12:29:42 +02:00
285b5ef458 Calc: Insert row/col before/after [2/2]
This part adds features to add rows/cols
after the selection which is a new behaviour.

Change-Id: Iec1201ae56970cd3dd0622c2ffa1eb6e46ad7446
Reviewed-on: https://gerrit.libreoffice.org/15831
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-05-31 17:59:25 +00:00
f97beeef35 Calc: Insert row/col before/after [1/2]
This part renames all INSROW / INSCOL to
INSROWS_BEFORE / INSCOLS_BEFORE which is
the current (default) behaviour.

Change-Id: Ia084f17a3be8bf09908e5d227ef4e6d09b8420a4
Reviewed-on: https://gerrit.libreoffice.org/15830
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-05-31 17:58:21 +00:00
51262ef0d1 Implemented formula group count statistic
Change-Id: I8b9c11fdd4b6e4343b467f1e5b1d1e96f1dd3140
Reviewed-on: https://gerrit.libreoffice.org/15927
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-05-30 09:06:58 +00:00
ba81e5c6bd tdf#91702 - fix stack-based MessBox allocation.
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-29 12:16:28 +00:00
f849d96463 tdf#91416 - fix some incorrectly allocated VirtualDevices.
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe
2015-05-26 17:54:27 +01:00
a4bf46accf Remove include stdio (part5)
Change-Id: Iea3eb02b5ae54de1de14b5357726d1073e54e1af
Reviewed-on: https://gerrit.libreoffice.org/15851
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-22 14:57:51 +00:00