d030c4a2a5
revert for mac and win unit case crashes after boost->std
...
Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
2015-09-17 18:59:32 +01:00
6f495a195b
boost->std
...
Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
2015-09-17 17:01:14 +01:00
c53b880f00
loplugin:defaultparams
...
Change-Id: Ib7a4be246e5d82f5a704a188f8b950f187d04138
2015-08-20 13:52:17 +02:00
3d2f43438d
loplugin:unusedmethods sd
...
Change-Id: I9b5399ace50db3259df2e619f28ae547a38e6c6d
Reviewed-on: https://gerrit.libreoffice.org/17254
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-21 09:05:41 +00:00
b7f9a397fb
loplugin:unusedmethods sfx2(part2)
...
Change-Id: I82223b72ddb6a9df1ee52a300b083002234602dc
Reviewed-on: https://gerrit.libreoffice.org/17075
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-16 05:48:12 +00:00
6390d2c52b
Get rid of comphelper::string::is*Ascii functions
...
Change-Id: I99912112e5b009d7a143f9816d757cdf6ebb1783
2015-06-24 15:27:28 +02:00
1234f96b96
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I0c6d14f0762ae804b931472bc201826821572e3e
2015-06-08 16:27:49 +02:00
3cbdf64ad5
convert DRAWMODE constants to scoped enum
...
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
2015-05-20 09:52:08 +02:00
f9e73fe26b
loplugin:cstylecast: nop between pointer types of exactly same spelling
...
Change-Id: Ia78ebb57f69c678ddc4ca2b42c82105fa528ff2b
2015-05-11 12:50:39 +02:00
1902ad6cad
convert SDR_SWAPGRAPHICS constants to scoped enum
...
and drop unused DOC constant
Change-Id: Id35d18241642742500cc007c575a8a54b5b8dd97
2015-04-29 10:41:39 +02:00
e8b97a52c9
Merge remote-tracking branch 'origin/feature/vclptr'
...
Resolve several thousand lines of conflicts.
Conflicts:
accessibility/source/extended/accessiblelistbox.cxx
accessibility/source/standard/vclxaccessiblecombobox.cxx
accessibility/source/standard/vclxaccessibledropdowncombobox.cxx
accessibility/source/standard/vclxaccessibledropdownlistbox.cxx
accessibility/source/standard/vclxaccessiblelistbox.cxx
accessibility/source/standard/vclxaccessibletextfield.cxx
basctl/source/basicide/basidesh.cxx
cui/source/inc/chardlg.hxx
cui/source/tabpages/tpbitmap.cxx
dbaccess/source/ui/dlg/UserAdmin.cxx
dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx
extensions/source/propctrlr/propertyeditor.hxx
extensions/source/scanner/sanedlg.cxx
filter/source/pdf/impdialog.cxx
include/sfx2/mgetempl.hxx
include/sfx2/sidebar/SidebarToolBox.hxx
include/sfx2/viewsh.hxx
include/svtools/brwbox.hxx
include/svtools/filectrl.hxx
include/svtools/scrwin.hxx
include/svx/dlgctrl.hxx
include/svx/sidebar/Popup.hxx
include/svx/sidebar/PopupContainer.hxx
include/svx/sidebar/PopupControl.hxx
include/svx/sidebar/SidebarDialControl.hxx
include/svx/sidebar/ValueSetWithTextControl.hxx
sc/source/ui/condformat/condformatdlgentry.cxx
sc/source/ui/navipi/navipi.cxx
sc/source/ui/sidebar/CellBorderStyleControl.hxx
sd/source/ui/animations/CustomAnimationDialog.cxx
sd/source/ui/inc/DrawViewShell.hxx
sd/source/ui/inc/Ruler.hxx
sd/source/ui/inc/SlideSorter.hxx
sd/source/ui/inc/ViewTabBar.hxx
sd/source/ui/inc/Window.hxx
sd/source/ui/inc/morphdlg.hxx
sd/source/ui/inc/sdpreslt.hxx
sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx
sd/source/ui/sidebar/LayoutMenu.hxx
sd/source/ui/sidebar/MasterPagesSelector.hxx
sd/source/ui/sidebar/NavigatorWrapper.hxx
sd/source/ui/sidebar/PanelBase.hxx
sd/source/ui/sidebar/RecentMasterPagesSelector.cxx
sd/source/ui/sidebar/RecentMasterPagesSelector.hxx
sd/source/ui/slideshow/showwindow.hxx
sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
sd/source/ui/view/ViewShellBase.cxx
sd/source/ui/view/drviewsa.cxx
sfx2/source/appl/fileobj.hxx
sfx2/source/appl/opengrf.cxx
sfx2/source/control/thumbnailviewacc.hxx
sfx2/source/dialog/securitypage.cxx
sfx2/source/dialog/templdlg.cxx
sfx2/source/doc/docinsert.cxx
sfx2/source/doc/guisaveas.cxx
sfx2/source/inc/alienwarn.hxx
sfx2/source/sidebar/Deck.cxx
sfx2/source/sidebar/Deck.hxx
sfx2/source/sidebar/DeckTitleBar.cxx
sfx2/source/sidebar/DeckTitleBar.hxx
sfx2/source/sidebar/MenuButton.cxx
sfx2/source/sidebar/MenuButton.hxx
sfx2/source/sidebar/Panel.cxx
sfx2/source/sidebar/Panel.hxx
sfx2/source/sidebar/PanelTitleBar.hxx
sfx2/source/sidebar/SidebarDockingWindow.hxx
sfx2/source/sidebar/SidebarToolBox.cxx
sfx2/source/sidebar/TabBar.hxx
sfx2/source/sidebar/TabItem.cxx
sfx2/source/sidebar/TabItem.hxx
sfx2/source/sidebar/TitleBar.hxx
sfx2/source/toolbox/imgmgr.cxx
starmath/inc/edit.hxx
starmath/inc/smmod.hxx
starmath/qa/cppunit/test_starmath.cxx
starmath/source/edit.cxx
starmath/source/smmod.cxx
svtools/source/brwbox/brwbox1.cxx
svtools/source/brwbox/datwin.hxx
svtools/source/contnr/fileview.cxx
svtools/source/contnr/simptabl.cxx
svtools/source/control/filectrl.cxx
svtools/source/control/valueimp.hxx
svx/inc/GalleryControl.hxx
svx/source/dialog/dlgctrl.cxx
svx/source/dialog/swframeexample.cxx
svx/source/fmcomp/fmgridif.cxx
svx/source/gallery2/GalleryControl.cxx
svx/source/sidebar/EmptyPanel.hxx
svx/source/sidebar/area/AreaPropertyPanel.hxx
svx/source/sidebar/area/AreaTransparencyGradientControl.hxx
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx
svx/source/sidebar/insert/InsertPropertyPanel.cxx
svx/source/sidebar/insert/InsertPropertyPanel.hxx
svx/source/sidebar/line/LinePropertyPanel.hxx
svx/source/sidebar/line/LineWidthControl.cxx
svx/source/sidebar/line/LineWidthControl.hxx
svx/source/sidebar/line/LineWidthValueSet.hxx
svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
svx/source/sidebar/possize/SidebarDialControl.cxx
svx/source/sidebar/text/TextCharacterSpacingPopup.hxx
svx/source/sidebar/text/TextPropertyPanel.hxx
svx/source/sidebar/tools/PopupContainer.cxx
svx/source/sidebar/tools/PopupControl.cxx
svx/source/sidebar/tools/ValueSetWithTextControl.cxx
svx/source/svdraw/svdfmtf.hxx
svx/source/svdraw/svdibrow.cxx
svx/source/tbxctrls/colrctrl.cxx
svx/source/tbxctrls/tbcontrl.cxx
sw/source/ui/dbui/mmaddressblockpage.cxx
sw/source/ui/dialog/uiregionsw.cxx
sw/source/ui/index/cnttab.cxx
sw/source/uibase/inc/drpcps.hxx
sw/source/uibase/sidebar/PageColumnControl.hxx
sw/source/uibase/sidebar/PageMarginControl.hxx
sw/source/uibase/sidebar/PageOrientationControl.hxx
sw/source/uibase/sidebar/PagePropertyPanel.hxx
sw/source/uibase/sidebar/PageSizeControl.hxx
sw/source/uibase/uiview/view2.cxx
sw/source/uibase/utlui/navipi.cxx
vcl/inc/svdata.hxx
vcl/source/control/combobox.cxx
vcl/source/control/lstbox.cxx
vcl/source/window/dockwin.cxx
vcl/source/window/winproc.cxx
Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-28 15:08:48 +01:00
7819d49fac
sd: convert new to ::Create.
...
Change-Id: I35c03ea4430eb5a5bd4c7cfaed74f741c09cbf18
2015-04-20 13:44:47 +02:00
9c50c39fb4
convert SEARCH_OPTIONS constants to scoped enum
...
Change-Id: Id0f0c7d692410cf5e1477c5180e7cfb8e7b0f52b
Reviewed-on: https://gerrit.libreoffice.org/15345
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-04-20 08:23:13 +00:00
d8ebd90441
sfx2: convert new to ::Create.
...
Change-Id: I53f95a65702c144ba4c4b0caac1e172015fec0fa
2015-04-17 17:53:05 +02:00
a7b7c64afc
convert SCRIPTTYPE_ constants to scoped enum
...
Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433
Reviewed-on: https://gerrit.libreoffice.org/15344
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-04-17 07:21:08 +00:00
71b809959b
remove unnecessary use of void in function declarations
...
ie.
void f(void);
becomes
void f();
I used the following command to make the changes:
git grep -lP '\(\s*void\s*\)' -- *.cxx \
| xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'
and ran it for both .cxx and .hxx files.
Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-15 11:47:12 +02:00
afb82d3729
implement SfxObjectShell subclasses' LOK interface
...
Change-Id: Iee2fbf71375631a349992a90c67c1c4c34e6ba3b
2015-04-14 00:55:17 +02:00
ccfa9fa13d
convert SFX_LOADED_ to scoped enum
...
Change-Id: I065a07e1bb5f5a7f85429c919830b6b9605206ea
2015-04-13 09:34:52 +02:00
8a65284fe3
Automated conversion of VclPtr construction to use Instance template.
...
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10 13:40:25 +01:00
8fa63f31ab
Fix OutputDevice members / stack allocation: slideshow, starmath, sd, sc.
...
Change-Id: I6d6d41b8a6501ce7d35c78e5b730ea45143d6b73
2015-04-10 12:17:54 +01:00
4ce5a6e2d5
compile fixes.
...
Change-Id: I210c71c1a7236d286256a498f3f4f28f4185d052
2015-04-10 12:11:13 +01:00
cf06c0135d
start of unwinding reference OutputDevice & Printer lifecycle.
...
Change-Id: I066337f46a3c39d1eaba5e7a1f4e1278816a0b27
2015-04-10 12:02:53 +01:00
2391931e21
convert SFXOBJECTSHELL_ constants to scoped enum
...
Change-Id: I5a159be0c342b778730cedb0fe35843c2c368c97
2015-04-10 09:48:07 +02:00
afc728fe76
convert SFXMODEL_ to scoped enum
...
and fix up some confusion in SC and STARMATH about which constants to
use
Change-Id: Ib75bc78a24bd2fad6ec6d7c94c4c1ad7dc222c1a
2015-04-10 09:48:07 +02:00
89dd3f8068
convert SfxObjectCreateMode to scoped enum
...
and fix some dodgy usage in /sc in the process
Change-Id: Ia2bee267df31aba431fc8cb81195bb83e5b64deb
2015-04-10 09:48:06 +02:00
84482f5193
convert SfxSlotFilterState to scoped enum
...
Change-Id: I424a1c71429078f8f83f8f0138c6e12567628ef8
2015-04-10 09:48:06 +02:00
1a9e23609b
const_cast: convert some C-style casts and remove some redundant ones
...
Change-Id: Iad769ac61d17f6e348681a38ae11c832f75f6353
2015-03-26 15:33:35 +01:00
abf60c4a0f
convert EE_CNTRL constants to enum class
...
there were a couple of lines in SC and SW where the code was using a
EV_CNTRL constant. I switched it to used the same-valued constant from
EE_CNTRL
Change-Id: I027183cc3b6e700bf365d48833e37eddc9b50f04
2015-03-25 08:56:14 +02:00
799a7878fd
convert SFX_PRINTER constants to enum class
...
Change-Id: I5dca39f7668be2c03c904c33b6181ba769b70990
2015-03-24 09:36:59 +02:00
fb14be5f8f
create new 'enum class' SotClipboardFormatId to unify types
...
of which there are several.
There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
numeric values to the underlying code, but perhaps further fixing is necessary?
Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-18 14:23:50 +02:00
b6d6dab920
V668 no sense in testing the result of new against null
...
Change-Id: I1cff71d15f4d1b5ee47cc734b3fc2168d7f99201
2015-03-10 15:44:58 +00:00
ba233e87ef
remove unnecessary parenthesis in return statements
...
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'
Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
309574394b
callcatcher: large newly detected unused methods post de-virtualization
...
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com >
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-29 23:42:26 +00:00
c4b3801c22
Some more loplugin:cstylecast: sd
...
Change-Id: I3562efaab55655bc758fe94090b2b6d05b548098
2015-01-21 14:03:43 +01:00
cb9e8bbdb9
sd: Use appropriate OUString functions on string constants
...
Change-Id: Ic402f5b5be1f657d9045091056bcb731b3407a9d
2014-12-18 14:12:31 +01:00
8307821419
We now only need one bit of information here
...
whether there *is* an id, or whether there is not an id. An id of 0 seems to
be used as a flag that an interface is some sort of superclass which can be
subclassed by something else and have its toolbars etc reused.
Convert this to a bool so we don't need an a resource id for each one and just
drop the third arg for the normal "final" case and use a different define for
the inheritable case
Change-Id: I98380f03d73d57bf8cba02d339097e384518abaa
2014-11-25 14:54:02 +00:00
d32be3ace8
fdo#86023 - O[U]String needs a 'clear' method
...
Added clear() method to OString and OUString class, Updated appropriate call-sites.
Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-11-14 09:20:38 +01:00
b52a7c4df4
loplugin: cstylecast
...
Change-Id: I071962c646199c30e842b9ec7673473de237ee45
2014-11-13 10:19:46 +02:00
da40cac540
Fix common typos. No automatic tools. Handmade…
...
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-11-12 11:04:11 +00:00
be36b1644d
loplugin: cstylecast
...
Change-Id: Ic4eca519c5ba8662b29901f196ecfd6e0aa776e2
2014-11-10 15:22:16 +02:00
10db2f7246
Related: fdo#84846 move code setting edit mode to a new method
...
First change in series to fix fdo#84846.
Change-Id: I52dc333c2caa30ee3c75d9cc80862cf24a204f93
Reviewed-on: https://gerrit.libreoffice.org/12148
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-10-30 16:53:11 +00:00
31af61ea09
Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"
...
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba.
Conflicts:
cui/source/tabpages/transfrm.cxx
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
tools/source/generic/rational.cxx
Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23 18:34:39 +02:00
858c2a2977
Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"
...
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e.
Conflicts:
svx/source/svdraw/svdedtv1.cxx
svx/source/svdraw/svdibrow.cxx
sw/source/filter/ww1/w1filter.cxx
Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23 18:34:34 +02:00
4332787892
nShearWink -> nShearAngle
...
Change-Id: I122f16783db4025b9335ed82a12f051516d98d4c
2014-10-21 08:56:29 +02:00
582ef22d3e
fdo#84854 it seems long is not enough on 32 bit
...
Fraction used BigInt internally for computations, rational does nothing
like that.
Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-16 17:44:44 +02:00
da77897d19
nDrehWink -> nRotationAngle
...
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-15 09:01:16 +02:00
2fff4927c4
coverity#1242426 Dereference after null check
...
Change-Id: I59c96846aa5bf4780e4c5bfb0b71242e3b928976
2014-10-14 13:42:19 +01:00
8044acf2db
convert SFX_CALLMODE constants to SfxCallMode enum class
...
and fix a couple of bugs in SC and SW where the call mode was
being passed to the hints parameter by accident
Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58
Reviewed-on: https://gerrit.libreoffice.org/11916
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-10-11 15:14:52 +00:00
1958ca235b
German comment translation.
...
Change-Id: I479da454235a7cfc084ae1517ab9ffa07580ab0c
2014-10-09 17:44:58 +01:00
c78d5fae81
German comment translation.
...
Change-Id: I98526bfd6f69d95d5c309e67c397bc85fb8817ab
2014-10-09 17:44:58 +01:00