I can't reprodue this in a product build and I'm not sure this was the
right fix for the problem.
This reverts commit bb4d5d96f4daf1dc1b92f823171ac567f6cf95a8.
The actual purpose is to help Plasma taskbar associate taskbar items
with .desktop files for the purpose of creating launchers. LibreOffice's
WM_CLASS handling is rather broken, but the class part of it usually
ends up being 'libreoffice-<component>', which however doesn't match
names of .desktop files or executables. I fear renaming .desktop files
would cause too much breakages in various places that expect the current
names, so adding StartupWMClass will help Plasma match them.
Change-Id: Ia946307b429d9a7c00408b2b508726fdc88908ac
(from white) to allow fill settings in the various apps to have an
effect
(cherry picked from commit 0050a8e4eace17ed1b55c7ec919edaa0daadc3a7)
Conflicts:
chart2/source/model/main/PageBackground.cxx
sc/source/ui/drawfunc/fuins2.cxx
sd/source/ui/view/viewshe2.cxx
Related: #i121334# turned back chart non-fill defaults...
done the non-fill using tooling when creating new chart modules
(cherry picked from commit af9220c24c9d80e5415d9d7d8f273b28d0d27cdb)
Conflicts:
chart2/source/model/main/PageBackground.cxx
sc/source/filter/starcalc/scfobj.cxx
sd/source/ui/view/viewshe2.cxx
svx/inc/svx/charthelper.hxx
svx/source/svdraw/charthelper.cxx
sw/source/ui/table/tablemgr.cxx
Related: #i121334# deactivated setting chart OLE background to transparent...
for better UI experience and better back-compatibility to other OpenOffice
derivates
(cherry picked from commit 5fa621198a981ea994d9903298e8a1d884ee686b)
Unname unused arguments to prevent compiler warnings.
(cherry picked from commit c3c4df7647d8d4ab1425bb3c7f38932c4adcbe74)
Change-Id: I1b4579aca701a4d637d21d7963b87f637458d0a5
01855cc3d4ec3c321109f924f6de4cdfbec4cd5d
18757f64ae84a415dc781929db4b76f571172ab1
de9879c2e1c249c0d957e4e46723b167ae1a8e90
AttributeOutputBase::TextField() passes the address of its local
variable to WriteExpand(), and DocxAttributeOutput::WriteField_Impl()
stored this. When it was to be used, the variable already went out of
scope, resulting in a crash. Given that SwField is an abstract base
class, the easiest way is to just copy the field and manually delete it
when it's no longer needed.
Change-Id: I9d1fe2485277f1ac21a576d7ff0d05003f0ac8a1
First attempt confused things ( and was error prone ) by introducing
maStart and maEnd BorderLine members to BorderLine model. Better to
just leave maLeft & maRight and attempt to swap if RTL.
Of course tbh this is somewhat of an optimistic attempt to swap start and end borders
if needed. I am not at all sure though that I am dectecting the RTL-ness
of a cell in the correct way. There are some comments in the code in any case
that reflect my uncertainty ( hopefully they will be of use if/when some tweak
is needed )
Change-Id: Ie953d73067630f0041fa037c6120cdbda683e796
it was removed with 66714f1888eaccef4eb5341971278ae7dfafa16b
but gobs of code (and UI) still existed to collect the help id
and give it to the missing help agent with various UI visible
options and buttons to control the help agent which isn't
there
Change-Id: I625da27b3046d481e43f4d35d32cc7063a1c6291
GetCaseCorrectPathNameEx() with bCheckExistence = true doesn't support windows
share path but occasionally it doesn't return failure and returns broken result.
For example, when we call with "\\USER-PC\Users\foo" then it converts the path
to "\Users\foo". And when "\Users\foo" exists, it returns "\Users\foo". It is
caused by missing error handling of searching for file "\\USER-PC". Also similar
bug possibly occurs even for local file path. This commit fixes these bugs.
Change-Id: Idf1dd1282510d8a6810ed239a83051bb0f8e2f87
Reviewed-on: https://gerrit.libreoffice.org/4151
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
The problem is the following: SwLayAction::InternalAction() saves
pPage->GetPrev() as pTmp, then SwFrm::CheckPageDescs(pPage) is called,
which deletes pPage->GetPrev(). SwLayAction has no idea that pTmp got
deleted, and later passes it to unlockPositionOfObjects(), which
obviously assumes a valid pointer.
To be on the safe side, just provide a possibility to let the caller
know its pointer has been deleted.
Change-Id: Ibb4d83266b1f4b6146a12dce0d4701f1056deecd
just set the Anchor to Alignment_TOP_RIGHT
Found by: Shan Zhu
Patch by: zhaoshzh
Review by: zhangjf
(cherry picked from commit 8de6941efffd22214da577ff637b2522e46c7fa5)
Conflicts:
oox/inc/oox/drawingml/chart/converterbase.hxx
oox/source/drawingml/chart/titleconverter.cxx
Change-Id: Iad1fe1af8f93e6904759c10a9c9206fd1f1aebbb
