Commit Graph

897 Commits

Author SHA1 Message Date
9eb4e4dc51 Some more modules at least building with mingw64
Change-Id: I3ea039655aecb7885bb310b1f2c29d66f9f7bb4f
2013-06-06 19:49:56 +02:00
287bc2bb76 Drop unused XInitialization from implementation
...now that it has been dropped from the service declaration with
75a87d9bc25c9c74810591bbfa560b0f7184e940 "fdo#46808, Convert
xml::crypto::XMLEncryptionTemplate to new style"---appears to be nonsense that
had been in there "since the beginning."

Change-Id: I75826b7eb0a4d5538204394a8f0e9c9e9f1393da
2013-06-05 18:17:35 +02:00
496a2c2e46 Drop unused XInitialization from implementation
...now that it has been dropped from the service declaration with
6a12e13870f15df93d2627f1538f7c64ca46e9e5 "fdo#46808, Convert
XMLSignatureTemplate service to new style"---appears to be nonsense that had
been in there "since the beginning."

Change-Id: I4e4d3649f1aa0dacebdc8bdcee0348cee294ab89
2013-06-05 17:29:14 +02:00
d11e59088f fix superclass-constructor call.
Was introduced in commit
   a4196fc3cf1e20e32cda9477a33ff56515f0c24e
   "fdo#46808, Convert XMultiServiceFactory in xmlsecurity module"

Change-Id: Ie06a3c89e3a8b4cf43e68afd575a0e86b48d6bc2
2013-06-05 15:22:49 +02:00
75a87d9bc2 fdo#46808, Convert xml::crypto::XMLEncryptionTemplate to new style
Change-Id: I45bcb3f0f4b9998105d361dbf6a98d8f5310da52
2013-06-05 14:48:20 +02:00
6a12e13870 fdo#46808, Convert XMLSignatureTemplate service to new style
Change-Id: I80530f84ad5a86eccc794f9ddd14f939d093a20d
2013-06-05 14:48:20 +02:00
a4196fc3cf fdo#46808, Convert XMultiServiceFactory in xmlsecurity module
Change-Id: Ia134170d07f33c2649b2a2620f40bc7b45ec7e16
2013-06-05 14:48:19 +02:00
dcbaf7c253 remove unused componentcontext.hxx includes
Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
2013-06-05 08:13:21 +02:00
3d8a7a435c Resolves: #i120675# the certificate store handles need to be closed
after closing the document

Found by: zhangjf
Patch by: zhangjf
(cherry picked from commit 33d9584bb6d285de1d935bf23adbb2c7666656f4)

Change-Id: I131a17276f33059eb944fc34272c50f838b6973f
2013-05-16 16:26:34 +01:00
e8eab43eeb cleanup whitespaces due to RTL_CONSTASCII_USTRINGPARAM removal
In e2e2cc61144cb22227eebfadff0ea24b51ccfbd0 the method was removed
automatically leaving several line breaks etc. as visual noise.
2013-05-06 19:21:07 +02:00
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
3155a8e60f xmlsecurity: drop no longer needed RTL_ASCII_USTRINGPARAM macro
Change-Id: Ia08688ef3c262ba4379213231032c73404ae748b
2013-05-06 09:24:01 +02:00
1e83da9aed some more namespace cleanup
Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
2013-04-26 18:01:51 +02:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
e79b387e03 It is very wrong to #undef _DEBUG in some source files of a library
Nowadays in a dbgutil build with MSVC, the debugging runtime (C++
library) is used. Just like with the GNU libstdc++, it is not binary
compatible with the non-debugging variant.

All sources that go into one DLL or EXE must be compiled with the same
_DEBUG settings (unless one is extremely careful and knows exactly
what one is doing, which presumably is not the case with this code).

With previous compilers this has gone undetected, but with MSVC2012 at
least, you get link-time errors, which is a good thing:

nssinitializer.o : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in biginteger.o

nssinitializer.o : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in biginteger.o

Whether this actually has caused run-time erroneous behaviour or
not in a dbgutil build is another thing...

Change-Id: I0c42161f00a0e37b438e3b911e3c0058edadd800
2013-04-17 13:23:35 +03:00
ba044b1e96 remove needless forward rtl::OUString declarations
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
2013-04-07 14:23:12 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
049ce78144 remove local css definitions
follow-up of 66a175834c39ccde9475eac3adb72a843110d01f

Change-Id: I1c495041ccc4db4dd9554d49b6324e989fa46c60
2013-03-30 00:56:42 +01:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
a9e6e5bf4d The [_]DEBUG_WAS_DEFINED macros are not used here
...but only in connectivity/source/drivers/mozab/{pre,post}_include_mozilla.h,
which is never included from here, so this smells like cargo-cult.

Change-Id: Iac0d7d60caad7c090445d551b7adb50424130e2a
2013-03-25 08:52:56 +01:00
ec52e5e5a2 Consolidate XMLSEC_NO_SIZE_T setting in xmlsecurity/xmlsec-wrapper.h
...so all xmlsec/*.h includes are bundled there now (except, for pragmatic
reasons, the xmlsec/mscrypto/*.h ones that unconditionally include windows.h and
only work on Windows).

Change-Id: I33e642f4f6a2e40edd6950af7f209c8b76c6e5fe
2013-03-25 08:52:55 +01:00
3b006a10b7 stricmp macro is unused
...since f3eb77586e067a46211334a78987652815f47744 "further removing of dead
code."

Change-Id: I6805c5adafcf19782f352cdacd0d99a9e7681eb6
2013-03-25 08:52:55 +01:00
9cac657749 add cui to Library_merged
Change-Id: I485426c0a0792e17bae5ef125d69f52827b469b2
2013-03-24 08:55:55 -04:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
1af22c05c6 fix other problems found by Wundef
Change-Id: Ib4aba95436f82d2a20b07a092f0fd07e0620fdcf
2013-03-18 17:15:57 +01:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
4bf95c4c31 make use of startsWith()
Change-Id: Ie70097de550ddd1cddc6714f8f86f9723cb36679
Reviewed-on: https://gerrit.libreoffice.org/2599
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-08 13:16:49 +00:00
5ecb308bd3 rename setInitialLayoutSize to setOptimalLayoutSize
and add a mechanism to know that we're in true
initial layout mode

Change-Id: I4ff61160ae67a7ccf1cb8b25c41870c195d32b94
2013-03-07 14:06:17 +00:00
41e03a166e doubled using
Change-Id: Ib1d3213a688194bfb027b7bca5bd9ac1b7bb1b28
2013-03-05 12:34:33 +01:00
ecda52f6b3 callcatcher: unused code
Change-Id: I7dcaa6f57815321e108cd7ce284fe145dc0506f2
2013-03-04 11:23:59 +00:00
875c997c7d fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher
Removed several unused methods.

Could not remove ScVbaFormat<ooo::vba::excel::XStyle>::getAddIndent() and ScVbaFormat<ooo::vba::excel::XStyle>::setAddIndent(com::sun::uno::Any const&) because it breaks compilation (they are implementing pure virtual methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
        unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
2013-02-27 15:40:16 +01:00
f1a96446fa Remove duplicate OID
This ID is refers to digestedData and hashedData.

http://msdn.microsoft.com/en-us/library/windows/desktop/aa381133(v=vs.85).aspx

Change-Id: I2b9585332e27fad860aee458ef3183a9772e9c3f
Reviewed-on: https://gerrit.libreoffice.org/2403
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-02-26 09:10:27 +00:00
dd3e879cfd remove some trivial duplicates
Change-Id: Ie736cb6d5ff7f4d1998338f4a3a3a3b0a67c79ad
2013-02-25 19:34:36 +01:00
3648c3226d Add OIDs for Russian crypto algorithms.
Change-Id: Id1d6a623863d7643401dce912991e61de16695f2
2013-02-24 13:56:37 +01:00
eb7185a168 Fix typo begining/beginning.
Change-Id: I9fff386181a2be0bc83787c8b5aec9c1cb4db9c3
2013-02-23 19:17:03 +01:00
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
931f62a520 coverity#735579 Logically dead code
Change-Id: I68a1dc0926b1310b196212e0ec602cc9d78b43de
Reviewed-on: https://gerrit.libreoffice.org/2230
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:51:17 +00:00
0be1b5f4a6 coverity#982735 Negative loop bound
Change-Id: I597cd1204b0b7f5c7351482c3cdd00fc6111218a
Reviewed-on: https://gerrit.libreoffice.org/2224
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:50:50 +00:00
975e269476 coverity#705782 Resource Leak
Change-Id: I8346d3fd2ce4345cc9a352abb608cfec5f6939f4
Reviewed-on: https://gerrit.libreoffice.org/2223
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:49:57 +00:00
50ba5ad06a coverity#982249 Unchecked return value
Change-Id: I959599c899b489aa42ccce60c6794869041522a0
Reviewed-on: https://gerrit.libreoffice.org/2222
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:48:32 +00:00
21f13f91f9 coverity#705976 coverity#7074977
Change-Id: Iaedb5fcd87a24f478d7c4a9c25e32cd2d0ee55da
Reviewed-on: https://gerrit.libreoffice.org/2221
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-02-22 07:47:47 +00:00
ef1d096ddc fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT
- replaced osl_trace with sal_info
 - added new log areas to log-area.dox

Change-Id: Ib47c4b4c9604bca1f8a635dd01bb89702b47b591
Reviewed-on: https://gerrit.libreoffice.org/2010
Reviewed-by: Thorsten Behrens <tbehrens@suse.com>
Tested-by: Thorsten Behrens <tbehrens@suse.com>
2013-02-19 16:02:40 +00:00
9a49ff646b nsscrypto_initializer: MSVC does not support C99 dynamic arrays
Change-Id: I407b2308756b46fbf0920881fc20972b486819b7
2013-02-19 11:34:29 +01:00
08ac21ddd9 coverity#705355 coverity#705356 Missing break in switch
Change-Id: I9a0a370eb1279a184a47e15bcefc6ce5e4025aa3
Reviewed-on: https://gerrit.libreoffice.org/2226
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-18 23:15:49 +00:00
21e2c2f164 coverity#982590 Explicit null dereferenced
Change-Id: Ie898603f64a4568a8502caf3db154ae5ce008af9
Reviewed-on: https://gerrit.libreoffice.org/2227
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-02-18 23:12:09 +00:00
cbe8883b51 coverity#982591 Dereference after null check
Change-Id: I8651ecb0287d686da3e1ca6a6e46549abe3e0c38
Reviewed-on: https://gerrit.libreoffice.org/2225
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
2013-02-18 21:38:42 +00:00
c163123e1f adapt macro security dialog code to .ui
Change-Id: I0527ff30508bd7fd9182ff0bfec87aef7907f1fb
2013-02-15 08:50:08 +00:00
6b3ecd1140 drop unused hid
Change-Id: Ie176d91aaa39a354829630bdca3d39cb75146651
2013-02-14 20:23:23 +00:00