Commit Graph

419897 Commits

Author SHA1 Message Date
ff6def51db forcepoint #5 check for short read
a zip file within a structured storage stream. underlying storage stream
claims larger size that it can satisfy on read

Change-Id: I8516b12df33ad78b2525192826f5e3aef2622eb8
Reviewed-on: https://gerrit.libreoffice.org/50238
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-23 18:10:46 +01:00
e2d8e2e0e2 tdf#115374: add GPG SEInitializer service for Windows
Amends commit 1c58b047d117bb087abc571b74c06cdf7499b1a0, seems we
need that now on Windows, too

Change-Id: Ia0c5e1e577a4f8dfe02b4d8eda0d220fa5e5f2a1
Reviewed-on: https://gerrit.libreoffice.org/50235
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-23 17:11:06 +01:00
1f3dd8f60c Fix --enable-python documentation
python is always used at build-time. Saying that --disable-python disables
python support at build-time is confusing.

Change-Id: Ic7206c832b1cf3ee41d67152198660c13aa86652
Reviewed-on: https://gerrit.libreoffice.org/50229
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-23 15:51:10 +01:00
e208b81540 Don't reformat all connectors every time spellchecking timer fires
Editing document with many (~1k) connectors eats all available CPU
power as every spellchecking event locks and then unlocks SdrModel
which in turn repositions ALL connectors in entire document, so let's
not do that

Additionally, set OutlinerParaObject and broadcast only when something
has actually changed

Change-Id: I647b7309729dce153b8e05eff4677fe7bb9840a7
Reviewed-on: https://gerrit.libreoffice.org/49995
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-23 15:27:43 +01:00
16700331da tdf#114768: Update default font list for Simplified Chinese
Change-Id: I23e92f1248d8f0bc424278e565bd5bfdbe30f7c5
Reviewed-on: https://gerrit.libreoffice.org/49520
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2018-02-23 13:51:22 +01:00
4902aeff48 tdf#113651 Sync Calc Track Changes commands with Writers
For a consistent UX

Change-Id: I1ad937124786d2e7d0a752f819144172ae902ed5
Reviewed-on: https://gerrit.libreoffice.org/45267
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-02-23 13:49:44 +01:00
64ada386b9 new loplugin:doubleconvert to with ColorData work
Change-Id: Ib8f2ef485f548645c4b0e7cf080b72b28c4e278d
Reviewed-on: https://gerrit.libreoffice.org/50226
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-23 13:40:15 +01:00
5746488461 blind android build fix
Change-Id: I8e5722ee922c609fa71c766692f79f138217bf05
2018-02-23 12:37:02 +00:00
508ac4c37e oss-fuzz: explicitly mention the rc files we want
Change-Id: Iabefbc3873b45f58fb8e493d043b0e08a3f425f9
2018-02-23 11:50:41 +00:00
03fc57826e no point in a checkbutton having a response
Change-Id: I2376336617d5ef324e03fa8a93137d3273dabc60
Reviewed-on: https://gerrit.libreoffice.org/50195
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-23 12:24:26 +01:00
c557889748 copy multiple single row cond formats correctly, tdf#115835
Change-Id: Ic20cc27f03edf3dbd27975f99c788bf5bffd4c48
Reviewed-on: https://gerrit.libreoffice.org/50211
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23 11:33:17 +01:00
2d5a9e9f26 tdf#115933 set document read-only on presence of hashValue attribute
Though there's currently no way (password dialog) to edit the
document other than saving it to a different file, this seems to
be what is expected.

Change-Id: Iafa8ac9f6e41c3011ed0ad4b19cc57382c9f2a75
2018-02-23 11:16:58 +01:00
0fe1b2fb82 Read algorithmName, hashValue, saltValue, spinCount, tdf#115933 prep
Change-Id: I799d4652099059fcd09088c02537ed5dec087259
2018-02-23 11:16:58 +01:00
62767cf606 Read algorithmName, hashValue, saltValue, spinCount, tdf#104250 prep
Change-Id: Idc68ad62e8420646d5aecd0d4126084390a1ed55
2018-02-23 11:16:58 +01:00
cffecd3c8d tdf#80282 swpagerelsize: corner case frame size max
Before the swpagerelsize commits,
(specifically 7c7fdf3e97bbf2301f9938082d4d44162f4ec3c0),
the max size was always Prt(). The regression comes if
the RelFrame is a pageFrame (like when the image is
anchored to the page). Then sometimes no maximum is set.

Change-Id: If1e93ce670bd0908eb2d1f89dabbe9861163d29e
Reviewed-on: https://gerrit.libreoffice.org/50034
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-23 09:31:37 +01:00
e3166f4034 Merge "Enable device=dri to fix opengl crashes" into flatpak-manifest.in
...from <https://github.com/flathub/org.libreoffice.LibreOffice/pull/18/commits/
637788fa1d9fc6514467a4a193e5cf32f696b400> "Enable device=dri to fix opengl
crashes"

Change-Id: Ic989bfb3e46057dc2fd20d2cd6f17d5733338642
2018-02-23 09:22:10 +01:00
5e1a50cc43 tdf#115883 DOCX import: catch RuntimeException from SwXFrame
getPropertyValue("Surround") for a non-inserted frame can throw, but
hasPropertyValue("Surround") still returns true. So fix the regression
by just catching the exception, assuming that in that case no increased
spacing is needed.

Change-Id: I49a78ce8d41b4e1cc7d23721d5dc70f7550c94af
Reviewed-on: https://gerrit.libreoffice.org/50175
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-23 09:06:16 +01:00
a2e53070ca xmlsecurity mscrypt: create XMLSignature instances with a constructor
Change-Id: Ie30885226d1ede4293adc888e587d6111343f5af
Reviewed-on: https://gerrit.libreoffice.org/50144
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-23 09:05:59 +01:00
b9e591e7ab Updated core
Project: help  76635096e9c9832d856e8eb1798ce70256f6d81b

Adapt CustomTarget_helpcontent2/source/auxiliary

...to core 906a2e4fa4e9ce231126c608e741c0c0d809157d "Always execute
pack_images.py with the right Python interpreter"

Change-Id: I7c6c9aed33222fb5b902e30a05cefe8f88c66df1
2018-02-23 08:46:18 +01:00
391660de41 lokdialog: Allow Execute()ing first, silently cancels others
We want to be able to detect which dialogs are important and need to be
converted to async while not completely disallowing them. Allow only
first instance of such dialogs being Execute()d and warn when another
such instance tries to Execute().

Change-Id: I6742784fa95d9e3f9ff87ece294126d390ae9e9e
Reviewed-on: https://gerrit.libreoffice.org/50092
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-23 08:43:40 +01:00
190a44fe05 lok: Factor out the code for finding vcl::Window of a document
This should also help with IME input on charts

Change-Id: Ie513790a5d0c87397c39301a328a44b59d394a45
Reviewed-on: https://gerrit.libreoffice.org/50091
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-23 08:43:31 +01:00
ce43b10cca get headless build to work again for Linux
This makes --disable-gui option build successfully again - which
means we again run on a headless server w/o any X11 or OpenGL libs.

Change-Id: I60019af571aecdac277adbe6d34d5fff065014f9
Reviewed-on: https://gerrit.libreoffice.org/50214
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-23 08:41:11 +01:00
b37a46fdf9 tdf#115938: Properly detect shadow size control's changed state
This change makes sure that only if the shadow size edit box' text
is changed, it is converted to the size in twips. It sets wrapper's
default value on each SetControlValue, to return proper initial
size when the size text wasn't modified.

Also both ExampleSet and OutSet in SfxTabDialog's Reset handler are
processed to set relevant items back to initial value; otherwise,
as the restored item (marked as unchanged) will be absent in tab's
result set, it would not modify the old items in the two, and they
would keep previous modified values.

Change-Id: Ie4362811968c6e6cbe0f9229bd3c9b29462f5704
Reviewed-on: https://gerrit.libreoffice.org/50196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-23 07:15:28 +01:00
fecc5d4a44 fix crash while trying to access icon set image file
Change-Id: Iaad9b5aeb4163a5262bcaf0a414ee30fd9279a49
Reviewed-on: https://gerrit.libreoffice.org/50219
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23 03:06:28 +01:00
f5eb32c635 fix incorrect icon set size
Change-Id: Iadd08f5a95121cc2c5e6ac0d5719bdfa07b5c95a
Reviewed-on: https://gerrit.libreoffice.org/50220
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-23 02:58:12 +01:00
06f04bf84d Simplify conditions a little
Change-Id: Iaa587f1a2d78f14b999f2e9e866db058d466493f
Reviewed-on: https://gerrit.libreoffice.org/50137
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-22 22:41:58 +01:00
6103b6698c add some whitespace to make it more readable, no change
Change-Id: I7a08d316b5d7fc99043344b1cf7cb8e326df75ae
Reviewed-on: https://gerrit.libreoffice.org/50170
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-22 22:18:25 +01:00
6a4c464b49 weld native message dialogs
just the straight-forward MessageDialog cases first

a) remove border_width from message dialog .ui so as to take
the default border width
b) retain 12 as default message dialog border for vcl widget case
c) remove layour_style from message dialog button boxes so as to
take the default mode (a no-op for vcl widget case)
d) use gtk response ids (vcl builder will converts to vcl ones)

Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154
Reviewed-on: https://gerrit.libreoffice.org/50143
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22 22:07:38 +01:00
f7733528e8 tdf#68889: Fix the weight reported by the system for the problematic font
Like the previous fix for Courier Std. Let's hope there won't be a lot
of these special cases. Maybe some generic heuristic would be better.
Like if a font's GetStyleName() is "Medium", "Medium Oblique", or
"Medium Italic" then always force its weight to be WEIGHT_NORMAL?

Change-Id: I204655cd9c4e32d5cbbd68bb93c6282d23993b80
2018-02-22 22:49:48 +02:00
f0a14acc4e sw: remove "ReplacementGraphicURL" related things
Change-Id: Ia6892e3cd84b2466ea30828e9b18310789dc1686
Reviewed-on: https://gerrit.libreoffice.org/50138
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-22 21:42:51 +01:00
06db1b3bd9 solenv: Update gb_PackageInfo_emit_l10n_for_one_lang
Add cjk_*, ctl_* and ctlseqcheck_$LANG.xcd files to install list

Change-Id: I2c56cf2af3cc444cb7075740a981b6954950e5f5
Reviewed-on: https://gerrit.libreoffice.org/50182
Reviewed-by: Rico Tzschichholz <ricotz@ubuntu.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-02-22 21:24:13 +01:00
906a2e4fa4 Always execute pack_images.py with the right Python interpreter
With --enable-python=fully-internal, where PYTHON_FOR_BUILD is empty, this
executed the "#!/usr/bin/env python" shebang in pack_images.py, using whatever
python would be found (or not) on the system.

With this fixed, there is no need any more for pack_images.py to be executable.

Change-Id: I40ad3769898f3eb711dbe555d4c3faa9e3c1456d
Reviewed-on: https://gerrit.libreoffice.org/50180
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22 21:21:16 +01:00
50bf4eec6f Use long path prefix in osl_getFileStatus
When installing an extension e.g., paths can get very long and they
hit the 255 char limit, thus the installation fails.
So we need to prefix the path with the long file name prefix
when its longer than MAX_PATH for windows api calls to succeed.

Change-Id: Ie62644192ba40a9d4802772cd9837fc84fae947a
Reviewed-on: https://gerrit.libreoffice.org/50079
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-22 20:23:39 +01:00
5ec76e5988 Bin unused function
Change-Id: I38e9f2e21fdb7cfeb379278e9300e6451c8b970d
2018-02-22 21:21:11 +02:00
4a8968039a loplugin:changetoolsgen in vcl
Change-Id: I0fc68cf51fb23ed9bb86a5087e8247c81b024494
Reviewed-on: https://gerrit.libreoffice.org/50107
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22 20:18:57 +01:00
1d7f96a324 tdf#67744: Fix the weight reported by the system for the problematic font
A hack, but oh well.

Change-Id: I13580d27acfb0cc200bdb0cc1911518675d3e32e
Reviewed-on: https://gerrit.libreoffice.org/50172
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-22 19:31:58 +01:00
8bd289c43c tdf#103690: Set up notifications only after VCL has been initialised
On some Macs, it seems that LibreOffice (or any app?) gets an
NSApplicationDidChangeScreenParametersNotification as soon as it has
started and asked for such a notification. Our handler for that
notification assumes that VCL is initialised. Thus we should not ask
for such notifications before VCL has been initialised.

I could not reproduce the reported crash with an unmodified
LibreOffice, only after inserting a sleep after the notifications had
been set up. But I am fairly sure this change fixes the problem.

Change-Id: I18d342eb7dc0c77cb7fc8623756bead65a1bd329
Reviewed-on: https://gerrit.libreoffice.org/50164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-22 19:20:28 +01:00
d4b4f5f1f4 Remove useless special handling of single-value ranges
... as they are treated by generic code just fine.
A check added to guard against overflow (0xFFFF + 1 -> 0).

Change-Id: Ibef85191eab82002981e12f83f313f3d122da74c
Reviewed-on: https://gerrit.libreoffice.org/50163
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-22 18:12:27 +01:00
b7e8ae27f8 Fix clean-up of gb_UIConfig_get_a11yerrors_target
The old code tried to remove non-exisiting *.a11yerrors files corresponding to a
UIConfig's individual *.ui files, not the one single *.a11yerrors file
corresponding to the UIConfig itself.

Also, there's no need to have a UIA11YErrorsTarget merely for clean-up.  Just
do that clean-up as part of gb_UIConfig_get_clean_target.

Change-Id: I6676f08496254398801bb75172c1326d1c843071
Reviewed-on: https://gerrit.libreoffice.org/50156
Reviewed-by: Samuel Thibault <sthibault@hypra.fr>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22 18:07:10 +01:00
ad1a885e3b Updated core
Project: help  235783d1ed47620748fe297f5ff5133121fbe75e

tdf#114995 CSV Link external data help page

Change-Id: I932bb17e0c599ea79dba950733e354e86f6efce4
Reviewed-on: https://gerrit.libreoffice.org/50193
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-22 17:18:10 +01:00
01d64f4bee Updated core
Project: help  75cf318614f73c93a51538a9508ccca2b47f82b1

Deletion [Runtime] from names functions

[Runtime] was deleted
[Runtime - VBA] was replaced to [VBA]
Combination of words "runtime functions" and "runtime categiries"
was replaced to "functions" and "categiries" respectively

Change-Id: I1f03a5f2ef1697e216e144ecccbfb8942b315718
Reviewed-on: https://gerrit.libreoffice.org/49914
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-22 17:17:46 +01:00
dc646858a2 Updated core
Project: help  5339d3c91fb81ea593a96c5602b767d68aba623f

tdf#115831 Review of rename sheet help page

Change-Id: Ibe2db947cd6a1ef52231013a6ecdb9efbf2e99a2
Reviewed-on: https://gerrit.libreoffice.org/50192
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-22 17:17:17 +01:00
1888a60200 Remove unused forward declarations from vcl/syswin.hxx
Change-Id: Ide4990afa32ba4cc7851d0e7d3d8d1247eb27b3b
Reviewed-on: https://gerrit.libreoffice.org/50155
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22 17:05:59 +01:00
9de93343af gb_UIConfig_get_imagelist_target missing from clean target
Change-Id: I541bd57815bd66978326486b29165d0480d8a7b6
Reviewed-on: https://gerrit.libreoffice.org/50157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22 16:47:40 +01:00
136dfa3fe0 Updated core
Project: help  90671d8531b28cebf6129402932320a437cf4544

tdf#115831 Renaming of sheet

Renaming of sheets have the same constraints whatever
the file format used.

Max number of sheets is 10,000. See tdf#44443

File modified with HelpAuthoring

Change-Id: Iff4ecdea6cdfede9844475eaac31c27c9d903a3d
Reviewed-on: https://gerrit.libreoffice.org/49949
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-22 16:44:41 +01:00
c7752298d4 Process all added uifiles
Change-Id: I9efb05973e7d8468afb82bd9875d527412a4fd1c
Reviewed-on: https://gerrit.libreoffice.org/50116
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-22 14:57:38 +01:00
367f7dd5f0 update emoji autocorrect files from po-files
Change-Id: Iee7034c3800b159694c3d03a8eed665d3360e6b8
2018-02-22 14:10:37 +01:00
8faa6b8bba update credits
Change-Id: I189e30718e5818d183dc308ecbb96f4943b4e20a
2018-02-22 13:55:08 +01:00
0c371a6b5e tdf#112689 : Replace chained O(U)StringBuffer::append() with operator+
Change-Id: I119d33b171da7024daab5c4ca4488ceb495eab2f
Reviewed-on: https://gerrit.libreoffice.org/49898
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-02-22 13:57:00 +01:00
e313f0f959 uitest - writer Watermark dialog
Change-Id: If701a563ce2ff0e811dfcaae6852ada05c925ce3
Reviewed-on: https://gerrit.libreoffice.org/50126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-22 13:30:38 +01:00