wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
419,897 Commits 5 Branches 0 Tags
ff6def51db86ea2a516739f2dd67f24fa024af4e
Commit Graph

2760 Commits

Author SHA1 Message Date
Caolán McNamara
6a4c464b49 weld native message dialogs 
just the straight-forward MessageDialog cases first

a) remove border_width from message dialog .ui so as to take
the default border width
b) retain 12 as default message dialog border for vcl widget case
c) remove layour_style from message dialog button boxes so as to
take the default mode (a no-op for vcl widget case)
d) use gtk response ids (vcl builder will converts to vcl ones)

Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154
Reviewed-on: https://gerrit.libreoffice.org/50143
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-22 22:07:38 +01:00
Shubham Verma
0c371a6b5e tdf#112689 : Replace chained O(U)StringBuffer::append() with operator+ 
Change-Id: I119d33b171da7024daab5c4ca4488ceb495eab2f
Reviewed-on: https://gerrit.libreoffice.org/49898
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
 2018-02-22 13:57:00 +01:00
Noel Grandin
bddd6c7781 Revert "loplugin:changetoolsgen in avmedia..basic" and reapply plugin 
because I
(a) forgot to insert parentheses which changes the meaning of some expressions and
(b) I now use the AdjustFoo calls when changing unary operations, which reads much better

This reverts commit 1adb1a320a7e9832a41545bde13fd59d27ce7954.

Change-Id: I52924b35008c8e4b44c8a6b6657cc3a1ac513886
Reviewed-on: https://gerrit.libreoffice.org/49848
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-16 19:50:47 +01:00
Caolán McNamara
7faa218231 ofz#6311 still problems with SdrEdgeObj listening to same obj at start as end 
Change-Id: Ibd80b484788779b73943b28a5f36e51ebcacec30
Reviewed-on: https://gerrit.libreoffice.org/49821
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-16 00:35:10 +01:00
Noel Grandin
1adb1a320a loplugin:changetoolsgen in avmedia..basic 
Change-Id: I4e355ae27b9fad1cc6e8f8f408dbd9e93d7256d7
Reviewed-on: https://gerrit.libreoffice.org/49603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-13 07:38:03 +01:00
Gabor Kelemen
4fae455fcd tdf#42949 Remove unneeded helpids.h headers (1/3) 
A side effect of the .ui migration is that we use a lot less HIDs
in the code. A lot of files still contain helpids.h includes
even if no actual HID is referenced.

This cleans up directories b* - e*.
Found with:
git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_  | grep :0$

Change-Id: I221d22f68584115d71660a97c4f108595625d12c
Reviewed-on: https://gerrit.libreoffice.org/46868
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-02-01 15:19:36 +01:00
Noel Grandin
945a119675 loplugin:constparams 
Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504
Reviewed-on: https://gerrit.libreoffice.org/48392
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-24 07:56:57 +01:00
Noel Grandin
be94207ecb new loplugin:emptyif 
Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42
Reviewed-on: https://gerrit.libreoffice.org/48128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-19 13:25:54 +01:00
Stephan Bergmann
f867ead158 Fix callback function type 
...that got broken with c394363c84064c041391627602665ea1fa74db60
"loplugin:constparams in basctl", causing -fsanitize=function to complain:

> sfx2/source/appl/app.cxx:452:28: runtime error: call to function basicide_handle_basic_error through pointer to incorrect function type 'long (*)(void *)'
> basctl/source/basicide/basobj3.cxx:48: note: basicide_handle_basic_error defined here
>     #0 0x7ff6340234aa in SfxApplication::GlobalBasicErrorHdl_Impl(SfxApplication*, StarBASIC*) sfx2/source/appl/app.cxx:452:28
>     #1 0x7ff63401cbef in SfxApplication::LinkStubGlobalBasicErrorHdl_Impl(void*, StarBASIC*) sfx2/source/appl/app.cxx:434:1
>     #2 0x7ff639142148 in Link<StarBASIC*, bool>::Call(StarBASIC*) const include/tools/link.hxx:84:45
>     #3 0x7ff63911f350 in StarBASIC::RTError(ErrCode, rtl::OUString const&, int, int, int) basic/source/classes/sb.cxx:1681:37
>     #4 0x7ff63965aafe in SbiInstance::Abort() basic/source/runtime/runtime.cxx:518:16
>     #5 0x7ff639664363 in SbiRuntime::Step() basic/source/runtime/runtime.cxx:865:28
>     #6 0x7ff6392ec321 in SbModule::Run(SbMethod*) basic/source/classes/sbxmod.cxx:1141:25
[...]

Change-Id: I66bd1ca720cebca4fb5fd52d86920de3fc7a604e
Reviewed-on: https://gerrit.libreoffice.org/48142
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-19 08:20:01 +01:00
Andrea Gelmini
a6b69a9384 Fix typo 
Change-Id: I51c97356c9c2939f2d94d6388c829a179ca00daa
Reviewed-on: https://gerrit.libreoffice.org/47853
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-01-15 13:53:21 +01:00
Stephan Bergmann
e662242ec0 More loplugin:cstylecast: basctl 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I3bddf4b08e064dead05eae87619db2232744d7f8
 2018-01-12 20:29:48 +01:00
Noel Grandin
f14b9d3029 convert (a>b?a:b) to std::max(a,b) 
with something like:
   git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2'

Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413
Reviewed-on: https://gerrit.libreoffice.org/47602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-11 07:35:43 +01:00
Caolán McNamara
e7980e60ee Resolves: tdf#114766 gtk3 solar mutex assert 
since

commit 33de587e95dddfc8e3c89b84f90b3d1bca823dae
Date:   Tue Mar 17 12:56:54 2015 +0530

    tdf#88230: cleanup solar mutex yielding

    Use SolarMutexReleaser, instead.

Change-Id: Ied2c78f95592c87b7908d14e9ab6c78e62f987e7
Reviewed-on: https://gerrit.libreoffice.org/47590
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-01-08 20:01:45 +01:00
Jan Holesovsky
028fd03cdf lokdialog: Allow language switching in SfxModule(s). 
Change-Id: Icef0b3610c3bfa858cdd61de6ef3f5edc1e3c96b
Reviewed-on: https://gerrit.libreoffice.org/47385
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
 2018-01-05 09:51:23 +01:00
Noel Grandin
31b5c9b9bc remove SfxUsrAnyItem typedef 
and rename SfxUsrAnyItem class to SfxUnoAnyItem, the choice being made
by leaving the most popular one behind

Change-Id: If3818ee0966a50e3036d7e2db951910b6282c91f
Reviewed-on: https://gerrit.libreoffice.org/47313
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-04 07:17:38 +01:00
Johnny_M
ca58ddb012 Translate German comment 
Change-Id: Id65ccfe3b2394c8c30d3531316b70b511e34e366
Reviewed-on: https://gerrit.libreoffice.org/47131
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-01-03 16:45:31 +01:00
Noel Grandin
acdba3c2ee loplugin:passstuffbyref more return improvements 
slightly less restrictive check when calling functions

Change-Id: I35e268ac611797b1daa83777cda02288a635aa32
Reviewed-on: https://gerrit.libreoffice.org/47259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-03 08:07:41 +01:00
Noel Grandin
4b030651a0 loplugin:passstuffbyref improved return in various 
Change-Id: I0a8282d8e0d9575b055243073fc89a7d6b67b560
Reviewed-on: https://gerrit.libreoffice.org/47173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-29 18:19:37 +01:00
Noel Grandin
3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Noel Grandin
c947a25b3a loplugin:countusersofdefaultparams in basctl..basegfx 
Change-Id: I515acfb9de1f6dff1de94a60055c5b600e5e5241
Reviewed-on: https://gerrit.libreoffice.org/45957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-07 07:19:59 +01:00
Noel Grandin
9a06b99d2f loplugin:salcall fix non-virtual methods 
first, since those are safer to change than virtual methods

Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe
Reviewed-on: https://gerrit.libreoffice.org/45798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-05 07:32:46 +01:00
Noel Grandin
2e5508a176 loplugin:unnecessaryparen check for (f1()).f2 
Change-Id: I93257b0ddd41c649875124d6d5c5faeaa431bae3
Reviewed-on: https://gerrit.libreoffice.org/45218
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-27 10:44:25 +01:00
Noel Grandin
7a1c21e53f loplugin:simplifybool for negation of comparison operator 
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-23 06:59:31 +01:00
Caolán McNamara
2161d04688 drop duplicate method 
Change-Id: Idadd0a64e41cd02f5167b275081c3576a6224b12
Reviewed-on: https://gerrit.libreoffice.org/45075
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-22 13:33:25 +01:00
Caolán McNamara
33a477004c coverity warnings 
Change-Id: I456210188ab96e6be03e65c94eedb348cc93a8e1
Reviewed-on: https://gerrit.libreoffice.org/45023
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-21 18:23:46 +01:00
tagezi
94c76b6d26 renameModuleOrDialog: add missing check for valid Reference 
Change-Id: I2cf33a4fae4db45b854e77e31e166afa0281a054
Reviewed-on: https://gerrit.libreoffice.org/44956
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-11-20 16:37:15 +01:00
tagezi
9abd653129 tdf#108872 Also remove VBA module info on module removal 
If this information is left, then css.container.ElementExistException
is thrown on following creation of a module with the same name in
XVBAModuleInfo::insertModuleInfo called from
ScriptDocument::Impl::createModule
(see commit 2be139d76bdb66e77719613d802dc0047c284456)

Change-Id: I6750819ce36c112c146d7800a6bab4cc207e0062
Reviewed-on: https://gerrit.libreoffice.org/44940
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-11-20 15:42:02 +01:00
Andrea Gelmini
d6d58bbef9 Fix typos 
Change-Id: Ib138f971c4efcc67c68c901c9f08b4d1d95cdde2
Reviewed-on: https://gerrit.libreoffice.org/44933
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-11-20 11:23:12 +01:00
Caolán McNamara
5280b3eaa6 silence some coverity warnings 
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d
Reviewed-on: https://gerrit.libreoffice.org/44875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-18 21:59:23 +01:00
Johnny_M
97b5b99d71 Translate German debug strings 
Change-Id: If4da1df3f7889d2b579fcde4fec5ac3c82026555
Reviewed-on: https://gerrit.libreoffice.org/44627
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2017-11-14 08:24:32 +01:00
Noel Grandin
1aba1955f1 loplugin:finalclasses in basctl 
Change-Id: I5974cf3df434ebfff1e3748ddd291e2a21cbb0de
Reviewed-on: https://gerrit.libreoffice.org/44536
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-10 10:52:26 +01:00
Noel Grandin
3dde9d988f loplugin:constparams in various(1) 
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b
Reviewed-on: https://gerrit.libreoffice.org/44261
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-04 07:50:01 +01:00
Noel Grandin
5d618d73ed loplugin:constantparam in basic,basctl 
Change-Id: If918c42d4b82d78c07786cfa47c74d0dfb7493d6
Reviewed-on: https://gerrit.libreoffice.org/44131
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-01 07:14:13 +01:00
Michael Stahl
11d2f3d6e1 vcl: make MapMode constructor explicit 
Insert constructor everywhere, except a couple places that apparently
want to compare GetMapUnit().

Change-Id: I1910deb60562e5e949203435e827057f70a3f988
 2017-10-26 23:17:45 +02:00
Noel Grandin
80a30219c4 new loplugin:dodgyswitch 
and fix bug in ScriptDocument::getTitle
which has been there since

    commit e304ba66f4aba5cc55612508b5738a1ed26a7904
    Date:   Thu Mar 15 14:59:30 2007 +0000
    INTEGRATION: CWS basmgr02 (1.1.2); FILE ADDED

plugin is off by default since it uses expensive parentStmt() calls

Change-Id: Id0f16baec48e0381e0083594d7e59b58b023da2f
Reviewed-on: https://gerrit.libreoffice.org/43750
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-25 08:32:16 +02:00
Stephan Bergmann
249071dd50 loplugin:includeform: basctl 
Change-Id: Id7d19b16505aa42877c456e2ac270157077a9365
 2017-10-23 22:46:14 +02:00
Caolán McNamara
2e001b40ad Resolves: tdf#113252 missing tabs in basic library organizer 
Like SfxTabDialog, as in interim measure throw away the TabPage if its not
suitable for reuse

Change-Id: If8247ea37dfca42e690716a8b687677e0f73c9a8
 2017-10-20 12:54:14 +01:00
Jan-Marek Glogowski
7f7ed0260a tdf#113052 needs mpUIBuilder to load breaklistmenu 
The mpUIBuilder object is also used in the else branch,
so move the creation in the outer scope.

Change-Id: I18211bbe3c6f85cdd7697225159a98ad672a4ce2
 2017-10-11 19:54:18 +02:00
Julien Nabet
ef2e16d1a1 Use erase-remove idiom 
Change-Id: Ib62b7fd36d6390bf58d98a8213e444109d81aa16
Reviewed-on: https://gerrit.libreoffice.org/43302
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-10 22:58:28 +02:00
Mike Kaganski
81ced4022c basctl: consistently use "" and <> in include directives 
Change-Id: I1796836fb0d53bd07d621af9cfc03becc969d420
Reviewed-on: https://gerrit.libreoffice.org/43299
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-10-10 07:50:31 +02:00
Noel Grandin
2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Noel Grandin
d3971ec256 new loplugin:blockblock 
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd
Reviewed-on: https://gerrit.libreoffice.org/43025
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-03 08:41:11 +02:00
Noel Grandin
20bae560c0 throw more useful uno::Exception's 
if we're going to throw the base class of the exception hierarchy,
we can at least put a useful message in there to make the source a little
bit easier to locate.

Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566
Reviewed-on: https://gerrit.libreoffice.org/42968
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-01 18:17:11 +02:00
Samuel Mehrbrodt
b9a8ac48d7 Rename GetSelectEntryData -> GetSelectedEntryData 
Change-Id: Ia6402f6d2c978cbd5557052a43e9728ca9e11173
Reviewed-on: https://gerrit.libreoffice.org/42285
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-09-25 10:54:53 +02:00
Samuel Mehrbrodt
83de03e077 Rename GetSelectEntryCount -> GetSelectedEntryCount 
Change-Id: I405b347b404ed0acb3b6a0204e0b914a7698ce25
Reviewed-on: https://gerrit.libreoffice.org/42284
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-09-25 10:00:46 +02:00
Noel Grandin
ac80f048f2 loplugin:flatten in basctl..configmgr 
Change-Id: I674cad57ce30a885e126d3bcc921f8fcb53dc36d
Reviewed-on: https://gerrit.libreoffice.org/42577
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-21 15:18:57 +02:00
Samuel Mehrbrodt
d99b65c864 Rename GetSelectEntryPos -> GetSelectedEntryPos 
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4
Reviewed-on: https://gerrit.libreoffice.org/42283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-09-21 12:45:38 +02:00
Samuel Mehrbrodt
b649e5bf1d Rename GetSelectEntry -> GetSelectedEntry 
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce
Reviewed-on: https://gerrit.libreoffice.org/42282
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-09-21 12:44:00 +02:00
Jochen Nitschke
4067487eb3 clang-tidy modernize-use-equals-default in basctl 
to find unneeded explicit defined or default able
copy assignments and copy constructors.
Remove the default destructor if it's not needed.

Change-Id: I8c53a8622a53398889397132ec1f464e996ac49d
Reviewed-on: https://gerrit.libreoffice.org/42525
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-21 07:06:34 +02:00
Noel Grandin
84cbd6a543 clang-tidy modernize-use-emplace in b* 
Change-Id: I51e0369ba2e1fe0b7c934531f71d3bda95ba09ec
Reviewed-on: https://gerrit.libreoffice.org/42109
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-08 20:17:31 +02:00