wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
419,897 Commits 5 Branches 0 Tags
ff6def51db86ea2a516739f2dd67f24fa024af4e
Commit Graph

304 Commits

Author SHA1 Message Date
Stephan Bergmann
2b9975f6cd More loplugin:cstylecast: chart2 
Change-Id: Id704acc62a62554a81673c512e84a71a71798013
 2018-01-15 09:07:04 +01:00
Noel Grandin
956dd4a202 TypedWhichId in svx part 2 
Change-Id: Id927679c9f07f1dd820f4fdca9a45eb7aede037c
Reviewed-on: https://gerrit.libreoffice.org/46850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-21 11:40:19 +01:00
Noel Grandin
18c40a087f convert chart2 to TypedWhichId 
Change-Id: I1dc569d5a1667e3288fa64f16c22d39db130e906
Reviewed-on: https://gerrit.libreoffice.org/46813
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-20 10:15:54 +01:00
Noel Grandin
4f4486c61d look for =() in loplugin:unnecessaryparen 
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0
Reviewed-on: https://gerrit.libreoffice.org/44944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-20 12:31:32 +01:00
Noel Grandin
0f0049d77a TypedWhichId for XATTR* constants 
Change-Id: Ie9d637d701b77a549de3b00956f9c74ee8bd08c1
Reviewed-on: https://gerrit.libreoffice.org/44830
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-20 09:43:25 +01:00
Noel Grandin
13b89618c4 use implict conversion operator in TypedWhichId 
instead of spreading calls to Which() everywhere.

Change-Id: Ie32d106e44f5cb583908eeebe254ab8b8168ae61
Reviewed-on: https://gerrit.libreoffice.org/44760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-16 07:54:24 +01:00
Noel Grandin
3588a48a82 TypedWhichId 
use a strong-typedef template to give which IDs a type, which we can
carry around to do a
(a) little bit more convenience when Get()'ing them
and
(b) a little bit of enforcement of which PoolItem subclass each ID uses

Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass
in AccessibleEditableTextPara::_correctValues

Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b
Reviewed-on: https://gerrit.libreoffice.org/44587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-15 08:24:29 +01:00
Noel Grandin
c4abbb6e10 inline ASSERT_EXCEPTION macro in chart2 
Change-Id: I6bdcde5fd416531e2cdd3c9ec160833f1022247c
Reviewed-on: https://gerrit.libreoffice.org/44246
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-03 13:03:13 +01:00
Stephan Bergmann
d63b706dad loplugin:includeform: chart2 
Change-Id: I5b455c684e7cd689d5160135246f3400363c7d40
 2017-10-23 22:46:12 +02:00
Noel Grandin
2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Noel Grandin
7aa7f4d9e4 loplugin:unnecessaryparen include c++ casts 
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb
Reviewed-on: https://gerrit.libreoffice.org/41874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-04 10:52:41 +02:00
Noel Grandin
3dcf6dfcee remove unnecessary use of 'this->' 
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-02 13:45:36 +02:00
Noel Grandin
612b489d3e loplugin:checkunusedparams 
the "check for taking address of function" part was generating false+

Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f
Reviewed-on: https://gerrit.libreoffice.org/40613
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-01 11:06:26 +02:00
Noel Grandin
56be2245bf loplugin:constparams in dbaccess 
Change-Id: I4994c4f0ae614c8f98466f440412f28380ddd6a6
Reviewed-on: https://gerrit.libreoffice.org/40589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-31 14:23:39 +02:00
Caolán McNamara
182a74d937 de-hrc various things 
e.g.  helpid[s].hrc -> helpids.h
and insert include guards where missing

move "ordinary" defines into .hxx files

remove .hrc entries that are used as arguments to dialog factory
when a dedicated method can be added instead

Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e
 2017-07-21 08:20:51 +01:00
Noel Grandin
8a75aa52ef use more OUString::operator== in a*..chart2 
Change-Id: Ifb5608abebffd9687ed55e8c74f9be54a749111d
Reviewed-on: https://gerrit.libreoffice.org/39887
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-13 11:02:55 +02:00
Noel Grandin
4b2262ab5b new loplugin unnecessaryparen 
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec
Reviewed-on: https://gerrit.libreoffice.org/39549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-05 11:08:48 +02:00
Stephan Bergmann
63a76a0d3d ChartTypeHelper::getSupportedLabelPlacements nDimensionCount was ignored 
...ever since the code's integration with
124d934dffd8737db2d4375029c5a8b3880acaec "INTEGRATION: CWS chart17: #i63857#,
 #i4039# more flexible placement of data point labels, best fit for pie labels"

Change-Id: I942d7ff128d0b9e42ede371f81860f3c67943879
 2017-06-29 10:34:27 +02:00
Noel Grandin
7b5fac67fd loplugin:unusedfields in accessibility..comphelper 
Change-Id: Ifb68d65fc3e48dd80e3ff2b7a4124468fdda1695
Reviewed-on: https://gerrit.libreoffice.org/39137
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-23 09:01:24 +02:00
Stephan Bergmann
94d9d895ed Remove some unnecessary scaffolding around SAL_WARN calls 
Change-Id: Iaec105d85a283ad15fdca6ffc5cf3d2ec5acac18
 2017-05-31 18:17:03 +02:00
Noel Grandin
ef513fd4b0 remove unnecessary use of OString::getStr 
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-28 19:44:08 +02:00
Noel Grandin
0b2f1292b3 loplugin:comparisonwithconstant in chart2 
Change-Id: I95787007b26cdcf0d5d1617ecd0e55d377b551d7
Reviewed-on: https://gerrit.libreoffice.org/37941
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-23 11:22:08 +02:00
Chris Sherlock
97eb00c75e revert OSL_ASSERT changes 
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
 2017-05-07 17:03:35 +10:00
Chris Sherlock
42bc6835c5 tdf#43157: convert chart2 controller source from OSL_ASSERT to assert 
Change-Id: I184c2c0ed74b6a94eb2366c35daf9ed386fbc36f
 2017-05-07 07:30:14 +10:00
Arnaud Versini
1fdb0e1897 Replace all OUString("") with OUString() 
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0
Reviewed-on: https://gerrit.libreoffice.org/37146
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-04 08:39:18 +02:00
Noel Grandin
da57421b36 commit: loplugin:checkunusedparams in chart2 
Change-Id: Ia1f42e74365ca1dace93babc132ad67fd09fc99d
Reviewed-on: https://gerrit.libreoffice.org/37064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-28 13:41:48 +02:00
Stephan Bergmann
0446cca0b6 Improved loplugin:redundantcast, static_cast on arithmetic types: chart2 
Change-Id: I21dd484a2d337d16f59d5a747afaee230a1e7c89
 2017-04-06 18:33:05 +02:00
Noel Grandin
8cd5002959 use actual UNO enums in chart2 
Change-Id: I05d4eed55f5deba4b1802389d1ba94582d30550f
Reviewed-on: https://gerrit.libreoffice.org/35917
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-31 07:00:10 +00:00
Jochen Nitschke
9bb21ef311 cleanup itempool includes 
Change-Id: I3762cdfc6d92d2c15ef6e42d9be8e18ad8d79a10
Reviewed-on: https://gerrit.libreoffice.org/35313
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-03-17 11:00:09 +00:00
Noel Grandin
198c41c4fe new loplugin unoany 
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-28 10:17:47 +00:00
Noel Grandin
80dd757500 convert GraphicObjectType to scoped enum 
and drop unused FILL_PROPERTIES enumerator

Change-Id: I302d9d1d997c4fc491f7950b220060740f831539
 2017-02-17 07:57:52 +02:00
Tor Lillqvist
6de3688cc6 Drop :: prefix from std in c*/ 
Change-Id: If078cda95fa6ccd37270a5e9d81cfa0b84e71155
Reviewed-on: https://gerrit.libreoffice.org/34324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-02-15 23:01:23 +00:00
Noel Grandin
a3190d7201 remove unused SCHATTR_DIAGRAM_STYLE 
and associated SvxChartStyleItem and SvxChartStyle

Change-Id: I1564a4583125dd32af71e4eff338dfcefc6517c4
Reviewed-on: https://gerrit.libreoffice.org/33988
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-08 08:12:56 +00:00
Noel Grandin
83721f4365 makeAny->Any in basctl..chart2 
Change-Id: Ief1cdffbfc59ab4e35ac945d020772ff84c50d61
Reviewed-on: https://gerrit.libreoffice.org/33867
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-03 08:50:50 +00:00
Stephan Bergmann
e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Jochen Nitschke
e87071ac57 replace boost::checked_deleter with std::default_delete 
and remove all traces of boost/checked_delete.hpp

Change-Id: I4486d0e07a7197d75f8739c8c6d79670163eaab2
Reviewed-on: https://gerrit.libreoffice.org/33182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-01-17 20:24:17 +00:00
Jochen Nitschke
a29bd2dabb cleanup tailing backslashes 
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-30 18:48:24 +00:00
Stephan Bergmann
cc7e9b5dbe No apparent reason for an unnamed namespace in an include file here 
Change-Id: I56f21c94086b34f766e3f2745f5a1291af676984
 2016-12-21 14:50:58 +01:00
Stephan Bergmann
705af606f7 loplugin:unnecessaryoverride (dtors) in chart2 
Change-Id: I013fd81467b353262e8de554a06a0b24e4deca6d
 2016-11-23 18:37:35 +01:00
Noel Grandin
bb674aa550 loplugin:unusedfields 
Change-Id: Id2dbbf384637223db3d334d95332251832918003
Reviewed-on: https://gerrit.libreoffice.org/30927
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-17 13:10:42 +00:00
Noel Grandin
1e49e33c26 loplugin:constantparam in chart2..connectivity 
Change-Id: Ic9e1bd36a11c7148fa7595a2b6c6de9bd7a8653d
Reviewed-on: https://gerrit.libreoffice.org/28834
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 06:40:30 +00:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Noel Grandin
7db7666f01 convert SvxChartKindError to scoped enum 
Change-Id: Ibf6798fb1bdb7d16801402798414171876da915d
 2016-08-25 08:40:00 +02:00
Noel Grandin
9781212b55 convert SvxChartIndicate to scoped enum 
Change-Id: I65183bd4ce21544608397164fc2660830378d975
 2016-08-25 08:40:00 +02:00
Noel Grandin
2927a5c1c7 convert SvxChartRegress to scoped enum 
Change-Id: Ibdaad10c7936a0e53ab61c2016c8c9f3ac278767
 2016-08-25 08:40:00 +02:00
Laurent Balland-Poirier
428711f03c Start tdf#100547 Trendline equation: customize X, Y names 
Change trend line UI to add fields: X name and Y name
to change "x" and "f(x)" in equation representation

Next to be done: save it to ODF file

Change-Id: I0680ee1bbfbbb74016ecc858917e10d6790ac63a
Reviewed-on: https://gerrit.libreoffice.org/27069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
 2016-08-16 20:54:54 +00:00
Stephan Bergmann
f35b1397ae Clean up uses of Any::getValue() in chart2 
Change-Id: I53224053ea05c715f5e359a4c68e1ae5efbfe792
 2016-06-17 08:45:28 +02:00
Noel Grandin
9eb2e683ab tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16) 
and put an assert in SfxPoolItem::SetWhich() so nothing new
creeps in.

Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df
Reviewed-on: https://gerrit.libreoffice.org/24324
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-27 07:21:45 +00:00
Stephan Bergmann
279f050554 Some more sal_Bool -> bool 
Change-Id: I4df1afecfe4c554fa98060e6ba1507911323656c
 2016-04-25 16:40:05 +02:00
Stephan Bergmann
a82805f8f9 Kill comphelper::MakeMap 
Change-Id: I97e9e79ef51e3d78f01b831dd3eee91218058823
Reviewed-on: https://gerrit.libreoffice.org/24344
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2016-04-25 06:11:27 +00:00