zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not use RtcEventLogs in media transport when used only for data channel.

Browse Source 
It is possible to get event logs from both RTP and MediaTransport when
media transport is only used for data channel. This is undesirable. We
would rather not get any logs from media transport when it's not used
for media.

This change disables rtc event log when media transport is not used for
media.

Bug: webrtc:9719
Change-Id: Ibc660b37c5d98001144e5f68b32f0608fd6ede33
Reviewed-on: https://webrtc-review.googlesource.com/c/123260
Commit-Queue: Peter Slatala <psla@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26776}
This commit is contained in:
Piotr (Peter) Slatala
2019-02-15 12:05:50 -08:00
committed by Commit Bot
parent ce27875b83
commit 01fe309803
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pc/jsep_transport_controller.cc
View File

@ -1039,7 +1039,9 @@ JsepTransportController::MaybeCreateMediaTransport(
settings.is_caller = local;
settings.pre_shared_key = std::string(
reinterpret_cast<const char*>(key.value().data()), key.value().size());
settings.event_log = config_.event_log;
if (config_.use_media_transport_for_media) {
settings.event_log = config_.event_log;
}
auto media_transport_result =
config_.media_transport_factory->CreateMediaTransport(
ice_transport, network_thread_, settings);