zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Makes aborting delayed probes default enabled."

Browse Source 
This reverts commit b898cee41e6909ce0c359c53a8f1de86549974b8.

Reason for revert: Triggers unexpectedly large perf changes.

Original change's description:
> Makes aborting delayed probes default enabled.
> 
> Bug: webrtc:11780
> Change-Id: Id4bd884e1d75eb1adc4f4f5aa7f0cb7f83eea0f7
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/180820
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Commit-Queue: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31864}

TBR=sprang@webrtc.org,srte@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:11780
Change-Id: I9ea728ab48fdb3144d6c25ecb8808d40f57aba9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/181076
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31886}
This commit is contained in:
Erik Språng
2020-08-07 14:40:09 +00:00
committed by Commit Bot
parent 94cd6bbce9
commit 022082f1c8
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/pacing/bitrate_prober.cc
View File

@ -38,7 +38,8 @@ BitrateProberConfig::BitrateProberConfig(
min_probe_delta("min_probe_delta", TimeDelta::Millis(1)), min_probe_delta("min_probe_delta", TimeDelta::Millis(1)),
min_probe_duration("min_probe_duration", TimeDelta::Millis(15)), min_probe_duration("min_probe_duration", TimeDelta::Millis(15)),
max_probe_delay("max_probe_delay", TimeDelta::Millis(3)), max_probe_delay("max_probe_delay", TimeDelta::Millis(3)),
abort_delayed_probes("abort_delayed_probes", true) { // TODO(bugs.webrtc.org/11780): Change to default true.
abort_delayed_probes("abort_delayed_probes", false) {
ParseFieldTrial( ParseFieldTrial(
{&min_probe_packets_sent, &min_probe_delta, &min_probe_duration, {&min_probe_packets_sent, &min_probe_delta, &min_probe_duration,
&max_probe_delay, &abort_delayed_probes}, &max_probe_delay, &abort_delayed_probes},