zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix misleading SequenceChecker variable name.

Browse Source 
I named the network sequence checker 'worker' some time ago.
It represents the network TQ in RtpTransportControllerSendInterface
though, so should rather be called 'network'.

Bug: none
Change-Id: If82d7528b8cfcc180e1515b2fad63ed01610ec32
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175340
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31291}
This commit is contained in:
Tommi
2020-05-16 11:52:50 +02:00
committed by Commit Bot
parent ec3ba734e9
commit 04c94ad491
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
call/call.cc
View File

@ -275,7 +275,7 @@ class Call final : public webrtc::Call,
const std::unique_ptr<BitrateAllocator> bitrate_allocator_;
Call::Config config_;
SequenceChecker configuration_sequence_checker_;
SequenceChecker worker_sequence_checker_;
SequenceChecker network_sequence_checker_;
NetworkState audio_network_state_;
NetworkState video_network_state_;
@ -364,7 +364,7 @@ class Call final : public webrtc::Call,
// OnNetworkChanged from multiple threads.
rtc::CriticalSection bitrate_crit_;
uint32_t min_allocated_send_bitrate_bps_
RTC_GUARDED_BY(&worker_sequence_checker_);
RTC_GUARDED_BY(&network_sequence_checker_);
uint32_t configured_max_padding_bitrate_bps_ RTC_GUARDED_BY(&bitrate_crit_);
AvgCounter estimated_send_bitrate_kbps_counter_
RTC_GUARDED_BY(&bitrate_crit_);
@ -473,7 +473,7 @@ Call::Call(Clock* clock,
transport_send_(std::move(transport_send)) {
RTC_DCHECK(config.event_log != nullptr);
RTC_DCHECK(config.trials != nullptr);
worker_sequence_checker_.Detach();
network_sequence_checker_.Detach();
call_stats_->RegisterStatsObserver(&receive_side_cc_);
@ -1079,7 +1079,7 @@ void Call::OnStartRateUpdate(DataRate start_rate) {
void Call::OnTargetTransferRate(TargetTransferRate msg) {
RTC_DCHECK(network_queue()->IsCurrent());
RTC_DCHECK_RUN_ON(&worker_sequence_checker_);
RTC_DCHECK_RUN_ON(&network_sequence_checker_);
{
rtc::CritScope cs(&last_bandwidth_bps_crit_);
last_bandwidth_bps_ = msg.target_rate.bps();
@ -1120,7 +1120,7 @@ void Call::OnTargetTransferRate(TargetTransferRate msg) {
void Call::OnAllocationLimitsChanged(BitrateAllocationLimits limits) {
RTC_DCHECK(network_queue()->IsCurrent());
RTC_DCHECK_RUN_ON(&worker_sequence_checker_);
RTC_DCHECK_RUN_ON(&network_sequence_checker_);
transport_send_ptr_->SetAllocatedSendBitrateLimits(limits);