zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Add possibility to expand strings in the autoroller."

Browse Source 
This reverts commit bfb6124a73af8c9fb806d9798c21aa28d36b125f.

Reason for revert: Testing Autoroller notifications. I will reland this later.

Original change's description:
> Add possibility to expand strings in the autoroller.
> 
> Starting from crrev.com/c/2265498, the Chromium DEPS file has a new
> function Str(), which seems to just expand to the string it wraps.
> 
> This causes the following error:
> 
>   NameError: name 'Str' is not defined
> 
> In //tools_webrtc/autoroller/roll_deps.py.
> 
> This CL adds a way to expand the string.
> 
> No-Try: True
> Bug: None
> Change-Id: I4cdb43410edeed72b393f200314c0ee7eea9cb2a
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178865
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31661}

TBR=mbonadei@webrtc.org,jleconte@webrtc.org

Change-Id: I69f75da132d6b838b96a559712ad4c0da929021c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178877
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31673}
This commit is contained in:
Mirko Bonadei
2020-07-08 13:50:13 +00:00
committed by Commit Bot
parent a376518817
commit 0973a55f82
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools_webrtc/autoroller/roll_deps.py
View File

@ -97,10 +97,6 @@ class RollError(Exception):
pass
def StrExpansion():
return lambda str_value: str_value
def VarLookup(local_scope):
return lambda var_name: local_scope['vars'][var_name]
@ -108,7 +104,6 @@ def VarLookup(local_scope):
def ParseDepsDict(deps_content):
local_scope = {}
global_scope = {
'Str': StrExpansion(),
'Var': VarLookup(local_scope),
'deps_os': {},
}