zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland of Make AudioSinkInterface::Data hold a const pointer to the audio buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2877013002/ )

Browse Source 
Reason for revert:
Re-land the original CL because the reverting it didn't fix the problem.

Original issue's description:
> Revert of Make AudioSinkInterface::Data hold a const pointer to the audio buffer. (patchset #1 id:1 of https://codereview.webrtc.org/2873803002/ )
>
> Reason for revert:
> Reverted because it possibly breaks the internal project.
>
> Original issue's description:
> > Make AudioSinkInterface::Data hold a const pointer to the audio buffer.
> >
> > This is in preparation for https://codereview.webrtc.org/2750783004/, where
> > requiring a non-const pointer for AudioSinkInterface would force an unmuting
> > and zeroing of every frame.
> >
> > BUG=webrtc:7343
> >
> > Review-Url: https://codereview.webrtc.org/2873803002
> > Cr-Commit-Position: refs/heads/master@{#18107}
> > Committed: 38605965bd
>
> TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7343
>
> Review-Url: https://codereview.webrtc.org/2877013002
> Cr-Commit-Position: refs/heads/master@{#18112}
> Committed: c904634823

TBR=solenberg@webrtc.org,henrik.lundin@webrtc.org,yujo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7343

Review-Url: https://codereview.webrtc.org/2880663003
Cr-Commit-Position: refs/heads/master@{#18113}
This commit is contained in:
zhihuang
2017-05-11 22:07:37 -07:00
committed by Commit bot
parent c904634823
commit 0acebe2238
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc/api/call/audio_sink.h
View File

@ -27,7 +27,7 @@ class AudioSinkInterface {
virtual ~AudioSinkInterface() {}
struct Data {
Data(int16_t* data,
Data(const int16_t* data,
size_t samples_per_channel,
int sample_rate,
size_t channels,
@ -38,7 +38,7 @@ class AudioSinkInterface {
channels(channels),
timestamp(timestamp) {}
int16_t* data; // The actual 16bit audio data.
const int16_t* data; // The actual 16bit audio data.
size_t samples_per_channel; // Number of frames in the buffer.
int sample_rate; // Sample rate in Hz.
size_t channels; // Number of channels in the audio data.