zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove incorrect cast to AsyncSocketAdapter.

Browse Source 
socket_ in OpenSSLAdapter should be (and is in tests) an AsyncSocket but
doesn't have to be an AsyncSocketAdapter. In tests this is
rtc::VirtualSocket which is an rtc::AsyncSocket. This also matches the
BIO_new_socket type signature.

This fixes the remaining UBSan vptr bot errors.

BUG=webrtc:5124, webrtc:5226
R=tommi@webrtc.org, torbjorng@webrtc.org

Review URL: https://codereview.webrtc.org/1639883002 .

Cr-Commit-Position: refs/heads/master@{#11391}
This commit is contained in:
Peter Boström
2016-01-27 12:35:40 +01:00
parent bab934bffe
commit 0b518bf6fc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/base/openssladapter.cc
View File

@ -336,7 +336,7 @@ OpenSSLAdapter::BeginSSL() {
goto ssl_error;
}
bio = BIO_new_socket(static_cast<AsyncSocketAdapter*>(socket_));
bio = BIO_new_socket(socket_);
if (!bio) {
err = -1;
goto ssl_error;