zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Default-enables WebRTC-DeferredFecGeneration.

Browse Source 
Bug: webrtc:11340
Change-Id: I9575fcf2ac12ce9b71b27f32deeb7870a1dff64b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185814
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32232}
This commit is contained in:
Erik Språng
2020-09-28 18:04:46 +02:00
committed by Commit Bot
parent 3f8966f4ab
commit 10ea118410
2 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
call/rtp_video_sender.cc
View File

@ -341,9 +341,9 @@ RtpVideoSender::RtpVideoSender(
field_trials_.Lookup("WebRTC-UseEarlyLossDetection"),
"Disabled")),
has_packet_feedback_(TransportSeqNumExtensionConfigured(rtp_config)),
use_deferred_fec_(
absl::StartsWith(field_trials_.Lookup("WebRTC-DeferredFecGeneration"),
"Enabled")),
use_deferred_fec_(!absl::StartsWith(
field_trials_.Lookup("WebRTC-DeferredFecGeneration"),
"Disabled")),
active_(false),
module_process_thread_(nullptr),
suspended_ssrcs_(std::move(suspended_ssrcs)),

20
modules/rtp_rtcp/source/rtp_sender_egress.cc
View File

@ -30,11 +30,12 @@ constexpr size_t kRtpSequenceNumberMapMaxEntries = 1 << 13;
constexpr TimeDelta kUpdateInterval =
TimeDelta::Millis(kBitrateStatisticsWindowMs);
bool IsEnabled(absl::string_view name,
const WebRtcKeyValueConfig* field_trials) {
bool IsTrialSetTo(const WebRtcKeyValueConfig* field_trials,
absl::string_view name,
absl::string_view value) {
FieldTrialBasedConfig default_trials;
auto& trials = field_trials ? *field_trials : default_trials;
return absl::StartsWith(trials.Lookup(name), "Enabled");
return absl::StartsWith(trials.Lookup(name), value);
}
} // namespace
@ -89,7 +90,9 @@ RtpSenderEgress::RtpSenderEgress(const RtpRtcpInterface::Configuration& config,
: absl::nullopt),
populate_network2_timestamp_(config.populate_network2_timestamp),
send_side_bwe_with_overhead_(
IsEnabled("WebRTC-SendSideBwe-WithOverhead", config.field_trials)),
IsTrialSetTo(config.field_trials,
"WebRTC-SendSideBwe-WithOverhead",
"Enabled")),
clock_(config.clock),
packet_history_(packet_history),
transport_(config.outgoing_transport),
@ -98,10 +101,11 @@ RtpSenderEgress::RtpSenderEgress(const RtpRtcpInterface::Configuration& config,
is_audio_(config.audio),
#endif
need_rtp_packet_infos_(config.need_rtp_packet_infos),
fec_generator_(
IsEnabled("WebRTC-DeferredFecGeneration", config.field_trials)
? config.fec_generator
: nullptr),
fec_generator_(!IsTrialSetTo(config.field_trials,
"WebRTC-DeferredFecGeneration",
"Disabled")
? config.fec_generator
: nullptr),
transport_feedback_observer_(config.transport_feedback_callback),
send_side_delay_observer_(config.send_side_delay_observer),
send_packet_observer_(config.send_packet_observer),